Commit Graph

546 Commits (712c5758ff9685d9d8a07cbbe91aa814ca32f0a9)

Author SHA1 Message Date
Steven Wittens 001d54f663 #84961: Add 'select all' and range select feature to admin tables. 2006-11-21 08:16:39 +00:00
Neil Drumm 7f25862f95 #93821 by lyricnz. Fix an undefined variable. 2006-11-12 00:11:15 +00:00
Neil Drumm 337c2f9b5d #92149 by Egon Bianchet. Fix an uncapitalized link. 2006-11-10 08:37:20 +00:00
Dries Buytaert 87f1359158 - Patch #82938 by edkwh and natrak: error in comments admin page after clicking on Update without selecting any comments. 2006-10-24 20:31:25 +00:00
Steven Wittens 36d44fbfb0 #84146: Use 'Sentence capitalization' for menu items, page titles, form items, etc 2006-10-22 08:28:47 +00:00
Dries Buytaert 8306444494 - Patch #78399 by Eaton and chx: don't allow HTML in the title. 2006-10-18 18:00:40 +00:00
Neil Drumm ea38bae2a7 #84443 by Shakur. Do not depend on a url argument being defined. 2006-10-17 08:45:51 +00:00
Dries Buytaert 7cb0c537c1 - Patch #87995 by merlinofchaos: cleaned up CSS and simplified the code. 2006-10-11 13:17:23 +00:00
Dries Buytaert 6e8a0a1602 - Patch #87755 by kjartan: anonymous comments can't save names. 2006-10-09 06:59:01 +00:00
Dries Buytaert cb8201c337 - Patch #83007 by edkwh: fixed multi-comment delete. 2006-09-17 19:09:34 +00:00
Neil Drumm d48100eb88 #73584 by keve an flk. Properly check if a variable is set. 2006-09-09 00:23:11 +00:00
Dries Buytaert 6f0e54b037 - Patch #82465 by webchick: renamed variables in hooks for consistency. 2006-09-08 16:33:02 +00:00
Neil Drumm 208090eeb0 #82336 by jvandyk. Set the default input format if we don't have one. 2006-09-05 02:36:02 +00:00
Dries Buytaert 49fa25fb76 - Rollback of patch #68418: clean up node submit hooks. Needs more thinkering.
Restores the old node API.
2006-08-31 21:58:36 +00:00
Dries Buytaert c64db1da29 - Patch #80952 by earl, webchick, neclimdul et al: .info files 2006-08-31 20:22:37 +00:00
Neil Drumm e051f5bd90 #81481 by erdemkose. Show the comment subject on delete confirmation. 2006-08-31 08:55:45 +00:00
Dries Buytaert 5524604a95 - Patch #68418 by Moshe et al: clean up node submit hooks. 2006-08-29 18:43:26 +00:00
Neil Drumm bceaf8f0da #80574 Eaton and chx. Replace $_POST['edit'] with $_POST. 2006-08-29 09:12:03 +00:00
Dries Buytaert f8534504b3 - Patch #80895 by webchick et al: make it easier to disable form elements. 2006-08-27 12:54:01 +00:00
Dries Buytaert c4f1e4ba13 - Patch #76444 by chx, moshe, eaton, angie et al: make it possible to control access to form elements. 2006-08-22 11:13:04 +00:00
Dries Buytaert e14c3aa6c0 - Patch #79498 by Eaton: fixed editing comments and nodes. 2006-08-19 21:40:58 +00:00
Dries Buytaert 7de41539df - Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model. 2006-08-18 18:58:47 +00:00
Steven Wittens 81938a3cdc #76802: Introduce placeholder magic into t()
See: http://drupal.org/node/64279#t-placeholders
2006-08-18 12:17:00 +00:00
Dries Buytaert ce85b7c7f8 - Patch #74326 by Eaton, Royboy, chx, et al: building $node->body with arrays like FAPI for viewing.
Once again, we're paving the path for CCK in core ... :)
2006-08-10 15:42:33 +00:00
Dries Buytaert d2eb90c45e - Patch #77896 by killes: don't clear cache inside loop. 2006-08-10 05:47:37 +00:00
Dries Buytaert 729fa6c11b - Patch #77422 by timcn: corrected various paths in the documentation. 2006-08-07 15:04:16 +00:00
Neil Drumm 129c8eb18c #62340 by chx, webchick, Jaza, Eaton, mathieu, and myself. Configurable node types. 2006-08-06 23:00:42 +00:00
Neil Drumm cd430165d7 #73884 by RobRoy, various code cleanup. 2006-08-05 00:26:36 +00:00
Dries Buytaert b138793b68 - Patch #72079 by Earl et al: give Drupal an overall administration page ... :-) 2006-07-31 11:25:55 +00:00
Neil Drumm c11c1c2800 #73605 by RobRoy, make hook_link() implementations consistent with documentation. 2006-07-19 07:15:35 +00:00
Neil Drumm e616f2b580 #73748 by RobRoy, add a themeable wrapper for comments 2006-07-19 06:19:17 +00:00
Steven Wittens dafb146b27 #74070: urlencode to drupal_urlencode() 2006-07-18 10:44:45 +00:00
Dries Buytaert e4e416d1f7 - Patch #73351 by Kris, Goba et al: only display comment link in RSS, if applicable. 2006-07-13 12:29:15 +00:00
Dries Buytaert 58752cfaa2 - Patch #72284 by me:
+ reorganized ?q=admin/settings
   + deprecated the _settings hook
2006-07-10 19:27:52 +00:00
Neil Drumm 84bad29516 #72865 by AjK, use more standard is_numeric() instead of ctype_digit(). 2006-07-10 18:00:37 +00:00
Neil Drumm 59aa2ae8e8 #71925 by Steven, remove # prefix from link array keys. 2006-07-04 08:59:05 +00:00
Neil Drumm d048681f03 #63990 by Heine and chx, allow commenting on nodes containing forms 2006-07-02 20:24:17 +00:00
Neil Drumm 2a89ab89f9 #67745 by AjK, handle deleting non-existant comments better. 2006-07-02 02:59:21 +00:00
Neil Drumm 4f078eb274 #51556 by greggles, Fixing an inaccurate comment. 2006-05-20 08:14:09 +00:00
Dries Buytaert 1b291a2917 - Patch #18260 by Ber, m3averck et al: allow overriding of links returned by modules 2006-05-18 14:58:57 +00:00
Neil Drumm 9cff02e91b #61802 by Zen, Double spaced sentences clean up 2006-05-07 00:08:36 +00:00
Neil Drumm 79598dc723 #61678 by Zen, Comment body validation should rely on fapi 2006-05-04 09:34:56 +00:00
Steven Wittens 546f5930a4 #58953: Flat collapsed mode and newest first order broken 2006-04-27 22:03:20 +00:00
Dries Buytaert 326f49b646 - Patch #58953 by tenrapid: critical bugfix: Flat Collapsed mode and Newest First order broken. 2006-04-24 18:42:53 +00:00
Gerhard Killesreiter 297ed741f8 #58221, Turn #after_build into a functions array in order to make validation of date fields possible. Patch by yched, tenrapid
Also makes forms API more consistent (see #pre_render)
2006-04-20 07:11:37 +00:00
Dries Buytaert 0484fcd1ed - Patch #58921 by markus_petrux: critical bug: database error when rendering comments in PostgreSQL.
Tested with MySQL only!
2006-04-17 20:45:00 +00:00
Steven Wittens 8b04c7f0db #51002: Admins could not see unpublished comments (plus minor usability enhancements for previewing/unpublished) 2006-04-15 04:07:18 +00:00
Gerhard Killesreiter d6a164c400 #5371, drupal_get_destination, pager and tablesort array handling, patch by Steven 2006-04-13 08:25:27 +00:00
Gerhard Killesreiter 70aae83c8e #58166, fixes for typos, patch by Uwe Herrmann 2006-04-11 11:33:15 +00:00
Steven Wittens 4c3fe45fe9 #56942: Comment cids should belong to the associated nid 2006-04-04 07:07:45 +00:00
Steven Wittens 57be840338 #57133: admin/comment needs to remember sort order in page 2006-04-04 01:26:05 +00:00
Steven Wittens b3cb4f0d9b #56346: XHTML validation error due to comment.module links 2006-03-30 17:23:29 +00:00
Gerhard Killesreiter a76ee6c9ed #34132, remove remnants of nodeapi('fields'), patch by myself 2006-03-28 06:12:15 +00:00
Steven Wittens d6f15f3051 - #55666: Comment reply form anchor fixes 2006-03-27 08:08:31 +00:00
Gerhard Killesreiter 5885925b0d #53348, Handling of deleted/blocked user accounts, patch by jreyero and Zen 2006-03-26 19:31:00 +00:00
Gerhard Killesreiter 0fad496ca0 #55622, Security threat -- any user can delete comments, patch by robertgarrigos 2006-03-24 11:38:00 +00:00
Gerhard Killesreiter 63b3fea2b3 #54687, Typo with page redirection upon login, patch by matt westgate 2006-03-20 16:40:06 +00:00
Dries Buytaert f51bc544f2 - Patch #51142 by markus: hook_comment not called for all update operations. 2006-03-06 20:52:55 +00:00
Dries Buytaert c54a0f575f - Patch #51543 by wtanaka: clicking on 'add new comment' takes you to the wrong place. 2006-03-06 18:09:17 +00:00
Dries Buytaert 5de716f100 - Patch #50835 by markus: print message when replying to non-existing comment. 2006-03-04 18:01:54 +00:00
Gerhard Killesreiter 784202418f #50771, Wrong user name in admin/comment, patach by Markus Petrux 2006-02-27 14:54:24 +00:00
Dries Buytaert 66576708a0 - Patch #51347 by eafarris: fixed typo: coment -> comment. 2006-02-26 19:52:09 +00:00
Dries Buytaert 3489651659 - Patch #46690 by Zen: 'user comments' -> 'comment settings'. 2006-02-26 19:47:55 +00:00
Dries Buytaert c94a2dabb0 - Patch #50755 by markus: = -> ==. 2006-02-22 19:02:58 +00:00
Dries Buytaert cb05945caf - Patch #47699 by wtanaka: performance improvement. 2006-02-22 10:05:06 +00:00
Dries Buytaert 3603fe1bd8 - Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.) 2006-02-21 18:46:54 +00:00
Dries Buytaert 7489c87476 - Patch #43572 by Tobias: don't accept spaces. 2006-02-14 19:17:00 +00:00
Dries Buytaert 583d5a4ee9 - Patch #48622 by adrian: remove drupal_goto from _submit functions. 2006-02-10 05:25:57 +00:00
Steven Wittens 1819de963f - #48518: Editing own comment broken under postgresl 2006-02-09 09:09:03 +00:00
Steven Wittens c9a19e3084 - #48239: Comment thread coding inefficient 2006-02-09 08:33:36 +00:00
Dries Buytaert 91e152b8b8 - Patch #47705 by DriesK: comment moderation/approval wasn't working due to a bug with its forms. 2006-02-04 09:54:16 +00:00
Dries Buytaert baa2ecc81c - Patch #47045 by Cvbge: fixed problem with deleting comments. 2006-02-01 14:04:50 +00:00
Dries Buytaert a6dac9d2ab - Modified patch #46227 by chx: comment token is broken. 2006-01-31 15:26:39 +00:00
Dries Buytaert 20154df528 - Modified patch #45723 by wtanaka: creating a comment, editing a comment, or anything that validates a comment fails on PHP5. 2006-01-26 08:48:57 +00:00
Dries Buytaert 5d43619ca7 - Patch #40752 by moshe/wtanaka: login and regsiter links on each comment don't redirect back to the topic. 2006-01-26 08:27:58 +00:00
Dries Buytaert b8832d76a0 - Patch #40753 by wtanaka/killes: #comment-form has disappeared from comment.module 2006-01-25 08:54:40 +00:00
Dries Buytaert b6b98bb60d - Patch #44101 by Cvbge: deleting a comment creates incorrect entry in node_comment_statistics. 2006-01-22 07:26:33 +00:00
Dries Buytaert 4da1540a9f - Patch #45380 by Neil: usability improvement: disable anonymous commenting options when anonymous people can't comment. 2006-01-20 09:33:03 +00:00
Dries Buytaert 8c02d4ec93 - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:

# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
  $form[$key]['#weight'] = $count/1000;
}

The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).

Consider the following pseudo example:

$form['game_title'] = array(
    '#type' => 'textfield',
    ...
    );
$form['game_description'] = array(
    '#type' => 'textarea',
    ...
    );
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;

Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).

The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
Dries Buytaert e84a98a22b - Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API. 2006-01-19 08:54:41 +00:00
Dries Buytaert 47dd0142e6 - Patch #43325 by chx/drumm/merlinofchaos: critical bugfix: made editing comments work. 2006-01-18 15:09:39 +00:00
Dries Buytaert cb45cf58fb - Patch #40755 by wtanaka: make the comment block themable. 2006-01-17 18:02:23 +00:00
Dries Buytaert 226a26a556 - Removed reference to comment moderation. 2006-01-10 19:41:15 +00:00
Steven Wittens 49e5e1cd47 - #43097: restore admin/comment tablesort 2006-01-08 00:29:37 +00:00
Steven Wittens 030fd1798a - Comment bug: anchor links should be specified using $fragment in url() and drupal_goto(). 2006-01-06 01:14:17 +00:00
Dries Buytaert 24899dba42 - Patch #40563 by chx, merlingofchaos, et al: bug fix: fixed the default comment settings on node sumbission forms. 2006-01-05 14:35:55 +00:00
Dries Buytaert 8d7ff5aea2 - Patch #39743 by merlinofchaos: critical bugfix: fixed comment ordering setting. 2006-01-05 10:53:47 +00:00
Dries Buytaert 72ed68d48b - Patch #42971 by markus_petrux: input format not correctly shown when editing a comment. 2006-01-03 23:04:23 +00:00
Dries Buytaert ea2d791095 - Patch 41169 by Chris: got rid of expensvie object 2 array casts. 2005-12-31 10:48:56 +00:00
Dries Buytaert 6164074655 - Patch #38999 by saerdna: There's no need that users with the "administer comments" role has to go via admin/comments to delete comments. this patch simply adds the delete link on each comment if you have administer comments role. "access administration pages" not needed; because if they not have it they can still delete from admin/comments. 2005-12-19 10:12:52 +00:00
Dries Buytaert 21a9442bbb - Patch #41081 by billturner: fixed problem with the comment settings form. 2005-12-15 16:31:01 +00:00
Dries Buytaert 922a46d281 - Patch #34920 by Morbus/webchick/tangent: fixed order of form fields. 2005-12-15 16:24:40 +00:00
Dries Buytaert 5accfa08f5 - Patch #41133 by DriesK: as of PHP 5.1.0, strtotime() returns FALSE on failure instead of -1.
Changed code to be compatible with all versions.
2005-12-15 16:02:50 +00:00
Dries Buytaert 764f1177ef - Patch #40631 by Chris Johnson: is_array() slower than isset() or empty(). 2005-12-14 20:10:45 +00:00
Dries Buytaert 3ae534a64e - Patch #28595 by Cvbge: fixed problems with bulk comment operations. 2005-12-08 09:11:32 +00:00
Dries Buytaert e019ce5107 - Patch #28595 by Jeremy: added support for bulk operations on comments. 2005-12-07 05:35:02 +00:00
Dries Buytaert 28fdb3975e - Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick. 2005-12-05 09:11:33 +00:00
Dries Buytaert 80e02e6e73 - Patch #36434 by assimonds: fixed problem with editing signatures. 2005-12-03 19:39:15 +00:00
Dries Buytaert 26bd449860 - Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'. 2005-12-02 15:21:01 +00:00
Dries Buytaert 8784a7d13a - Patch #39024 by Zen: comments that should be in the moderation queue get published. 2005-11-27 11:45:03 +00:00