Commit Graph

1965 Commits (70ce81aafdf8519a85831a8c40b1fcc45b947655)

Author SHA1 Message Date
Greg Dunlap 1bc549de8f Merge remote-tracking branch 'origin/8.x' into 8.x-file-config 2012-02-29 19:47:35 -08:00
Nathaniel bdb71c6fa7 Merge remote branch 'crell/dbtngtng' into 8.x 2012-03-01 12:22:48 +09:00
Larry Garfield 2d52eeeee2 Move DrupalApp back to being a kernel implementation, since, really, that's what it is. 2012-02-28 20:43:33 -06:00
Larry Garfield 2dec350acd Add a listener to handle path resolution. For now we hack ['q'] still so that legacy code still works, but that will go away soon. 2012-02-26 15:24:46 -06:00
Larry Garfield aa62145650 More useful generic exception message. 2012-02-26 13:41:54 -06:00
Larry Garfield 1c91c1fe0c Add an access listener that should throw a 403 exception if the menu router's access check failed. This is totally not the right way to do this long term, but it works for our current codebase. 2012-02-24 00:20:58 -06:00
Larry Garfield 3a79e7535a Proper type hint. 2012-02-23 23:57:18 -06:00
Larry Garfield 251d38bd84 Lots of documentation and cleanup. 2012-02-23 23:00:05 -06:00
Larry Garfield de96603ccb Add an HTML listener for 403 errors. 2012-02-23 22:48:31 -06:00
Larry Garfield 298240393a Convert the matcher into a RouterListener, which in turn handles the error handling to return the right kind of exception at the right time on a 404. 2012-02-23 22:33:05 -06:00
Larry Garfield 16dbf2ec4b Refactor DrupalApp into a series of building methods rather than one long method. 2012-02-23 01:06:03 -06:00
Larry Garfield fd02c84604 Move the HTML request type handling to a subscriber class so that it's nicely encapsulated. 2012-02-23 00:58:41 -06:00
Larry Garfield 501f6d5af6 Clean up debug code. 2012-02-23 00:34:08 -06:00
Larry Garfield fdbc8a2404 Convert DrupalKernel into simply a DrupalApp class, since all of the kernel-y stuff is happening in HttpKernel anyway. 2012-02-23 00:33:14 -06:00
Larry Garfield 87e5aede35 Convert all exception handling to be part of the event dispatcher, for consistency. 2012-02-23 00:28:54 -06:00
Greg Dunlap a9cabde4e3 Cleaning up some todos 2012-02-22 21:28:37 -08:00
Larry Garfield f9fe640f78 Move the new routing logic into a DrupalKernel object. 2012-02-22 22:53:15 -06:00
Greg Dunlap 13db511a47 Stramlined read code slightly 2012-02-22 12:02:03 -08:00
Greg Dunlap e666688a1f Exceptions now successfully being caught when db is missing 2012-02-22 12:01:25 -08:00
Greg Dunlap cc3d5edc53 Removed throw_exception because apparently that's not the problem after all 2012-02-22 10:55:30 -08:00
Greg Dunlap 612c29cff6 Added an exception handler to config->get() which handles situations where the db is not in place, allowing us to remove a call to db_table_exists() which should improve cached performance a bit 2012-02-22 01:07:21 -08:00
Larry Garfield 5ee04f81cb Handle page callback files that need to be lazy-loaded. 2012-02-21 08:44:56 -06:00
Larry Garfield 3b8be7dfa9 Fix typo. 2012-02-21 08:44:36 -06:00
Larry Garfield 56654ae8db Fix front page handling. 2012-02-21 08:44:22 -06:00
Greg Dunlap b537f79f47 Docblock for clear() 2012-02-17 14:17:29 -08:00
Greg Dunlap eb6ea697b8 Renamed unset back to clear because unset is a reserved word which is the whole reason I didn't name it unset in the first place 2012-02-17 14:15:16 -08:00
Greg Dunlap c256f64104 Renamed clear() to unset() 2012-02-17 14:09:59 -08:00
Greg Dunlap aa0e17824b Added docblock for castValue 2012-02-17 14:08:21 -08:00
sun 208af9fec5 Chainable config()->set(). 2012-02-16 14:28:51 -08:00
Greg Dunlap 112afc273a Removing extra blank lines 2012-02-16 13:17:07 -08:00
sun 4f0f3c876f Fixed missing type casting for configuration values. 2012-02-14 12:25:52 -08:00
sun 40cc21c89d Fixed Image module tests. Added many critical todos:
- Config values are not casted to strings (despite promised).
- Config keys are not casted to strings (although promised, too).
- XML can be invalid and not parse-able for many reasons.
- Config keys are not validated/sanitized.
- config()->clear() should really be ->unset().
- Configuration must not be additionally cached by a module in any way (static cache / database cache).
- Some modules invoke drupal_alter() on configuration (e.g., image styles).
- Need a way to list config object names/suffixes _after_ a specified prefix.
- Need a way to determine whether a config object exists.
- Some modules might have a valid use-case for retrieving/listing config objects using a wildcard within the name (instead of only searching by prefix).
- The key of a retrieved value is unknown; since you only get the value.  Configuration values (or sub-values) may be passed forward to another function/callback, and thus, that function no longer knows about the key of the value. (unless the key is contained in the value, which is a very very wonky duplication)
- Config keys must not contain periods (within a specific key).
2012-02-14 12:25:39 -08:00
sun 64eb1643d0 Fixed coding style. 2012-02-14 12:19:43 -08:00
sun 3e65c6d1a1 Added @todo for $config->name property. 2012-02-14 12:16:43 -08:00
sun 598cb86d2d Added DrupalConfigStorageInterface::writeToFile().
write() called into copyToFile() previously, which needlessly re-loaded the configuration data from the active storage, whereas the data is already available.
2012-02-14 12:13:10 -08:00
sun b068ec4031 Instantiate SignedFileStorage object only once per config object. 2012-02-14 12:10:10 -08:00
James Gilliland cf096e698a Stash the Drupal menu item
This will bubble down to the request and since that will be passed around, make
a lot of integration with Symfony and transitioning easier.
2012-02-13 11:05:42 -05:00
James Gilliland 3ef99f9000 Convert to our own UrlMatcher
This is a transitional implementation but by using the UrlMatcherInterface
we can embed our matching logic directly into Symfony's routing logic.
2012-02-13 10:00:50 -05:00
Greg Dunlap 00e4f78537 Expanded the comment on ->get() to be more explicit about string conversions 2012-02-13 14:15:40 -05:00
Greg Dunlap 0810f57d8a Merge branch '8.x-file-config' of git.drupal.org:sandbox/heyrocker/1145636 into 8.x-file-config 2012-02-13 13:56:57 -05:00
Greg Dunlap 9485cf0ce8 Adding ability to return NULL if a value is not found 2012-02-13 13:02:02 -05:00
sun f71138695f Fixed configuration file directory not setup for tests. 2012-02-13 18:53:07 +01:00
justinrandell 9689b0be06 Fully qualify path to PHP's Exception in our namespaced code. 2012-02-11 23:23:54 -05:00
Greg Dunlap a8df28f40d Made config->delete() also blank out the internal data array to prevent people retrieving the data after deletion 2012-02-13 10:30:12 -05:00
Greg Dunlap 5674c60a31 Removed getData() function since this is now replicated in get() 2012-02-13 09:42:41 -05:00
Greg Dunlap c0d37effeb Removed todo that no longer applies 2012-02-12 14:00:59 -05:00
Greg Dunlap 79c10d633d Converting config system to PSR-0 2012-02-12 11:17:29 -05:00
Larry Garfield b9131de629 Clean up exception naming with a new interface. 2012-02-02 23:17:31 -06:00
Greg Dunlap a7c6328d17 Merge remote-tracking branch 'core/8.x' into 8.x-file-config 2012-02-01 14:02:58 +01:00
catch 037faa8fbf Issue #1400748 by Crell, jbrown, plach: Proposal for unified namespace organization. 2012-02-01 12:23:30 +09:00
Larry Garfield 49839784e7 Add file docblocks to new DB files. 2012-01-28 18:27:11 -06:00
Larry Garfield 5a5c830761 Rename transaction use statement. 2012-01-28 17:54:14 -06:00
Larry Garfield e9453d8b04 Merge branch '1400748-namespaces' into dbtngtng 2012-01-28 17:51:18 -06:00
Larry Garfield 24390d5857 Add empty stub files for Postgres. 2012-01-28 17:43:54 -06:00
Larry Garfield 03bd99a28b Update documentation blocks for fully qualified class names. 2012-01-28 17:40:14 -06:00
Larry Garfield a6b6fa5b91 Fix logic in Logger backtrace scanning now that the code is not in the includes directory anymore. 2012-01-28 16:44:35 -06:00
Larry Garfield a731ac1df9 Merge branch '1400748-namespaces' into dbtngtng 2012-01-26 23:48:06 -06:00
Larry Garfield 808c88bd82 Add new readme file for the lib directory itself that specifies PSR-0. 2012-01-25 09:01:39 -06:00
Larry Garfield fc73713158 Minor language tweaks. 2012-01-25 09:01:12 -06:00
Larry Garfield f4a58c3f3a Move Postgres code to PSR-0. 2012-01-23 21:16:26 -06:00
Larry Garfield 92286713d5 Move database files to the new lib directory and update code accordingly. 2012-01-22 23:56:07 -06:00
Larry Garfield 8b8c2a9463 refs #1400748 by Crell: Update docblocks and the installer for the new namespaces. 2012-01-22 22:25:13 -06:00
Larry Garfield 8b0adb6e1e refs #1400748 by Crell: Add README files to document the purpose of various core directories. 2012-01-22 21:24:00 -06:00
Larry Garfield 7048b2195f refs #1400748 by Crell: Move Cache subsystem to the Core namespace. 2012-01-22 21:05:01 -06:00
Larry Garfield 0cb703be45 refs #1400748 by Crell: Move Drupal and Symfony code to core/lib and core/vendor respectively. 2012-01-22 20:56:35 -06:00