Commit Graph

541 Commits (6eb60a3669eee5e2bc3adfbb35d80fc79b51d340)

Author SHA1 Message Date
Nathaniel Catchpole 5b3fdce48b Issue #2887142 by maxocub, phenaproxima, Jo Fitzgerald, Adita, heddn, andypost: NodeType source plugin should include comment information 2017-10-10 15:12:03 +01:00
Nathaniel Catchpole 2e18fe9373 Issue #2715485 by harsha012, mfernea, malavya, himanshu-dixit, vprocessor, tameeshb, Mile23, RajeevK, Jo Fitzgerald, tiago.urbano, xjm, klausi: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard 2017-09-25 14:14:30 +01:00
Lee Rowlands 73bba855dc
Issue #2866513 by michielnugter, jonathan1055, mpdonadio, Jo Fitzgerald, Lendude, dawehner, Wim Leers: Convert web tests to browser tests for comment module 2017-09-24 10:44:51 +10:00
Nathaniel Catchpole 4577185c9b Issue #2572791 by Mile23, andriyun, attiks, RoSk0: Fix 'Drupal.WhiteSpace.OpenBracketSpacing' coding standard 2017-09-22 12:16:23 +01:00
xjm 465348f98d Issue #2759789 by mfernea, Mile23, andriyun, dawehner, klausi: Fix 'Drupal.Semantics.FunctionAlias' coding standard 2017-09-17 16:58:08 -05:00
xjm 2242f4ad9e Issue #2901785 by mfernea, xjm, andriyun: Fix 'Generic.Formatting.SpaceAfterCast' coding standard 2017-09-17 16:38:34 -05:00
xjm cc30270e9a Revert "Revert "Revert "Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard"""
This reverts commit b06757615a.
2017-09-16 14:24:44 -05:00
xjm b06757615a Revert "Revert "Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard""
This reverts commit 964954e1f3.
2017-09-16 12:02:55 -05:00
xjm 964954e1f3 Revert "Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard"
This reverts commit 2df73e2c00.
2017-09-16 12:02:42 -05:00
xjm 2df73e2c00 Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard 2017-09-16 11:19:25 -05:00
xjm 44a5c4cbe0 Issue #2901739 by andriyun, Jo Fitzgerald, mfernea, xjm: Fix 'Squiz.Arrays.ArrayDeclaration' coding standard 2017-09-15 16:52:14 -05:00
Lee Rowlands 32e402231e
Issue #2905000 by amateescu, timmillwood: Add a default filter on the 'published' field in the base views wizard plugin for publishable entity types 2017-09-15 07:36:58 +10:00
Nathaniel Catchpole 9ef92a408b Issue #2905627 by Lendude, dawehner: Part-2: Convert UpdatePathTestBase to BrowserTestBase 2017-09-08 14:24:15 +01:00
Nathaniel Catchpole ff6eea71c5 Issue #2614504 by blackra, jibran, mohit_aghera, Yogesh Pawar, larowlan, lokapujya, Munavijayalakshmi, thpoul, andypost, xjm: Values of 'name' & 'email' fields should be NULL when comment has author (uid > 0) 2017-09-05 13:42:31 +01:00
Nathaniel Catchpole 1f191080c1 Issue #2902723 by mfernea, ccjjmartin: Fix 'Drupal.Commenting.FunctionComment.ReturnCommentIndentation' coding standard 2017-08-21 13:39:47 +09:00
xjm 11ef44a7f7 SA-CORE-2017-004 by arshadcn, amateescu, Wim Leers, Berdir, Lendude, dawehner, klausi, pwolanin, xjm, mpdonadio, mlhess, larowlan, milesw
(cherry picked from commit 65cef2e9f5)
2017-08-16 12:41:33 -05:00
Nathaniel Catchpole 7d1c57aada Issue #2787873 by claudiu.cristea, jibran, amateescu, catch, dawehner, cilefen, xjm, larowlan, vaplas: Add a base class for entity reference selection handlers and fix the structure of their configuration 2017-08-15 14:12:50 +09:00
Nathaniel Catchpole d7c496150e Issue #2569805 by quietone, Jo Fitzgerald, mikeryan, joelpittet, heddn, Adita, Miguel.kode, iMiksu, tvb, maxocub, juancasantito, phenaproxima, alexpott, neclimdul, xjm: For Drupal migration, identify the source module 2017-08-15 14:08:32 +09:00
xjm 620cc4c752 Issue #2898344 by jibran, xjm, Lendude, dawehner, andypost, mradcliffe, larowlan, annajl, Bojhan: Add filters to the comments administration pages 2017-08-14 20:51:57 -05:00
Lee Rowlands 04d69926b4
Issue #1986606 by jibran, pcambra, vijaycs85, dawehner, andypost, mbovan, Arla, adnen, vprocessor, tkuldeep17, xjm, kim.pepper, dobe, snig, larowlan, miro_dietiker, tim.plunkett, Berdir, Lendude, plach, olli, damiankloip: Convert the comments administration screen to a view 2017-07-29 16:55:37 +10:00
Lauri Eskola 7f27bbaba1 Issue #2704871 by pepegarciag, Mile23, Manuel Garcia, ieguskiza, snehi, gaurav.pahuja, dimaro, rajeshwari10, gargsuchi, pashupathi nath gajawada, penyaskito, xjm, ZeiP, Wim Leers, alexpott: Replace usages of deprecated method drupal_render() 2017-07-03 18:35:13 +03:00
Chris McCafferty d5d37e0649 Revert "Issue #2787873 by claudiu.cristea, amateescu, jibran, dawehner, catch: Add a base class for entity reference selection handlers and fix the structure of their configuration"
This reverts commit b0900c73b1.
2017-05-27 20:49:12 -04:00
Nathaniel Catchpole b0900c73b1 Issue #2787873 by claudiu.cristea, amateescu, jibran, dawehner, catch: Add a base class for entity reference selection handlers and fix the structure of their configuration 2017-05-24 13:15:19 +01:00
Alex Pott 4398109471 Issue #2293697 by Wim Leers, dawehner, Jo Fitzgerald, clemens.tolboom, vedpareek, tedbow, Munavijayalakshmi, hchonov, alexpott, effulgentsia, tstoeckler, Crell, klausi, EclipseGc: EntityResource POST routes all use the confusing default: use entity types' https://www.drupal.org/link-relations/create link template if available 2017-05-15 13:05:40 +01:00
Alex Pott 780a770ded Issue #2403703 by claudiu.cristea, pritish.kumar, larowlan, alexpott, jibran, pwolanin, dawehner, Berdir: Allow field types to enforce the cardinality 2017-05-12 11:14:25 +01:00
Alex Pott 012bca1943 Issue #2687977 by claudiu.cristea, alexpott, prics: Comment::preSave() unconditionally sets hostname to client host 2017-03-14 08:56:27 +00:00
Nathaniel Catchpole 01f8bd64ed Issue #2854529 by alexpott, xjm, klausi, Chi, Mixologic: Fix Drupal.Scope.MethodScope - all methods should have scopes 2017-03-06 11:25:01 +00:00
xjm 52e3eec616 Issue #2776975 by joelpittet, dawehner, tim.plunkett, xjm, pfrenssen: March 3, 2017: Convert core to array syntax coding standards for Drupal 8.3.x RC phase 2017-03-03 19:20:24 -06:00
Alex Pott 23d140fd6c Issue #2117305 by disasm, Pavan B S, ieguskiza, Jo Fitzgerald: Replace usages of db_or() and db_and() 2017-03-03 11:37:33 +00:00
xjm f0f5a2ef6d Issue #2851761 by MariaDenysyuk, andypost: Comment logs messages under both 'content' and 'comment' loggers; make it consistent 2017-02-16 19:32:42 -06:00
xjm a7c559777e Issue #2807785 by claudiu.cristea, OwilliwO, mpdonadio, cllamas, klausi, xjm, Berdir, Wim Leers, Mile23, daffie, Prashant.c, dawehner, sneha_surve: Move global constants from *.module files into interfaces 2017-02-12 16:50:41 -06:00
Chris McCafferty 91736cadcb Issue #2665152 by alexpott, Andrej Galuf, tfranz, longwave, andypost, jsimonis, bojanz: Simplify module form structure and fix bugs when Suhosin is used 2017-02-10 16:55:04 -05:00
Nathaniel Catchpole a90e686658 Revert "Issue #2665152 by alexpott, Andrej Galuf, tfranz, longwave, jsimonis, andypost, bojanz: Certain modules can't be enabled when Suhosin is used"
This reverts commit 7f37114aca.
2017-02-09 21:40:11 +00:00
Nathaniel Catchpole 6018d048bb Issue #2389335 by Berdir, naveenvalecha, claudiu.cristea, almaudoh, joachim, jibran: Deprecate entity.query service and replace with using the entity storage's getQuery() method 2017-02-09 21:10:34 +00:00
Alex Pott 1fcd3d5c56 Issue #2808233 by gnuget, dawehner, Wim Leers, tedbow, Chi, dysrama: REST 403 responses don't tell the user *why* access is not granted: requires deep Drupal understanding to figure out 2017-02-09 19:56:28 +00:00
Nathaniel Catchpole 7f37114aca Issue #2665152 by alexpott, Andrej Galuf, tfranz, longwave, jsimonis, andypost, bojanz: Certain modules can't be enabled when Suhosin is used 2017-02-09 16:09:22 +00:00
Nathaniel Catchpole 3d72d4be83 Issue #2194783 by Berdir, vprocessor, andypost, Antonnavi, tim.plunkett, Crell, Mile23, catch: Rename EntityTypeInterface::isSubclassOf() to ::entityClassImplements() 2017-01-11 22:06:48 +00:00
Nathaniel Catchpole 83018b7596 Revert "Revert "Issue #2834291 by claudiu.cristea, Berdir, amateescu, timmillwood, catch: Add a SQL index for entity types that are using EntityPublishedInterface""
This reverts commit d2e8cbdc2e.
2016-12-29 16:26:55 +00:00
Nathaniel Catchpole d2e8cbdc2e Revert "Issue #2834291 by claudiu.cristea, Berdir, amateescu, timmillwood, catch: Add a SQL index for entity types that are using EntityPublishedInterface"
This reverts commit 7469f227c6.
2016-12-21 15:23:09 +00:00
Nathaniel Catchpole 7469f227c6 Issue #2834291 by claudiu.cristea, Berdir, amateescu, timmillwood, catch: Add a SQL index for entity types that are using EntityPublishedInterface 2016-12-20 13:44:43 +00:00
Alex Pott ad4629a14a Issue #2835515 by seanB: ContentEntityForm interface changed, change all forms extending it 2016-12-14 11:54:02 +00:00
xjm e223ebe5f7 Revert "Issue #2704871 by pepegarciag, ieguskiza, snehi, gaurav.pahuja, rajeshwari10, dimaro, gargsuchi, pashupathi nath gajawada, penyaskito, Manuel Garcia, Mile23: Replace usages of deprecated method drupal render()"
This reverts commit ae3ee31751.
2016-12-12 13:03:21 -06:00
xjm ae3ee31751 Issue #2704871 by pepegarciag, ieguskiza, snehi, gaurav.pahuja, rajeshwari10, dimaro, gargsuchi, pashupathi nath gajawada, penyaskito, Manuel Garcia, Mile23: Replace usages of deprecated method drupal render() 2016-12-12 12:49:03 -06:00
Alex Pott 67c7387fd9 Issue #2789315 by amateescu, timmillwood, claudiu.cristea, sandervd, GroovyCarrot, catch, Wim Leers, Berdir, pfrenssen, twistor, xjm: Create EntityPublishedInterface and use for Node and Comment 2016-12-02 22:18:44 +00:00
Alex Pott ee23c1875a Revert "Issue #2789315 by amateescu, timmillwood, claudiu.cristea, sandervd, GroovyCarrot, catch, Wim Leers, pfrenssen, Berdir, twistor, xjm: Create EntityPublishedInterface and use for Node and Comment"
This reverts commit d2af11699a.
2016-11-28 14:48:43 +00:00
Alex Pott d2af11699a Issue #2789315 by amateescu, timmillwood, claudiu.cristea, sandervd, GroovyCarrot, catch, Wim Leers, pfrenssen, Berdir, twistor, xjm: Create EntityPublishedInterface and use for Node and Comment 2016-11-28 14:27:42 +00:00
xjm 3e58b4981c Issue #2572553 by larowlan, LoMo, znerol, Upchuk, fil00dl, Truptti, maartendeblock, andypost, tim.plunkett, keesje, catch: Incomprehensible validation message when anonymous tries to submit comment with an existing username 2016-11-08 11:12:01 -06:00
Nathaniel Catchpole bf42d739aa Issue #2408667 by pguillard, mpdonadio, marvin_B8, Xano, geertvd, lomasr, dawehner, yched: Rename Field.php to EntityField.php 2016-10-21 13:57:58 +01:00
Nathaniel Catchpole 6ddd0ba55c Issue #2810381 by timmillwood, plach: Add generic status field to ContentEntityBase 2016-10-20 13:33:59 +01:00
xjm a8579d60d5 SA-CORE-2016-004 by alexpott, andypost, antongp, cashwilliams, catch, Chi, dawehner, dsnopek, Heine, kierheyl, Pere Orga, pwolanin, larowlan, q2u, stefan.r, xjm
(cherry picked from commit 75d6aa33cd)
2016-09-21 12:41:50 -05:00
Nathaniel Catchpole 35778ab269 Issue #2730973 by Wim Leers, larowlan, JonasRMuc, andypost: Comment permalinks are cached incorrectly when multiple pages exist 2016-09-02 09:20:44 +01:00
Nathaniel Catchpole 0515e65bd5 Issue #2642260 by gnuget, gargsuchi, naveenvalecha, dinarcon: Missing URL fragment for the comment's title link 2016-08-30 14:34:08 +01:00
Alex Pott 89df46f5d2 Issue #2428509 by andypost, rahul.shinde, emma.maria: Comment links weight should be managed by view display 2016-08-29 10:40:17 -05:00
Nathaniel Catchpole da5262f4c5 Issue #2703159 by vdanielpop: Add plural labels to Entity Types in Comment module 2016-08-29 08:15:31 +01:00
Nathaniel Catchpole f6ae58526c Issue #2572801 by alexpott, vprocessor, andriyun, andypost, chishah92, Mile23, attiks, hussainweb, klausi, dawehner, pfrenssen: Fix 'Drupal.WhiteSpace.ScopeIndent' coding standard 2016-08-28 18:16:36 +01:00
Alex Pott 2e5e060c53 Issue #2783395 by Mile23: Fix 'Drupal.Commenting.FunctionComment.InvalidReturn' coding standard 2016-08-28 06:25:45 -05:00
Alex Pott 24343f970b Issue #2763283 by naught101, thomas73: Failure on comments with no subject 2016-08-13 23:52:22 +01:00
Nathaniel Catchpole ad76a96a40 Issue #2723607 by valthebald, deepakaryan1988: Remove entity_load* usage for dynamic entity types 2016-08-05 09:29:20 +01:00
Alex Pott a1af9fdcc9 Issue #2468375 by tduong, joaquin.solino, Berdir, David4514: Status Reports: The following token types are not defined but have tokens - $info['types']['entity'] 2016-07-28 16:36:01 +01:00
Alex Pott 7f8e1c93fc Issue #2627678 by claudiu.cristea, larowlan, jonathanjfshaw, alexpott, catch: Specify view mode to be used by comment formatter 2016-07-19 14:47:30 +01:00
Alex Pott 55707edb94 Issue #2737607 by generalredneck: Migration Source Plugins are not extendable because of ambiguous database field names 2016-06-08 11:45:28 +01:00
Alex Pott f0e5004171 Issue #2723521 by valthebald: Remove entity_load* usage for action entity type 2016-05-11 15:47:50 -05:00
Alex Pott d7b430a402 Issue #2707255 by timmillwood, dawehner, amateescu, Berdir: All content entities should inherit baseFieldDefinitions 2016-05-08 17:50:14 -05:00
Alex Pott 133c212ed9 Issue #2719695 by alexpott, Mile23: Fix 'Drupal.Classes.ClassDeclaration.CloseBraceAfterBody' coding standard 2016-05-08 10:05:38 -05:00
Alex Pott d5d0d6ce87 Issue #2572777 by andypost, alexpott, attiks, andriyun: Fix 'Squiz.Strings.ConcatenationSpacing' coding standard 2016-05-05 12:07:19 +01:00
Alex Pott 6ab5a3aaa1 Issue #2715741 by Mile23, pfrenssen: Fix 'Drupal.Classes.FullyQualifiedNamespace' coding standard 2016-04-30 15:11:15 +01:00
Alex Pott 6098437ef5 Issue #2572793 by attiks, andypost: Fix 'Drupal.WhiteSpace.OperatorSpacing' coding standard 2016-04-29 12:02:20 +01:00
Alex Pott 6dce6c2a9f Issue #2697909 by pguillard, himanshugautam, snehi, aburrows, jhodgdon: Fix "login (noun/adjective)" vs. "log in (verb)" in comments (and logout/log out) 2016-04-27 16:16:19 +01:00
Nathaniel Catchpole 548fe99192 Issue #2709525 by kevin.dutra: Comment bundle label is incorrect 2016-04-25 11:46:38 +01:00
Alex Pott 904b0de0d3 Issue #2700661 by anoopjohn: Ensure core compliance to Drupal.Commenting.FunctionComment.ParamCommentIndentation (part 1). 2016-04-16 13:17:32 +01:00
Nathaniel Catchpole e60bb5703e Issue #2703339 by alexpott: Many files have the wrong file permissions of 755 and not 664 2016-04-11 10:54:44 +09:00
Alex Pott bfde6d3423 Issue #2665992 by alexpott, klausi, heykarthikwithu, xjm, tstoeckler: @file is not required for classes, interfaces and traits 2016-04-09 15:48:39 +01:00
Nathaniel Catchpole 187a3c54ae Issue #2689655 by cafuego: D8 Comment date views arguments uses incorrect database column 2016-04-04 11:41:53 +09:00
Alex Pott 0db5b13892 Issue #2686207 by Berdir: Convert simpletest kernel tests in modules A-I to phpunit 2016-03-28 19:36:47 +01:00
Alex Pott 4202cdd04b Issue #2684141 by benjy, dawehner: Convert migrate kernel tests to KernelTestBaseTNG 2016-03-21 09:31:08 +00:00
Nathaniel Catchpole fb8d5b1f0c Issue #2686765 by sidharthap, thhafner: cacheUntilEntityChanges() is deprecated and should be replaced with addCacheableDependency() 2016-03-16 10:34:36 +09:00
Alex Pott ee9f19cf98 Issue #2553655 by dawehner, Berdir, martin107: Convert ViewKernelTestBase to use KernelTestBaseTNG 2016-03-15 14:54:15 +00:00
Nathaniel Catchpole 1cc137f372 Issue #2676222 by alexpott, johnrosswvsu: Move MigrationInterface out of the migrate\Entity namspace now they are plugins 2016-03-15 08:52:48 +09:00
Nathaniel Catchpole 732300b86d Issue #2625696 by chx, benjy, alexpott, catch, mikeryan, andypost, phenaproxima: Make migrations themselves plugins instead of config entities 2016-03-14 21:23:43 +09:00
Nathaniel Catchpole 4d185faff1 Issue #2674408 by alexpott, dawehner: Fix Drupal.Classes.UnusedUseStatement standard in core 2016-03-14 09:22:44 +09:00
Alex Pott daa52e9f1a Issue #2684095 by dawehner, amateescu: Convert field kernel tests to KernelTestBaseTNG 2016-03-10 15:54:24 +00:00
Nathaniel Catchpole 49a419dea2 Issue #2471689 by klopez, shashikant_chauhan, harings_rob, snehi, jhodgdon: Entity API documentation should consistently refer to handlers rather than controllers 2016-03-09 08:33:30 +09:00
Nathaniel Catchpole 7cd80db7bc Issue #2641682 by gnuget: permalink breaks in comment 2016-03-08 11:26:17 +09:00
Nathaniel Catchpole 85ef01dec6 Issue #2678550 by imrancluster: Need full stop (.) for description field's help text in Add comment type' section 2016-03-07 09:08:31 +09:00
Nathaniel Catchpole 348aa684a7 Issue #2672600 by borisson_, arunkumark, Mile23: Replace deprecated usage of entity_create('node') with a direct call to Node::create() in comment,datetime,editor,field,hal,system,taxonomy,views 2016-03-04 10:59:57 +09:00
xjm 73f91709fb Revert "Issue #2625696 by chx, alexpott, benjy, mikeryan, andypost, phenaproxima: Make migrations themselves plugins instead of config entities"
This reverts commit 694994fe9b.
2016-02-29 13:14:52 -06:00
Alex Pott 694994fe9b Issue #2625696 by chx, alexpott, benjy, mikeryan, andypost, phenaproxima: Make migrations themselves plugins instead of config entities 2016-02-27 08:23:44 +00:00
Scott Reeves f7c02dfef2 Issue #2579691 by lauriii, alexpott, stefan.r, YesCT, dawehner: Remove usages of SafeMarkup::isSafe() 2016-02-25 12:54:06 +05:30
Nathaniel Catchpole 45689e4b8f Issue #1808478 by Mile23, prhavile, naveenvalecha, llbbl, hctom, nikunjkotecha, Lars Toomre, deepakaryan1988, mrjmd, jgeryk, mlevasseur: Add missing type hinting to Comment module docblocks 2016-02-24 14:23:02 +09:00
Alex Pott 98d39d1bdb Issue #2669400 by jungle, dimaro, rakesh.gectcr, lluvigne, Mile23: Replace deprecated usages of entity_create('type') with a direct call to <EntityType>::create() 2016-02-20 10:55:26 +05:30
Nathaniel Catchpole a3f5ca8a81 Issue #2338747 by dawehner, chx: Move {router} out of system.install and create the table lazy 2016-02-19 13:26:53 +09:00
Nathaniel Catchpole 854649c923 Issue #2641624 by heykarthikwithu, Mac_Weber, kostyashupenko: Replace deprecated usage of entity_create('user') with a direct call to User::create() 2016-02-16 16:54:49 +09:00
Nathaniel Catchpole 55e3b42546 Issue #2667346 by mohit_aghera: EntityViewsData extending classes should use $this->t() but many use t() 2016-02-15 20:45:25 +09:00
Nathaniel Catchpole a79891dadf Issue #2503411 by DuaelFr, Mac_Weber: Replace deprecated usage of entity_create('comment*') with a direct call to Comment/CommentType::create() 2016-02-15 08:43:00 +09:00
Nathaniel Catchpole d4e7281f28 Issue #2641586 by Mac_Weber, marvin_B8: Replace deprecated usage of entity_create('field_storage_config') with a direct call to FieldStorageConfig::create() 2016-02-09 08:52:18 +09:00
Nathaniel Catchpole 9d050abbf0 Issue #2643274 by swentel, Mac_Weber, amateescu: EntityAutocomplete does not recognize URLs ending with a parenthesis 2016-02-01 19:03:03 +09:00
Alex Pott 991bb0856b Issue #2526064 by Mile23, naveenvalecha: Remove usage of comment_view() & comment_view_multiple() 2016-01-19 14:22:33 +00:00
Alex Pott 9f4034ac98 Issue #2642236 by TR: Various setUp() and tearDown() methods are not protected (the sequel) 2016-01-05 10:53:08 +00:00
Alex Pott 1546d71f80 Issue #2605214 by Gábor Hojtsy, ChuChuNaKu, EclipseGc, dawehner: Views InOperator::getValueOptions() children do not return values like InOperator::getValueOptions() 2016-01-04 11:58:51 +00:00
Nathaniel Catchpole 7a4f6f5802 Issue #2494775 by DuaelFr: Replace deprecated usage of entity_create('action') with a direct call to Action::create() 2016-01-01 13:26:26 +09:00