Dries Buytaert
9986cb36b5
- Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
2004-07-02 18:46:42 +00:00
Dries Buytaert
3701c02e59
- Small watchdog module optimization by Morbus.
2004-07-02 18:32:12 +00:00
Dries Buytaert
d279d16ccb
- Patch #8996 by James: theme_user_picture() linked to bad url.
2004-07-02 18:13:45 +00:00
Dries Buytaert
07d490058e
- Patch #8952 by Morbus: made the watchdog module more doxygenish:
...
* @file header with a oneliner and blurb description about watchdog.module.
* standardized the text between admin/help#watchdog and admin/logs.
* tweaked the descriptions of log types available ever so slightly.
* removed anything that referred to the old settings page.
* added an assumed 'type' to one of the menu's.
2004-07-02 07:11:35 +00:00
Dries Buytaert
c7b27b18de
- Simplified referrer links. Suggested by Morbus.
2004-06-30 21:00:41 +00:00
Dries Buytaert
60513799a1
- Patch #8941 by JonBob: allow local tasks to be ordered by weight, as well
...
as simplifying the theming of local tasks so they can be more easily
rendered in a non-tab manner.
2004-06-30 20:45:45 +00:00
Dries Buytaert
fcded380a8
- Patch #8937 by James: fixed typo.
2004-06-30 20:43:07 +00:00
Dries Buytaert
e3e051cc0d
- Patch #8585 by Junyor: sort blog items by creation date. Added some database indices.
2004-06-30 07:26:02 +00:00
Dries Buytaert
4f00182423
- Fixed typo reported by Steven Mansour: form_set_name() -> form_set_error()
2004-06-30 05:44:59 +00:00
Dries Buytaert
b284477713
- Bug #8898 by Morbus: fixed incorrect date being displayed in the forum overview when a topic has no comments yet.
2004-06-29 20:35:58 +00:00
Dries Buytaert
8edcb47063
- Patch #8900 by Junyor: updated help text to reflect menu changes.
2004-06-29 20:24:29 +00:00
Dries Buytaert
f04547efd1
- Patch #8908 by Junyor: fixed broken link on the drupal.module setting page.
2004-06-29 19:41:04 +00:00
Steven Wittens
93b56f5073
- Fixing some usability bugs with aggregator admin: some forms lacked status messages, and redirected to themselves
...
- Now uses drupal_goto after every form submission [1]. Patches for other modules will follow.
[1] http://lists.drupal.org/archives/drupal-devel/2004-06/msg01147.html
2004-06-28 23:16:59 +00:00
Steven Wittens
6a00c7c2f2
- Preventing caching of page when status messages are present (needed for redirects after form submission to work properly)
...
- Double-quotes to Single-quotes
2004-06-28 20:00:53 +00:00
Dries Buytaert
fa192ae767
- Fixed bug with user information not being shown in the profile forms.
2004-06-28 08:32:16 +00:00
Dries Buytaert
2f393aaf31
- Fixed glitch in _user_categories(). Reported by Steven Mansour.
2004-06-28 08:09:30 +00:00
Dries Buytaert
47ef2e21de
- Fixed 'pass by reference'-bug in the validation code and further simplified
...
it.
2004-06-28 07:23:53 +00:00
Steven Wittens
72155f8bbf
Using drupal_specialchars() instead of htmlentities(). htmlentities() is not UTF-8 safe.
2004-06-27 22:09:12 +00:00
Dries Buytaert
7ebcac265a
- Removed left-over instance of _user_profile().
2004-06-27 19:41:55 +00:00
Dries Buytaert
1b1c47025a
I refactored quite a bit of the user.module:
...
$ diffstat user.patch
database/database.mysql | 4
database/database.pgsql | 2
database/updates.inc | 10 -
modules/block.module | 20 +-
modules/locale.module | 9
modules/profile.module | 108 +++++++----
modules/system.module | 8
modules/user.module | 456 +++++++++++++++++++-----------------------------
8 files changed, 289 insertions(+), 328 deletions(-)
More functionality, less code. Here is a list of the changes:
- Some user API changes:
+ When $type is 'form', you have to return an associative array of groups. In turn, each group is an array with a 'title', 'data' and 'weight'.
+ A new $type has been added, namely 'categories'. User settings can be organized in categories. Categories can be sorted, as can the groups within a category. (Ordering 'categories' is somewhat broken due to a bug in the menu system.)
- The 'my account > edit' page will use subtabs for each 'category'. Read: you can break down the account settings into multiple subpages.
- Profile module improvements:
+ Added support for private fields to the profile module!
+ Improved workflow of profile administration pages.
+ Improved the form descriptions.
- Code improvements:
+ Unified user_edit() and user_admin_edit().
+ Unified and cleaned up the validation code. Fixed some validation glitches too.
2004-06-27 19:10:52 +00:00
Steven Wittens
83851509f6
- Tweak for sticky patch: ANSI SQL does not allow ordering on a column which is not part of the selected fields.
2004-06-27 18:10:39 +00:00
Dries Buytaert
47e3055f56
- More updates
2004-06-27 16:04:35 +00:00
Dries Buytaert
0a35280978
- Patch #8603 by TDobes: added support for sticky forum topics to the blog
...
and forum module.
2004-06-27 16:02:31 +00:00
Dries Buytaert
d4e7affba8
- Bugfix: made it possible for administrators to edit the values of custom
...
profile fields of users.
2004-06-24 22:12:36 +00:00
Dries Buytaert
ea676b3a1c
- Patch #8785 by Morbus Iff (modified): with the acceptance of "anonymous-but-named" comments, anonymous users can leave behind their names as opposed to the 'anonymous' setting. These names are shown as "$name (not verified)" on regular nodes. This change provides the same display for forums (assuming anonymous commenting on forums is allowed).
2004-06-24 05:11:28 +00:00
Dries Buytaert
3468310a61
- Patch #8778 by Morbus Iff: with the tabs patch, user/login, user/register, and user/password now show all three forms, as opposed to just the requested relevance. The attached patch implements a quick workaround: three new callbacks, and a cheapy modification of user_page where I use a ternary to test whether arg(2) exists (as it would in the case of user/nnn/edit). If it does, we set that to $op, and if it doesn't (in the case of user/login, etc.), we set arg(1).
2004-06-24 05:07:55 +00:00
Dries Buytaert
9f4a335887
- Taxonomy fix by Matt.
2004-06-23 20:52:46 +00:00
Dries Buytaert
23142e0efb
- Patch #8757 by Morbus Iff: fixed redirection after comment moderation.
2004-06-23 05:41:16 +00:00
Dries Buytaert
ae6aa4e59e
- Patch #8758 by Morbus Iff: allow users to modify their profile under
...
the new tabs system.
2004-06-23 05:11:35 +00:00
Dries Buytaert
fa2be0b8f0
- Fixed administration pages being broken due to tabs changes, improved form
...
handling and form descriptions and fixed an incorrect title.
2004-06-22 20:33:12 +00:00
Dries Buytaert
e288b4ddb1
- Patch #8747 by JonBob: extended and standardized node.module Doxygen
...
comments, and made formatting and quote usage more consistent.
2004-06-22 20:24:27 +00:00
Dries Buytaert
0ee30cbca2
- Fixed broken URLs in the user module (access rules) due the the recent
...
tabs patch.
2004-06-22 20:21:13 +00:00
Dries Buytaert
81bebc01fd
- Patch #8500 by jseng (modified/simplified): improved usability of editing
...
URL aliases.
2004-06-22 18:26:24 +00:00
Dries Buytaert
f6b7f75512
- Patch #8733 by Morbus Iff: fixed statistics module.
2004-06-22 18:13:04 +00:00
Dries Buytaert
0be1e6cff7
- Issue #8735 by njivy: made the pager code ignore EOLs.
2004-06-22 05:45:15 +00:00
Dries Buytaert
7f06d092a5
- Patch #8708 (modified) by Stefan: refactored the 'add new block' form a but.
2004-06-21 21:11:36 +00:00
Dries Buytaert
77ec01f592
- Patch #8344 by Kjartan: drupal_http_request() did not always handle EOLs
...
correctly.
2004-06-21 20:14:41 +00:00
Dries Buytaert
090743bdba
- Patch #8670 by asimmonds: more spelling fixes.
2004-06-21 20:05:37 +00:00
Dries Buytaert
bfa7d178a9
- Patch #8713 by stefan: changed some 'node's to 'post's. Usability improvement.
2004-06-21 20:01:49 +00:00
Dries Buytaert
ad3c6f345e
- Patch #8681 by asimmonds: more help text updates
2004-06-21 08:26:20 +00:00
Dries Buytaert
e30fdce6cb
- Patch #8617 by TDobes: changes all gifs to pngs for better consistency (and
...
to get of proprietary formats).
2004-06-20 20:19:59 +00:00
Dries Buytaert
bd49f9d1b3
- Patch #8681 by Stefan: more help fixes.
2004-06-20 20:12:00 +00:00
Dries Buytaert
b713e3d489
- Patch #8617 by TDobes: changes all gifs to pngs for better consistency (and
...
to get of proprietary formats).
- Added forum-sticky.png. Made by Steven.
2004-06-20 20:04:28 +00:00
Dries Buytaert
c2d7419f23
- Patch #8681 by stefan: fixed some broken URLs and help texts.
2004-06-20 19:49:14 +00:00
Dries Buytaert
4b449a7e5d
- Patch #8670 by asimmonds: spelling fixes.
2004-06-20 19:43:28 +00:00
Dries Buytaert
4e1f368e88
- "" -> ''.
2004-06-20 08:31:45 +00:00
Dries Buytaert
ce45c91a53
- Patch #8652 by Adrian: incorrect implode.
2004-06-20 08:30:57 +00:00
Dries Buytaert
efed4cfc70
- Patch #8679 by asimmonds: fixed spelling mistakes.
2004-06-20 08:27:03 +00:00
Dries Buytaert
1b46d7fcfe
- Patch #8614 by JonBob: better way to display menus.
2004-06-19 14:57:44 +00:00
Dries Buytaert
d2ff1ca54e
Changed 'static' back to 'sticky' ... ;-)
2004-06-19 10:45:06 +00:00