Commit Graph

15 Commits (6ca7f1e2f3536cc2713944d70264cf01d135f1c8)

Author SHA1 Message Date
Dries Buytaert 6ca7f1e2f3 Various smaller changes: one of the more interesing is the addition of a
check()-function which validates input from forms.  The allowed HTML tags
can be configured in config.inc.
2000-09-21 07:20:17 +00:00
Dries Buytaert 1f0a87f4e7 Over the last 2 days I redid and reorganized an afwul lot of code and
made quite a lot of additions.   The most remarkable addition is the
diary server, which I slapped together in less then 40 minutes.   Most
of the other changes are however `unvisible' for the user but add much
value to a better maintainability from a developer's objective.  Like
always, I fixed quite a number of small bugs that creeped into the code
so we should have a bigger, better and more stable drop.org.

Unfortunatly, some theme update _are_ required:


REQUIRED THEME UPDATES:
=======================

* use format_username() where usernames are used
* use format_date() where timestamps/dates are used
* use format_email() where e-mail addresses are displayed
* use format_url() where url are displayed
* replace 'formatTimestamp' with format_date
* replace 'morelink_*' with 'display_morelink'

[most of these functions are in function.inc or template.inc]

___PLEASE___ (<- this should get your attention ;) update your themes
as soon as possible - it only takes 30 min. to get in sync with the
other themes.  Don't start whining about the fact you don't know what
to change ... either eat the source cookie, or ask me to elaborate on
a few changes.  Just let me know what's puzzling you and I'll try to
help you out!


TODO LIST FOR NEXT WEEK
=======================
* Add checks for max. text length in textarea's?  Is there an HMTL
  attribute for this or ...?
* Comment moderation + mojo
* Edit/admin user accounts: block, delete, change permissions, ...
* E-mail password, change password, change e-mail address -> extra
  checks and routines to validate such `special' changes.
* Input checking - input filter: bad words, html tags, ...
2000-09-11 07:45:22 +00:00
Dries Buytaert 7daa3fd8ee A really BIG, BIG UPDATE, after two straight days of nothing but code
and sleep, new stuff is finally in drop.org.  This is a quite large
and wide-ranging update, which affects almost all of the system files
in one way or another.  I fixed quite a lot of bugs and added quite a
lot of new features, mostly administrative tools as these were really
lacking.  It's far from finished but it's a start ...
2000-09-04 16:14:46 +00:00
Dries Buytaert 8035aebac4 * Just a quick test 2000-07-13 13:34:24 +00:00
Dries Buytaert f7b554d9c9 * Fixed 2 small bugs in submit.php reported by Pepijn (kangaroot.net). 2000-07-13 13:30:44 +00:00
Dries Buytaert e214bd06c6 Updates:
--------

* URI/URL enhancements to make the URLs more comprehensive and shorter.
* Fixed a bug in submit.php that slipped in during the latest commit.
* Changed a few tidbits on the calendar.
* Fixed a bug in most themes:
    $tid       --> $cid
    COUNT(tid) --> COUNT(cid)
  Updated most themes except for UnConeD's.
* Fixed a handful of problems with Jeroen's theme.  However, Jeroen's
  theme is still not working yet - some features are completly missing,
  making the theme not very useful ...

Any known bugs left?  If not, I'll head on tonight and add some new
features.  I'll probably add basic admin tools to edit articles and
such.  Once done, we can start on the comment moderation.
2000-07-13 07:21:57 +00:00
Dries Buytaert 75129c1fdd Bugfixes:
(1) fixed SQL bug in search.php.
  (2) fixed SQL bug in discussion.php.
  (3) fixed theme-bug in submit.php.
  (4) fixed theme-bug in discussion.php.
  (5) fixed Dries2-theme: it more or less works now though
      I still have to change the look/layout.

Important:
  (3) and (4) did fix the i-suddenly-seem-to-log-out behavior.
2000-07-12 07:15:09 +00:00
Dries Buytaert de707b6797 * Various small bugfixes and enhancements: I think I fixed all bugs I
knew about.
* The code generated by my theme `Dries' is now 90% of the time
  aligned correctly. :o)
2000-06-22 20:21:07 +00:00
Dries Buytaert 0f5a60e109 IMPORANT - IMPORTANT - :)
=========================

Wulp.  I did a major upgrade by (a) breaking a lot of stuff and (b) by
re-doing those things in a much better way.  I redesigned the stories
and submissions SQL tables, the way they work and the way they co-
operate together.

In addition, I changed the way parameters are passed to
$theme->abstract() and $theme->article().  Instead of passing a
sh!tload of parameters that only cluttered the code and required too
much pre-processing on the engine-side, we now pass a singly object
$story.  $story has more variables then the paramaters we used to pass,
so it allows for better theming (if you feel like it).

I'm not finished yet but I decided to upload my changes so you can
start patching and updating your themes: PLEASE update your themes
ASAP!  I don't plan making heavy changes like this again, so don't
get intimiated. ;)  You mainly have to update article() and abstract()
as well as a minor update of footer():

article(), abstract():
----------------------
 - use the $story object - see my theme!
 - the morelink can now be themed.  Currently you can use the function
   morelink_bytes() in function.inc to `render' the old morelink.  The
   idea is to make a morelink_words() or morelink_lines() sooner or
   later because "188 bytes in body" is not half as clear as "52 words
   in body".  Clearly, "52 words" is much more informative. ;-)

footer():
---------
 - in the article-part, you need to update the displayRelatedLinks():
   instead of passing it $sid, you need to pass it $story (after you
   globaled $story).

Everything should display correct on the following pages:
 - main page
 - article page (follow a `read more | xxx bytes in bdoy | x comments' link)
 - submission queue
Check if they work with your theme: they should as they work fine for
me (theme `Dries') ...  If you got stuck, just look at my theme or ask
for a hand on the list!


Hopefully you can update your themes asap.  Thanks in advance.
2000-06-21 15:41:20 +00:00
Dries Buytaert 988707a61c Here we go again with a rather large commit:
fixed a lot of annoying bugs and boxed whatever there was left to be boxed.

 * user.class.php: renamed $user->update() to $user->rehash().
 * user.class.php: fixed a typical quote-bug in $user->rehash().
 * functions.inc: fixed bug in displayOldHeadlines().
 * functions.inc: improved several functions.
 * account.php: fixed major bug in showUser().
 * account.php: added some extra words to the human-readable
                password-generator(tm).
 * account.php: boxed ALL functions! Fieuw!
 * submit.php: add some general information and guidlines on how to
               post submissions.
 * config.inc: re-thought the categories to be more generic.
 * submission.php: minor changes
 * search.pph: fixed minor bug with the author's names.

Woops.  I have an exam within 4 hours: back to my books. ;-)

--------------------------------------------------------------------

 * Anyone could check sumbit.php, sumbission.php and faq.php for
   typoes?
 * Anyone could adjust calendar.class.php to fit IE?  *huh*huh*
 * Don't be scared to hack along (see below)!  I'll be working on
   the submissions and comments.

--------------------------------------------------------------------

Status of drop v0.10:
(make the system erational' and release it.)

  - submissions:
      submission queue         (75% complete)
      submission moderation    (75% complete)
  - comments:
      comment moderation       ( 0% complete)
      comment administration   ( 0% complete)
      fixup timestamp mess     ( 0% complete)
  - user system:
      mail password            ( 0% complete)
      user administation       (50% complete)
      patch admin.php          ( 0% complete)
      account confirmation     ( 0% complete)
      e-mail confimation upon modification of e-mail address
                               ( 0% complete)
  - proper handling of forms: text2html, html2text
      html2txt, txt2html       (10% complete)
      bad-word filter          (80% complete)
      automatic link detection ( 0% complete)
      allowed HTML-tag checker ( 0% complete)
  - FAQ:
      cleanup, disclaimer      (50% complete)
  - theme:
      box everything          (100% complete)
2000-06-20 07:33:17 +00:00
Dries Buytaert 17a008caa2 * Boxed submit.php - whew, it's a pain to edit all those print statements.
* Fixed quite a lot of HTML-bugs in the HTML code generator and cleaned up
  the generated coded quite a lot.

=> much better now :)
2000-06-16 13:45:57 +00:00
Dries Buytaert 1887ba8018 Hoeray! I have a first core version of submission moderation up and
running.  This means people can submit stories, and moderators can
moderate stories.  When a submission reaches a certain positive
threshold (currently set to 2) the submission becomes a story and up
it goes.   If a submission reaches a certain negative threshold
(currently set to -2) the submission is dumped.

The fact this is all done by our visitors (without our intervention)
makes it truly spiffy imho.  The website can live a life on it's own,
fed by the visitors.

Beware, a lot of work need to be done though ... it's just a first
basic implementation with the core functionality.  There are quite
a lot of things that I'll need to change, extend and improve.  But
comments, suggestions and ideas are - as always - welcomed.

Please read this log message carefully!  It features quite a lot of
important information.

To test the moderation, log in, select theme 'Dries' (the other themes
need a small update) and head by clicking the one and only 'submission
moderation' link.  Don't be afraid to submit lame/funny/useless
stories for testing purpose ... as soon we go public, we'll wipe out
the story database.  ;-)


WHAT'S NEW?
-----------
* Added 2 new operations to user.class.php to set and retrieve the
  user's "history".  Very evil but required to avoid people voting
  twice.
* Moved dbsave() from account.php to functions.php.  In addition, I
  added a new function to user.class.php called `save()' that ...
  well, saves the object back to the database.  It's (IMHO) a better
  approach compared to dbsave(): it keeps things organized. ;-)


BUGFIXES:
---------
* Fixed a (heavy) memory leak in the constructor of user.class.php:
  mysql_fetch_array() returns an _associative_ array which made the
  constructor `pollute' the object with a lot of useless variables.
* Fixed the slash-problem on the account pages. :-)
* Fixed UnConeD's theme glitch, alas the warning.
* Fixed the e-mail address not showing in the confirmation email
  (upon registration).
* Fixed the typical quote and backslash problems in submit.php.
* submit.php now uses the database abstraction layer.

IMPORTANT:
----------
* You can check the new submission system at:
    http://beta.drop.org/submission.php
  or by following the `submission moderation' link from my theme.
* UnConeD, Jeroen: you'll need to update your themes to take
  advantage of the new function: displayAccount().  This function
  will display the `submission moderation' link when a user is
  logged on.
* Natrak: you might want to apply the patches in user.class.php
  on the other sites using the same user-system.
2000-06-13 09:42:58 +00:00
Dries Buytaert 595316b004 * Bugfix: the `story submission'-form is no longer toasted due to the new
user system.
2000-06-05 15:59:06 +00:00
natrak 776dcde419 Hopefully this will not break anything *prays*
;)
2000-06-02 18:36:14 +00:00
Dries Buytaert 2569242afd Imported sources 2000-05-18 19:52:00 +00:00