Commit Graph

269 Commits (6ab934660c2abaf3350dacd0368e75f7f8fce90e)

Author SHA1 Message Date
Dries Buytaert be7bb9be9b - Patch #63704 by chx: fixed the order of validation. (Needs more wide-spread testing before being backported to DRUPAL-4-7.) 2006-05-16 10:11:19 +00:00
Neil Drumm 58db2b27a4 #62829 by Jaza, Multi selects in hook_settings are broken 2006-05-16 01:55:57 +00:00
Dries Buytaert ee12ae6493 - Patch #63251 by sammys: added validation of dates. 2006-05-15 06:27:32 +00:00
Neil Drumm 9cff02e91b #61802 by Zen, Double spaced sentences clean up 2006-05-07 00:08:36 +00:00
Neil Drumm 133617cb13 #57834 by chx, Replace theme_weight with more appropriate process_weight 2006-05-04 09:57:14 +00:00
Neil Drumm 6411e09dc9 #56508 by chx (modified), Remove notices from form.inc and move theme_form_element from theme.inc to form.inc. 2006-05-02 09:26:33 +00:00
Neil Drumm 58db005b93 Forward port from 4.7
#60797, moved comment, patch by Zen
2006-04-30 00:40:57 +00:00
Neil Drumm 8e10f1d48c Forward port from 4.7
#60797, leftovers, patch from chx
2006-04-30 00:32:48 +00:00
Gerhard Killesreiter d04b659673 #60797, theme('taxonomy_term_select', $element) called, but output is ignored, patch by chx 2006-04-28 12:40:54 +00:00
Steven Wittens b538ba870b #60370: #theme callback on element broken 2006-04-26 18:21:07 +00:00
Steven Wittens 83e279a7b8 #58059: Fix bug with IE not sending form button values when pressing enter. 2006-04-26 18:12:24 +00:00
Gerhard Killesreiter 8d48ee17b9 #60338, better name for #form_submitted, patch by chx 2006-04-25 20:46:57 +00:00
Gerhard Killesreiter 83cd31cd76 #60267, user password get lost if editing user account, patch by Jaza 2006-04-25 20:44:00 +00:00
Gerhard Killesreiter 3300aa2d4e #59960, Can't store the value of submit, patch by Zen 2006-04-25 10:00:57 +00:00
Dries Buytaert 9e9e0e2c63 - Patch #60017 by praseodym: add id's to hidden form fiels. Useful for Javascript purposes. 2006-04-24 19:34:50 +00:00
Gerhard Killesreiter 8d4147637a #59526, password_confirm fields don't flag error when required and empty, patch by sammys 2006-04-22 08:24:55 +00:00
Gerhard Killesreiter 0d0a939ab1 #47544, Checkboxes, radios, and improper use of LABELs., patch by Zen 2006-04-21 06:43:03 +00:00
Gerhard Killesreiter b354396b69 #59528, password_confirm fields don't highlight errors, patch by sammys 2006-04-20 16:35:29 +00:00
Gerhard Killesreiter 297ed741f8 #58221, Turn #after_build into a functions array in order to make validation of date fields possible. Patch by yched, tenrapid
Also makes forms API more consistent (see #pre_render)
2006-04-20 07:11:37 +00:00
Dries Buytaert d071f99172 - Removing trailing whitespace. 2006-04-17 20:48:26 +00:00
Steven Wittens fb8ef28375 #56921: Remove all reference magic from form api. w00t. 2006-04-15 21:52:44 +00:00
Gerhard Killesreiter 062412e1a4 #58586, code simplification, patch by chx 2006-04-13 19:50:13 +00:00
Gerhard Killesreiter 61b9b3587d #58586, Checkbox element is broken, patch by chx 2006-04-13 17:49:25 +00:00
Gerhard Killesreiter 6b80d55a80 #58536, A #required element always needs validation, patch by chx
fixes checkboxes, radios, and selects.
2006-04-13 14:56:13 +00:00
Gerhard Killesreiter 70aae83c8e #58166, fixes for typos, patch by Uwe Herrmann 2006-04-11 11:33:15 +00:00
Gerhard Killesreiter 29f51725e2 #57836, Remove the reference indicator from drupal_validate_form, patch by chx 2006-04-08 17:18:25 +00:00
Gerhard Killesreiter 8c3ea3d869 #57832, fix reference for forms docs, patch by Moshe 2006-04-08 17:16:10 +00:00
Gerhard Killesreiter 27e562e390 #57694, Class attributes form-select and form-textarea more consistent, patch by Flanker, cleaned up by me 2006-04-07 13:22:12 +00:00
Gerhard Killesreiter 14178a50f1 #55408, hook_validate called twice, patch by chx 2006-04-07 13:00:37 +00:00
Gerhard Killesreiter c3cb1ea435 #56921, revert earlier patches, patch by chx 2006-04-06 15:30:19 +00:00
Gerhard Killesreiter 35c4ad2bc2 #54104, CSS classes broken on all form elements, patch by Nedjo 2006-04-05 18:12:48 +00:00
Neil Drumm 352fb57d6c #56921 by chx, removing the $form = from $form = form_builder($form_id, $form) then it works. 2006-04-02 23:14:51 +00:00
Gerhard Killesreiter 3a84ed2a90 #56921, break up references in _validate, patch by chx 2006-04-02 13:07:00 +00:00
Neil Drumm 6ad023451a #56143 by chx: Non multiple form elements also set to array 2006-03-29 23:29:41 +00:00
Gerhard Killesreiter 4779490127 #56089, fixed typo, patch by tenrapid 2006-03-28 06:03:14 +00:00
Gerhard Killesreiter cad28df22b #56089, $form['#redirect'] shouldn't be clobbered by the _submit return value., second try, patch by chx 2006-03-28 01:45:41 +00:00
Gerhard Killesreiter d0818780e3 #55766, Custom submit handlers get insufficient arguments, patch by Adrian 2006-03-27 18:07:32 +00:00
Gerhard Killesreiter ca1dbd8099 #56089, $form['#redirect'] shouldn't be clobbered by the _submit return value., patch by Adrian 2006-03-27 18:04:29 +00:00
Gerhard Killesreiter 4db70f8a62 somehow escaped committing, belongs to #28625 2006-03-26 17:41:06 +00:00
Gerhard Killesreiter 247451fca5 do not allow override of #value => NULL for #type => value elements
patch by chx
2006-03-25 18:02:52 +00:00
Gerhard Killesreiter dcfbcf5c71 #51303, Forms with form tokens fail validation for anonymous users when caching is enabled, patch by chx 2006-03-20 16:28:10 +00:00
Gerhard Killesreiter d4db109e42 #54019, Can't set classes on submit elements, patch by m3avrck 2006-03-16 15:32:44 +00:00
Gerhard Killesreiter c7c9b57ec2 #53967, form_builder checkbox/textfield/validation stuff, patch by hunmonk and chx 2006-03-15 08:57:37 +00:00
Dries Buytaert 2a3e3b2fed - Patch #53480 by chx et al: clean and harden form_builder for various types of posted elements. 2006-03-12 09:28:12 +00:00
Neil Drumm c828449991 #52292 by hunmonk, multipart node forms broken
Adds a new form attribute that lets form writers hook into a conveniant place when the form building requires knowledge of the validation results.
2006-03-09 22:55:01 +00:00
Dries Buytaert 21a3c24380 - Patch #52292 by hunmonk/chx: multipart node forms were broken. 2006-03-06 14:46:51 +00:00
Neil Drumm 4b663a62af #52484 by chx: filter_form needs validation 2006-03-05 02:46:55 +00:00
Dries Buytaert 350b8b346e - Patch #51516 by Steve Dondley: it should be possible to set errors on selection items. 2006-03-04 18:03:57 +00:00
Gerhard Killesreiter aeead6cf9c #48209, Prevent system module forms (system/theme settings) from saving 'reset' to the variables table., patch by Markus Petrux 2006-02-27 14:57:54 +00:00
Gerhard Killesreiter 539994e29c #43826, no way to suppress form_id, patch by wtanaka 2006-02-27 14:46:49 +00:00
Dries Buytaert f29e0405f4 - Patch #49799: fixed form goto problem (Today's critical bugfix #1.) 2006-02-23 10:30:03 +00:00
Dries Buytaert e172910dd3 - Patch #43953 by wtanaka: fixed problem with buttons on GET-forms. 2006-02-21 16:08:54 +00:00
Dries Buytaert 62b610d8d9 - Patch #48918 by chx: remove POST from poll. 2006-02-17 10:51:57 +00:00
Dries Buytaert 583d5a4ee9 - Patch #48622 by adrian: remove drupal_goto from _submit functions. 2006-02-10 05:25:57 +00:00
Dries Buytaert da1d11935d - Patch #45821 by jvandyk: improved 'illegcal choice in .' messages 2006-02-09 07:34:16 +00:00
Dries Buytaert afde65151c - Patch #47420 by m3everck: put fieldset descriptions at top. 2006-02-05 15:45:09 +00:00
Dries Buytaert 035fc5c649 - Patch #47544 by Morbus: Element #name, not #id, were being passed to theme_form_element. 2006-02-04 09:50:28 +00:00
Steven Wittens b005189398 - #42083: Form API IP should be xhtml id of <form> tag 2006-02-02 02:10:31 +00:00
Steven Wittens 635cf5eb6d - #39179: Allow skipping of option validation for selects 2006-02-02 01:35:32 +00:00
Dries Buytaert dbf0bb7e4c - Patch #46255 by chx et al: don't save formapi data for user registrations. 2006-01-27 15:57:43 +00:00
Dries Buytaert 8e47cc95c5 - Patch #45845 by Jaza: Weight elements need default value of zero. 2006-01-26 13:39:48 +00:00
Dries Buytaert 0293848199 - Patch by chx: made form tokens work. 2006-01-25 13:59:05 +00:00
Dries Buytaert 552b5e5e7a - Patch #46227 by yogadex: fixed problem with form validation. 2006-01-25 08:40:53 +00:00
Dries Buytaert 6f978a04f9 - Patch #45793 by chx: fixed bug in user.module that results in storing plain text passwords. 2006-01-24 10:15:03 +00:00
Dries Buytaert 4c83a0347a - Patch #36591 by chx: use session id to check form submissions, rather than the IP address. 2006-01-24 10:13:27 +00:00
Dries Buytaert b9f6b72a58 - Patch #45834 by jvandyk: removed forms API warnings. 2006-01-24 08:20:45 +00:00
Dries Buytaert 616544667f - Patch #45281 by flevour/chx: fixed problem with categories not being set properly validated. 2006-01-19 17:53:53 +00:00
Dries Buytaert 7b87ff1a6f - Patch #45365 by chx: critical bugfix: Fix and simplify selection options. 2006-01-19 09:22:16 +00:00
Dries Buytaert e84a98a22b - Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API. 2006-01-19 08:54:41 +00:00
Dries Buytaert 9528c30037 - Patch #45281 by flevour/chx: fixed problem with categories not being set properly on editing. 2006-01-18 19:46:57 +00:00
Dries Buytaert a35ca55bbf - Patch #45224 by jvandyk: improved PHPdoc comments. Corrected spelling, improved grammar. 2006-01-18 19:04:12 +00:00
Dries Buytaert 84beb25884 - Patch #44771 by jvandyk: small performance improvement. 2006-01-15 16:55:35 +00:00
Steven Wittens 2e9bbda791 - #44772: {} -> [] (in anticipation of PHP de-deprecation) 2006-01-15 07:14:14 +00:00
Dries Buytaert a3ae365057 - Patch by Zen/drumm: fixed glitch in form_select. 2006-01-13 07:44:59 +00:00
Dries Buytaert 57447dc571 - Patch #42105 by chx / merlinofchaos: made form elements themable. 2006-01-10 19:37:27 +00:00
Dries Buytaert 6aae7ff747 - Patch #40927 by vhmauery: added attributes for files. Required for some contributed modules to work. 2006-01-09 10:22:12 +00:00
Dries Buytaert df82a1edc4 - Patch #43835 by jakeg: critical bugfix: fixed admin/modules. 2006-01-08 16:04:58 +00:00
Dries Buytaert 7f083e0c2f - Patch #35570 by ccourtne and Steve: forms API does not adhere #return_value for checkboxes. 2006-01-08 12:40:25 +00:00
Dries Buytaert cade6b2bda - Patch #39179 by chx; make optgroups work with choice checker. 2006-01-06 07:15:47 +00:00
Dries Buytaert 780d33c77b - Patch #43429 by drumm: bug fix: made comparison of checkboxes more strict. 2006-01-05 11:05:14 +00:00
Dries Buytaert 749284633f - Patch #42057 by hunmonk and chx: made saving user accounts work again. 2006-01-02 08:35:59 +00:00
Dries Buytaert 45db74aa77 - Patch #37494 by darius / chx: fixed problem with dates. 2006-01-02 08:04:02 +00:00
Steven Wittens 5e49dd2a68 - #42446: Resizable textareas. 2005-12-29 03:59:30 +00:00
Dries Buytaert 6c2f3e7982 - Patch #39179 by chx et al: fix checkboxes #default_values. 2005-12-26 11:14:14 +00:00
Dries Buytaert 4f13fbb709 - Patch #41023 by wtanaka: custom form elements can't cleanly set a value for themselves. 2005-12-19 14:43:42 +00:00
Dries Buytaert eb412f7c7e - Patch #39179 by chx: improved validation of forms. 2005-12-19 14:30:53 +00:00
Dries Buytaert bd4fe6ede9 - Patch #40813: Taxonomy forms should be in a fieldset. 2005-12-16 06:23:46 +00:00
Dries Buytaert b6dba6fa8e - Patch #40486 by chx/netbjarne: duplicate form id's breaks html validation. 2005-12-15 22:47:16 +00:00
Dries Buytaert 764f1177ef - Patch #40631 by Chris Johnson: is_array() slower than isset() or empty(). 2005-12-14 20:10:45 +00:00
Dries Buytaert c0a43c50dc - Patch #40765 by chx: fixed problem with form types. 2005-12-14 13:22:19 +00:00
Dries Buytaert 0f80b09a4a - Patch #39875 by chx: make form sorting work with PHP5. 2005-12-05 21:21:49 +00:00
Dries Buytaert 7ef324ec84 - Unrolled chx's form sort patch. 2005-12-05 09:48:54 +00:00
Dries Buytaert a2d8174cd4 - Patch #39875 by chx: form_sort is broken with PHP5. 2005-12-05 08:47:24 +00:00
Dries Buytaert 77f55aa7f2 - Patch #39989 by hunmonk: can't pass args properly to #process callback. 2005-12-05 08:41:29 +00:00
Dries Buytaert a806db88fa - Patch #39085 by chx/angie: simplified #tree-#parent code. 2005-12-04 08:14:07 +00:00
Dries Buytaert 75d2089fba - Patch #39155 by Alex/chx: #validate, #submit, #process consistency 2005-12-03 09:44:50 +00:00
Dries Buytaert 26bd449860 - Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'. 2005-12-02 15:21:01 +00:00
Dries Buytaert 63a78a617b - Patch #38038: hook_elements override instead of merge. 2005-11-28 16:37:11 +00:00
Dries Buytaert 50f148dab7 - Patch by chx: fixed form validation. 2005-11-23 16:21:12 +00:00
Dries Buytaert a3f84c7782 - Patch #38349 by hunmonk:
1. hook_form_validate_alter and hook_form_execute_alter have been eliminated. there usage was limiting and a bit confusing. now, only hook_form_alter remains
   2. replacing those hooks are the #validate and #execute attributes. these can be used either when building the form in a module, or via hook_form_alter. these attributes are built in array form, to allow for flexibility in how they are called. for example, a module could simply add an element to the #validate array via hook_form_alter if it wished to perform additional validation, or it could redeclare the entire #validate array if it wanted to override any existing validation
   3. attributes #validation_arguments and #execution_arguments have been added to allow args to be used w/ custom validation and execution functions. this are also declared in array format
   4. renamed #valid attribute to #validation. this doesn't cause any conflicts, and makes the naming convention more consistent
   5. renamed the existing #execute attribute associated w/ submit buttons to #submit
2005-11-22 21:31:15 +00:00
Dries Buytaert 1b388b4653 - Patch #35863 by chx: add link to forms API documentation 2005-11-21 18:14:23 +00:00
Dries Buytaert 03dda45573 - Patch #37752 by chx and Richard: renamed #post_process to #after_build. 2005-11-21 18:10:26 +00:00
Dries Buytaert 463ffe24ec - Patch #35724 by asimmonds: fixed handling of empty form fields. 2005-11-21 16:21:51 +00:00
Dries Buytaert 61ebf7b56b - Patch #37401 by webchick: fixed dependency of date selection form element on profile module. 2005-11-21 09:42:14 +00:00
Dries Buytaert f852db82dc - Patch #37915 by chx: improved readability of forms API. 2005-11-18 13:48:09 +00:00
Steven Wittens 36b62d969d #37078: forms api does not respect form_id when populating from ['edit'] or validating 2005-11-12 03:45:57 +00:00
Dries Buytaert 3768616a65 - Patch #36829 by hunmonk: current form_id_form_alter will cause name collisions. 2005-11-08 20:17:42 +00:00
Dries Buytaert d8425d23d2 - Patch #36606 by hunmonk: validation callback functions can't be overridden. 2005-11-08 20:02:24 +00:00
Dries Buytaert 7f0909ebfd - Patch #36407 by DriesK: make sure the private key is set. 2005-11-06 11:38:56 +00:00
Dries Buytaert cbcb85560a - Patch #35816 by chx: fixed problem with checkbox handling in the form API. 2005-11-03 15:42:31 +00:00
Dries Buytaert 5684831958 - Patch #35874 by asimmonds: added missing $Id$ tags. 2005-11-01 09:58:01 +00:00
Dries Buytaert f2185037be - Patch #35630 by adrian: fixed problem with how form trees are build. 2005-10-29 07:00:33 +00:00
Steven Wittens f2675cfd3a - Remove left over class from form api conversion 2005-10-26 01:25:01 +00:00
Steven Wittens fbaede7ec0 - #35264: More form api fixes 2005-10-26 01:24:09 +00:00
Steven Wittens 5f0e0f3649 - #33433: More form API fixes, and error handling improvements by Chx. 2005-10-13 10:02:31 +00:00
Dries Buytaert 75fe6b6c0a - Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes. 2005-10-11 19:44:35 +00:00
Dries Buytaert fd96728f3c - Second batch of form API fixes by chx. 2005-10-09 10:39:15 +00:00
Dries Buytaert 7863be5e82 - Patch #33433 by chx: fixed a number of form API problems.
* Default form value
    * Leftover debug function in form.inc
    * PHP5 issue with comment date (I got this patch from another issue)
    * Validation error fix (was calling legacy form validate)
    * Lots o' warnings on comment preview
    * Filter tips plus argument (gremlins. I swear this was not there.)
    * Message to clear what's going on with system settings
    * Non-freetagging taxonomies fixed
2005-10-08 12:21:47 +00:00
Dries Buytaert 7e1527ee61 - Patch #29465: new form API by Adrian et al.
TODO:
  + The contact.module was broken; a new patch for contact.module is needed.
  + Documentation is needed.
  + The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00