Commit Graph

224 Commits (66f228f2b44facb13521a7accc8a9d5dcb44aa05)

Author SHA1 Message Date
Steven Wittens 198ec98f75 #18329: Unify confirmation messages (and make them themable) 2005-03-03 20:51:27 +00:00
Dries Buytaert 59c2208ea6 - Patch #16253 by Goba: incremental improvements to the new content markers.
Goba: it would be nice if one of the core themes would showcase this functionality. ;-)
2005-01-30 09:53:19 +00:00
Dries Buytaert 467dbdc4a1 - Patch #16253 by Goba: this simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though. 2005-01-27 12:57:08 +00:00
Dries Buytaert 2b17b3a966 - Patch #13907 by Neil: less ways to set the page title.
* Less logic in theme code.
   * Encourages use of the menu system.
   * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
   * Very slightly more efficient.
2004-12-15 21:19:42 +00:00
Dries Buytaert cc508ad2f0 - Patch 13738 by TDobes: there was a major theming issue I missed in my bug-testing after the multi-site patch landed. Styles now seem to have their description field filled with the filename of their parent theme/template rather than the theme_key of the parent. This is a problem because init_theme still expected to see the theme_key and therefore dropped back to the base theme (no theme at all). 2004-12-01 22:41:19 +00:00
Dries Buytaert 4e4e2aa777 - Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated. Check your contributed modules and update them accordingly. 2004-11-24 22:50:25 +00:00
Dries Buytaert 30110a8770 - Patch #6166 by Moshe: node preview should not display links. Push the links to the theme instead of the theme having to pull them in using node_link().
TODO:
    1. Update theme upgrade instructions in the handbook: node_link() is gone.
    2. Remove page_link() just like we removed node_link().
2004-11-23 23:11:59 +00:00
Steven Wittens 583e63c136 Theme system bug: only show search box if search.module is enabled. 2004-10-14 02:38:33 +00:00
Steven Wittens 9c9905d9a0 #10648: Fix watchdog-related tablesort coloring bug in IE, add support for <tr> attributes to theme_table() and reduce specificy of watchdog coloring CSS rules. 2004-09-14 20:01:00 +00:00
Dries Buytaert b84b6e42cf - Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments. 2004-09-09 05:51:08 +00:00
Steven Wittens 98a9d5ee2d - #9576: Patch by TDobes, only allow the user to choose between enabled themes. 2004-08-22 14:43:49 +00:00
Dries Buytaert 6881cc9ad6 - Patch #10202 by Ax: don't emit an erroneous whitespace when no table headers are provided. Makes for clean XHTML. 2004-08-21 16:21:56 +00:00
Dries Buytaert 03fa966c1f - Patch #9576 by TDobes: bugfix: fixed bug in recent theme system changes. 2004-08-21 10:16:13 +00:00
Steven Wittens 9f2d6f0e51 - Fixing 'flash of unstyled content' in bluemarine/pushbutton, which got reintroduced after the template changes.
- Fixed separate styles: added theme_get_styles() and the xtemplate {styles} tag to make sure stylesheets get included in the right order (drupal-specific, template-specific, style-specific).
- Fixing missing class on screenshots.
- Renamed drupal_get_theme_setting() and drupal_get_theme_settings() to theme_get_setting() and theme_get_settings().
2004-08-20 17:21:37 +00:00
Dries Buytaert 81861a8e91 - Removing some DOS-style line endings. Thanks TDobes. 2004-08-20 09:34:53 +00:00
Dries Buytaert 6ea5c56ded - Theme system changes. Please consult http://drupal.org/node/view/9576 for details. 2004-08-20 07:51:27 +00:00
Steven Wittens 9cb5f7cdf8 Avatar/picture fixes:
- Changing theme('image') so the automatic image size fetching can be toggled independently from attributes. Specifying attributes and autosizing are 2 different things.
- Suppressing PHP errors from getimagesize() using @. drupal_set_message() is used to report these errors already and in a much prettier way.
- #9958: Fixing broken displaying of avatars.
- Don't show the default avatar in 'edit my account' if the user has no avatar of his/her own.
- Added ability to delete avatars (without having to replace them).
2004-08-20 04:35:33 +00:00
Dries Buytaert d5e1e83e77 - Patch #9900 by Al: bugfix: don't display two <hr />'s. 2004-08-16 21:27:39 +00:00
Dries Buytaert f99830a498 - Patch by Al: improved the admin/help pages (first step). 2004-08-10 05:44:17 +00:00
Dries Buytaert 9bbdb71ee4 - Patch #9330: ucfirst() gives problem when used with multibyte charset.
Replaced the use of ucfirst() with a CSS-based solution.
2004-08-06 20:15:32 +00:00
Dries Buytaert c71bfded3d - Patch #9657: more intelligent theme() function. Hopefully, Adrian will be
able to use this patch too.
2004-08-04 20:40:01 +00:00
Steven Wittens edc2f13d82 - #9287: More doxygen/documentation fixes by JonBob 2004-07-22 16:06:54 +00:00
Dries Buytaert 56fa37cb8e - Made the example theme display status messages. Not sure why it wasn't. 2004-07-08 16:08:21 +00:00
Dries Buytaert 5b73def39b - Changed the way status messages are printed as per Kristjan's suggestion:
http://drupal.org/files/issues/error_messages_list.png (issue #9138).

  drupal_set_message() has been changed to group message by type and a
  helper function, theme_status_message(), is added to display the messages.
  Chameleon and Xtemplate have been updated to use this new function.

- Updated CHANGELOG.txt.
2004-07-08 16:04:07 +00:00
Dries Buytaert 9986cb36b5 - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site). 2004-07-02 18:46:42 +00:00
Dries Buytaert 090743bdba - Patch #8670 by asimmonds: more spelling fixes. 2004-06-21 20:05:37 +00:00
Dries Buytaert b713e3d489 - Patch #8617 by TDobes: changes all gifs to pngs for better consistency (and
to get of proprietary formats).

- Added forum-sticky.png.  Made by Steven.
2004-06-20 20:04:28 +00:00
Dries Buytaert 54b77d6435 Tabs patch!
CHANGES
-------

 + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.

 + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.

 + Grouped settings. All settings have been grouped under 'administer > settings'.

TODO
----

 + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.

 + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
Dries Buytaert cd48e69b29 - Patches #6863 by Kristjan and Moshe: implemented pretty tables and fixed some tablesort glitches. 2004-06-02 05:35:51 +00:00
Dries Buytaert 7f08110a5e - Improved form handling.
+ Introduced two new functions:
      1. form_set_error($name, $message): files an error against the form
         element with the specified  $name.
      2. form_has_errors(): returns true if errors has been filed against
         form elements.

  + Updated the form handling:
       1. The form_ functions will add 'class="error"' when a form field
          has been found to be erroneous.
       2. The error message is passed to theme_form_element() when the
          particular form field has been found to be erroneous.

  + I updated the user and profile module to take advantage of these new
    functions.

  + IMPORTANT: the _user() hook changed.  The 'validate' case should no
    longer retun an error message when something goes wrong but should
    set it with form_set_error().
2004-05-31 09:40:56 +00:00
Dries Buytaert 5cd371578e - Patch #6863 by Moshe: add 'class="active"' to the table elements of
the active column.
2004-05-29 17:38:54 +00:00
Dries Buytaert 01f08e86dd - Patch #7966 by Goba: The box has it's content wrapped in a paragraph now, which is not suitable for the purposes the box is used in. Boxes are used to wrap tables or forms with titles. The comment module uses theme(box, ...) to wrap forms into boxes for example. Therefore using a paragraph does not make the output valid XHTML and a div is needed. 2004-05-24 05:10:32 +00:00
Dries Buytaert dc8a68ea28 - Patch #6791: mark required fields. Modified patch by Michelangelo. 2004-04-24 15:39:31 +00:00
Dries Buytaert 8fa7d74d4d - Patch #6498 by jhriggs: <label> requires opening and closing tags. 2004-04-21 20:11:22 +00:00
Dries Buytaert 8145c7695c - Tracker and forum module improvements!
Note: the CSS of the tracker page has changed.  Some CSS files still have
  to be updated.
2004-03-20 13:23:34 +00:00
Dries Buytaert 38e89dd03f - Patch 5775 by Goba: fixes the only error currently reported by the doxygen
parser in Drupal core, plus fixes some errorneous (copy-pasted) doxygen docs.
2004-02-10 19:28:39 +00:00
Dries Buytaert 8239dd0711 - Changed some double quotes to single quotes. 2004-02-08 21:04:08 +00:00
Dries Buytaert 294286687a - Patch #5163 by mattias: allow theme_table to accept a html attributes
parameter array.
2004-01-31 21:07:54 +00:00
Dries Buytaert c8daca07d2 - Patch #5448 by pz: removed code duplication from theme.inc. 2004-01-29 06:47:19 +00:00
Dries Buytaert abc8317a0b - Fixed bug #5384: tablesort outputs invalid HTML (improved patch). 2004-01-29 06:42:03 +00:00
Dries Buytaert 007efa52b6 - Fixed bug #5384: tablesort outputs invalid HTML. 2004-01-28 22:24:48 +00:00
Kjartan Mannes acd5eb1eb6 - Fixed bug #5439: Doxygen errors in theme.inc 2004-01-28 11:36:29 +00:00
Dries Buytaert 667022830e - Patch 5140 by Moshe: removed the theme("header") and theme("footer") functions. 2004-01-26 19:05:21 +00:00
Dries Buytaert 6fc2070a22 Patch 5114 by Kjartan:
- Adds drupal_set_header() and drupal_get_headers().
 - Cache now stores custom headers.
 - Replace theme_head() with drupal_get_html_head(), added drupal_set_html_head().
 - Added RSS autodiscover links to node, blog and taxonomy pages.
2004-01-14 22:30:09 +00:00
Dries Buytaert ee305ae144 Round 3 of aggregator improvements:
- Added support for new tags:
   + Optinal feed image: <image> tag.
   + Dublin core dates: <dc:date> <dcterms:created>, <dcterms:issued>,
     <dcterms:modified>.
 - Usability improvements:
   + On the administration page, made the feed/bundle titles link
     to the feeds/bundles' pages.  On the feed/bundle's page, made
     the 'Last updated' field link to the administration page.
   + Moved the 'syndication' menu one level down.
 - Updated some content sensitive help.
 - Further improved themeability.
 - Fixed some invalid HTML.
2004-01-11 15:05:21 +00:00
Dries Buytaert 56a637fefa - Fixed bug #5004: missing <title>-tag in the example theme. 2004-01-07 18:42:02 +00:00
Dries Buytaert f6082cda98 - Fixed bug 4916: users can have disabled themes. Modified patch by Mathias.
1. Remove the theme object.  There is no need to keep it around since meta
      information for a theme can be retrieved via list_themes().  All we really
      need is the theme name.

   2. Check if the user selected theme is enabled during theme initialization.
      This is the easiest place to put the check and doesn't mess with the user's
      settings.  Their database profile will still contain the disabled theme
      selection, but they will be rendering the default admin-selected theme
      until their chosen theme is once again activated.
2004-01-02 16:24:28 +00:00
Dries Buytaert 2dcb890477 - Fixed bug #4771: variable_get(site_name, ...) -> variable_get('site_name', ...); 2003-12-22 22:54:59 +00:00
Dries Buytaert 770174b299 - Updated documentation, small bug fix and small improvements to the <label>
tags.

  To be discussed and investigated: when a form element has no title an empty
  <label> tag will be emitted (eg. "remember me" checkbox).  This doesn't make
  sense but is our best option for now.
2003-12-22 15:38:07 +00:00
Dries Buytaert 54a74abaa3 - Accessibility improvements: made the <label>-tags use the 'for'-attribute. 2003-12-22 14:45:00 +00:00