Commit Graph

124 Commits (64ce2fb5fba4d399584c3c873b07013eebbff1f8)

Author SHA1 Message Date
natrak b885ccb824 - Fixed "Recent nodes" showing not showing "No nodes recently" in
account_track_site().
2001-07-12 15:14:15 +00:00
Dries Buytaert 5077cafd38 - account.php:
+ tidied up the texts

- common.inc:
    + undid bad coding style
    + fixed typo in permissions

- poll.module:
    + (automatically) removed tabs and trailing whitespaces
2001-07-07 16:37:27 +00:00
Dries Buytaert adfbda3d9a - Tidied up some stuff in account.php and theme.inc.
- Tidied up the box() API.
2001-07-07 11:14:25 +00:00
Dries Buytaert 9c43e8fc7a Extremely large commit:
- Fixed tiny quote problem in account.php.

- Fixed tiny bug in comment.inc.

- Fixed tiny bug in comment.module.

- Fixed tiny bug in meta.module.

- Simplified user_access() API.

- Rewrote link system: still needs fine-tuning and testing so don't
  upgrade if you are running a production site. ;)

  Updated all modules and themes to reflect this change.  All other
  themes and modules need updating too!
2001-06-29 22:08:57 +00:00
Dries Buytaert d29684a664 - Added simple referer module, for sake of fun. 2001-06-24 11:38:08 +00:00
Dries Buytaert 72065fb835 - Added a brand-new access.module which allows you to manage 'roles'
(groups) and 'permissions' ... (inspired by Zope's system).

    + Once installed, click the help-link for more information.

    + See updates/2.00-to-x.xx.sql for the SQL updates.

- Modified loads of code to use our new access.module.  The system
  still has to mature though: new permissions have to be added and
  existing permissions need stream-lining.  Awaiting suggestions.

- As a direct result of the new access system, I had to rewrite the
  way the top-level links in admin.php are rendered and displayed,
  and xhtml-ified admin.php while I was at it.

TODO

- Home-brewed modules need updating, home-brewed themes not.
  (Examples: file.module, trip_link.module)

- As soon we *finished* the refactoring of the user system (KJ has
  been working on this refactoring already) we should consider to
  embed this role and permission code into account.module ...
2001-06-20 20:00:40 +00:00
Dries Buytaert 7752dc4c7c - Fixed small bug in account.php with some usernames not being tolerated. 2001-06-19 20:21:04 +00:00
Dries Buytaert 29e0e0fc66 - Made it so that usernames can contain spaces. Like that, people can
use their full name as their username.
2001-06-19 06:55:19 +00:00
Dries Buytaert 3d73a48edc - Merged "system settings" and "module settings" into one page. IMHO
it wasn't a good idea to split them up in first place, and it turned
  out to be quite hard to decide where to put some variables.

  Also moved some variables around and even renamed a few variables
  while doing so.

- Added a page_header() and page_footer() to all top-level .php pages.
2001-06-17 20:35:48 +00:00
Dries Buytaert 03c06a86eb Oops, a rather large commit:
- Changed meta.module, node.module and index.php to use comma-seperated
  lists of attributes rather then "foo=a,bar=b" lists.  This makes it a
  a lot easier to use both modules.  In addition, error handling can be
  discarded as it can't be made any simpler, really ...

  It fits rather nicely in Drupal's design so I'm getting more and more
  happy with this meta.module (but we are not 100% there yet).

- node.module, node.inc:

   + Improved the node-related admin interface so that navigating back
     and forth the administrative menus is made both easier and faster.

   + Removed some redundant database fields from the node table.  See
     2.00-to-x.xx.sql!

   + Added 2 news hooks called "node_insert" and "node_update".  Just
     like this is the case with the existing hook "node_delete" these
     new hooks will automatically get called when a node has been
     inserted or udpated.  Note that this is an optional call-back that
     only needs to be implemented when required.  With the addition of
     these two hooks, the node mechanism (version 1) is pretty well
     completed.

- watchdog.module:
   + Fixed bug whit the 'regular messages' query in the watchdog.module.

- book.module:
   + Fixed bug in book.module: the 'parent' was not set properly when
     updating a book page.
   + Made it so that older versions of a book page are automatically
     reactived upon deletion of the most recent version, i.e. when
     doing a version roll-back.

- comment.inc:
   + Undid Remco's patch to comment.inc; it does not work in some cases.


- conf.module:
   + Fine-tuned some of the options in conf.module a bit.

- marvin.theme:
   + Visual changes to make it look better on Windows browsers.  Mind
     to give some feedback on this?
   + Fixed 3 HTML typos/bugs.
   + XHTML-ified the theme at a best effort basis; I didn't carry the
     XHTML specification with me.
   + Made use of the theme_slogan variable to display the site's slogan.
   + As soon we have at least one valid XHTML theme we can wonder on how
     to integrate other XML namespaces (cfr. MathML story at drop.org).

- database.mysql:
   + Updated database.mysql so that it contains all the latest "database
     patches".
2001-06-17 18:31:25 +00:00
natrak 21386979e7 Changes
- Added a conf option to disable/enable user registrations.
- Added a add account feature to account.module.
- Moved some functions from account.php to account.module.

Todo
- Move most (all?) of account.php to account.module.
2001-06-15 11:34:06 +00:00
Dries Buytaert 1045715f44 - Added very basic 'filters' to the watchdog.module which should make it
easier to sort through all the watchdog "noise".  I'm sure the current
  filters will do for 99% of all the Drupal sites though.

  (Sorry for the awful color scheme, Coney but I can't do any better.)
2001-06-15 10:43:39 +00:00
Dries Buytaert a37211cf82 - Revised the 'track sitename' feature: it should be more accurate now. 2001-06-08 19:49:20 +00:00
Dries Buytaert a616715ae2 - Revised the 'track sitename' feature: it should be more accurate now. 2001-06-08 19:43:42 +00:00
natrak ca908eb724 - Sorted by n.nid in account_track_comments/nodes() so users can see the
status on what they recently submitted. Will try and make this a little more
  configurable in the near future.
2001-06-04 22:09:16 +00:00
Dries Buytaert b0c349e247 - Moved most of the options in structure.module to node.module. The
structure.module either needs work, or replacement by index.module:
  see "admin > node > node settings".

  It will do for now and it can always made better when we can think
  of a better solution; it is the best I could think of.   Now what?
  index.module or structure.module?  I'm currently pro index.module.

- Drastically simplified "variable.inc".

- Removed most dependecies on structure.module from all content related
  modules.  Thus making our modules more modular.  ;)

- Fixed calculation glitch in queue.module.

- Fixed potential function name clash/conflict in rating.module, and
  simplified some code on my way.

- Started removing all global variables $status and $rstatus.  Global
  variables are "yucky" so in near future, we will replace all global
  $status variables by a call to node_status().  Originally, $status
  was only introduced as a temporary hack and nothing is as permanent
  as a temporary hack so I took it out when still possible.

- Changed the watchdog messages a bit.
2001-06-02 22:12:35 +00:00
Dries Buytaert 20397ad3d9 CHANGES
- Redid settings.module and even renamed it to conf.module.
    * Settings are now grouped in basic categories like "system
      settings", "module settings" and "filters".
  * Added new settings to make Drupal easier to configure and
  to make some aspects like the watchdog scale better.

- Renamed includes/settings.php to includes/conf.php.

- Added filter support to conf.module and introduced filter hooks so
  modules can implement and export new filters.  Example filters are
  an HTML filter (implemented), a profanity filter, an url converter,
  ASCII smileys to images filter and so on ...

- Reworked the check_* functions: user contributed content/input is
  only verified and filtered once in its lifespan.

NOTES

- Altough this is a large commit, no database changes are required.
2001-05-20 13:51:40 +00:00
Dries Buytaert 14ddbc473c - Created 2 new functions:
+ path_uri(): returns the fully-qualified URI of your drupal site.
    + path_img(): returns the image directory or http://image-server.com/
                  in case you prefer to load-balance bandwidth usage.

  Replaced all occurences of the variable "site_url" with path_uri()
  and removed "site_url" from "setting.module".

- Drastically simplified the node_save() API, which should make the
  node-forms more secure.  Updated "story.module", "book.module",
  "forum.module", "page.module" and "node.module" to reflect this
  change.  This is needs more testing so hit it, beat it, tease it.

- Fixed an occasional glitch in the configuration file loading logic.

- Made "queue.module" display an informative notice when an anonymous
  user tries accessing the moderation queue.

- Updated the hard-coded information in drupal.module a bit.
2001-05-15 18:38:57 +00:00
Steven Wittens 9790dc105c I think I've fixed the "chicken and egg"-problem when creating the first user account. I've made a snippet that deducts the host/path combo from $HTTP_HOST and $REQUEST_URI, which seems to be working OK over here. Try it out... 2001-05-14 21:12:41 +00:00
Dries Buytaert be8e898d23 - Uhm. Rewrote the module system: less code clutter, less run-time
overhead, and a lot better (simpler) module API.  I had to edit a
  LOT of files to get this refactored but I'm sure it was worth the
  effort.

  For module writers / maintainers:

  None of the hooks changed, so 95% of the old modules should still
  work.  You can remove some code instead as "$module = array(...)"
  just became obsolete.  Also - and let's thank God for this - the
  global variable "$repository" has been eliminated to avoid modules
  relying on, and poking in drupal's internal data structures.  Take
  a look at include/module.inc to investigate the details/changes.

- Improved design of the content modules "story", "book" and "node"
  (to aid smooth integration of permisions + moderate.module).  I'm
  still working on the permissions but I got side tracked for which
  I "Oops!".
2001-05-05 13:57:29 +00:00
Dries Buytaert fead09a8de Welp. Large commit ahead.
CHANGES:

- Added "read" and "write" permissions into drupal but removed
  it again because - when finished after 3 hours of work - it
  was considered nothing but added complexity that didn't buy
  us anything. :I

  (I'll explain this in detail on the mailing list, I guess.)

- Added a very simple help.module to group all available
  documentation on a single page.

- Fixed bug in node_control(), book.module: UnConeD forgot to
  global $user when updating the combobox code.

- Removed static wishlist.module: in future, the wishlist can
  be maintained as a page in our collaborative book.

- Revised most of settings.module: tidied up the code and the
  descriptions to accompany the settings and introduced a new
  "default maximum number of nodes to display on the main page"
  variable.

- Revised most of comment.module: the administration interface
  looks better now, integrated node permissions, and -finally-
  made it possible to delete comments.

- Polished on:
   + account.module
   + structure.module
   + locale.module
   + module.module
   + forum.module

- Form-ified:
   + account.php
   + account.module
   + setting.module
   + cvs.module
   + submit.php
   + comment.module
   + forum.module
   + book.module
   + page.module
   + locale.module

- Updated CHANGELOG

INFO:

- Designed a "generic tracker system with optional backends"
  on paper.  The idea is to allow registered users to hot-list
  certain topics, individual nodes or threads (comments) and
  to "plug-in" output backends like - for instance - an e-mail
  digest.  The design requires "intelligent blocks" though.


TODO:

- I want to tidy up the headline.module and backend.class as
  well as merge in headlineRSS10.module.  Julian spent quite
  some time working on headline.module but I'm not sure what
  he changed and whether he'd contribute it back?
2001-04-30 17:13:08 +00:00
Dries Buytaert a6e6dfb921 - Addition: added 2 new functions check_mail() and check_name()
to functions.inc useful for resp. verifying an e-mail address
  and username: currently used by account.php - but reusable by
  Julian's refer.module for example (prepares integration).
2001-04-19 19:54:37 +00:00
Dries Buytaert b9952f537d Large commit, read it carefully, and make the required changes to
your theme:

- corrected some missing translations in story.module.  Oops!
- grealty simplified the "moderation threshold mechanism"(tm) so
  that module writers don't have to worry about this.  As a result
  story.module and book.module became a bit smaller and easier to
  grasp.
- greatly simplified new "category" and "topic" code which is soon
  going to replace the "section" code.  Needs more work though so
  hang on thight.
- includes/section.inc and modules/section.module are replaced by
  includes/structure.module and modules/structure.module.
- beautified example.theme a bit without adding HTML complexity:
  it is a good example but still useful as a theme
- made theme example use "categories" and "topics"
    --> TAKE A LOOK AT IT AND UPDATE YOUR THEME
- made theme marvin use "categories" and "topics"
    --> TAKE A LOOK AT IT AND UPDATE YOUR THEME
- added 2 new "story listings" to administrator interface of
  story.module to verify story integrity.
- optimized comment table a bit (work in progress)
2001-04-16 11:38:12 +00:00
Dries Buytaert 1f0565806b - improved submit.php:
it now uses the new category code, incl content bindings.
  You can setup different "categories" which map on a content
  type.  Example:
    review   -> review.module
    article  -> story.module
    column   -> story.module
    announc. -> story.module
    addons   -> file.module
    themes   -> file.module
- "generalised" story.module and book.module's output.
- fixed bug in includes/timer.inc
- fixed glitch in theme example.theme: it said "$how by" but
  the variable $how has never been declared.
- added "drupal development settings" to display some timings
- more work on the categories/topics -> does NOT work yet
2001-04-15 17:01:32 +00:00
Steven Wittens 02e28d29a8 Typo: "the language the site" -> "the language of the site". 2001-04-12 18:18:38 +00:00
Dries Buytaert 0d14ee0b0c - fixed small bug in "recent nodes" 2001-04-08 16:33:34 +00:00
Dries Buytaert 8213f5b262 A lot of small changes (search-n-replace) make a big commit:
- fixed update bug in book.module
  - provide a log message when both adding and updating book pages
  - all configurable variables are now accessed through "variable_get()":
  - rewrote watchdog and submission throttle and removed watchdog.inc
  - improved robustness of sections.inc
  - imporved story.module
  - updated ./database/database.sql
2001-04-06 14:14:16 +00:00
Dries Buytaert 8d249c5f28 Last night's updates:
- improved "track drop.org": it has now 2 boxes, one for "track
   comments" and one for "track nodes"
 - various small improvements to the book module based on the
   feedback we got.
 - fixed typo in moderation module
 - ...
2001-04-04 12:54:10 +00:00
Dries Buytaert 805107cd22 Commiting my work of last Sunday:
- removed ban.inc and ban.module and integrated it in account.module
   under the name "access control" --> the ban code was not really up
   to standard so this has now been dealt with.  This refactoring and
   reintegration cuts down the code size with 100 lines too.  :-)
   (The ban.module code was really old and it showed.)

 - added node.module and made the other modules reuse some of this
   code --> cut down the code size of modules by at least 100 lines
   and adds stability.

 - added a status() function to admin.php to display a conform status
   message where appropriate.  See admin.php for usage.

 - removed $theme->control() and made comments.inc handle this itself
   wrapped in a $theme->box().  No need to clutter the themes with
   such complexity --> updated all themes already. :-)

 - some small visual changes to some administration pages to be more
   consistent across different modules.
2001-04-02 15:54:37 +00:00
natrak 1f5bc83d79 Just a minor adjustment to tanslate \n to <BR> in account_user() for bio and sig. 2001-04-01 21:22:33 +00:00
Dries Buytaert 04ad9b8af9 - fixed issue depricated call-by-reference issues
- fixed small visual glitch in includes/function.inc
- changed SQL tables around a bit to be more consistent
  (result: small changes to a lot of different files)
- improved robustness of includes/node.inc
- improved output of cron.module
- improved output of node.php
2001-03-29 19:50:31 +00:00
Dries Buytaert a53d198cac - on popular demand:
added the # votes to the "track your comments" page
2001-03-28 21:29:12 +00:00
Dries Buytaert 3f2b0e0b3f Flushing my backlog (in case Natrak wants to make more changes):
- tidied up some of the code
 - fixed a small problems
2001-03-28 07:03:47 +00:00
Dries Buytaert f4deafca9e - refactoring, refactoring, refactoring 2001-03-25 16:51:08 +00:00
Dries Buytaert 1f79863053 - large commit of everything else that has been queued in my backlog:
it's not 100% stable yet
2001-03-25 10:57:01 +00:00
Dries Buytaert 68f2112b4d - nodified index.php:
the index page will only display stories for now but this will/can
    change in the near future
- all other files now thinks in terms of nodes, rather then stories
2001-03-24 17:04:11 +00:00
Dries Buytaert a4b93e3cc4 - forgot to commit this last night but this should fix deekayen's small
Windows glitch
2001-03-12 14:53:13 +00:00
Dries Buytaert accd5f0c31 - applied David Norman's patch to turn all <?'s into fully qualified
<?php's.
2001-03-10 11:07:52 +00:00
Dries Buytaert f516626a29 A rather large and important update:
revised most of the SQL queries and tried to make drupal as secure as possible (while trying to avoid redundant/duplicate checks).  For drupal's sake, try to screw something up.  See the mail about PHPNuke being hacked appr. 6 days ago.  The one who finds a problem is rewarded a beer (and I'm willing to ship it to Norway if required).  I beg you to be evil.  Try dumping a table a la "http://localhost/index.php?date=77778;DROP TABLE users" or something. ;)
2001-03-07 21:29:40 +00:00
Dries Buytaert 728249cbc4 - fixed small translation glitch in format_interval
- added a couple of missing t() functions
- improved the comments module, fixed the score problem Jeroen
  reported earlier -> it's slicker but I hope it won't break anything
2001-03-01 21:34:09 +00:00
Dries Buytaert 19408c6199 - small fix in account.php
- updated CHANGELOG
2001-02-23 22:05:01 +00:00
Dries Buytaert 5b1451ce29 - a small improvement to the "track drop.org" page 2001-02-23 14:15:17 +00:00
Dries Buytaert 0505e7b999 - removed one redundant "." 2001-02-22 16:46:01 +00:00
Dries Buytaert 86e315e2b4 - locale module: added documentation (first draft)
- locale module: improved administration interface
- headline module: fixed small visual glitch in export function
- account: small improvements
2001-02-21 08:25:21 +00:00
Dries Buytaert 4371b627d5 - added fine-grained user permission system which allows us to give
certain users access to specific administration sections only.
    Ex. a FAQ maintainer can only edit the FAQ, and members of an
        "editorial board" can only edit comments, diaries and
         stories, ..
- code review => rewrote include/user.inc which is much easier now
- fixed 4 small bugs
2001-02-18 15:14:56 +00:00
Dries Buytaert 52a1d1bbe8 - More updates on the translation support 2001-02-17 12:59:24 +00:00
Dries Buytaert e7f043c30a - updates 2001-02-14 09:32:33 +00:00
Dries Buytaert db554e857d - initial import of the preliminary translation code.
- added timer.inc for benchmarking purpose
- bugfix for php-clean
- bugfix for account.php
- removed redundant format_data
- ...
2001-02-12 20:40:43 +00:00
Dries Buytaert 3ba9cb5d72 - small updates 2001-02-10 17:54:51 +00:00
Dries Buytaert 171479fcfa - a 2nd batch of various updates 2001-02-10 14:36:49 +00:00