Commit Graph

616 Commits (63b3fea2b38d62da171cca6310adfd518fb2131e)

Author SHA1 Message Date
Gerhard Killesreiter e13799c9eb #45988, Nodes with menu items bypass node permissions system, patch by chx. 2006-03-20 16:29:55 +00:00
Neil Drumm 2b9d04d5c2 -bug #51522 by m3avrck, node teasers are empty 2006-03-09 22:38:40 +00:00
Gerhard Killesreiter 306a04e503 #43032, Can't move forum topics created by anonymous (Authored by not set), patch by Cvbge. 2006-03-09 22:10:57 +00:00
Gerhard Killesreiter f1962e8fb1 #52586, node preview broken with php5, patch by greggles 2006-03-09 21:59:43 +00:00
Gerhard Killesreiter 45092bdd5f #53012, make "Create new revision" respect node type settings, patch by Zen 2006-03-08 19:07:41 +00:00
Dries Buytaert 8fe244ff6a - Patch #51522 by paddy: break at beginning doesn't work 2006-03-07 19:38:19 +00:00
Steven Wittens fe77e77431 - #49405: Minor advanced search UI/code tweaks 2006-02-28 21:10:04 +00:00
Steven Wittens 03c8120c23 - #51110: Make search results page more flexible 2006-02-28 13:32:33 +00:00
Gerhard Killesreiter 8d8b816ca5 #44129, patch by Zen 2006-02-27 13:33:48 +00:00
Dries Buytaert 58d9b02e3e - Patch #51189: fixed submit redirects. 2006-02-26 19:44:45 +00:00
Dries Buytaert 3603fe1bd8 - Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.) 2006-02-21 18:46:54 +00:00
Dries Buytaert 890356a0b5 - Patch #50219 by pz: removed some redundant code. 2006-02-21 08:37:41 +00:00
Dries Buytaert 999d3dafd4 - Patch #50219 by pz: removed death code. 2006-02-20 16:41:25 +00:00
Dries Buytaert 864eab75aa - Patch #50105 by chx: simplified some code. 2006-02-19 21:47:50 +00:00
Dries Buytaert 7b71373701 - Patch #44298 by DriesK: prevent unaccessible links from being generated. 2006-02-19 21:46:04 +00:00
Steven Wittens 740dc97b5f - #35073: Admin/node category filter not working 2006-02-14 21:12:09 +00:00
Dries Buytaert 583d5a4ee9 - Patch #48622 by adrian: remove drupal_goto from _submit functions. 2006-02-10 05:25:57 +00:00
Dries Buytaert 51f8d2f33b - Patch #47406 by Zen: menu sorting shouldn't be case insensitive. 2006-02-09 08:36:54 +00:00
Dries Buytaert df492f35ae - Patch #43622 / #46627 by markus: 'delete the selected posts' operation on admin/node doesn't work. 2006-02-09 07:46:04 +00:00
Dries Buytaert 6b706b50b3 - Patch #48564 by JonBob: grammar fix. 2006-02-09 07:16:47 +00:00
Steven Wittens a0454264af - Node revisions 404/403 handling called drupal_not_found() twice. 2006-02-08 00:47:14 +00:00
Dries Buytaert dbdca484c1 - Patch #48021 by Zen: removed unused variable. 2006-02-06 05:54:17 +00:00
Dries Buytaert 514bef01f0 - Patch #46933 by Gerhard: moderated nodes are not indexed. 2006-02-01 14:11:53 +00:00
Dries Buytaert 15ff8c8e32 - Patch #46827 by wulff: fixed incorrect links. 2006-01-29 07:50:45 +00:00
Dries Buytaert 2210b607b0 - Patch #46705 by killes: don't use array_merge. 2006-01-29 07:46:57 +00:00
Dries Buytaert 576399c1f4 - Modified patch #37754 by Thomas: made the status message show up. 2006-01-24 08:26:21 +00:00
Dries Buytaert 8c02d4ec93 - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:

# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
  $form[$key]['#weight'] = $count/1000;
}

The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).

Consider the following pseudo example:

$form['game_title'] = array(
    '#type' => 'textfield',
    ...
    );
$form['game_description'] = array(
    '#type' => 'textarea',
    ...
    );
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;

Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).

The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
Dries Buytaert e84a98a22b - Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API. 2006-01-19 08:54:41 +00:00
Steven Wittens ecd26ac8ae - #42277: Make node search indexing more robust against bad nodes and timeouts. 2006-01-18 21:31:40 +00:00
Dries Buytaert 2220c03633 - Patch #45206 by markus: attempt at making the node filters somewhat translatable. 2006-01-18 19:09:46 +00:00
Dries Buytaert 46913a7efd - Patch #45259 by chx/drumm: cast to object required. 2006-01-18 14:30:42 +00:00
Dries Buytaert 186ebd18da - Patch #42072 by m3avrck: more improvements to the node revesion overview screen. 2006-01-17 21:19:43 +00:00
Dries Buytaert baaf319c59 - Patch #42072 by m3avrck: improved the revision overview screen. 2006-01-17 19:26:49 +00:00
Dries Buytaert 51d2ac2b9e - Critical feature #40670: made the form array accessible. 2006-01-17 17:42:29 +00:00
Dries Buytaert baa5c2ff89 - Extended the form description for clarity. 2006-01-14 09:51:57 +00:00
Dries Buytaert 7f87b19eeb - Patch #42886 by chx: critical feature: allow modules to be reordered. 2006-01-08 12:49:51 +00:00
Dries Buytaert 859e045db6 - Patch #42955 by Cvbge: critical bugfix: users can't create new content. 2006-01-06 16:21:34 +00:00
Steven Wittens c27b62b182 - #41940: Locale string search broken in some cases (and remove some inappropriate db_escape_string() usage)
- #43491: Missing drupal_goto() after saving settings
2006-01-05 23:35:34 +00:00
Dries Buytaert 9e23a23d73 - Patch #35770 by DriesK: make node preview settings work. 2006-01-04 09:04:27 +00:00
Dries Buytaert db92352671 - Patch #43032 by Steve Dondley: critical fix: can't update nodes by anonymous users. 2006-01-03 19:40:29 +00:00
Dries Buytaert ea2d791095 - Patch 41169 by Chris: got rid of expensvie object 2 array casts. 2005-12-31 10:48:56 +00:00
Steven Wittens 79a193a2d2 - #42234: Use standardized feed icon for RSS 2005-12-29 04:46:40 +00:00
Dries Buytaert 02eb24bfbd - Bug #42107: redirect to the main page instead of to 'node'. 2005-12-27 14:31:42 +00:00
Dries Buytaert ed7256f37a - Patch #28159 by chx: removed some dead code from the search module's form. 2005-12-26 11:21:19 +00:00
Dries Buytaert ba12462fc9 - Patch #42153 by Junyor: slight clean-up of node_revision_delete(). 2005-12-24 13:05:22 +00:00
Dries Buytaert 29a619b598 - Patch #30098 by killes: node revisions should only be viewable by admins. 2005-12-22 10:57:02 +00:00
Steven Wittens c2384e2c18 - #41973: Ensure -\>changed and -\>created are equal on node creation 2005-12-22 00:22:19 +00:00
Steven Wittens 19aad8934f - #34826: Search results don't include last part of longer pages 2005-12-21 14:30:09 +00:00
Dries Buytaert 922a46d281 - Patch #34920 by Morbus/webchick/tangent: fixed order of form fields. 2005-12-15 16:24:40 +00:00
Dries Buytaert 5accfa08f5 - Patch #41133 by DriesK: as of PHP 5.1.0, strtotime() returns FALSE on failure instead of -1.
Changed code to be compatible with all versions.
2005-12-15 16:02:50 +00:00