Commit Graph

425 Commits (5ad1751e1129dda9518c110b9365d702826024b8)

Author SHA1 Message Date
Alex Pott 5b84c09246
Issue #3268829 by quietone, bbrala: Fix class property comments for Drupal.Commenting.DocComment.ShortSingleLine 2022-10-03 10:59:05 +01:00
Alex Pott 2c468a0049
Issue #3264947 by Niklan, quietone, ravi.shankar, longwave, TR, xjm: [Sep 12, 2022] Add missing docblocks for test methods ::setUp() and ::tearDown() 2022-09-27 13:28:52 +01:00
Alex Pott f8b4d7a105
Issue #3082053 by vsujeetkumar, kristiaanvandeneynde, Wim Leers: EntityResourceTestBase needlessly tests the caching layer 2022-09-27 12:55:44 +01:00
Alex Pott 386d79e2e0
Issue #3283794 by mondrake, longwave: Fix 'should return {type} but return statement is missing' PHPStan L0 errors in test code 2022-06-14 14:10:16 +01:00
Alex Pott 6dd0db56c8
Issue #3281535 by mondrake, daffie: Fix 'Access to an undefined property' PHPStan L0 errors in test code 2022-06-14 11:27:54 +01:00
catch 81c78829db Issue #3284759 by longwave: Remove deprecated BcTimestampNormalizerUnixTestTrait 2022-06-13 08:53:36 +01:00
Alex Pott 39b12c461c
Issue #3264122 by Spokje, Taran2L, ankithashetty, quietone, catch, xjm, daffie: Move all non migration aggregator tests to the module in preparation of removal in d10 2022-03-17 14:05:52 +00:00
catch 0cec48668c Issue #3263654 by Spokje, bbrala, daffie, Kristen Pol, longwave: Move all HAL tests to the module in preparation of removal in D10 2022-02-20 14:43:28 +00:00
Gábor Hojtsy ac05f3d0d0 Issue #3264435 by catch, Spokje: Help topics and rest don't filter out deprecated modules when testing 2022-02-15 19:06:32 +01:00
Alex Pott 42630422b9
Issue #3261486 by catch, longwave, dww: Remove core updates added prior to 9.3.0 and adjust test coverage 2022-02-08 12:16:18 +00:00
catch 27158f7c9d Issue #3262190 by daffie, longwave: Add miscellaneous return type hints for Symfony 6 2022-02-03 17:41:13 +00:00
Alex Pott 6688d5c2f1
Issue #3260243 by neclimdul: EntityTestDateRangeTest fails testing 2022-01-25 01:33:30 +00:00
catch eacb05b19f Issue #3212346 by longwave, Spokje, alexpott: Avoid hundreds of unnecessary installs when testing config entities 2022-01-24 17:25:00 +00:00
catch 7f93a36802 Issue #3209723 by murilohp, daffie, longwave, andypost: [Symfony 6] Symfony\Component\HttpKernel\HttpKernelInterface::MASTER_REQUEST is deprecated, use ::MAIN_REQUEST instead 2022-01-24 14:31:35 +00:00
Alex Pott 7b324dd8f1
Issue #3197482 by longwave, Spokje, Taran2L, murilohp, catch, Gábor Hojtsy, daffie: Update Drupal 10 to depend on Symfony 5.4 (as a stepping stone to Symfony 6, for deprecation checking support) 2022-01-17 09:03:46 +00:00
catch cfd8517353 Issue #3182103 by TR, dan2k3k4, longwave, mondrake, Sweetchuck, Kristen Pol: Ensure correct signature for setUp(), tearDown(), setUpBeforeClass(), and assertPostConditions() methods 2021-12-14 12:05:17 +00:00
Lee Rowlands 6d39cdeeb4
Issue #3222769 by bbrala, alexpott, longwave, Matroskeen: [November 8, 2021] Replace all list (array destructuring) assignment to the array syntax 2021-11-15 12:35:55 +10:00
catch 1b66ab0cb3 Issue #3130606 by shaktik, mondrake, KapilV, longwave, daffie: MockBuilder::setMethods is deprecated in PHPUnit8 and removed from PHPUnit10 2021-09-13 17:23:15 +01:00
catch 6951f4d77a Issue #3225328 by mxr576, Berdir, longwave: Improve page performance by sorting cache contexts/tags on-demand 2021-08-27 12:36:31 +01:00
catch 068f00c4c9 Issue #3191935 by mondrake, tedbow, xjm, alexpott, longwave: Replace usages of AssertLegacyTrait::assertNoText, which is deprecated 2021-07-28 14:41:19 +01:00
Lee Rowlands cffb02aad6
Issue #2571235 by alexpott, claudiu.cristea, dawehner, Wim Leers, gabesullice, IJsbrandy, benjifisher, alisonjo315, larowlan, Berdir, effulgentsia, longwave, herom, dmouse, heddn, catch: [regression] Roles should depend on objects that are building the granted permissions 2021-07-09 14:50:54 +10:00
catch e48dcff470 Issue #2879159 by Spokje, LoMo, ravi.shankar, quietone, mondrake: Some calls to assertEquals have expected/actual parameters reversed 2021-06-21 11:27:34 +01:00
catch 37bd3765c3 Issue #3124762 by Spokje, dww, johnwebdev, paulocs, piyuesh23, Suresh Prabhu Parkala, Deepak Goyal, catch, larowlan, rpsu, xjm, andypost, alexpott, daffie, longwave, fgm, Wim Leers, anmolgoyal74: Add 'lifecycle' key to .info.yml files 2021-06-17 11:50:33 +01:00
catch 116ebd1e2c Issue #3217706 by Spokje, longwave, guilhermevp, mondrake: Replace usages of assertFileNotExists(), that is deprecated 2021-06-14 09:26:39 +01:00
catch 3066423e43 Issue #3186661 by Spokje, longwave, mondrake, paulocs, daffie: [May 24, 2021] Remove usage of drupalPostForm 2021-05-24 14:27:52 +01:00
catch f3ad0680a3 Issue #3133162 by jungle, ravi.shankar, Deepak Goyal, Neslee Canil Pinto, anmolgoyal74, xjm, Kristen Pol: Replace the start verb Test with Tests in method comments of tests 2021-05-24 14:26:11 +01:00
Alex Pott 3872f1a8ed
Issue #3139404 by mondrake, munish.kumar, pavnish, longwave: [May 25, 2021] Replace usages of AssertLegacyTrait::assertText, that is deprecated 2021-05-20 22:10:07 +01:00
Alex Pott 3f75f72de2
Issue #3131281 by mondrake, rahulrasgon, longwave, ridhimaabrol24, naresh_bavaskar, jungle, daffie: [May 17th 2021] Replace assertEqual() with assertEquals() 2021-05-20 00:39:14 +01:00
catch 9c2bfa8df0 Issue #3203476 by mondrake, longwave, alexpott: Convert assertions involving use of xpath on divs to WebAssert 2021-04-28 11:08:17 +01:00
Alex Pott 08766c5dee
Issue #2903911 by joshmiller, longwave, anmolgoyal74, ankithashetty, init90, Pooja Ganjage, _gradient_, daffie, borisson_: Fix 'Drupal.Commenting.FunctionComment.ParamMissingDefinition' coding standard 2021-03-29 16:22:14 +01:00
catch 69a0a83546 Issue #3032390 by alexpott, dww, Pancho, 3CWebDev, kim.pepper, larowlan, Berdir, catch, andypost, chr.fritsch, Wim Leers: Add an event to sanitize filenames during upload 2021-02-24 16:02:18 +00:00
catch afd86e7d3c Issue #3193955 by mondrake, daffie, catch: Swap assertEqual arguments in preparation to replace with assertEquals 2021-01-28 09:57:41 +00:00
Lee Rowlands fd1d6759f2
Issue #2863652 by alexpott, anmolgoyal74, javi.pl, dww, zaporylie, moinak_dutta, iampuma, a.dmitriiev, benjifisher, Pancho, larowlan, yoroy: Do not allow files with "php|pl|py|cgi|asp|js" extensions to be renamed to *.txt and be uploaded if *.txt is not allowed by the field widget 2021-01-23 09:16:07 +10:00
catch 6c64763741 Issue #2867959 by mondrake, danielnv18, xjm, ZeiP, daffie: Replace usages of deprecated AssertLegacyTrait::assertIdentical 2021-01-21 10:01:43 +00:00
catch d722e9d760 Issue #3192221 by mondrake, daffie, longwave: Swap assertIdentical arguments in preparation to replace with assertSame 2021-01-18 17:35:30 +00:00
catch 39bacf4426 Issue #3192427 by mondrake, daffie: Replace usages of deprecated AssertLegacyTrait::assertNotEqual 2021-01-18 16:16:33 +00:00
Alex Pott 21bd33d6ce
Issue #3186582 by tim.plunkett, raman.b, dead_arm, alexpott, Lendude: Replace the word "master" with "default" in Views 2020-12-22 22:08:17 +00:00
catch fdb7c47527 Issue #3188056 by longwave: [Symfony 5] Symfony\Component\Serializer\Encoder\DecoderInterface::decode() no longer accepts NULL as $format 2020-12-17 17:18:30 +00:00
catch 96d4338074 Issue #3168375 by mondrake, manishsaharan29497, longwave: Convert calls to drupalPostForm(NULL, ...) to submitForm 2020-11-23 14:35:28 +00:00
xjm 1994ca5ccb SA-CORE-2020-012 by ufku, mrf, fgm, samuel.mortenson, dww, Heine, mlhess, David_Rothstein, pwolanin, xjm, fgm, stefan.r, dsnopek, rickmanelius, David Strauss, tedbow, alexpott, dww, larowlan, kim.pepper, Wim Leers, quicksketch, mcdruid, Fabianx, effulgentsia, drumm, pandaski, Mixologic 2020-11-17 16:16:53 -06:00
catch 783e7eb88e Issue #3145005 by longwave, mondrake, cburschka, raman.b, Lal_, dww, xjm: [November 9, 2020] Remove uses of t() in drupalPostForm() calls 2020-11-16 16:51:39 +00:00
catch 1d6e7e25d5 Issue #2851394 by GoZ, hgunicamp, oknate, jungle, wolffereast, tameeshb, mmatsoo, ridhimaabrol24, jofitz, swarad07, tanc, shaktik, dimaro, shashikant_chauhan, MerryHamster, quietone, nitesh624, martin_q, boaloysius, gaurav.kapoor, nitvirus, ankithashetty, Munavijayalakshmi, kostyashupenko, leolando.tan, amit.drupal, ravi.shankar, akashkrishnan01, Swapnil_Kotwal, Saviktor, mrinalini9, anmolgoyal74, Venkatesh Rajan.J, shimpy, lomasr, Dinesh18, shubham.prakash, mahtab_alam, markdorison, cilefen, longwave, bleen, xjm, alexpott, gmaltoni: Fix grammar 'a' to 'an' when necessary 2020-11-13 14:25:11 +00:00
catch 5939e6b5f8 Issue #3145418 by longwave, paulocs, shetpooja04, Spokje, nikitagupta, mondrake, ravi.shankar, sarvjeetsingh, mrinalini9: [November 9, 2020] Remove uses of t() in assertText() calls 2020-11-13 11:06:01 +00:00
catch 7dbdbcb1fa Issue #3166450 by mondrake, longwave, snehalgaikwad: Split assertTrue using && into multiple assertions 2020-11-09 12:07:29 +00:00
Alex Pott e37745362c
Issue #3173076 by anmolgoyal74, shetpooja04, sulfikar_s, Pooja Ganjage, longwave, alexpott: Unused variable $parseable_valid_request_body_2 in EntityResourceTestBase.php, rest module 2020-10-09 22:01:55 +01:00
catch 47355e3ba7 Issue #3135027 by mondrake, Spokje, ayushmishra206, rajandro, nitesh624: Replace usages of assertArrayEquals, deprecate it 2020-09-30 10:32:01 +01:00
Alex Pott 472b19010a
Issue #3139418 by mondrake, jungle, longwave: Replace usages of AssertLegacyTrait::assert(No)LinkByHref, that is deprecated 2020-09-08 16:00:31 +01:00
catch 15de0783ff Issue #3101247 by mondrake, longwave, Saurabh_sgh, alexpott, jhedstrom, xjm: Deprecate AssertHelperTrait::castSafeStrings() in favour of MarkupInterfaceComparator 2020-09-01 14:10:13 +01:00
catch 30ca835cce Issue #3139408 by mondrake, jungle, dww: Replace usages of AssertLegacyTrait::assert(No)Field, that is deprecated 2020-08-10 11:26:28 +01:00
Alex Pott 661d8a83f6
Revert "Issue #2780869 by claudiu.cristea, Lendude, joachim, jmadden27: Cannot save a view where a filter value option contains a period"
This reverts commit 104bca1e0e.
2020-08-03 12:35:50 +01:00
catch d7300cc380 Issue #3142755 by sja112, mondrake, alexpott, mrinalini9, xjm: AssertLegacyTrait::assert(No)Field() in functional tests still have a message passed in 2020-07-29 14:57:52 +01:00
Alex Pott 104bca1e0e
Issue #2780869 by claudiu.cristea, Lendude, joachim, jmadden27: Cannot save a view where a filter value option contains a period 2020-07-15 15:59:38 +01:00
catch eafefd897a Issue #2619482 by cburschka, ankit.singh, ravi.shankar, jungle, daffie: Convert all get_called_class()/get_class() to static:: 2020-07-13 15:35:49 +01:00
catch a050029323 Issue #3135538 by mondrake, longwave, jungle: Replace remaining assert* involving use of count() where relevant 2020-07-02 13:16:28 +01:00
xjm de32f3ca2d Issue #3133033 by munish.kumar, xjm, Hardik_Patel_12, daffie, swatichouhan012: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the drupalCreateUser() test method 2020-06-21 16:39:19 -05:00
xjm 94ca9bc3a0 Issue #2972224 by alexpott, longwave, jungle, sja112, xjm, dww, daffie, kiamlaluno, dawehner, quietone, Lendude: Add .cspell.json to automate spellchecking in Drupal core 2020-06-21 14:15:29 -05:00
Alex Pott 9d1faa52f4
Issue #2824935 by idebr, mfernea, Deepak Goyal, pfrenssen, longwave, hgunicamp, jofitz, andypost, daffie: Fix Squiz.ControlStructures.SwitchDeclaration coding standard 2020-06-02 09:46:52 +01:00
xjm 8acabfb7e7 Issue #3138786 by sja112, mohrerao: Fix "Protected" relevant typos in core 2020-05-28 19:53:53 -05:00
xjm a6c0adae4d Issue #3139439 by mondrake, daffie: Replace usages of deprecated AssertLegacyTrait::assertHeader() 2020-05-24 16:38:15 -05:00
xjm 11387380d5 Issue #3139218 by mondrake, daffie: Replace usages of AssertLegacyTrait::assertResponse(), which is deprecated 2020-05-24 08:33:20 -05:00
xjm f09c890298 Issue #3132964 by jungle, longwave, sja112, dww, xjm, daffie: assertResponse() does not actually support a $message parameter, so stop passing one 2020-05-22 12:37:50 -05:00
catch df127208e7 Issue #2907402 by Berdir, neel24, Wim Leers, damiankloip, tedbow: HAL normalization of file fields don't provide file entity id or file entity REST URL 2020-05-07 19:38:39 +01:00
catch 40a5bd7e0a Issue #3126965 by jungle, quietone, longwave, mondrake, dww: Replace assert* involving count() and an integer literal with assertCount() 2020-05-07 19:07:00 +01:00
catch ca1aa9e4ba Issue #3094398 by martin107, alexpott, andypost, klausi: Update Symfony response and request events to new classes 2020-05-06 15:39:38 +01:00
xjm 99cb88d6a7 Issue #3131816 by Spokje, jungle, mondrake, xjm, longwave: Replace assertions involving calls to is_array() with assertIsArray()/assertIsNotArray() 2020-05-04 07:43:32 -05:00
Alex Pott 3f87e0d805
Issue #3132745 by jungle, longwave, xjm, swatichouhan012, daffie: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the $modules test property 2020-05-02 12:34:00 +01:00
catch 222e10447b Issue #3131088 by Spokje, longwave: Replace assertions involving calls to file_exists with assertFileExists()/assertFileNotExists() or assertDirectoryExists()/assertDirectoryNotExists() 2020-04-27 14:13:40 +01:00
catch 4d02fe7c25 Issue #3128746 by mondrake, longwave, dww: Replace assertions involving calls to strpos() with more accurate string assertions 2020-04-27 10:02:44 +01:00
catch 5132c83fac Issue #3082415 by Krzysztof Domański, mondrake, alexpott, longwave, jungle: Replace assert(Not)Same/Identical() on booleans with assert(Not)True/False() in PHPUnit tests 2020-04-17 16:00:07 +01:00
catch 09be91a395 Issue #3126564 by longwave, mondrake: Replace usage of assertArraySubset(), that is deprecated 2020-04-16 19:40:52 +01:00
Alex Pott 6bf02d966d
Issue #2822382 by voleger, pfrenssen, erozqba, jungle, RytoEX, borisson_, jofitz, shashikant_chauhan, sidharthap, dawehner, xjm, kiamlaluno, catch, daffie, klausi: Make every $modules property protected on classes extending BrowserTestBase and KernelTestBase 2020-04-13 12:05:00 +01:00
Alex Pott 0dc28534c8
Issue #3107732 by mondrake, longwave, swatichouhan012, salah1, xjm, catch, alexpott, Berdir: Between April 13 and April 17, 2020: Add return typehints to setUp/tearDown methods in concrete test classes 2020-04-13 09:56:30 +01:00
Alex Pott 6108526c9c
Issue #3113077 by mondrake, Hardik_Patel_12, Neslee Canil Pinto, swatichouhan012, prabha1997, neelam_wadhwani, Berdir, longwave: Replace assertContains() on strings with assertStringContainsString() or assertStringContainsStringIgnoringCase() 2020-04-12 12:34:00 +01:00
catch 85319ebabb Issue #3122605 by Beakerboy, daffie: EntityResourceTestBase.php uses a static query that should be dynamic 2020-03-31 13:07:47 +01:00
catch ce1885d16c Issue #3119027 by Berdir, andypost: Use filled dump for RestSettingsDeletionUpdateTest 2020-03-10 22:26:23 +00:00
Alex Pott 5d4c083edf
Issue #3098475 by Berdir, catch, TravisCarden, xjm, benjifisher, alexpott, larowlan, dww: Add more strict checking of hook_update_last_removed() and better explanation 2020-02-27 10:08:46 +00:00
Alex Pott b57afe5c7f
Issue #3069696 by Berdir, andypost, dhirendra.mishra, longwave, alexpott: Remove BC layers from the entity system 2020-02-26 08:25:29 +00:00
catch 1d1f222288 Issue #2893795 by sokru, Wim Leers, Berdir, Stefdewa: Remove serialization.module BC layers 2020-02-04 16:50:15 +00:00
catch 720924f719 Issue #2893804 by Wim Leers, Stefdewa, Berdir, catch: Remove rest.module BC layers 2020-01-27 17:41:43 +00:00
catch e1a041c493 Issue #3087644 by jibran, Berdir, alexpott, longwave, Wim Leers, amateescu, catch, xjm, larowlan, dpi, quietone: Remove Drupal 8 updates up to and including 88** 2020-01-24 23:52:03 +00:00
Lee Rowlands 2e53ac1699
Revert "Issue #3087644 by jibran, Berdir, alexpott, longwave, Wim Leers, amateescu, catch, larowlan, dpi, quietone: Remove Drupal 8 updates up to and including 88**"
This reverts commit 136f055066.
2020-01-22 10:30:15 +10:00
Lee Rowlands 136f055066
Issue #3087644 by jibran, Berdir, alexpott, longwave, Wim Leers, amateescu, catch, larowlan, dpi, quietone: Remove Drupal 8 updates up to and including 88** 2020-01-22 09:33:30 +10:00
catch 4bfd652e46 Issue #3067762 by alexpott, Berdir, Wim Leers: Fix bug in \Drupal\rest\RequestHandler::createArgumentResolver and handle "Passing in arguments the legacy way is deprecated" deprecation 2020-01-01 16:47:05 +00:00
Alex Pott 2a009c5edd
Issue #3048498 by jonathan1055, Lendude, naveenvalecha, klausi, alexpott, Gábor Hojtsy: [≈Nov. 11] Fix Drupal.Commenting.Deprecated coding standard 2019-11-14 09:08:15 +00:00
catch 19f9474b9b Issue #2742585 by ZeiP, alexpott, mondrake, klausi, tomasnagy, Krzysztof Domański, sokru, kristiaanvandeneynde, dawehner, jeroenbegyn: Deprecate dangerous assertTrue/False() compatibility overrides in PHPUnit Kernel, Functional and FunctionalJavascript tests 2019-11-08 13:53:52 +00:00
catch 32d95eccd7 Issue #3082655 by Wim Leers, alexpott, iyyappan.govind, dww, lauriii: Specify the $defaultTheme property in all functional tests 2019-11-08 13:39:33 +00:00
catch bc6aabc9cd Issue #3087692 by Wim Leers, alexpott: Remove the core key from views configuration 2019-10-22 20:40:16 +01:00
catch e37031e09a Issue #3072702 by alexpott, Wim Leers, mikelutz, xjm, catch, Berdir, tedbow, webchick, shaal, Mixologic, heddn: Core extensions should not need to specify the new core_version_requirement in *.info.yml files so that 9.0.x can be installed 2019-10-15 15:34:52 +01:00
catch 77286bebfc Issue #3085673 by mikelutz: [Symfony 4] EntityResourceValidationTraitTest should not get a mock for an internal trait 2019-10-04 12:59:14 +01:00
catch 099ce08ac8 Issue #2336597 by amateescu, slashrsm, jibran, Wim Leers, saki007ster, Berdir, catch, plach, Charlie ChX Negyesi, dawehner, gabesullice: Convert path aliases to full featured entities 2019-10-01 11:30:19 +01:00
Alex Pott e10377015e
Issue #2869855 by mcdruid, Krzysztof Domański, wturrell, rjg, manarth, dpagini, Wim Leers, catch, xjm, cilefen: Race condition in file_save_upload causes data loss 2019-09-23 08:55:26 +01:00
Alex Pott 0a6a417ec9
Issue #3073318 by Spokje, Mile23, mondrake: Remove usages of \PHPUnit_Framework_MockObject_MockObject 2019-09-02 12:24:14 +01:00
Alex Pott b5238ac9a8
Issue #2818677 by msankhala, NickWilde, Berdir, alexpott, dimaro, poornima.n, sidharthap, dhirendra.mishra, keshav.k, xjm, mahtab_alam, ieguskiza, borisson_, catch, larowlan: Replace usages of deprecated method drupal_render_root() 2019-07-19 06:30:43 +01:00
catch 2844951c51 Issue #3067206 by voleger: Properly deprecate drupalGetHeaders() method of Drupal\Tests\BrowserTestBase 2019-07-12 16:22:06 +01:00
catch 06d2de1111 Issue #3063180 by piggito, andypost: REST views: View result counter shows {{counter}} placeholder when using "data_field" row plugin 2019-07-11 15:40:01 +01:00
catch b57f550d12 Issue #3031466 by mondrake, Wim Leers: EntityResourceTestBase::assert406Response uses a wrong assertion and results in false positives (and fails for PHPUnit 7) 2019-06-28 09:54:33 +01:00
Alex Pott e82e0c0573
Issue #3059090 by clepson, mondrake, alexpott: Deprecate \Drupal\Tests\PhpunitCompatibilityTrait::setExpectedException() 2019-06-11 12:38:53 +03:00
Alex Pott 23fad5b6a5
Issue #2926068 by almaudoh, andypost, voleger, claudiu.cristea, Oleksiy, YurkinPark, yo30, alexpott, dawehner, Berdir: Deprecate system_rebuild_module_data() and remove usages in core 2019-06-03 12:49:38 +01:00
Alex Pott 91fe1d2f77
Issue #2929133 by voleger, alexpott, Lendude: Replace all usages of getMock() 2019-05-31 10:22:21 +01:00
catch 615123f51c Issue #2286655 by alexpott, attiks, mark_fullmer, nielsonm, Mark Slatinek, quietone, catch, dawehner, aburke626, justafish: Gender neutral language 2019-04-17 16:30:13 +09:00