Commit Graph

286 Commits (5ac59aacd2c5d60155b7236c588bed2e750b3e04)

Author SHA1 Message Date
Dries Buytaert 7624580f76 - Bugfix: added a missing break statement. Patch by Stefan. 2003-10-15 17:15:17 +00:00
Dries Buytaert e688dfe6db - Fixed prefix problem with the book module. Patch by Moshe.
- Usability improvements to the user module: removed some redundant menu
  items by taking advantage of the column sorting, added status messages
  and so on.  Patch by Moshe plus some fixes.

- Made the profile module use the table() function.  Patch by Moshe.

- Fixed breadcrumb spacing.  Patch by Moshe.

- Fixed colspan problem with node overview table.  Patch by Stefan.

- Fixed inconsistency with table sorting.  Patch 0122 by Al.
2003-10-13 19:18:39 +00:00
Dries Buytaert 2ff3222458 - Fixed translation bugs with statistics module. Patch by Gabor.
- Removed 'homepage' field from user table.  Patch by Gabor.

- Added 'real name' field to the profile module.  Patch by Gabor.
2003-10-12 21:25:42 +00:00
Dries Buytaert 250902621a - Fixed some link titles that were no longer correct due to the menu
changes.

- Fixed some broken links.
2003-10-09 22:00:29 +00:00
Dries Buytaert ba67040b63 - Fixed a broken link in the user module's documentaiton. 2003-10-09 21:29:51 +00:00
Dries Buytaert 1a5fcacdd9 - Committed part 3 of Michael's help system improvements: removed the $help
parameter from the menu() function.
2003-10-09 18:53:22 +00:00
Dries Buytaert 22c889e7c0 - Help system improvements: eliminated the _system hook. Patch by Michael.
- Bloggerapi module fixes.  Patch by Kjartan.

- Coding style fixes.  Patch by Michael.
2003-10-07 18:16:41 +00:00
Kjartan Mannes 934938c486 user_mail_encode() fixes:
- Made sure the chunk sizes always include groupings of 4 bytes.
- Added more comments so fixes are not lost in future changes.
2003-10-04 12:59:46 +00:00
Kjartan Mannes cb6e232990 - Re-wrote user_mail_encode(). 2003-10-03 22:44:32 +00:00
Dries Buytaert 95f3278e0e - Fixed small performance bug: when a user has no permissions, the query
in user_access() was not cached.
2003-10-03 07:09:34 +00:00
Dries Buytaert 392304da5f - Moved the locale settings from the user module to the locale module.
Patch by Stefan.

- Moved the theme settings from the user module to the system module and
  made the code more intelligent.  Patch by Stefan.
2003-09-30 21:48:32 +00:00
Dries Buytaert 446dc8244b - Changed 'view my blog' to 'my blog' and 'view recent posts' to 'recent
posts'.  See mailing list discussion.
2003-09-30 05:15:12 +00:00
Dries Buytaert 7531e82969 - Made sure non US-ASCII mails are sent out properly. Patch by Gabor.
TODO: rename user_mail() to drupal_mail() and move it to common.inc.
  Other modules, such as the project module, should use this as well
  or they risk to send out /invalid/ mails.
2003-09-29 18:35:46 +00:00
Dries Buytaert c1e7b3f43a - Fixed CSS. 2003-09-28 21:14:46 +00:00
Dries Buytaert 234f278487 - Fixed bug with "new user". Reported by Matt. 2003-09-28 20:32:59 +00:00
Kjartan Mannes e2c206dafa - Renamed User information block to Navigation.
- Fixed Navigation block header.
2003-09-28 18:53:30 +00:00
Dries Buytaert 32e8d77cd6 - Associate a callback with the menu links! (This callback is not yet being
called but will be as soon the remaining links have been transformed to use
  the menu system.)

- Made sure the menu does not render links with no callback and no children.
  Like this, the 'create content' link is not being shown when the user has
  no permission to add any content.
2003-09-28 17:53:04 +00:00
Dries Buytaert c8b28009cd - Made sure all menu items can be translated. Path by Goba. 2003-09-28 15:18:55 +00:00
Dries Buytaert 2fe79310df - Rewrote the most of the menu system; this fixes Al's problem with the
"create content" link.

- Manually merged the user module's new menu items.  Al's patch did not
  apply.

- Added some missing t()s.
2003-09-28 10:51:40 +00:00
Dries Buytaert fe09d5a786 - Committed Al's new admin link texts. Remarks:
1) As explained by Al, there is still a glitch with the 'create content'
     menu.
  2) The user module part of the patch did not apply due to Kjartan's earlier
     patch.
2003-09-27 06:00:43 +00:00
Dries Buytaert 0ff789c61d - Patch by Kjartan:
+ Fixed CSS to use the same format as the rest of drupal.css.
   + Added fallback routine for menu icons.
   + Fixed anonymous users not seeing the menu.
   + Added proper access checks for admin and help menu items.
2003-09-26 23:05:14 +00:00
Dries Buytaert f104d3cc12 - Committed the admin menu integration patch. Thanks Adrian, Stefan and others. 2003-09-26 10:04:09 +00:00
Dries Buytaert 9eb0067ce4 - Fixed off-by-one error in user admin pages. 2003-09-20 16:56:36 +00:00
Dries Buytaert 2fbc7fcf27 - Committed a partial administration page integration patch. 2003-09-19 07:41:55 +00:00
Dries Buytaert 9fbab016f9 - Tidied up the usage of module_invoke() and module_invoke_all(). Patch by
Jonathan Chaffer.
2003-09-14 18:33:16 +00:00
Dries Buytaert 18e840ac66 - Bugfix: fixed string being check_query()-ed twice. Bug #2425. Patch by
Matt.
2003-09-14 08:57:18 +00:00
Dries Buytaert 9801a1967d - Changed $theme->links() to theme("links", $links).
- Added page titles.  Modified version of patch 0104 by Kendow; patch updated
  for HEAD branch.

  > Modified 4.2.0 code to pass localized title text to theme header so user
  > pages have meaningful <title> element content.
2003-09-13 15:24:04 +00:00
Dries Buytaert b9633dcded - Patch by Bart Jansen:
<quote>

  This adds session support for anonymous users and fixes a bug/typo.

    1. changed rid for user #0 from 0 to 1 (rid 1 == anonymous user) to make
       inner join work.

    2. replaced "if ($user .." by "if ($user->uid .." because now $user is
       always set (my previous change probably caused this).

    3. db_next_id("user_uid") -> db_next_id("users_uid");
  </quote>

  I repeat:

  "This adds session support for anonymous users and fixes a bug/typo."
2003-09-10 19:30:34 +00:00
Dries Buytaert 8e657f64ef - Gerhard's uid 0 patches. These patches bring various performance
improvements.  Requires a database update.
2003-09-09 18:18:43 +00:00
Dries Buytaert 756a5da544 - Added an "edit account" link. 2003-08-30 21:52:39 +00:00
Dries Buytaert 6a5ce3cad1 - Fixed bug #2548: error reporting from modules didn't always work. 2003-08-23 12:15:45 +00:00
Dries Buytaert 4e2ee96d4c - Removed left-overs from the rating module. Patch by Gerhard. Updated the
PostgreSQL and MSSQL database scheme as well.

- Made sure the update script updates the correct tables when database
  prefixing is enabled.  Patch by Bart Jansens.

- Improved the breadcrumb navigation of the book and the forum module as per
  Keith Instone's suggestions.

- Updated page titles (or block titles) and links to match.  Suggested by
  Keith Instone.

- Added missing 'thread' field to the comment table of the MySQL database scheme.
  Fixes bug #2590.
2003-08-22 17:06:44 +00:00
Dries Buytaert 134c9eb887 - Added some missing {} to make database prefixing work. Patch by Moshe. 2003-08-22 05:07:25 +00:00
Dries Buytaert 7f6ecbec0e - Fixed bug with user sessions. Patch by Jeremy. 2003-08-22 05:00:43 +00:00
Dries Buytaert 8d013b1666 - Applied Moshe's tablesort patch! Note that I changed the arrow images
because those of Moshe where not identical.
2003-08-21 15:47:50 +00:00
Dries Buytaert 0431f0700f - Committed Jeremy's session patch: this brings us one step closer to having
session for anonymous users.
2003-08-20 19:19:13 +00:00
Dries Buytaert b79b831152 - Updated the user module to use the new help system approach. 2003-08-19 20:48:25 +00:00
Dries Buytaert 6842d59732 - Documentation fixes by Michael F. 2003-08-13 18:40:26 +00:00
Dries Buytaert e0b97a7587 - Usability improvement: changed the title of the main block on the user
information page.  Suggested by Keith Instone.
2003-08-13 07:08:27 +00:00
Kjartan Mannes 48805032c8 - Applied modified version of almaw's 0064 patch: form item attributes.
- Applied modified version of mathias' 0073 patch: node form name.
  $params["options"] is now an array so some contrib modules might
  need minor changes.

- Applied mathhias' 0074 patch: missing access check on who is new
  block.
2003-08-12 20:37:16 +00:00
Dries Buytaert 37310ee6f0 - Added missing t() functions to watchdog. Patch #80 by Stefan. 2003-08-12 19:12:22 +00:00
Kjartan Mannes 17ef869e3a Applied 0007.almaw.home-link-using-l.patch
- Fix link_page to use l() to generate home link.

Applied 0058.kika.themeable-usermenu.patch
- Modifies user menu be themeable.
2003-08-11 20:41:37 +00:00
Dries Buytaert 173dfb5950 - Added missing {}. Fixes bug 2423 reported by kenzky. 2003-08-05 07:06:26 +00:00
Dries Buytaert 9fe3d9c46a - Fixed bug in user_validate_name(): . (dot) should be allowed for DA to work.
Fixes bug #107.
2003-07-26 18:01:14 +00:00
Dries Buytaert 75512ae3dc - Fixed the update path of user_save(). Patch by Gerhard. Tnx. 2003-07-23 19:48:08 +00:00
Dries Buytaert 83ae5b5c36 - Fixed typo: implde() -> implode(). Reported by Moshe. 2003-07-23 05:16:10 +00:00
Dries Buytaert c39562ae03 - Fixed node_save() and user_save() bug introduced by table prefix changes.
Modified patches from Gerhard.

- Changed the order of the checks in node_teaser().  Patch from Kobus.
2003-07-21 15:36:05 +00:00
Dries Buytaert 337b3c9de9 - Committed a slightly modified version of Slavica's table prefix patch. 2003-07-10 17:46:44 +00:00
Dries Buytaert c89f78aa4d - Bugfix: fixed the "check for duplicate e-mail addresses" test. Patch by
Marco.
2003-07-09 21:54:35 +00:00
Dries Buytaert d017514eba - Improvement: made it possible to translate the forum module. Patch #53 by Stefan.
- Improvement: some small changes to the user module to ease translation and to make things slightly more consistent.  This should be a better alternative for patch #54.

- Improvement: increase the maxlength of the node title.  This should fix bug #2018 and #2176.
2003-07-02 17:09:09 +00:00
Dries Buytaert 886ae2bf15 - Fixed some "search related" bugs introduced by Moshe's latest patch.
Fixes bug #2127.
2003-06-30 19:18:47 +00:00
Dries Buytaert 2323e57233 - Improvement: moved hard-coded CSS from user module to drupal.css. Patch
#57 by Kristjan.
2003-06-26 19:30:20 +00:00
Dries Buytaert 2689d6aa1e - Narrow the set of allowed usernames to prevent people from messing with it. 2003-06-25 15:46:03 +00:00
Dries Buytaert 3ee119d0f7 - Improvement: SQL improvements to the user module. Patch #44 and #45 by
Gerhard.

- Improvement: CSS improvements.  Patch #40 by Al.

 (TODO: we might be able to simplify admin.css now both drupal.css and
 admin.css are included to render administration pages.  Tags like "body"
 and friends can probably be inherited.)
2003-06-23 18:02:56 +00:00
Dries Buytaert fbbccada8e - Translation improvement. Patch by Stefan. 2003-06-20 18:29:35 +00:00
Dries Buytaert e57faf2192 - Bugfix: fixed problem with changing themes. Didn't apply Al's patch as
the fix was somewhat simpler.  Fixes bug #2003.

- Bugfix: fixed problem with voting on certain poll pages.  Patch #37 by Al.

- Improvement: removed stupid descriptions from profile module.
2003-06-20 17:43:03 +00:00
Dries Buytaert 7fd4cc4bf7 - Bugfix: fixed problem with the use of % on the user module form. Patch
by Slavica.  Fixes bug #1730.
2003-06-20 05:05:53 +00:00
Dries Buytaert 828ba66500 - Bugfix: fixed utf-8 problem for people that use PHP 4.2.x or below. Patch #33 by Al.
- Bugfix: fixed translation problems in the user module and the block module.  Patch by Stefan.

- Improvement: made it impossible to delete user role #1 and #2.  Patch #38 by Al.

- Improvement: fixed the "Allowed HTML tag" issues.  Makes for better code and improved usability.  Patch #35 by Al.

  NOTE: as soon the compose tips make their way into CVS, most of this code can be removed.
2003-06-19 17:26:27 +00:00
Dries Buytaert 63fb132ec6 - Bugfix: it was not possible to delete a user account when "delete" was
translated.  Patch by Stefan.
2003-06-18 18:13:28 +00:00
Dries Buytaert f4fe0cf1e7 - Improvement: made the user module use themeable lists. Patch #32 by Kristjan. 2003-06-18 17:44:09 +00:00
Steven Wittens 282566271f Bugfix: user timezone-selection now uses the site's configured date_format_long value rather than a hardcoded one. 2003-06-16 21:03:12 +00:00
Dries Buytaert e5f2c1ef0e - Usability improvement: avoid showing two login forms on one page. Suggested
by Keith.
2003-06-15 20:24:49 +00:00
Dries Buytaert 8a9a5ba3da - Bugfix: the variable 'user_mail_welcome_approval_subject' was too long.
Modified patch from Al; used 'user_mail_approval_subject' instead of
  'user_mail_welcome_approval_subj'.  Patch #11 by Al.  Fixes bug #1976.
2003-06-15 19:17:43 +00:00
Dries Buytaert c31fe45f2f - Improvement: fixed wrapping in code samples in user module so that admin help doesn't have a huge horizontal scrollbar. Patch #13 by Al. 2003-06-15 19:11:17 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert 3e9aabe058 - Moved some CXX checks to a centralized place; less error-prone. 2003-06-14 07:02:32 +00:00
Dries Buytaert d95499bf03 - Bugfix: small Xtemplate fixes. Patch by Ax. (Slightly modified.)
- Bugfix: block patch fix.  Patch by Gerhard.

- Bugfix: fixed broken URL in ping.  Patch by Gerhard.

  (This should fix the problems shown on http://www.blo.gs/info.php?id=1515.)

- Improvement: added better password generator.  Patch #1 by Al.  Fixes bug
  #1935.

- Improvement: performance improvement to the blog module.  Patch by Marco.
2003-06-13 17:34:18 +00:00
Dries Buytaert 9e813c08a4 - Bugfix: when clean URLs are enabled, the cookie path was not always set correctly when the
user logged using the user block from within a subdirectory.  Patch by Ulf Rompe.
2003-06-11 20:42:31 +00:00
Dries Buytaert 3b8c99d91e - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan.
- Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.

- Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:

  <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />

  IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.

- Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.

- Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.

- Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.

- Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.

- Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.

- Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
2003-06-11 18:16:32 +00:00
Dries Buytaert cf5a17ca0d Patch be Matt Westgate:
- Bugfix: in the user_admin_edit() function, the data array returned from the callback modules was not being merged into the edit array.

- Bugfix: added enctype="multipart/form-data" to the form tag so that we can update things like the avatar image in the admin interface.
2003-06-10 19:00:48 +00:00
Dries Buytaert d4ec431b44 - Bugfix: fixed approval e-mail and tidied up the e-mail handling. Patch #43 by
Al.  Fixes bug #1828.
2003-06-08 10:12:46 +00:00
Dries Buytaert ae45b735d3 - Bugfix: clicking the "Login" button after having created the first user
redirected you to an incorrect page.  Patch by Moshe.
2003-06-07 21:35:45 +00:00
Dries Buytaert 23423b46fb - Check the destrination URL before redirecting. 2003-06-07 15:59:49 +00:00
Dries Buytaert aa38097c07 - Dropped check_input(); use check_query() instead.
- Made the statistics module use referer_uri() for security's sake.
2003-06-06 21:37:11 +00:00
Dries Buytaert 48bf7db71c - Bugfix: removed redundant check_input()s such that quotes are handled
properly.  You couldn't use a username or passwords that had quotes.
2003-06-06 20:52:21 +00:00
Dries Buytaert 3436c02c81 - Bugfix: fixed the login problem due to incorrect use of drupal_goto().
Gerhard's patch was not 100% correct and I found a better alternative.
2003-06-06 17:30:09 +00:00
Dries Buytaert ed528531c7 - CSS improvements: use form functions wrapped in a <div> instead of
hard-coded form elements.  Modified patch by Kristjan.

  I added some CSS to drupal.css to center the text and ordered the
  list of CSS tags alphabetically.
2003-06-03 20:02:33 +00:00
Dries Buytaert c8b646320d - Resized two textfields for UI consistentcy. Patch by Stefan. 2003-06-02 18:09:07 +00:00
Dries Buytaert 5e2ce07616 - Documentation fixes by Kjartan. 2003-05-31 23:05:18 +00:00
Dries Buytaert 1fc8a18c2d - Al's CSS patches. This commit improves the themability of some core
components such as lists, form items, removes an ugly hack from the
  archive module and should fix the poll problem (although it doesn't
  Opera/Konqueror).
2003-05-29 10:18:38 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Kjartan Mannes 8c037610ab - $_SERVER["edit"] -> $_POST["edit"] 2003-05-19 18:59:34 +00:00
Kjartan Mannes 1a2f8acb2c - Patch by Jonathan Chaffer: $_SERVER["op"] -> $_POST["op"] 2003-05-19 18:58:50 +00:00
Dries Buytaert 8bc39e9083 - Undid my changes to user_access(). 2003-05-19 09:07:42 +00:00
Dries Buytaert 8205b62666 - Replaced some PHP_SELF's by request_uri()'s. Patch by Gerhard. 2003-05-18 20:21:35 +00:00
Dries Buytaert 494aa87e37 - Small change that reduces the number of SQL queries when a certain role has
no permissions set.
2003-05-18 09:10:17 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Dries Buytaert c60e3b13fa - Added missing t() function. Patch ba Al. 2003-05-06 06:42:01 +00:00
Dries Buytaert 54459cc01a - Fixed the function prototypes of the newly introduced theme_user_list(),
theme_node_list(), and theme_menu_list().  This will fix the excessive
  gap between lists and avoids generating empty <b></b> constructs.
2003-05-02 20:44:14 +00:00
Dries Buytaert 2d6408dff3 - Committed Adrian's item patch. It would be nice if one or more of the
standard themes could be updated to demonstrate the possibilities.
2003-04-29 20:48:50 +00:00
Dries Buytaert db04650411 - Added support for user registration guidelines. Patch by Al. Feature request #1109. 2003-04-28 21:36:43 +00:00
Dries Buytaert a956de78b9 - Fixed some PHP "notices". 2003-04-21 14:55:03 +00:00
Dries Buytaert 02f437a2f4 - Renamed 'validate_email_address' to 'valid_email_address'.
- Added a 'form_radio' function.
2003-04-13 13:42:51 +00:00
Dries Buytaert cb2d27c78d - Patch by Ax. Fixed some syntax errors:
-    case t("whatever");
    +    case t("whatever"):
2003-04-04 06:17:02 +00:00
Dries Buytaert 4742ba3549 - Fixed some SQL query directives. 2003-03-29 16:30:40 +00:00
Dries Buytaert d1be768b28 - Moved the logic of email validation from user_validate_mail to a new function
in common.inc.  Modified patch from Gerhard.
2003-03-28 10:55:27 +00:00
Dries Buytaert 65b6203700 - Another improvement to the e-mail address validation code. Fixed Debian
bug #185217.  Patch by Gerhard.
2003-03-19 17:34:27 +00:00
Dries Buytaert 31fce3f08c - Fixed glitch in e-mail verification code. Patch by Gerhard. 2003-03-18 19:18:30 +00:00
Dries Buytaert 170b674a09 - All LIMIT queries must go through the pager or through db_query_range().
The syntax for db_query_range() was enhanced so it matches db_query(). So
  you may pass extra arguments of the SQL statement which are checked via
  check_query() and then substituted into the SQL statement. After these
  optional arguments, you always pass $from and $count parameters which
  define your range.  Most often, the $from is 0 and the count is the max
  number of records you want returned.  Patch by Moshe.

- The pager_query() function for PEAR was enhanced so that it adds  proper
  GROUP BY statement counting the number of records to be paged. Patch by
  James Arthur.

- MSSQL database scheme by Moshe.
2003-03-16 07:02:20 +00:00