Commit Graph

122 Commits (5a90aa1175e020afeda9fe4775301e60468c7e91)

Author SHA1 Message Date
Dries Buytaert 67e68fc679 - Patch #28786 by Neil: move pagers out of table. 2005-09-24 07:53:26 +00:00
Dries Buytaert c9fc300b1f - Patch #29785 by Chx: multiple node types were broken so we refactored
part of the node system!  If you have a module that implements node
  types, you'll have to udpate its CVS HEAD version.

  We replaced _node_name() and _node_types() by _node().  The new _node()
  hook let's you define one or more node types, including their names.
  The implementation of the _node() hook needs to:

   return array($type1 => array('name' => $name1, 'base' => $base1),
                $type2 => array('name' => $name2, 'base' => $base2));

  where $type is the node type, $name is the human readable name of the type
  and $base is used instead of <hook> for <hook>_load, <hook>_view, etc.

  For example, the story module's node hook looks like this:

    function story_node() {
      return array('story' => array('name' => t('story'), 'base' => 'story'));
    }

  The page module's node hook module like:

    function page_node() {
      return array('page' => array('name' => t('page'), 'base' => 'page'));
    }

  However, more complex node modules like the project module and the
  flexinode module can use the 'base' parameter to specify a different base.

  The project module implements two node types, proejcts and issues, so it
  can do:

    function project_node() {
      return array(
       array('project_project' => array('name' => t('project'), 'base' => 'project'),
       array('project_issue' => array('name' => t('issue'), 'base' => 'project_issue'));
    }

  In the flexinode module's case there can only one base ...

  This hook will simplify the CCK, and will make it easy (or easier) to merge
  the story and page module.

  In addition, node_list() became node_get_types().  In addition, we created
  the following functions: node_get_name($type) and node_get_base($type).
2005-08-28 15:29:34 +00:00
Dries Buytaert 7b8a409675 - Patch #29385 by chx: no ?> add end of files. 2005-08-25 21:14:17 +00:00
Dries Buytaert 7625a4e91a - Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
Usernames can now be themed; eg. an icon/avatar could be added.

  TODO: update contributed modules + update the migration docs.
2005-08-01 05:14:05 +00:00
Dries Buytaert dbd806c41a - Patch #22857 by mathias: removed redundant DISTINCT(). 2005-05-14 17:01:31 +00:00
Dries Buytaert 381853c6b9 - Patch #21221 by Robert: make status values in comment.module defined constants for readability. 2005-05-05 20:12:49 +00:00
Dries Buytaert 38402b6c91 - Bug #21452 reported by njivy: added missing return to tracker_user_page().
It did not return nor print its output.
2005-05-01 16:09:52 +00:00
Dries Buytaert a76a1e1f3f - Patch 20910 by chx: centralize print theme page. 2005-04-24 16:34:36 +00:00
Dries Buytaert 5b7ecb8650 - Patch #17208 by asimmonds: help text fixes:
- permissions menu link updates in a number of modules help
    - anchor link fix in distributed auth help
    - "my account" link fix in user help
    - spelling correction in tracker.module help

- I also changed 'admin/access/perms' to 'admin/access/permissions'.
2005-02-12 07:51:14 +00:00
Dries Buytaert 59c2208ea6 - Patch #16253 by Goba: incremental improvements to the new content markers.
Goba: it would be nice if one of the core themes would showcase this functionality. ;-)
2005-01-30 09:53:19 +00:00
Dries Buytaert 18a0cc2327 - Added a missing DISTINCT() to the pager query. Spotted by Steven. 2005-01-30 08:39:35 +00:00
Dries Buytaert de9179147d - I had to use DISTINCT for the tracker.module's SQL queries. 2005-01-29 22:21:22 +00:00
Dries Buytaert 993ea0c6c5 - Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query. 2005-01-29 22:02:37 +00:00
Dries Buytaert 467dbdc4a1 - Patch #16253 by Goba: this simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though. 2005-01-27 12:57:08 +00:00
Steven Wittens 09bd156ba2 - Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes).
- Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings.
2005-01-19 01:46:25 +00:00
Steven Wittens 86af977eca - #15500: Fix tracker not showing nodes without comments.
- Tiny code style fix
2005-01-19 01:12:14 +00:00
Steven Wittens e7edb55d63 - The real code fixes ;) 2005-01-17 19:00:03 +00:00
Dries Buytaert 971a0e24aa - Patch #14731 by chx: made it possible to rewrite node queries. 2005-01-16 18:44:49 +00:00
Dries Buytaert 22869afd38 - Patch #14262 by Richard: help text improvements for the tracker module. 2004-12-16 21:42:30 +00:00
Dries Buytaert 9574766ad8 - Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency. 2004-11-23 22:20:41 +00:00
Dries Buytaert 9979aceab0 - Patch #12783 by Stefan: various small consistency/usability improvements. 2004-11-15 11:16:39 +00:00
Dries Buytaert 7ad36e3f59 - Modifed patch by ccourtne: made the tracker module take advantage of the node_comment_statistics table. Improves performance of the tracker page by facter 10 because it eliminates up to 20 SQL queries. 2004-11-04 20:17:07 +00:00
Dries Buytaert dfb3c3aec4 - Patch #11577 by drumm: changed t('ago') -> t('%time ago', ...) to make it
translatable in languages such as Spanish.
2004-10-15 05:10:35 +00:00
Dries Buytaert 96121dbbe2 - Small refinement with regard to the page title. 2004-10-06 20:43:05 +00:00
Dries Buytaert 36c0cda221 - Rewored 'track posts' to 'track'. 2004-10-06 20:00:56 +00:00
Dries Buytaert 67e4f74449 - Usability improvement: the 'recent posts' feature on the user pages lead
to a page with a confusing (wrong) title so I shuffled things around a bit
  and tab-ified it as 'track'.
2004-10-06 18:26:01 +00:00
Dries Buytaert 5c7983c4de - Patch #8179 by JonBob: reintroduced menu caching. 2004-09-16 07:17:56 +00:00
Dries Buytaert 94e30bf776 - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks. 2004-08-21 06:42:38 +00:00
Dries Buytaert fa25c7a0ca - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions). 2004-08-19 15:41:57 +00:00
Dries Buytaert 9bbdb71ee4 - Patch #9330: ucfirst() gives problem when used with multibyte charset.
Replaced the use of ucfirst() with a CSS-based solution.
2004-08-06 20:15:32 +00:00
Dries Buytaert 202eee42a9 - Patch #9543 by JonBob: added node-level access control! 2004-07-31 09:30:09 +00:00
Dries Buytaert 702a057683 - Patch #9478 by JonBob: allow printf-style arguments in pager_query.
Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.

  This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
2004-07-25 14:25:42 +00:00
Dries Buytaert 9e43afadc7 - Patch by Matt: made it possible to alias an URL multiple times. 2004-07-11 06:53:39 +00:00
Dries Buytaert 78876f01d5 - Fixed colspan in tracker table.
- Renamed '... your ...' to '... my ...' (cfr. 'my account).
2004-07-08 15:18:48 +00:00
Dries Buytaert 039c77121a - Patch #9031 by Morbus: this last tracker patch was broken - for installations where the comment.module is turned on, $comments is never set to 0, and posts that have no comments instead get the value of the last successful comment_num_all. The attached patch corrects this ($comments is set to 0 before we do anything) and also merges the if statements. 2004-07-08 06:15:49 +00:00
Dries Buytaert 4e9ef33896 - Patch #9031 by Ber: if the comment module is not available comment_num_all()
should not be called.
2004-07-06 07:38:35 +00:00
Dries Buytaert c2d7419f23 - Patch #8681 by stefan: fixed some broken URLs and help texts. 2004-06-20 19:49:14 +00:00
Dries Buytaert 54b77d6435 Tabs patch!
CHANGES
-------

 + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.

 + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.

 + Grouped settings. All settings have been grouped under 'administer > settings'.

TODO
----

 + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.

 + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
Dries Buytaert 67675b498c - More code improvements by JonBob. 2004-05-24 18:37:50 +00:00
Dries Buytaert 7231c88a32 - Added support for 403 handling. Patch by JonBob. As a side benefit,
administrators will be able to define a custom 403 page, just as they
  can define 404 pages now.

  This needs to be documented in the "Changes since / migrating to ..."
  pages.
2004-04-21 13:56:38 +00:00
Dries Buytaert 7f13bad91c - Remove redundant line. Patch by killes. 2004-04-01 18:57:41 +00:00
Dries Buytaert 637898ecc3 - Tiny usability improvement for translators. Patch by Gerhard. 2004-03-29 19:00:07 +00:00
Dries Buytaert 754f2ac26a - More profile module improvements:
+ Updated the _user() hook's "$type == 'view'" case to match the
     "$type == 'edit'" case.  That is, both have to return an associtive
     array of the format array('category' => 'fields').

   + Updated the profile pages to group fields by category.  Made possible
     thanks to the above change.

   + Moved logic out of the theme_ functions.
2004-03-21 14:28:15 +00:00
Dries Buytaert 142dd6ba43 Patch #5588 by bylund: XHTML improvements: <i> -> <em> and <b> -> <strong>. 2004-03-20 13:29:06 +00:00
Dries Buytaert 8145c7695c - Tracker and forum module improvements!
Note: the CSS of the tracker page has changed.  Some CSS files still have
  to be updated.
2004-03-20 13:23:34 +00:00
Dries Buytaert 2101f6c454 - Rewrote the profile module:
+ Added a 'created' field to the users table and renamed the 'timestamp'
     fied to 'changed' (cfr. node table).  Update.php will try to determine
     a 'created' timestamp for existing users.

   + The profile module no longer uses serialized data but has its own set
     of tables.  Known existing profile data is migrated by these new tables.
       TODO: migrate the birthday field.

   + The profile fields can be grouped, and within each group, profile fields
     can be sorted using weights.

   + The profile pages can be themed.

   + The profiles can be browsed based on certain properties/settings.

   + Change the _user hook: (i) 'private_view' and 'public_view' are merged
     into 'view' as there are no private fields and (ii) 'edit_form' has
     been renamed to 'edit'.

   + Avatar handling has been refactored and is now part of the user module.
     The users table has a dedicted 'picture' field.

   + Simplified the way themes should use display/visualize pictures or
     avatars.

   + Made it possible for administrators to replace or delete avatars.

   + ...

  I hope this make for a good base to build on collectively.
2004-03-11 20:33:59 +00:00
Kjartan Mannes 2c2b0904dc - Coding style fixes.
- Extended tracker comments to handle project issues.
2004-02-21 22:20:21 +00:00
Dries Buytaert 4b0b2d02ee - Patch by Steven: removed redundant permission checks. These are no longer
required thanks to the new 404 handling.
2004-02-15 20:09:46 +00:00
Dries Buytaert 8c909397d7 - Patch #5501: fixed invalid HTML in the comment and tracker module. 2004-02-07 10:57:27 +00:00
Dries Buytaert fb1195258f - Fixed tracker bug: tracker module has a line of faulty code which tries
to get the node name in the old way.  Patch by JonBob.
2004-01-31 21:32:06 +00:00