Commit Graph

572 Commits (53872d2396f15260a1e7748f477f320296c6eacc)

Author SHA1 Message Date
Dries Buytaert 7b8a409675 - Patch #29385 by chx: no ?> add end of files. 2005-08-25 21:14:17 +00:00
Dries Buytaert 6a4e6df36f - Patch #17592 by killes: improved access denied messages. 2005-08-22 20:39:43 +00:00
Dries Buytaert 3b8220e6f5 - Patch #29335 by jonbob: shuffled the case-statements around for performance's sake. 2005-08-22 10:11:15 +00:00
Dries Buytaert ceb013278e - Patch #23750 by jerakeen: use the creation date rather than the update date in RSS feeds. 2005-08-11 12:53:39 +00:00
Dries Buytaert 2a87b5029b - Patch #24002: fixed node created timestamp changing on node edit. 2005-08-07 15:53:26 +00:00
Dries Buytaert 79f08aca2c - Patch #26637 by Robert Douglas: $teaser misnamed in themes theme_node().
TODO: update documentation!
2005-08-07 14:55:17 +00:00
Steven Wittens f7039a67cc - #25395: Allow for more integers in node_access grant_x columns 2005-08-05 13:11:10 +00:00
Steven Wittens 88c6184c25 - #27864: Correctly distinguish 403s from 404s for nodes. 2005-08-05 00:38:38 +00:00
Dries Buytaert 7625a4e91a - Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
Usernames can now be themed; eg. an icon/avatar could be added.

  TODO: update contributed modules + update the migration docs.
2005-08-01 05:14:05 +00:00
Dries Buytaert 70bc4639fa - Patch #27535 by Ber: set 'preview status message' using drupal_set_message(). 2005-07-31 10:28:50 +00:00
Steven Wittens e4096e1418 - #27551: Rename check_output() to check_markup(). Needs contrib updates! 2005-07-29 21:06:33 +00:00
Steven Wittens f0c5a2860a - #26458: node_search doesn't node_view, causing bad snippets. 2005-07-29 03:29:53 +00:00
Steven Wittens d720c66148 - #26458: node_search doesn't node_view, causing bad snippets. 2005-07-29 03:21:09 +00:00
Dries Buytaert 31387c5a77 - Patch #26467 by drumm: make the destination persist across multiple pages
and fixed the node delete form to use a return destination.
2005-07-20 10:48:20 +00:00
Steven Wittens 5ed64a71bd - Fix oopsie in node_load() after recent patch. 2005-07-18 20:27:32 +00:00
Dries Buytaert 1a0655dce9 - Updated handbook-link to reflect the recent handbook restructuring. 2005-07-18 08:46:30 +00:00
Dries Buytaert b7c0975e23 - Fixed typo in PHPdoc 2005-07-17 21:08:49 +00:00
Dries Buytaert 2895357de0 - Modified patch #25031 by chx: modified node_list() so one has both the module and its type.
TODO: update migration page in handbook.
2005-07-17 20:57:43 +00:00
Dries Buytaert 160a1e0ef8 - Patch #25634 by chx: simplified node_load(). 2005-07-17 18:29:32 +00:00
Dries Buytaert 73010a5215 - Fix by darix: fixed content type settings broken by berkes' last patch. 2005-07-07 13:30:50 +00:00
Dries Buytaert d96e7e0bbb - Patches by Ber: move user settings and node settings to admin/settings. 2005-07-03 16:41:42 +00:00
Dries Buytaert 2c10ff4b5f - Fixed problems with filter formats and problem with XML-RPC server. 2005-06-29 19:53:14 +00:00
Dries Buytaert 58aee8cdad - Patch #25603 by Stefan: made the sizes of forms consistent.
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
Dries Buytaert 5c8843704c - Patch #18213 by chx: boostrap system. Modified to work with HEAD, tidied
up the documentation a little.

  chx: can you double-check whether the global $conf variable is secure?
       (That is, make sure it can't be send using the URL or something.)
2005-06-22 20:19:58 +00:00
Dries Buytaert f3a9a99570 - Patch #25121 by Robrecht J.: changed itemized lists with hardcoded CSS to definition lists. 2005-06-21 18:58:27 +00:00
Dries Buytaert e550f84162 - Patch #16204 by Thox: committed the collapsible form elements patch.
NOTE: this patch works well, but the improved node edit form still has
        some rough edges.  It is important that we continue to improve
        usability.  Give it a try.
2005-06-21 09:45:45 +00:00
Dries Buytaert 8436082fe1 - Removing some whitespace 2005-06-06 14:07:04 +00:00
Steven Wittens c928f9c1bb - #18836: Cleanup teaser generation code, and refine handling of PHP code teasers. 2005-06-01 03:42:47 +00:00
Steven Wittens 5257b684ff - #18836: Cleanup teaser generation code, and refine handling of PHP code teasers. 2005-06-01 03:32:22 +00:00
Steven Wittens a597354bcb - Code cleanup: improve format_plural usage, add some missing placeholder/check calls, and introduce API for <link> tags. 2005-05-31 21:14:27 +00:00
Dries Buytaert d0390be0bd - Patch #18275 by Steven: "create content" menu displays extraneous links.
(Not sure if this needs to be backported to DRUPAL-4-6.)
2005-05-26 19:29:48 +00:00
Steven Wittens cbd6837b40 - #18406: make node_page 404 on meaningless nids 2005-05-25 07:14:00 +00:00
Steven Wittens 09354344e0 - Sort admin-content by descending node date. This got lost in the refinement-filter patch. 2005-05-25 03:51:00 +00:00
Steven Wittens 58bddf8abc * cue Star Wars theme tune *
Return of the JavaScript!

- #22519: form_autocomplete(): Ajax based autocompletion. Currently used for user names and folksonomy tags.
2005-05-24 06:00:22 +00:00
Dries Buytaert a5489b7b1c - Patch by chx: added a db_rewrite_sql() in node_load() just to make sure. 2005-05-17 20:24:33 +00:00
Dries Buytaert a76a1e1f3f - Patch 20910 by chx: centralize print theme page. 2005-04-24 16:34:36 +00:00
Dries Buytaert 9802b20a17 - Patch #20188 by Goba: Node_feed() instructs the nodeapi view call it invokes to deal with the body of the node, but afterwards it only uses the teaser to generate the feed. So the nodeapi hook should be called with teaser processing in mind. This simple patch fixes that. 2005-04-11 16:39:19 +00:00
Dries Buytaert 91e8b1b1e4 - Removed weird phpdoc line 2005-04-05 07:25:11 +00:00
Dries Buytaert a3e9b35afc - Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook. 2005-04-01 15:55:02 +00:00
Dries Buytaert 7bdcba1720 - Patch #19739 by Uwe: corrected many typo's in the documentation and code comments 2005-03-31 21:18:08 +00:00
Steven Wittens be14203534 - #18817: Clean up plain-text checking (see drupal-devel!) 2005-03-31 09:25:33 +00:00
Steven Wittens 54dfc577ba - #19353: Fix 'submit' button behaviour wrt optional previewing and form errors. 2005-03-27 21:34:50 +00:00
Steven Wittens d8fad6e24f - #17343: Fix safari CSS issues with node admin. 2005-03-27 15:54:44 +00:00
Steven Wittens 576c60803d - #19405: Fix SQL in comment block for anonymous users. 2005-03-24 22:09:31 +00:00
Steven Wittens 1185839923 - #19089: Remove depency on taxonomy.module by node.module (kjartan) 2005-03-18 18:46:23 +00:00
Steven Wittens e17490b653 - #12401: Non-admins should obey workflow wrt revisions. 2005-03-18 08:14:37 +00:00
Dries Buytaert 49240b6b1e - Patch #18216: fixed nodeapi settings hook. 2005-03-07 21:58:13 +00:00
Dries Buytaert 0f7be2573e - Bumped the RSS version from 0.92 to 2.0 2005-03-07 21:52:57 +00:00
Dries Buytaert 77f7aa0211 - Patch #18418 by chx: jonbob node_access_view_all patch changed the return value of node_access_where_sql to empty which breaks nicely all queries which are still using this function. This is a good incentive to upgrade to db_rewrite_sql, yes, but I think it causes confusion, 'cos it is not really trivial why the query suddenly not works. Let's make it trivial -- rename it _node_access_where_sql, it is no longer a function to be called from outside. node_access_join_sql similarly. 2005-03-05 11:05:07 +00:00
Steven Wittens 96eb9c6f9f #18226: Non-admins were not obeying workflow. 2005-03-04 00:48:22 +00:00
Steven Wittens 198ec98f75 #18329: Unify confirmation messages (and make them themable) 2005-03-03 20:51:27 +00:00
Dries Buytaert 3123d7e6ec - Patch #18045 by JonBob: the node type admin page uses an unclear callback name, and uses arg() where it is not necessary. The attached patch cleans this up by unifying node_types() with node_types_configure(). 2005-03-01 20:07:48 +00:00
Dries Buytaert a4befbb68b - Patch #18123 by chx: the $return['distinct'] in the past should have been module_implements('node_grants') but after JonBob's node_access_view_all_nodes, that part happens only if node_grants is in effect, so it is simplified to 1. 2005-03-01 20:01:40 +00:00
Steven Wittens ff386b90bb #17747: PGSQL improvements 2005-02-28 18:00:59 +00:00
Steven Wittens 538a3071de - #17870: Add preview CSS class to node preview (drumm) 2005-02-27 02:54:24 +00:00
Dries Buytaert 1e15bed312 - Patch #17687 by Gerhard: removed some cruft. 2005-02-21 19:47:44 +00:00
Steven Wittens bb08146c67 - Fixing broken search after sql rewrite patches
- Minor code style fixes.
2005-02-19 22:24:24 +00:00
Dries Buytaert d6b553c256 - Patch #16558 by JonBob: improved performance of node access checks. 2005-02-18 18:40:05 +00:00
Dries Buytaert 892d828629 - Fixed broken colspan. Reported by asimmonds. 2005-02-14 21:28:08 +00:00
Dries Buytaert 95f4d9751e - Fixed broken colspan. 2005-02-11 19:10:28 +00:00
Dries Buytaert 470fe1c1fd - Patch #16960 by Goba: fixed content type options. 2005-02-10 20:58:03 +00:00
Dries Buytaert 08e7c8b3a7 - Patch #16246 by Moshe: "Here is a patch for node.module since thta hunk failed last time. Note that I've removed the 'delete' link since it doesn't work and is mostly obsolete with the 'mass delete' feature. I've also added smart destination andling to the 'url alias delete' feature." 2005-02-10 19:30:08 +00:00
Steven Wittens 95907f0c2e - Fixing broken drupal_goto() after node submission on PHP5. 2005-02-04 20:48:37 +00:00
Steven Wittens 7fe195a07e - PHP5 fix due object references: node previewing should not put node output into form. 2005-02-04 20:14:05 +00:00
Steven Wittens ab816b6d6d - Fix warning due to old session variable. 2005-02-02 01:03:25 +00:00
Steven Wittens d56cf2b59c #10296: Clean up admin - content:
- Mass-delete functionality (with confirmation)
- Flexible filtering for the overview table based on status, type and taxonomy.
- Missing drupal_goto's
- Clean up watchdog messages
- Remove some dead code
2005-02-02 00:55:59 +00:00
Dries Buytaert 7931c778d7 - Patch #16513 by James (slightly modified): export categories and enclosures to RSS feeds (and made RSS feeds extensible).
NOTE: this needs to be documented.
2005-02-01 14:09:31 +00:00
Dries Buytaert 96c039680a - Patch #16111 by chx: fixed some bugs in the db_rewrite_sql() code. 2005-01-31 20:45:10 +00:00
Dries Buytaert 59c2208ea6 - Patch #16253 by Goba: incremental improvements to the new content markers.
Goba: it would be nice if one of the core themes would showcase this functionality. ;-)
2005-01-30 09:53:19 +00:00
Dries Buytaert 993ea0c6c5 - Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query. 2005-01-29 22:02:37 +00:00
Dries Buytaert c0f06fbe67 - Patch #6025 by Jeremy: avoid data to get lost when two users are editing a node at the same time. 2005-01-27 14:45:42 +00:00
Dries Buytaert 7415e0b1c8 - Patch #16192 by Neil: moved the submission guidelines found in forum, story, and blog and the minimum number of words found in story and blog (blog had a slight bug) into the node module. 2005-01-26 22:59:41 +00:00
Dries Buytaert 173f528f59 - Modified patch #14170 by Neil: improved default workflow (default node type) configuration page.
Modified the patch to remove some redundant code, to translate strings, and to better use the menu system.
2005-01-24 21:20:16 +00:00
Dries Buytaert 9cd36863b0 - I had to modify chx's patch/change because it did not work with PHP5. Please double-check. 2005-01-23 16:20:10 +00:00
Dries Buytaert 898e02252d - Patch #16026 by chx: fixed node-level permissions. 2005-01-23 15:45:38 +00:00
Steven Wittens a332228326 Documenting a tricky regexp. 2005-01-22 22:33:20 +00:00
Steven Wittens 4e6ceaae99 - Another code style fix. 2005-01-19 01:51:58 +00:00
Steven Wittens 09bd156ba2 - Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes).
- Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings.
2005-01-19 01:46:25 +00:00
Steven Wittens 86af977eca - #15500: Fix tracker not showing nodes without comments.
- Tiny code style fix
2005-01-19 01:12:14 +00:00
Steven Wittens e7edb55d63 - The real code fixes ;) 2005-01-17 19:00:03 +00:00
Steven Wittens a1579a3aee - Reversing bad commit, sorry everyone. 2005-01-17 18:56:11 +00:00
Steven Wittens b45bd13d44 - Various code style fixes 2005-01-17 00:41:35 +00:00
Dries Buytaert 971a0e24aa - Patch #14731 by chx: made it possible to rewrite node queries. 2005-01-16 18:44:49 +00:00
Steven Wittens 92bc08b5b9 - Make the search settings page more user-friendly. 2005-01-11 09:41:49 +00:00
Steven Wittens 8655d4368a - Fixing a couple of watchdog() calls. 2005-01-09 12:58:53 +00:00
Dries Buytaert 64b100d19a - Patch #13260 by UnConeD: watchdog module improvements.
We added a 'severity' column to watchdog():
    watchdog($type, $message, $link) --> watchdog($type, $message, $severity, $link);

    * Specify a severity in case you are reporting a warning or error.
    * The $link-parameter is now the fourth parameter instead of the third.

  TODO: document this in the upgrade guide.
2005-01-09 09:22:40 +00:00
Dries Buytaert 1dbe0dc2ee - Patch #14917 by UnConeD/Steven:
1) The different types of search, which used to be radio button options in the search form, are now subtabs of "search" (default "search/node"). This seems better from a UI point of view, but also has another advantage: modules which implement a custom search form (flexinode, project) can add it as a subtab of search. This means that all search forms will be located in the same place, and also without needing an extra api call to search.module.

2) The current code was a bit hackish, as the indexing of comments along with nodes was hardcoded in node.module. Instead, I created a nodeapi operation "update index" which allows modules to add more data for a node that is being indexed. Comments are now indexed using this mechanism and from comment.module, which is a lot cleaner.

3) The search results format was also hardcoded to include "N comments". I replaced this with a nodeapi operation "search result" and moved the comment code to comment.module where it belongs. This op is quite useful, as for example I also modified upload.module to add "N attachments" to a search result if any are present.
2004-12-31 09:30:12 +00:00
Dries Buytaert 05ede21745 - Patch #6308 by gordon: allow node_submit() to be used by external interfaces. 2004-12-26 20:10:02 +00:00
Steven Wittens 61b174e7d2 #11548: node.module - Ensure that only valid fields are saved 2004-12-24 06:44:11 +00:00
Dries Buytaert fde5f1bf6f - Patch #14709 by matteo: added missing call to the nodeapi's 'view' hook. 2004-12-23 23:26:14 +00:00
Steven Wittens 9f7b16ada9 #12793: Remove dependency of node.module on search.module. 2004-12-20 14:34:41 +00:00
Dries Buytaert 2b17b3a966 - Patch #13907 by Neil: less ways to set the page title.
* Less logic in theme code.
   * Encourages use of the menu system.
   * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
   * Very slightly more efficient.
2004-12-15 21:19:42 +00:00
Dries Buytaert 6e3eb60aab - Removed some cruft: left-over xxx_help_page() functions. 2004-12-11 14:13:24 +00:00
Dries Buytaert 60352821bf - Refactored the queue module: removed the queue module's field from the node table. With help from Gerhard.
- Slight addition to INSTALL.txt with regard to PHP versions.

- Updated/reworded some node type descriptions as per Boris' suggestions.

- Adding missing {} around a table name in update.php.
2004-12-07 16:55:38 +00:00
Steven Wittens 2afd987398 Search: indexing should invoke nodeapi to catch all user-visible data (e.g. file attachment names). 2004-12-02 06:44:55 +00:00
Dries Buytaert b83b34018f - Patch #10697 by matteo: avoid that administrators can create nodes with the wrong node type. 2004-11-29 12:49:17 +00:00
Dries Buytaert e1cf88e7f8 - Modified patch #11840 by Stefan: added conctext-sensitive help text to the 'revision'-page. 2004-11-27 10:02:06 +00:00
Dries Buytaert 30110a8770 - Patch #6166 by Moshe: node preview should not display links. Push the links to the theme instead of the theme having to pull them in using node_link().
TODO:
    1. Update theme upgrade instructions in the handbook: node_link() is gone.
    2. Remove page_link() just like we removed node_link().
2004-11-23 23:11:59 +00:00
Dries Buytaert 9574766ad8 - Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency. 2004-11-23 22:20:41 +00:00
Dries Buytaert fa97839088 - Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
Read the manual for pg_escape_string:  "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
2004-11-21 08:25:17 +00:00