Commit Graph

798 Commits (529550a4b2ae73194f4dc72171326daffe954e69)

Author SHA1 Message Date
Alex Pott 3f75f72de2
Issue #3131281 by mondrake, rahulrasgon, longwave, ridhimaabrol24, naresh_bavaskar, jungle, daffie: [May 17th 2021] Replace assertEqual() with assertEquals() 2021-05-20 00:39:14 +01:00
daffie 83c20c7c49 Issue #3209453 by daffie: The service "search.index" should be backend_overridable 2021-04-24 20:17:46 +00:00
Alex Pott e3dfd1a9db
Issue #2937858 by SherFengChong, Saviktor, longwave, jhodgdon, catch: Fix 'Drupal.Commenting.DocCommentAlignment' coding standard 2021-04-04 09:39:06 +01:00
Alex Pott bd882e9b7b
Issue #2992894 by mohit_aghera, adityasingh, adalbertov, raman.b, vsujeetkumar, mgifford, RenatoG, nishantghetiya, Kristen Pol, alexpott, penyaskito, andrewmacpherson, catch: Search results of multi-lingual pages fail Language of Parts 2021-03-30 16:21:38 +01:00
catch 39e442948d Issue #3198400 by mondrake, daffie, alexpott, longwave: Convert assertions involving use of xpath on input tags to WebAssert 2021-03-08 12:15:37 +00:00
catch 5152d6638f Issue #2623718 by attiks, vsujeetkumar, andypost, MerryHamster, ankithashetty, anmolgoyal74, pfrenssen, longwave, alexpott, borisson_: Fix 'Drupal.Commenting.HookComment' coding standard 2021-02-18 20:32:15 +00:00
catch 3ce319d6a2 Issue #3187309 by longwave, Spokje, ayushmishra206, adityasingh, mondrake: Convert assertions involving use of xpath on select and option elements to WebAssert 2021-02-12 10:04:12 +00:00
Alex Pott 33700d0162
Issue #3193163 by mondrake, longwave: Deprecate AssertLegacyTrait::verbose and remove its usage 2021-02-09 16:09:11 +00:00
catch afd86e7d3c Issue #3193955 by mondrake, daffie, catch: Swap assertEqual arguments in preparation to replace with assertEquals 2021-01-28 09:57:41 +00:00
Alex Pott 10ec6052e9
Issue #3192951 by raman.b, daffie: Cleanup parameter in calls to database query extenders 2021-01-25 16:10:11 +00:00
catch 6c64763741 Issue #2867959 by mondrake, danielnv18, xjm, ZeiP, daffie: Replace usages of deprecated AssertLegacyTrait::assertIdentical 2021-01-21 10:01:43 +00:00
catch 2ef2387216 Issue #3193600 by ankithashetty, mondrake, daffie: Convert assertEqual() calls involving NULL, TRUE and FALSE to more appropriate PHPUnit assertions 2021-01-20 21:23:44 +00:00
catch d722e9d760 Issue #3192221 by mondrake, daffie, longwave: Swap assertIdentical arguments in preparation to replace with assertSame 2021-01-18 17:35:30 +00:00
catch 39bacf4426 Issue #3192427 by mondrake, daffie: Replace usages of deprecated AssertLegacyTrait::assertNotEqual 2021-01-18 16:16:33 +00:00
catch 9ac7689b1a Issue #3159788 by mondrake, ravi.shankar, narendra.rajwar27, longwave, Hardik_Patel_12, ankithashetty, sarvjeetsingh, kishor_kolekar: AssertLegacyTrait::assert(No)Text() in functional tests still have a message passed in 2021-01-11 10:24:10 +00:00
Alex Pott d78e53bb0b
Issue #3189880 by mondrake, raman.b, Pooja Ganjage, daffie, Megha_kundar, dww, S_Bhandari: Use square brackets syntax in sql queries 2021-01-05 15:02:37 +00:00
catch cf64091c38 Issue #3132919 by mondrake, pavnish, tvb, jungle, msuthars, ridhimaabrol24, Hardik_Patel_12, mrinalini9, Suresh Prabhu Parkala, longwave, ravi.shankar: Replace assert*() involving equality comparison operators with assert(Not)(Equals|Same) 2020-12-18 12:15:57 +00:00
Alex Pott 989fdedc77
Issue #3151993 by anmolgoyal74, huzooka, benjifisher, Wim Leers, quietone: Search settings migration (d7_search_settings) assumes that the search_default_module variable is always set 2020-12-08 14:11:15 +00:00
catch 86c7ed07ab Issue #3183673 by jonathan1055, longwave: Fix 'Drupal.Commenting.DocComment.ShortFullStop' coding standard - part 1 auto-fixes 2020-11-30 18:10:49 +00:00
catch dee581d3fa Issue #3128815 by mondrake, jungle, sja112, Spokje, shobhit_juyal, jameszhang023, nikitagupta, mrinalini9, xjm, longwave, dww: Replace assert*() involving greater/less comparison operators with assert(Greater|Less)Than(OrEqual) 2020-11-24 09:57:55 +00:00
catch 96d4338074 Issue #3168375 by mondrake, manishsaharan29497, longwave: Convert calls to drupalPostForm(NULL, ...) to submitForm 2020-11-23 14:35:28 +00:00
catch 783e7eb88e Issue #3145005 by longwave, mondrake, cburschka, raman.b, Lal_, dww, xjm: [November 9, 2020] Remove uses of t() in drupalPostForm() calls 2020-11-16 16:51:39 +00:00
catch 1d6e7e25d5 Issue #2851394 by GoZ, hgunicamp, oknate, jungle, wolffereast, tameeshb, mmatsoo, ridhimaabrol24, jofitz, swarad07, tanc, shaktik, dimaro, shashikant_chauhan, MerryHamster, quietone, nitesh624, martin_q, boaloysius, gaurav.kapoor, nitvirus, ankithashetty, Munavijayalakshmi, kostyashupenko, leolando.tan, amit.drupal, ravi.shankar, akashkrishnan01, Swapnil_Kotwal, Saviktor, mrinalini9, anmolgoyal74, Venkatesh Rajan.J, shimpy, lomasr, Dinesh18, shubham.prakash, mahtab_alam, markdorison, cilefen, longwave, bleen, xjm, alexpott, gmaltoni: Fix grammar 'a' to 'an' when necessary 2020-11-13 14:25:11 +00:00
catch 5939e6b5f8 Issue #3145418 by longwave, paulocs, shetpooja04, Spokje, nikitagupta, mondrake, ravi.shankar, sarvjeetsingh, mrinalini9: [November 9, 2020] Remove uses of t() in assertText() calls 2020-11-13 11:06:01 +00:00
catch 7dbdbcb1fa Issue #3166450 by mondrake, longwave, snehalgaikwad: Split assertTrue using && into multiple assertions 2020-11-09 12:07:29 +00:00
Alex Pott aba38bc0b2
Issue #3177377 by ranjith_kumar_k_u, kapilkumar0324, paulocs, longwave: Remove unused variable $charcodes and $node2 2020-10-27 13:56:38 +00:00
catch a33344f95c Issue #3173595 by shetpooja04, meena.bisht, Pooja Ganjage, quietone, longwave: Remove only Unused variable $email in SearchBlockTest.php, search module 2020-10-26 13:48:04 +00:00
catch 484d80dbb9 Issue #3172438 by mondrake, kishor_kolekar, longwave, NitinLama, mikelutz, jungle: Since symfony/phpunit-bridge 5.1: Using "@expectedDeprecation" annotations in tests is deprecated, use the "ExpectDeprecationTrait::expectDeprecation()" method instead 2020-10-15 15:00:17 +01:00
Alex Pott e0c3bb56f6
Issue #3173873 by shetpooja04: Unused variable $pos in SearchQuery.php, search module 2020-10-02 13:03:18 +01:00
Lee Rowlands a44a9b1cd0
Issue #3159230 by mondrake, sandeep_jangra, ravi.shankar, naresh_bavaskar, larowlan, longwave: AssertLegacyTrait::assert(No)Raw() in functional tests still have a message passed in 2020-09-11 08:05:30 +10:00
Alex Pott 472b19010a
Issue #3139418 by mondrake, jungle, longwave: Replace usages of AssertLegacyTrait::assert(No)LinkByHref, that is deprecated 2020-09-08 16:00:31 +01:00
catch c09dc39b8f Issue #3139419 by mondrake, aleevas: Replace usages of AssertLegacyTrait::assertUrl, that is deprecated 2020-09-02 14:52:13 +01:00
catch f4fd2d7336 Issue #3166349 by paulocs, snehalgaikwad, naresh_bavaskar, mondrake: Remove uses of t() in assertNoText() 2020-08-28 12:48:09 +01:00
catch 4a7c205450 Issue #3153143 by ridhimaabrol24, Hardik_Patel_12, siddhant.bhosale, guptahemant, quietone, paulocs: Remove uses of t() in linkExists() and linkNotExists() calls 2020-08-28 10:46:35 +01:00
catch 3ab889a1aa Issue #3153150 by Suresh Prabhu Parkala, paulocs, ravi.shankar, Deepak Goyal, Hardik_Patel_12, longwave: Remove uses of t() in assertTrue() and assertFalse() calls 2020-08-28 10:07:33 +01:00
Lee Rowlands 82949679ce
Issue #3143870 by mondrake, pavnish, longwave: Calls to AssertLegacyTrait::assertUrl() have wrong number of arguments 2020-08-28 11:22:44 +10:00
catch 7628e38b90 Issue #3139433 by mondrake, Hardik_Patel_12, mohrerao, jungle: Replace usages of AssertLegacyTrait::assert(No)Escaped, that is deprecated 2020-08-10 11:29:50 +01:00
Alex Pott 3312c7b19f
Issue #3160267 by nijolawrence, jungle, daffie, alexpott: Change static queries to dynamic queries in core/modules/{every module}/tests 2020-08-07 22:47:39 +01:00
Alex Pott f124d526c6
Issue #3130655 by daffie, andypost, Beakerboy, ravi.shankar, alexpott, mradcliffe, Lendude: Deprecate creating an instance of the class Drupal\Core\Database\Query\Condition with the new keyword 2020-08-07 21:00:15 +01:00
Alex Pott 5412462830
Issue #3138766 by mohrerao, longwave, sja112, jameszhang023, Lal_, ravi.shankar, jungle, xjm: Fix "Don't" relevant typos in core 2020-07-31 17:30:18 +01:00
Nathaniel Catchpole fa14ee6fad Issue #3138781 by mohrerao, jungle, mrinalini9, sja112: Standardize "ORed", "ANDed", etc. in core 2020-07-30 09:01:32 +01:00
Alex Pott 640ea36a25
Issue #3075703 by kim.pepper, andypost, ravi.shankar, daffie, pavnish, jungle, alexpott, jhodgdon: Move search text processing to a service 2020-07-21 13:56:40 +01:00
Alex Pott 09c6b3d80d
Issue #3139428 by jungle, ridhimaabrol24, Hardik_Patel_12, mondrake, mrinalini9, Bunty Badgujar: Replace usages of deprecated AssertLegacyTrait::assert(No)FieldChecked() 2020-07-15 23:46:47 +01:00
catch 920d1708c9 Issue #3151364 by Charlie ChX Negyesi, amateescu, alexpott, jhodgdon: diacritics are not removed from ǢǣǼǽǮǯ 2020-07-14 13:16:26 +01:00
Lauri Eskola 311db38d3a
Issue #3155221 by andypost, jhodgdon: Remove outdated todo and link to 3086795 2020-07-07 11:44:29 +03:00
catch 2b7d2e1e26 Issue #3139437 by pavnish, mrinalini9, mondrake, longwave, Bunty Badgujar: Replace usages of AssertLegacyTrait::assertCacheTag, that is deprecated 2020-06-29 16:26:59 +01:00
Alex Pott 240dcf72d4
Issue #3086795 by jhodgdon, mohrerao, dww: "Search help" link in search form is ambiguous and confusing 2020-06-25 23:33:33 +01:00
xjm de32f3ca2d Issue #3133033 by munish.kumar, xjm, Hardik_Patel_12, daffie, swatichouhan012: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the drupalCreateUser() test method 2020-06-21 16:39:19 -05:00
xjm 94ca9bc3a0 Issue #2972224 by alexpott, longwave, jungle, sja112, xjm, dww, daffie, kiamlaluno, dawehner, quietone, Lendude: Add .cspell.json to automate spellchecking in Drupal core 2020-06-21 14:15:29 -05:00
Alex Pott 0f9cecbab6
Issue #3139414 by cburschka, mohrerao, pavnish, jungle, ravi.shankar, daffie, mondrake, sja112: Replace usages of deprecated AssertLegacyTrait::assert(No)Link() 2020-06-16 10:29:37 +01:00
Alex Pott 073679e731
Issue #3142752 by sja112, mondrake, xjm, longwave: AssertLegacyTrait::assert(No)Escaped() in functional tests still have a message passed in 2020-06-14 14:00:06 +01:00
Alex Pott 9d1faa52f4
Issue #2824935 by idebr, mfernea, Deepak Goyal, pfrenssen, longwave, hgunicamp, jofitz, andypost, daffie: Fix Squiz.ControlStructures.SwitchDeclaration coding standard 2020-06-02 09:46:52 +01:00
Alex Pott 40d62a67e7
Issue #3086794 by andypost, alexpott, jhodgdon, Amber Himes Matz, catch, xjm: Search results pages plugins could display results in administrative theme 2020-05-31 12:17:18 +01:00
xjm 88375258cd Issue #3139412 by Bunty Badgujar, longwave, mondrake, xjm: Replace usages of deprecated AssertLegacyTrait::assertTitle() 2020-05-29 16:55:45 -05:00
xjm e4e64fa0ee Issue #3143339 by mohrerao, mondrake, longwave: Clean up the arguments of calls to WebAssert::titleEquals() and AssertLegacyTrait::assertTitle() 2020-05-28 17:29:40 -05:00
xjm 11387380d5 Issue #3139218 by mondrake, daffie: Replace usages of AssertLegacyTrait::assertResponse(), which is deprecated 2020-05-24 08:33:20 -05:00
xjm f09c890298 Issue #3132964 by jungle, longwave, sja112, dww, xjm, daffie: assertResponse() does not actually support a $message parameter, so stop passing one 2020-05-22 12:37:50 -05:00
catch 421c588c16 Issue #3131343 by mondrake, dww, jungle: Replace assertions involving calls to in_array() with assertContains()/assertNotContains() 2020-05-11 09:10:55 +01:00
xjm 84f3be3d90 Issue #3134333 by xjm, longwave, ravi.shankar, daffie: Change Drupal\Tests\search\Functional\SearchSimplifyTest and Drupal\Tests\search\Functional\SearchTokenizerTest to kerneltests 2020-05-09 15:00:59 -05:00
catch 40a5bd7e0a Issue #3126965 by jungle, quietone, longwave, mondrake, dww: Replace assert* involving count() and an integer literal with assertCount() 2020-05-07 19:07:00 +01:00
Alex Pott 3f87e0d805
Issue #3132745 by jungle, longwave, xjm, swatichouhan012, daffie: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the $modules test property 2020-05-02 12:34:00 +01:00
catch 4d02fe7c25 Issue #3128746 by mondrake, longwave, dww: Replace assertions involving calls to strpos() with more accurate string assertions 2020-04-27 10:02:44 +01:00
catch 5132c83fac Issue #3082415 by Krzysztof Domański, mondrake, alexpott, longwave, jungle: Replace assert(Not)Same/Identical() on booleans with assert(Not)True/False() in PHPUnit tests 2020-04-17 16:00:07 +01:00
Alex Pott 6bf02d966d
Issue #2822382 by voleger, pfrenssen, erozqba, jungle, RytoEX, borisson_, jofitz, shashikant_chauhan, sidharthap, dawehner, xjm, kiamlaluno, catch, daffie, klausi: Make every $modules property protected on classes extending BrowserTestBase and KernelTestBase 2020-04-13 12:05:00 +01:00
Alex Pott 0dc28534c8
Issue #3107732 by mondrake, longwave, swatichouhan012, salah1, xjm, catch, alexpott, Berdir: Between April 13 and April 17, 2020: Add return typehints to setUp/tearDown methods in concrete test classes 2020-04-13 09:56:30 +01:00
xjm 4c453683e4 Issue #3106666 by catch, jungle, xjm, alexpott, tim.plunkett, Berdir: Remove post updates added prior to 8.8.0 2020-03-11 15:58:38 -05:00
Alex Pott 915b74f937
Issue #2570985 by ifrik, chipway, lomasr, jhodgdon, shimpy, govind.maloo, vacho, Balu Ertl, Manjit.Singh, alexpott, Bojhan, volkswagenchick, mradcliffe, xjm, tkoleary, yoroy, no_angel, dawehner, webchick, Sam152, RuslanP, Gábor Hojtsy, wengerk, wla_g: Update the module descriptions on the Extend page 2020-02-24 14:24:57 +00:00
catch 720924f719 Issue #2893804 by Wim Leers, Stefdewa, Berdir, catch: Remove rest.module BC layers 2020-01-27 17:41:43 +00:00
Alex Pott 267ccab755
Issue #3081145 by Berdir, andypost, longwave, catch, tim.plunkett, larowlan: Remove BC layers in the Plugin component 2020-01-25 10:01:58 +00:00
catch e1a041c493 Issue #3087644 by jibran, Berdir, alexpott, longwave, Wim Leers, amateescu, catch, xjm, larowlan, dpi, quietone: Remove Drupal 8 updates up to and including 88** 2020-01-24 23:52:03 +00:00
Lee Rowlands 2e53ac1699
Revert "Issue #3087644 by jibran, Berdir, alexpott, longwave, Wim Leers, amateescu, catch, larowlan, dpi, quietone: Remove Drupal 8 updates up to and including 88**"
This reverts commit 136f055066.
2020-01-22 10:30:15 +10:00
Lee Rowlands 136f055066
Issue #3087644 by jibran, Berdir, alexpott, longwave, Wim Leers, amateescu, catch, larowlan, dpi, quietone: Remove Drupal 8 updates up to and including 88** 2020-01-22 09:33:30 +10:00
Alex Pott eb5e8d5dbd
Issue #3104420 by peterkokot, mondrake: PHP 7.4 Deprecated curly brace syntax for accessing array elements 2020-01-14 11:13:27 +00:00
catch 3408494d71 Issue #3097443 by andypost, longwave: Remove all @deprecated code in the Search module 2019-11-29 15:52:14 +00:00
Alex Pott 2a009c5edd
Issue #3048498 by jonathan1055, Lendude, naveenvalecha, klausi, alexpott, Gábor Hojtsy: [≈Nov. 11] Fix Drupal.Commenting.Deprecated coding standard 2019-11-14 09:08:15 +00:00
catch 19f9474b9b Issue #2742585 by ZeiP, alexpott, mondrake, klausi, tomasnagy, Krzysztof Domański, sokru, kristiaanvandeneynde, dawehner, jeroenbegyn: Deprecate dangerous assertTrue/False() compatibility overrides in PHPUnit Kernel, Functional and FunctionalJavascript tests 2019-11-08 13:53:52 +00:00
catch 32d95eccd7 Issue #3082655 by Wim Leers, alexpott, iyyappan.govind, dww, lauriii: Specify the $defaultTheme property in all functional tests 2019-11-08 13:39:33 +00:00
Alex Pott 2e34e1cacf
Issue #3086832 by jhodgdon: SearchPageRepositoryInterface doc block error 2019-11-02 07:57:23 +01:00
catch e37031e09a Issue #3072702 by alexpott, Wim Leers, mikelutz, xjm, catch, Berdir, tedbow, webchick, shaal, Mixologic, heddn: Core extensions should not need to specify the new core_version_requirement in *.info.yml files so that 9.0.x can be installed 2019-10-15 15:34:52 +01:00
Lee Rowlands 1c4e7f7f9a
Issue #3087407 by jhodgdon: Search indexing calls are inefficient 2019-10-13 20:06:19 +10:00
Lee Rowlands 7dc65c5c5d
Issue #3075695 by kim.pepper, andypost, jhodgdon, larowlan, pwolanin, Sam152: Move search_index() and related functions to a service 2019-10-11 15:03:59 +10:00
Alex Pott 0a6a417ec9
Issue #3073318 by Spokje, Mile23, mondrake: Remove usages of \PHPUnit_Framework_MockObject_MockObject 2019-09-02 12:24:14 +01:00
Lee Rowlands a7847919c4
Issue #2940038 by Sweetchuck, drunken monkey, rajeshwari10, borisson_: Use $this in @return PhpDoc comments instead of the name of the current class or interface 2019-08-06 15:56:28 +10:00
Lee Rowlands ce189a3f75
Issue #3067943 by andypost, jhodgdon, Amber Himes Matz, pwolanin: Add capability for search blocks on non-default search 2019-07-31 12:34:20 +10:00
Alex Pott ae248f2e43
Issue #3047801 by Eduardo Morales, mikelutz, pguillard, nlisgo, sathish.redcrackle, Berdir: Replace all calls to the deprecated Drupal::l() function in Core 2019-07-24 16:48:42 +01:00
Alex Pott 330e575d4d
Issue #3067198 by Berdir, mikelutz, alexpott: Properly deprecate UrlGeneratorTrait 2019-07-19 21:47:32 +01:00
catch 01e11fa4c0 Issue #3066539 by shubham.prakash, Ujin, jhodgdon: Docs for search_index_clear $sid parameter are incorrect 2019-07-18 11:41:25 +01:00
Alex Pott e39262bf5b
Issue #2228741 by rpayanm, mikelutz, voleger, epari.siva, malotor, Rolf van de Krol, quietone, Mile23, andypost, ianthomas_uk, Lendude, alexpott, dawehner, xjm, Gábor Hojtsy, Berdir, catch: Replace calls to format_string() with Drupal\Component\Render\FormattableMarkup 2019-07-11 09:06:33 +01:00
Gábor Hojtsy c1734c6185 Issue #2936365 by quietone, mikelutz, heddn, larowlan, masipila, effulgentsia, maxocub, Gábor Hojtsy, webchick, phenaproxima, jhodgdon, catch: Migrate UI - allow modules to declare the state of their migrations 2019-07-10 20:14:17 +02:00
Alex Pott 91fe1d2f77
Issue #2929133 by voleger, alexpott, Lendude: Replace all usages of getMock() 2019-05-31 10:22:21 +01:00
Alex Pott 408c540ccf
Issue #2886622 by Berdir, martin107, Mile23, tim.plunkett, mikelutz, jonathan1055: Deprecate all EntityManager methods with E_USER_DEPRECATED 2019-05-30 12:36:55 +01:00
Lee Rowlands 275c864dda
Issue #2875394 by voleger, erozqba, Berdir, mondrake: Replace all calls to db_query, which is deprecated 2019-05-28 07:15:20 +10:00
Lee Rowlands ba509afbc9
Issue #3047866 by mikelutz, Berdir, TR, alexpott, andypost, Satyanarayan Reddy: Remove usage of deprecated \Drupal::entityManager() in core 2019-05-24 16:44:36 +10:00
Alex Pott e192b14dcb
Revert "Issue #2852463 by mikelutz, tim.plunkett, heddn, xjm, MegaChriz, joachim, phenaproxima, dawehner, benjifisher: Create a trait to implement \Drupal\Component\Plugin\ConfigurableInterface"
This reverts commit 109dfd58bd.
2019-05-22 21:18:24 +01:00
Alex Pott ffd99ca739
Issue #3055495 by Mile23, Lendude: Search page migration tests are misplaced kernel tests 2019-05-18 15:44:09 +02:00
catch 9791614b78 Issue #2731817 by mikelutz, ashishdalvi, Sonal.Sangale, dbt102, andypost, jhodgdon, martin107, roderik: Replace all calls to the deprecated Drupal::url() function in Core 2019-04-16 14:38:27 +09:00
Alex Pott 109dfd58bd
Issue #2852463 by mikelutz, tim.plunkett, heddn, xjm, MegaChriz, joachim, phenaproxima, dawehner, benjifisher: Create a trait to implement \Drupal\Component\Plugin\ConfigurableInterface 2019-04-12 14:23:23 -07:00
Nathaniel Catchpole 9d96532b79 Issue #3035383 by andypost, martin107, Berdir: Replace deprecated usages of entityManager in list builder classes 2019-03-18 16:28:26 +00:00
Alex Pott 81915a93a3
Issue #3025427 by Berdir, amateescu: Add @trigger_error() to deprecated EntityManager->EntityTypeBundleInfo methods 2019-02-26 15:05:23 +00:00
Alex Pott 4bb82a8eb5
Issue #2946122 by mikelutz, heddn, tim.plunkett, phenaproxima, alexpott, joelpittet, MegaChriz, joachim, xjm: Deprecate ConfigurablePluginInterface and replace with an interface that doesn't extend DependentPluginInterface 2019-02-24 13:42:45 +00:00