Commit Graph

1386 Commits (506d92fc98e4ca902aefd286c1618d8c30b00fb4)

Author SHA1 Message Date
Alex Pott e4b39ba7b9
Issue #2970052 by martin107, marcel66, Mile23, longwave, dawehner, borisson_, alexpott, catch: Fix "assertNoPattern() is deprecated and scheduled for removal in Drupal 9.0.0. Use $this->assertSession()->responseNotMatches($pattern) instead" 2018-09-11 11:41:53 +02:00
Nathaniel Catchpole bb7c0570b8 Issue #2970831 by alexpott, martin107, catch, huascarmc, Mile23: Fix "AssertLegacyTrait::getRawContent() is scheduled for removal in Drupal 9.0.0. Use $this->getSession()->getPage()->getContent() instead. 2018-08-31 10:09:18 +09:00
Lee Rowlands 36ecfc620a
Issue #2828793 by andypost, catch, wturrell, Jo Fitzgerald, jibran: Stop logging comment IP addresses by default 2018-08-24 14:20:17 +10:00
Nathaniel Catchpole 5cbcd6d33d Issue #2988562 by jeqq, amateescu, timmillwood: Classes that extend SqlContentEntityStorageSchema should not hardcode table names and use the ones provided by the storage instead 2018-08-22 21:42:17 +09:00
xjm fa6b3d95dd Revert "Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase"
This reverts commit 69501f3062.
2018-08-16 18:12:22 -05:00
Nathaniel Catchpole 69501f3062 Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase 2018-08-15 19:55:23 +09:00
Alex Pott 6c40e077ef
Issue #2937853 by idebr, mfernea, SherFengChong, alexpott, borisson_: Fix 'Drupal.Formatting.MultipleStatementAlignment' coding standard 2018-08-13 11:13:36 +01:00
Lauri Eskola e742590eed
Issue #2981652 by ApacheEx, corbacho, drpal, dawehner, xjm, alexpott, lauriii: Format core JavaScript using recently add Prettier 2018-08-09 18:49:18 +03:00
Alex Pott 2650c43409
Issue #2809467 by michielnugter, Lendude: Convert \Drupal\comment\Tests\CommentPagerTest to BrowserTestBase 2018-07-30 11:33:13 +01:00
Gábor Hojtsy 242b03dad4 Issue #2863437 by maxocub, masipila: Migrate Drupal 7 title data to Drupal 8 2018-07-29 14:58:48 +02:00
Gábor Hojtsy 0f336ae86d Issue #2975666 by maxocub, benjifisher, masipila, jcnventura, jigarius, phenaproxima, catch, quietone: Migrate Drupal 7 node entity translations data to Drupal 8 2018-07-27 21:41:20 +02:00
Nathaniel Catchpole 3b0682ea1b Issue #2945513 by jpoesen, johnnny, Meenakshi.g, idebr, nno: Variable comment_parent in comment.html.twig should be parent_comment 2018-07-25 15:36:47 +09:00
Alex Pott 8c5075ad69
Issue #2985147 by eliclaggett, msankhala, neclimdul: Correct copy pasted plugin constructor documentations 2018-07-24 16:18:58 +01:00
Alex Pott f45132741a
Issue #2874133 by ApacheEx, borisson_, dawehner: Convert \Drupal\comment\Tests\CommentNewIndicatorTest to JavascriptTestBase and/or BrowserTestBase 2018-07-14 22:53:05 +01:00
Nathaniel Catchpole 14a769b758 Issue #2631698 by Jo Fitzgerald, robpowell, phenaproxima, heddn, quietone: Fix sub-optimal DX in MigrateFieldInterface 2018-07-13 12:39:04 +01:00
Nathaniel Catchpole 163144a923 Issue #2973791 by alexpott, martin107, mairi, volkerk: Fix deprecation messages related to deprecated comment Action plugins 2018-07-12 13:01:47 +01:00
Alex Pott 4ddf8b84e8
Issue #2983355 by ApacheEx, drpal: JS codestyle: indent 2018-07-05 16:34:50 +01:00
Nathaniel Catchpole d1a1cc5b39 Issue #2979916 by maxocub, masipila, phenaproxima: D7 comment field values are not migrated 2018-06-28 23:11:06 +01:00
Alex Pott 646584b3f7
Issue #2946419 by vaplas, Lendude, Mile23: Entity: Convert system functional tests to phpunit 2018-06-25 13:51:30 +01:00
Alex Pott f9f81a30f8
Issue #2878151 by joachim: collection link template for comment_type entity type is incorrect 2018-06-04 14:01:49 +01:00
Alex Pott d8029d7ee0
Issue #1596472 by catch, amateescu, claudiu.cristea, Berdir, Mile23, Sam152, pounard, fago, alexpott, fubhy, hchonov: Replace hard coded static cache of entities with cache backends 2018-05-31 12:07:30 +02:00
Lee Rowlands 585e6338b5
Issue #2938035 by Wim Leers, alexpott: When PATCHing a field is disallowed, no reason is given for *why* this happens 2018-05-16 11:30:32 +10:00
Alex Pott 92be45b46f
Issue #2910883 by vaplas, ShawnB, Wim Leers: Move all entity type REST tests to the providing modules 2018-05-15 12:37:57 +01:00
Lee Rowlands 0d6d22af0b
Issue #2926120 by idebr, zaporylie, borisson_: @var tag must not end with a full stop 2018-05-15 06:49:38 +10:00
Lee Rowlands 75850cddaf
Issue #2860259 by claudiu.cristea, larowlan: Move the comment hostname default value to a default value callback 2018-05-12 08:44:22 +10:00
Nathaniel Catchpole c2585a1888 Issue #2961691 by alexpott, Berdir, timmillwood, idebr: Change SYMFONY_DEPRECATIONS_HELPER back to strict 2018-05-11 15:20:00 +01:00
Alex Pott be6d515cad
Issue #2572613 by Malevi4, idebr, pfrenssen, Mile23, RajeevK: Fix 'Drupal.Array.Array.CommaLastItem' coding standard 2018-05-11 10:40:33 +01:00
Alex Pott b8f93d5b61
Issue #2901730 by mfernea, ankitjain28may, idebr: Fix 'Squiz.WhiteSpace.FunctionSpacing' coding standard 2018-05-11 10:26:36 +01:00
Nathaniel Catchpole 154f282899 Issue #2849669 by alexpott, pwolanin, Munavijayalakshmi, dawehner: Fix \Drupal\Component\Utility\Unicode() because of the Symfony mbstring polyfill 2018-05-08 21:55:21 +01:00
Alex Pott 7476b37f60
Issue #2906298 by qzmenko, runeasgar: Comments per page number validation 2018-05-08 15:17:39 +01:00
Alex Pott 84d5e36141
Issue #2969549 by marcel66, martin107: Fix "The $published parameter is deprecated since version 8.3.x and will be removed in 9.0.0." deprecation 2018-05-05 22:36:51 +01:00
Alex Pott 3bfc5a384b
Issue #2938970 by MerryHamster, surbz, msankhala, alexpott, Jo Fitzgerald, Yasiru Nilan, Manuel Garcia, ZeiP, boaloysius, xjm, wturrell, tameeshb, darrenwh, ritzz: Replace drupal_render() in @param, @return, @see, @link, etc 2018-05-03 17:58:24 +01:00
Lee Rowlands 312b93c612
Issue #2894261 by alexpott, Berdir, deepakaryan1988, andypost: Deprecated service entity.manager needs to be replaced with entity_type.manager in ContentEntityForm 2018-05-03 09:30:57 +10:00
Nathaniel Catchpole 45bc05523f Issue #2958429 by alexpott: Properly deprecate SafeMarkup::format() 2018-05-01 16:14:09 +01:00
Alex Pott b84b827d42
Issue #2935256 by Jo Fitzgerald, voleger, kim.pepper, ibustos, Yogesh Pawar, catch, jibran: Remove all usages of drupal_get_message and drupal_set_message in modules 2018-05-01 10:15:07 +01:00
Nathaniel Catchpole fb4c903430 Issue #2955803 by zviryatko, andypost: Do not attach history for non-node entities in CommentViewBuilder::buildComponents() 2018-04-30 12:12:35 +01:00
Alex Pott 2023ce8e0c
Issue #2950125 by owenbush, Wim Leers: Add helpful reason for 'update' and 'delete' access not being allowed to CommentAccessControlHandler 2018-04-17 13:06:06 +01:00
Nathaniel Catchpole d90ac78f3e Issue #2798891 by ankitjain28may, trobey, TR: Define project dependencies in core module .info files 2018-04-06 13:13:01 +01:00
Alex Pott 7d2f3a3b76 Issue #2946603 by drpal, alexpott, dawehner: JS codestyle: no-use-before-define 2018-03-05 09:14:08 +00:00
xjm a2ae6fd09c SA-CORE-2018-001 by cashwilliams, catch, cilefen, droplet, dawehner, bonus, agentrickard, David_Rothstein, Chi, Gábor Hojtsy, Heine, Wim Leers, Schnitzel, drpal, effulgentsia, tedbow, tim.plunkett, tstoeckler, xjm, will_c, stefan.r, samuel.mortenson, larowlan, greggles, logaritmisk, mpdonadio, pwolanin, plach 2018-02-21 10:59:15 -06:00
Alex Pott 7e0ddac162 Issue #2711099 by heddn, Jo Fitzgerald, edysmp, edgewl2, alexpott, Charlotte17, mikeryan, masipila, quietone, maxocub, phenaproxima: Categorize migrations according to their type 2018-02-15 06:27:23 +00:00
Alex Pott 3d5592257d Issue #2670730 by chr.fritsch, robpowell, alexpott, tstoeckler, Berdir, bojanz, dawehner: Provide a delete action for each content entity type 2018-01-26 14:18:10 +00:00
Nathaniel Catchpole 1c72ba5a4a Issue #2935575 by gaurav.kapoor, kiamlaluno, amateescu: Fix or remove the @see tag 2018-01-22 16:02:45 +00:00
Lee Rowlands 47c2dda6d1
Issue #2927746 by alexpott, catch, slasher13, mpdonadio, martin107, RoSk0, jibran, larowlan, pounard, Mile23, Jo Fitzgerald, deviantintegral, pritish.kumar: Update Symfony components to 3.4.* 2018-01-18 17:54:38 +10:00
webchick f724db3453 Issue #2936793 by tim.plunkett, tstoeckler, EclipseGc: EntityReferenceItem::generateSampleValue() should create a sample entity if a referenceable entity is not found 2018-01-15 15:32:50 -08:00
Nathaniel Catchpole 601593f06e Issue #2935617 by alexpott, chr.fritsch: Move User module's temp stores to core 2018-01-12 10:04:36 +00:00
Alex Pott cbd3299e68 Issue #2916740 by chr.fritsch, xjm, Manuel Garcia, tstoeckler, alexpott, seanB, Sam152, amateescu, tim.plunkett, dawehner, larowlan, Berdir: Add generic entity actions 2018-01-09 08:47:01 +00:00
webchick f1e33ca3d8 Issue #2925064 by drpal, dawehner, droplet, xjm, webchick, justafish: [1/2] JS codestyle: no-restricted-syntax 2018-01-03 15:27:55 -08:00
Nathaniel Catchpole a83b06a46b Issue #2923015 by cburschka, amateescu, tstoeckler, alexpott, hchonov, mondrake, pfrenssen: [PHP 7.2] Incompatible method declarations 2017-12-22 13:15:21 +00:00
Nathaniel Catchpole 03fd77c842 Issue #2927806 by alexpott, mondrake, jibran, Mile23: Use PHPUnit 6 for testing when PHP version >= 7.2 2017-12-22 12:47:46 +00:00
Lee Rowlands 5ea62f1d3e
Issue #2876085 by heddn, maxocub, phenaproxima, Jo Fitzgerald, vasi, quietone, yoroy, masipila, larowlan, neclimdul, krystalcode, catch: Before upgrading, audit for potential ID conflicts 2017-12-16 08:36:36 +10:00
Nathaniel Catchpole 6f6abec964 Issue #2894014 by adriancid, Cottser: Additional space in a field setting schema label 2017-12-15 09:56:46 +00:00
Lee Rowlands 7d1545b32a
Issue #2927569 by tstoeckler, amateescu: Various tests do not set values for required field when creating entities 2017-12-11 07:07:20 +10:00
xjm dcfee314ad Revert "Issue #2925064 by drpal, dawehner, xjm, justafish, droplet: [1/2] JS codestyle: no-restricted-syntax"
This reverts commit b0a4d7e017.
2017-12-01 13:28:53 -06:00
xjm 42634ef62d Issue #2927520 by marcoscano: Fix wrong documentation in comment module 2017-12-01 02:00:18 -06:00
Nathaniel Catchpole 4daa23c89b Issue #2923886 by mfernea: Fix 'Squiz.WhiteSpace.LanguageConstructSpacing' coding standard 2017-11-29 11:34:02 +00:00
webchick b0a4d7e017 Issue #2925064 by drpal, dawehner, xjm, justafish, droplet: [1/2] JS codestyle: no-restricted-syntax 2017-11-28 15:40:07 -08:00
xjm 752fd5a721 Issue #2924780 by zaporylie: Missing @var annotation for scalars that provide default values 2017-11-22 12:43:49 -06:00
xjm 5d2b7fba92 Issue #2924779 by zaporylie, martin107: Fix existing but somehow invalid @var annotation 2017-11-22 10:36:28 -06:00
Nathaniel Catchpole 4d176b95ea Issue #2902407 by mfernea, zaporylie: Fix 'Drupal.Commenting.DataTypeNamespace' coding standard 2017-11-16 15:00:40 +00:00
Nathaniel Catchpole 700a72fa37 Issue #1472946 by gnuget, andypost, mmrares, sidharthap, kiamlaluno, Himanshu5050, dineshkumares, amit.drupal: Remove usages of deprecated function drupal_realpath() throughout core functions 2017-11-14 15:53:29 +00:00
xjm 6dc062eb45 Issue #2901562 by mfernea, Jo Fitzgerald, Yogesh Pawar, 3ssom, Mile23, borisson_: Fix 'Squiz.WhiteSpace.SuperfluousWhitespace' coding standard 2017-11-09 15:13:57 -06:00
xjm 33818be2d8 Issue #2917883 by quietone, TR, Jo Fitzgerald, masipila, phenaproxima: Rename 'migration_templates' directories in core modules to 'migrations' 2017-11-07 06:19:19 -06:00
Gabor Hojtsy 4e83abc5e4 Issue #2911306 by alexpott, roynilanjan, mondrake, quicksketch, quietone: Migration module breaks with PHP 7.2 due to inherited method signature differences 2017-11-03 13:13:19 +01:00
Nathaniel Catchpole c203575397 Issue #2916451 by Lendude, xjm: Move everything related to Bulk Form to Views module 2017-10-20 14:30:17 +01:00
Nathaniel Catchpole 2fc85e7f0f Issue #2901572 by Jo Fitzgerald, bluccas, mfernea, klausi: Fix 'Drupal.Commenting.PostStatementComment' coding standard 2017-10-13 13:43:02 +01:00
Nathaniel Catchpole ee0f806896 Issue #2873696 by nvexler, wengerk, gido, Jo Fitzgerald, xjm: Add @internal to core classes, methods, properties to Form Classes 2017-10-12 16:15:53 +01:00
Alex Pott 336d30dc4d Issue #2914719 by nod_, droplet: JS codestyle: newline-per-chained-call 2017-10-11 15:40:35 +01:00
Nathaniel Catchpole 64fa6ad712 Issue #2901744 by mfernea: Fix 'PSR2.Namespaces' coding standard 2017-10-10 16:09:51 +01:00
Nathaniel Catchpole 5b3fdce48b Issue #2887142 by maxocub, phenaproxima, Jo Fitzgerald, Adita, heddn, andypost: NodeType source plugin should include comment information 2017-10-10 15:12:03 +01:00
Gabor Hojtsy 93b36cb7dc Issue #2873768 by dhopki12, WidgetsBurritos, harsha012, Mile23, catch: Add Change record to @deprecated for *.modules constants 2017-10-10 09:30:23 +02:00
webchick 5cfa420d7e Issue #2853872 by heddn, maxocub, masipila, phenaproxima, quietone, andypost, larowlan: Migration for forum and article comments: duplicate comment types and incorrect comment_entity_statistics 2017-09-29 17:40:12 +02:00
Nathaniel Catchpole 2e18fe9373 Issue #2715485 by harsha012, mfernea, malavya, himanshu-dixit, vprocessor, tameeshb, Mile23, RajeevK, Jo Fitzgerald, tiago.urbano, xjm, klausi: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard 2017-09-25 14:14:30 +01:00
Lee Rowlands 73bba855dc
Issue #2866513 by michielnugter, jonathan1055, mpdonadio, Jo Fitzgerald, Lendude, dawehner, Wim Leers: Convert web tests to browser tests for comment module 2017-09-24 10:44:51 +10:00
Nathaniel Catchpole 4577185c9b Issue #2572791 by Mile23, andriyun, attiks, RoSk0: Fix 'Drupal.WhiteSpace.OpenBracketSpacing' coding standard 2017-09-22 12:16:23 +01:00
xjm 465348f98d Issue #2759789 by mfernea, Mile23, andriyun, dawehner, klausi: Fix 'Drupal.Semantics.FunctionAlias' coding standard 2017-09-17 16:58:08 -05:00
xjm 2242f4ad9e Issue #2901785 by mfernea, xjm, andriyun: Fix 'Generic.Formatting.SpaceAfterCast' coding standard 2017-09-17 16:38:34 -05:00
xjm cc30270e9a Revert "Revert "Revert "Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard"""
This reverts commit b06757615a.
2017-09-16 14:24:44 -05:00
xjm b06757615a Revert "Revert "Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard""
This reverts commit 964954e1f3.
2017-09-16 12:02:55 -05:00
xjm 964954e1f3 Revert "Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard"
This reverts commit 2df73e2c00.
2017-09-16 12:02:42 -05:00
xjm 2df73e2c00 Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard 2017-09-16 11:19:25 -05:00
xjm 44a5c4cbe0 Issue #2901739 by andriyun, Jo Fitzgerald, mfernea, xjm: Fix 'Squiz.Arrays.ArrayDeclaration' coding standard 2017-09-15 16:52:14 -05:00
Lee Rowlands 32e402231e
Issue #2905000 by amateescu, timmillwood: Add a default filter on the 'published' field in the base views wizard plugin for publishable entity types 2017-09-15 07:36:58 +10:00
Nathaniel Catchpole 9ef92a408b Issue #2905627 by Lendude, dawehner: Part-2: Convert UpdatePathTestBase to BrowserTestBase 2017-09-08 14:24:15 +01:00
Nathaniel Catchpole ff6eea71c5 Issue #2614504 by blackra, jibran, mohit_aghera, Yogesh Pawar, larowlan, lokapujya, Munavijayalakshmi, thpoul, andypost, xjm: Values of 'name' & 'email' fields should be NULL when comment has author (uid > 0) 2017-09-05 13:42:31 +01:00
Nathaniel Catchpole cb9b6d420f Issue #2722609 by anoopjohn, mfernea, Jo Fitzgerald, chishah92, druprad, martin107, Mile23: Fix Drupal.Commenting.FunctionComment.ParamNameNoMatch 2017-09-04 18:30:59 +01:00
Nathaniel Catchpole 4f24c9169b Issue #2734345 by danmuzyka, hchonov, Jo Fitzgerald, GoZ, kristiaanvandeneynde, Berdir, alexpott: Comments: entity_id base field not overridden correctly in comment bundle field definitions for comment bundles attached to different entity target_type 2017-09-04 13:31:56 +01:00
Nathaniel Catchpole 1f191080c1 Issue #2902723 by mfernea, ccjjmartin: Fix 'Drupal.Commenting.FunctionComment.ReturnCommentIndentation' coding standard 2017-08-21 13:39:47 +09:00
xjm 11ef44a7f7 SA-CORE-2017-004 by arshadcn, amateescu, Wim Leers, Berdir, Lendude, dawehner, klausi, pwolanin, xjm, mpdonadio, mlhess, larowlan, milesw
(cherry picked from commit 65cef2e9f5)
2017-08-16 12:41:33 -05:00
Nathaniel Catchpole 9a389442d4 Issue #2901778 by xjm, jibran, annajl: Provide correct display name and title for comment admin view displays 2017-08-15 16:10:56 +09:00
Nathaniel Catchpole 7d1c57aada Issue #2787873 by claudiu.cristea, jibran, amateescu, catch, dawehner, cilefen, xjm, larowlan, vaplas: Add a base class for entity reference selection handlers and fix the structure of their configuration 2017-08-15 14:12:50 +09:00
Nathaniel Catchpole d7c496150e Issue #2569805 by quietone, Jo Fitzgerald, mikeryan, joelpittet, heddn, Adita, Miguel.kode, iMiksu, tvb, maxocub, juancasantito, phenaproxima, alexpott, neclimdul, xjm: For Drupal migration, identify the source module 2017-08-15 14:08:32 +09:00
xjm 620cc4c752 Issue #2898344 by jibran, xjm, Lendude, dawehner, andypost, mradcliffe, larowlan, annajl, Bojhan: Add filters to the comments administration pages 2017-08-14 20:51:57 -05:00
Lee Rowlands 04d69926b4
Issue #1986606 by jibran, pcambra, vijaycs85, dawehner, andypost, mbovan, Arla, adnen, vprocessor, tkuldeep17, xjm, kim.pepper, dobe, snig, larowlan, miro_dietiker, tim.plunkett, Berdir, Lendude, plach, olli, damiankloip: Convert the comments administration screen to a view 2017-07-29 16:55:37 +10:00
Nathaniel Catchpole db4cb40e13 Issue #2860654 by amateescu: Field storage CRUD operations must use the last installed entity type and field storage definitions 2017-07-20 16:10:48 +01:00
Lauri Eskola 612c1fa68c Issue #2880007 by drpal, nod_, droplet: Auto-fix ESLint errors and warnings 2017-07-06 09:21:40 +03:00
Lauri Eskola 7f27bbaba1 Issue #2704871 by pepegarciag, Mile23, Manuel Garcia, ieguskiza, snehi, gaurav.pahuja, dimaro, rajeshwari10, gargsuchi, pashupathi nath gajawada, penyaskito, xjm, ZeiP, Wim Leers, alexpott: Replace usages of deprecated method drupal_render() 2017-07-03 18:35:13 +03:00
Nathaniel Catchpole c53b322847 Issue #2068063 by timmillwood, Berdir, tduong, Manuel Garcia, nlisgo, yongt9412, esod, lauriii, jonathan1055, vijaycs85, yoroy, amit.drupal, tkoleary, ifrik, Bojhan, xjm, tstoeckler, amateescu: Change "Save and keep un-/published" buttons to a "Published" checkbox and an included "Save" button 2017-06-15 13:02:05 +01:00
Chris McCafferty d5d37e0649 Revert "Issue #2787873 by claudiu.cristea, amateescu, jibran, dawehner, catch: Add a base class for entity reference selection handlers and fix the structure of their configuration"
This reverts commit b0900c73b1.
2017-05-27 20:49:12 -04:00
Alex Pott 4bd9426ae0 Issue #2881012 by Lendude, dawehner, michielnugter: Move generatePermutations out of testbase into a trait 2017-05-24 22:26:39 +01:00