Commit Graph

223 Commits (48bf7db71c673d29bdb64af0d6d08b13dfbbae23)

Author SHA1 Message Date
Dries Buytaert de3b0796d2 - Bugfix: better charset support for non-ISO-8859-1 languages. Patch 0029.charset.fixes.patch by Al. Could East Asia test this please.
- Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.

- Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.

- Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.

- Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.

- Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.

- CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.

- Updated the MAINTAINERS file.
2003-06-05 18:09:39 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 3151a1cb71 - Usability improvements to the node form. Patch by Al. Will incorporate
some of Moshe's node form work later on.

TODO:

- I just spotted a problem with the promote field; it does not seem to be
  "sticky" when you click the preview button.  I checked and this was also
  the case prior to applying this patch.
2003-06-03 20:33:56 +00:00
Dries Buytaert 882c3f6d2d Removed node_get_node_from_nid() and modified node_load() to take an optional 2nd arguments to return a specified revision. Patch be Kjartan. 2003-06-01 06:32:55 +00:00
Dries Buytaert b7a0a744c6 - Committed Al's rollback fixes and the title improvements. Thanks again. 2003-05-31 12:34:11 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Dries Buytaert c7bc17103a - Fixed braino. Reported by Remco as bug #1787. 2003-05-28 15:07:25 +00:00
Dries Buytaert b9e8016fc1 - Fixed validate problem. Patch by Ax. 2003-05-26 21:31:18 +00:00
Dries Buytaert d8f78a7c95 - Removed check_output() from the theme system layer. 2003-05-26 19:50:39 +00:00
Dries Buytaert 102cbe5ee2 - Undid Kjartan's latest change (it breaks the feeds) and fixed it properly. 2003-05-25 07:08:21 +00:00
Kjartan Mannes 94fd74096c - Moved the theme("header") call in node_page outside the access check so the
page renders properly when a user does not have access to content.
2003-05-24 23:13:58 +00:00
Dries Buytaert 45d5aad6df - Updated Drupal to use "on output" filters. Derived from Gerhard's patch. 2003-05-24 16:26:13 +00:00
Dries Buytaert 9863dd5a71 - Fixed typo in URL(). Patch by Al.
- Added a filter option to disable/enable the rewrite_old_urls() filter.
  See task #1542.
2003-05-23 21:59:44 +00:00
Dries Buytaert b5e644d6b0 - Some fields can be passed through the $_GET array (eg. to make the "blog
it" modules work).  Patch by Ax.
2003-05-19 18:36:58 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert 7aa28ea114 - Added an option to make "node previews" optional. Patch by n8. See
"site configuration > modules > node".
2003-05-10 13:54:38 +00:00
Dries Buytaert 54459cc01a - Fixed the function prototypes of the newly introduced theme_user_list(),
theme_node_list(), and theme_menu_list().  This will fix the excessive
  gap between lists and avoids generating empty <b></b> constructs.
2003-05-02 20:44:14 +00:00
Dries Buytaert 2d6408dff3 - Committed Adrian's item patch. It would be nice if one or more of the
standard themes could be updated to demonstrate the possibilities.
2003-04-29 20:48:50 +00:00
Dries Buytaert a956de78b9 - Fixed some PHP "notices". 2003-04-21 14:55:03 +00:00
Dries Buytaert 3c2dc18c82 - Fixed bug #1545: incorrect sequence tables on PostgreSQL. Patch by Neil.
In addition, I have updated update.php so it makes the corresponding
  changes for MySQL users.
2003-04-20 20:33:28 +00:00
Dries Buytaert 2de4c1c643 - Node API improvements by Moshe:
"implemented pieces of kjartan's original nodeAPI patch. the mingling
  of other modules into node.module logic decreases (a good thing). for
  example, the string "taxonomy" now appears nowhere in node.module

  - moved the saving of taxonomy terms when submitting a node out of
  node.module and into taxonomy.module

  - moved the deletion of comments while deleting a node out of
  node.module and into comment.module

  - improved usability of node forms by including node type in the title
  of the box and page"
2003-04-15 19:50:04 +00:00
Dries Buytaert 70f5b8649b A batch of changes:
- Renamed '---' to '<!--break-->'.

- Removed hard-coded call to the statistics module from the node module.
  Patch by Gerhard.

- Removed tables from poll module.  Modified patch by Al.  Changes to Al's
  patch are:
    "polltext" -> "poll-text"
    "pollfg"   -> "poll-foreground"
    "pollbg"   -> "poll-background"

- Changed some 'statistics.foo's to 's.foo's.  Patch by Gary.

[If this closes any bug reports, please update them on drupal.org.]
2003-04-14 18:44:59 +00:00
Dries Buytaert 4742ba3549 - Fixed some SQL query directives. 2003-03-29 16:30:40 +00:00
Dries Buytaert 297bc73f81 - Bugfix: deleting a node should flush the cache. 2003-03-16 21:47:15 +00:00
Dries Buytaert 170b674a09 - All LIMIT queries must go through the pager or through db_query_range().
The syntax for db_query_range() was enhanced so it matches db_query(). So
  you may pass extra arguments of the SQL statement which are checked via
  check_query() and then substituted into the SQL statement. After these
  optional arguments, you always pass $from and $count parameters which
  define your range.  Most often, the $from is 0 and the count is the max
  number of records you want returned.  Patch by Moshe.

- The pager_query() function for PEAR was enhanced so that it adds  proper
  GROUP BY statement counting the number of records to be paged. Patch by
  James Arthur.

- MSSQL database scheme by Moshe.
2003-03-16 07:02:20 +00:00
Dries Buytaert dc19b22fb8 - Modified patch of Moshe. Enhances the tracker module so it displayes recent
*nodes* in addition to comments.  This will be helpful for tracking down new
  book nodes, blog posts, news items, and other stuff which isn't interesting
  enough to be promoted to the home page.
2003-03-14 20:41:27 +00:00
Kjartan Mannes 7c63dbccc8 - Fixing typos. 2003-03-11 08:43:59 +00:00
Kjartan Mannes b5ba5e22e1 - Added another security layer.
- Modified some moderation logic to make it more workable.
2003-03-10 12:01:26 +00:00
Kjartan Mannes 5a646024db - Ahem , trailing spaces. 2003-03-09 17:21:22 +00:00
Kjartan Mannes 1421c878d1 - Moved moderation logic back into node module.
* After having a chat with Dries we have agreed on the logics (or
      more specifically he told me how its supposed to work). The queue
      module is just a method to make moderation public, but its not
      necessarily the only way. This brings the power back.
- Minor interface tweaks (names, case changes, etc).
- Fixed error that would show when you tried to view the profile of a
  blocked user.
2003-03-09 17:19:50 +00:00
Kjartan Mannes a0deb476fa - Changed _nodeapi("conf") to _nodeapi("settings").
- Changed node settings page to use table().
- Minor code beautification here and there.
2003-03-08 14:35:42 +00:00
Kjartan Mannes 831ee21303 - Renamed "form.admin" to "form admin".
- Added node_admin_settings() to let users set node defaults.
    * Added _nodeapi("conf")
- Modified form_checkbox() to unset options. (Modified the patch from Ax.)
- Removed the _save() hook.
- Fixed a logical flaw in field_get() and field_set() which would break
  moderation.
- Moved some admin menus around and cleaned up some typos.
2003-03-07 22:11:44 +00:00
Dries Buytaert d659fedb38 - Removed the path_uri() function in favor of the $base_url variable and
fixes a handful of bugs introduced by the clean URL patch.
2003-03-07 06:37:30 +00:00
Dries Buytaert 6ccb8438bc - Fixed the "adminster" link at the bottom of every node's display. Patch
by Al.
2003-03-02 20:51:57 +00:00
Dries Buytaert 91dfef65af - Fixed some typos spotted by Al Maw. 2003-02-25 19:52:32 +00:00
Dries Buytaert b1f4758455 - Fixed typo. Patch by Garym. (Something went wrong with my earlier commit.) 2003-02-23 21:36:29 +00:00
Dries Buytaert 20e8bc12ca *** empty log message *** 2003-02-23 21:30:52 +00:00
Dries Buytaert 277ceae515 - New menu houskeeping. Prototyped by Zbynek.
The following modules need updating:
    * glossary module
    * feed module (Breyten's version)
    * mailhandler module
    * notify module
    * project module
    * smileys module
    * admin module
    * style module
    * taxonomy_dhtml module

  To avoid unexpected problems menu_add() is deprecated (it will print an
  error message when used) and menu() should be used instead.
2003-02-20 22:44:51 +00:00
Kjartan Mannes dd329e1d95 - Added function node_invoke_all($hook, &$node, $op, $arg = 0).
- Added a _nodeapi hook that in time will replace the _node hook. Trying
  to make as few changes to existing code as possible until the new api
  is stabilized.
- Modified node_form() to add administration options from other modules
  using the _nodeapi hook.
- Modified node_save() to fetch which fields should be saved to the node
  table from the _nodeapi hook.
- Moved comment and queue options from node_form() and node_save() to
  the modules _nodeapi hooks.
2003-02-16 14:57:35 +00:00
Dries Buytaert 83f5d82876 - Everything is using theme("function") now instead of $theme->function(). 2003-02-15 11:39:56 +00:00
Dries Buytaert e90f3b883b - See http://lists.drupal.org/pipermail/drupal-devel/2003-February/021824.html. 2003-02-11 20:01:17 +00:00
Dries Buytaert 9281d0cdd7 - Applied Alastair's date patch.
- Removed all instances of '$user->nodes'.

- Committed Moshe's taxonomy patch - minus the node_compact_list() bit.  It needs a bit more thought/work.  This patch changes the links of taxonomy pages/feeds so update your custom code and themes accordingly!

Themes should now use "taxonomy_link("taxonomy terms", $node)" to get an array of taxonomy term links.  The old construct is deprecated and should be changed.

// old theme blob:
if (function_exists("taxonomy_node_get_terms")) {
  foreach (taxonomy_node_get_terms($node->nid) as $term) {
    $terms[] = l($term->name, NULL, array(), "or=$term->tid");
  }
}

// new theme blob:
if (module_exist("taxonomy")) {
  $terms = taxonomy_link("taxonomy terms", $node);
}

// old URL:
http://foo.com/index.php?or=1,2

// new URL:
http://foo.com/?q=taxonomy/page/or/1,2
2003-02-09 17:39:40 +00:00
Dries Buytaert 10cb57a0b7 - Removed redundant code. 2003-02-02 21:05:34 +00:00
Dries Buytaert 2e6e1efbae - Renamed "Allow HTML tags" to "Filter HTML tags" for clarity. Reported by
Ax.
2003-01-29 23:15:10 +00:00
Dries Buytaert 37fe442d89 - Moved the filter()s back to the individual node modules as it used to be. 2003-01-23 18:11:19 +00:00
Dries Buytaert 637004c539 - Tidied up XHTML. Patch by Ulf.
- Added missing t() function.  Patch by Stefan.
2003-01-23 09:24:20 +00:00
Dries Buytaert d268783669 - Small improvement to the admin menu based on feedback from Michael. 2003-01-14 20:33:42 +00:00
Dries Buytaert 0fba793aff - Fixed a typo that caused quite a few redundant SQL queries. 2003-01-12 15:29:28 +00:00
Dries Buytaert 6334ee2093 - Code improvement: forgot to update an URL to the clean URL scheme. 2003-01-09 21:55:51 +00:00
Dries Buytaert 89b2069e4d - Clean URL patch. 2003-01-06 19:51:01 +00:00