Commit Graph

112 Commits (48805032c8bbcf45f65687c592438e2cc960ece8)

Author SHA1 Message Date
Dries Buytaert b22cd5d1c7 - Bugfix: changed an inner join back to a left join. Patch by Bart Jansens 2003-08-10 10:35:26 +00:00
Dries Buytaert 39950fe2e2 - Committed a modified version of Ulf's input checking changes. Patch #95.
I added an error message, changed a few things around and fixed tw typos.
2003-08-08 22:24:55 +00:00
Dries Buytaert 22b6d2f30c - Performance improvement: changed a fair amount of "left joins" to "inner
joins".  Patch by Gerhard.
2003-07-12 22:21:55 +00:00
Dries Buytaert 337b3c9de9 - Committed a slightly modified version of Slavica's table prefix patch. 2003-07-10 17:46:44 +00:00
Dries Buytaert 877143131d - Bugfix: don't show the "blog it" links when the blog module is disabled.
Patch by Bart Jansens.
2003-07-08 09:07:30 +00:00
Dries Buytaert 4d29898a96 - Bugfix: flush the cache after updating the new feeds (or after having
added or removed news items).  Fixes bug #2088.
2003-06-28 22:48:18 +00:00
Dries Buytaert f4df719502 - Reworked the CXX checking; now, _any_ user input will be checked
and the request will be terminated when something suspicious is
detected.  This will be logged in the watchdog.  With help from Marco.

- Fixed translation issue in the archive module.  Patch by Gerhard.

- Removed dead parameter from variable_get().  Patch by Chris Johnson.
Fixes bug #2111.

- Improved input checking of taxonomy module.  Patch by Gerhard.
Fixes bug #2112.
2003-06-27 17:48:20 +00:00
Dries Buytaert 1c38cd9099 - Bugfix: renamed "create PHP content" to "create php content". Reported
by Simon, patch by Gerhard.

- Improvement: synchronized the import module help with the version on
drupal.org.
2003-06-24 15:55:22 +00:00
Dries Buytaert 265127591f - Bugfix: fixed the character when importing news feeds. Reported at
http://drupal.org/node/view/2036.
2003-06-22 07:36:06 +00:00
Dries Buytaert ef8735614f - Improvements: XHTML-ifications. Patch by GmbH. See feature #1813. 2003-06-16 17:09:23 +00:00
Dries Buytaert 2edb978db3 - Bugfix: fixed glitch with "blog it" images. Patch #15 by Al. 2003-06-15 19:41:15 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert b0081e5ac9 - Bring back the "blog it" icon. Patch #47 by Al. Thanks.
(I don't like the suggested icon so I suggest we continue to use the existing one, which I don't like either but oh well.  Thoughts?)
2003-06-08 19:31:27 +00:00
Dries Buytaert a448f5a9b4 - Charset simpliciations. Patch #46 by Al. 2003-06-08 16:50:05 +00:00
Dries Buytaert de3b0796d2 - Bugfix: better charset support for non-ISO-8859-1 languages. Patch 0029.charset.fixes.patch by Al. Could East Asia test this please.
- Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.

- Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.

- Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.

- Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.

- Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.

- CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.

- Updated the MAINTAINERS file.
2003-06-05 18:09:39 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert ed1a9cbfa7 Patch by Al:
- Made the import module use theme_item_list() instead of emitting the HTML
  and CSS itself.

- Renamed the "blog-it" tag to "icon" so it can be used for other (but
  similar) purposes.
2003-05-30 05:53:10 +00:00
Dries Buytaert e39cfcd22b - More CSS updates and fixes. Patch by Al. 2003-05-29 15:36:17 +00:00
Dries Buytaert 1fc8a18c2d - Al's CSS patches. This commit improves the themability of some core
components such as lists, form items, removes an ugly hack from the
  archive module and should fix the poll problem (although it doesn't
  Opera/Konqueror).
2003-05-29 10:18:38 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Dries Buytaert 4a9e233d75 - News items are now filtered using node_filter() instead of filter(). This stops the other filters (such as textile) from kicking in and messing with the data. Reported by Gary. 2003-04-28 21:23:11 +00:00
Dries Buytaert a956de78b9 - Fixed some PHP "notices". 2003-04-21 14:55:03 +00:00
Dries Buytaert 3c2dc18c82 - Fixed bug #1545: incorrect sequence tables on PostgreSQL. Patch by Neil.
In addition, I have updated update.php so it makes the corresponding
  changes for MySQL users.
2003-04-20 20:33:28 +00:00
Dries Buytaert b85cf71962 - Applied modified version of Al's "block delta" patch. I left out the
blogroll feature as I think it would get very confusing.  I don't mind
  to add it but it need some thought and documentation as it somewhat
  conflicts with the existing cloud module.

  These changes require you to run update.php.
2003-04-19 16:42:42 +00:00
Dries Buytaert 6bc00ed3b3 - Fixed bug with empty <title>-tags. Reported by Gary Lawrence Murphy.
- Fixed bug with "add new feed" and "add new bundle" forms.  It would
  display the edit forms as well due to a missing break-statement.
2003-04-19 08:37:49 +00:00
Dries Buytaert 3ad7449bc7 - Various improvements to the menu system.
- Changed the import and taxonomy module to use better URLs.  Patches by
  Al.

- Fixed locale module weirdness.  Patch by Kjartan.
2003-04-01 06:05:15 +00:00
Dries Buytaert 4742ba3549 - Fixed some SQL query directives. 2003-03-29 16:30:40 +00:00
Dries Buytaert ad2d4d8496 - Bugfix. Reported by Gunnar 2003-03-23 19:14:26 +00:00
Dries Buytaert 9836201e7f - Bugfix. Reported by Gunnar 2003-03-23 19:12:38 +00:00
Dries Buytaert 016b8336f8 - Bugfix: ignore "textinput" and "image" tags, for now. Reported by Al Maw. 2003-03-23 11:48:53 +00:00
Dries Buytaert e2ab17fbae - Refactored the import module: it will now use PHP's built-in XML parser
rather then a set of regular expressions.  Solves Debian bug #184252:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=184252

- Fixes some invalid db_query_range() queries.  This solves bug #1287:
http://drupal.org/node/view/1387

- Fixed the use of '%d' and '%s' in some queries.

- Fixed some translation bugs.

- Improved error/status reporting.
2003-03-23 09:35:32 +00:00
Dries Buytaert 170b674a09 - All LIMIT queries must go through the pager or through db_query_range().
The syntax for db_query_range() was enhanced so it matches db_query(). So
  you may pass extra arguments of the SQL statement which are checked via
  check_query() and then substituted into the SQL statement. After these
  optional arguments, you always pass $from and $count parameters which
  define your range.  Most often, the $from is 0 and the count is the max
  number of records you want returned.  Patch by Moshe.

- The pager_query() function for PEAR was enhanced so that it adds  proper
  GROUP BY statement counting the number of records to be paged. Patch by
  James Arthur.

- MSSQL database scheme by Moshe.
2003-03-16 07:02:20 +00:00
Dries Buytaert d0a8e9221b - Removed target attribute from <a href="">. Patch by Al. 2003-03-13 21:19:36 +00:00
Kjartan Mannes 9a57a20732 - Fixes invalid link generation in import module (wouldn't work with
clean urls enabled).
- Changed the logic in blog module to handle "blog it" links.
2003-03-13 14:02:44 +00:00
Dries Buytaert 491b0b59ec - Bugfix to make parsing http://www.veganporn.com/syndicate-j.pl work.
Patch by Trent.
2003-03-08 00:20:47 +00:00
Dries Buytaert a15bf99e46 - Fixed the links in the admin menu. Patch by Ax. 2003-03-05 18:56:57 +00:00
Dries Buytaert 277ceae515 - New menu houskeeping. Prototyped by Zbynek.
The following modules need updating:
    * glossary module
    * feed module (Breyten's version)
    * mailhandler module
    * notify module
    * project module
    * smileys module
    * admin module
    * style module
    * taxonomy_dhtml module

  To avoid unexpected problems menu_add() is deprecated (it will print an
  error message when used) and menu() should be used instead.
2003-02-20 22:44:51 +00:00
Dries Buytaert 83f5d82876 - Everything is using theme("function") now instead of $theme->function(). 2003-02-15 11:39:56 +00:00
Dries Buytaert e90f3b883b - See http://lists.drupal.org/pipermail/drupal-devel/2003-February/021824.html. 2003-02-11 20:01:17 +00:00
Dries Buytaert 637004c539 - Tidied up XHTML. Patch by Ulf.
- Added missing t() function.  Patch by Stefan.
2003-01-23 09:24:20 +00:00
Dries Buytaert 9a23223e25 - Applied Ori's format_plural() patch; see mailing list for details.
NOTE: some modules in the contributions repository might need to be updated.
2003-01-21 22:44:25 +00:00
Dries Buytaert 485e1c394a Great patch from Ulf:
- The href target for a new window is "_new", not "new".

- Generating <div> sections within <p> sections is forbidden by the
  XHTML standard. Using just the right aligned <div> should be
  sufficient and makes XHTML themes possible.
  (Prove at http://blog.rompe.org/ )

- While parsing the header of an RSS feed one should be aware that
  there may be more <title> tags in subsections and that POSIX regular
  expressions are always gready. So make shure we don't get too much.
  (If you agree that using PCRE instead of the POSIX ones would be
  generally a good idea, then I am willing to make the patch, but for
  now I didn't want to mix POSIX and PCRE in one file.)
  (Prove at http://blog.rompe.org/index.php?q=import/feed/43 , try
  this feed without my patch)

- Some RSS 2.0 feeds don't have a per item <link> section but have the
  permalink embedded in the <guid> section. This is not perfectly
  correct and the documentation mentions this possibility only in the
  examples, but since Dave Winer himself implements it this way it
  will happen more than once. So, if there is no link available and
  the guid looks like an address, then use that one.
  (Prove at http://blog.rompe.org/index.php?q=import/feed/22 , try
  this feed without my patch)

- Don't only write eventually new Feed Header information into the
  database but also use them immediatly. Reuse the $feed array that is
  made for it.

- If a feed doesn't provide per item titles, make shure to not produce
  defective markup by cutting the remainder of an entity. Instead of
  just cutting off anything behing the leading 30 characters of the
  cleaned description, it seems slicker to use up to 40 characters and
  split on word boundaries, but not on "&" or ";".
  (Prove also at http://blog.rompe.org/index.php?q=import/feed/22 .
  This feed will have title tags starting on February 1st, but I
  suspect many others without them out there.)

With this patch one could consider Drupals aggregator RSS 2.0 ready.
2003-01-07 19:09:42 +00:00
Dries Buytaert 89b2069e4d - Clean URL patch. 2003-01-06 19:51:01 +00:00
Dries Buytaert de95001c92 - Tidied up the use of check_output(). Might make rendering pages a bit
snappier (performance improvement).
2002-12-31 12:34:07 +00:00
Dries Buytaert 3a43fdd414 - Usability improvement: made the access log, referrer logs and popular post
tables use the new table rendering functions.

- Usability improvement: a couple of strings could not be translated.
2002-12-29 16:54:31 +00:00
Dries Buytaert 22fa9ed70a - Refactored the administration pages. 2002-12-24 15:40:32 +00:00
Dries Buytaert 24d903638b - Fixed warning in import module. Reported by Pete. 2002-12-16 21:38:58 +00:00
Dries Buytaert 7ce686c152 o Permission improvements:
+ Removed the "post content" permission and replaced it by more fine-grained permissions such as "maintain static pages", "maintain personal blog", "maintain stories", etc.

o Usability improvements to teasers:

   + Teaser forms are no more.  Teasers are extracted automatically but can also be instructed using a delimiter "---".  Furthermore, when a post it too short for a teaser, the user won't be bother with teaser stuff anymore.

   + Added an option to set the teaser length, or to disable teasers all together.

   + When previewing a post, both the short (if any) and the full version of a post are shown.  This addresses a common complaint; for example, when writing a book page there was no way you could preview the short version of your post.

   + Forum posts can be teasered now.  This is particularly helpful in the context of drupal.org where we promote forum topics.

o Bugfix: replaced all PHP short tags (<?) with long tags (<?php).

o Bugfix: removed hard-coded dependence on comment module.

o Bugfix: when the queue module was disabled, it was not possible to approve updated book pages.

o Bugfix: applied modified version of Marco's node_teaser() fix.
2002-12-10 20:35:20 +00:00