77dc67ec92
#56415 , menu_set_location (menu_set_active) mangles $_GET/arg(), patch by JonBob
2006-04-07 15:18:40 +00:00
c706d11a0d
#16542 , add db rewriting for menus, patch by chx
...
fixes 57406 too
2006-04-07 11:28:20 +00:00
3e9948e529
#55869 : Redirect back to requested page after log-in
2006-04-04 07:46:02 +00:00
d87aa9e464
#56796 : Don't show offline notice more than once per page
2006-04-04 06:17:52 +00:00
dae2bdbb3b
#45988 , Nodes with menu items bypass node permissions system
...
patch by chx
2006-03-20 20:48:19 +00:00
07fe4198ad
#42388 , Rehaul menu builder, patch by chx
2006-03-15 08:49:24 +00:00
a70522881e
- #53857 : External URL suppor for menus broken by SA-2006-001
2006-03-14 15:20:41 +00:00
0539f5483b
- sa-2006-001: Custom menu items are accessible to anyone
2006-03-13 21:33:18 +00:00
3fccc5b2eb
#42388 , Out of range value adjusted for column, patch by drumm
2006-03-09 22:12:53 +00:00
308d1f200f
- Patch #48993 by jvandyck: removed notices.
2006-02-14 19:19:34 +00:00
583d5a4ee9
- Patch #48622 by adrian: remove drupal_goto from _submit functions.
2006-02-10 05:25:57 +00:00
5c75ee8947
- Patch #46184 by Jaza: breadcrumb gone for pages that use menu_set_location()
2006-01-29 07:43:22 +00:00
ca9f0fab45
- Patch #45854 by Jaza: fixed problem with menu_rebuild().
2006-01-23 07:27:18 +00:00
14ae238973
- Patch #45320 by Zen: improved usability of off-line mode.
2006-01-22 07:51:06 +00:00
a177c29622
- Patch #40849 by wtanaka and Richard: killed some menu.inc warnings/notices.
2006-01-20 09:12:26 +00:00
f828c0ade2
- Patch #39430 by Jaza and Richard: code improvements: improved separation between UI and logic.
2006-01-19 08:58:00 +00:00
b7a993639b
- Patch #9477 by Neil and Richard: fixed inconsistent behavior of user-specified paths.
2006-01-16 08:45:30 +00:00
6ff8147a75
- Patch #44176 by Zen: performance improvement: split() -> explode().
2006-01-13 14:38:38 +00:00
3607a2b059
- Patch #44373 by m3avrck: improved generated HTML/CSS.
2006-01-12 09:58:49 +00:00
70c097f2be
- Modified patch #43082 by chx: return a 404 when a callback function does not exist.
2006-01-08 12:17:57 +00:00
34a5d46022
- Patch #36465 by chx / Richard: made it possible to link to the front page.
2005-12-27 10:36:16 +00:00
b4552cd977
- Patch #40512 by Richard: fixed coding style + performance improvements.
2005-12-10 20:01:55 +00:00
c7bce9efd4
- Patch #35768 by JonBob/Richard: separate callback handling from menu handling.
...
Moves callbacks and arguments to a separate data structure from the visible menu tree. As mentioned on drupal-devel, this change has little impact except to slightly improve code legibility and prepare the code base for future separation of these tasks, with an eye toward performance improvements of the menu system. Also changes array_key_exists() to isset() in several places, which is reported to perform better.
2005-12-03 14:50:27 +00:00
c1dbd83e40
- Patch #11758 by Richard Archer: fixed mbstring clash.
2005-11-28 15:45:04 +00:00
5cf74ccb72
#27582 : menu.inc doc update
2005-11-24 22:04:10 +00:00
ea53aad7c8
- Patch #22215 by Richard Archer: refactored primary and secondary links.
...
Deprecates the primary_links module.
This patch was much needed. Thanks Richards!
NOTE: if some themers could investigate if there is room for improvement
with regard to theming, that would be awesome.
2005-11-03 19:33:37 +00:00
22cf0b4ef7
- Patch #35410 by kbahey: made site offline feature work.
2005-10-29 06:58:56 +00:00
f6764cfbd8
- Patch #30930 by m3avrck/deekayen: cured PHP5 warnings.
2005-10-22 15:14:46 +00:00
709b9005f5
- Modified version of patch #32622 by kbahey: added 'site offline/maintenance' feature.
...
(Untested because the admin/settings page doesn't work yet.)
2005-10-08 12:38:20 +00:00
f906d2dd50
- Patch #31306 by ax: fixed menu system warning.
2005-09-18 17:03:26 +00:00
7b8a409675
- Patch #29385 by chx: no ?> add end of files.
2005-08-25 21:14:17 +00:00
b69b43d1ec
- Patch #28482 by Uwe: add CVS $Id$ tags to all source files in Drupal core. This allows admins to know exactly which version of which files they use. In addition I want to use CVS $Id$ tags in my upcoming security.module to check for possible vulnerabilities. That's not possible if some files simply don't have $Id$s.
...
Note: I also (mostly) unified the tags to use the "// ID" form instead of "/* ID */", but that's more of a cosmetic issue. I'm not sure whether *.txt files and the stuff in themes/ need tags(?).
2005-08-11 12:57:41 +00:00
5c8843704c
- Patch #18213 by chx: boostrap system. Modified to work with HEAD, tidied
...
up the documentation a little.
chx: can you double-check whether the global $conf variable is secure?
(That is, make sure it can't be send using the URL or something.)
2005-06-22 20:19:58 +00:00
efdd76ad3d
- Patch #22416 : fixed typo that prevented menu item descriptions from showing up in links.
2005-06-05 09:47:13 +00:00
a76a1e1f3f
- Patch 20910 by chx: centralize print theme page.
2005-04-24 16:34:36 +00:00
6ba8f32cca
- Patch #13503 by chx: made the menu cache locale aware.
2005-04-07 20:00:48 +00:00
2b6d4c566e
- Patch #17869 : make local tasks more themeable.
2005-02-28 16:23:27 +00:00
1e15bed312
- Patch #17687 by Gerhard: removed some cruft.
2005-02-21 19:47:44 +00:00
42e7e7d519
- Small clean-up: '>= 1' => '> 0' => ''.
2005-01-22 09:10:59 +00:00
df3b371853
- Patch #15976 by Neil: if one single admin modifiable menu item is added then it is not put in the menu table because the comparison is > 1 instead of > 0.
2005-01-22 09:09:06 +00:00
24a68b209c
- Patch #9477 by JonBob: improved handling of user-specified paths.
2005-01-19 21:57:58 +00:00
76eace311e
- Usability improvement: only display subtabs if there is more than one subtab. If there is only one, make sure it is the set to be the default subtab and all is well.
2004-11-28 12:03:11 +00:00
c214cee319
- On popular demand, patch #10178 by jhriggs: made it possible to expand menu items.
2004-11-06 12:11:02 +00:00
b228f0183a
#11449 : Adding a failsafe check for an improperly prefixed menu sequence. This is a temporary fix, awaiting a proper install system to end manual prefixing ;).
2004-10-16 19:42:52 +00:00
12eb20238c
- Patch #11430 by JonBob: reseting the menus broke the admin pages.
2004-10-14 21:38:12 +00:00
986a476c45
Reverting the last #9292 (php 5 compatibility) patch, by request of killes. It broke stuff.
2004-10-12 23:33:38 +00:00
306cfdf17a
- Patch #9292 by Gerhard: fixed another array_merge + PHP5 woe.
2004-10-12 20:20:28 +00:00
5c7983c4de
- Patch #8179 by JonBob: reintroduced menu caching.
2004-09-16 07:17:56 +00:00
b84b6e42cf
- Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments.
2004-09-09 05:51:08 +00:00
27f055b5cd
- Patch #10192 by JonBob: fixed issue with menus not expanding.
2004-09-07 21:48:49 +00:00
1b1bcc35ac
- Patch #10026 by Al: bugfix: don't show the 'more help' links when the help module is disabled.
2004-08-16 21:25:54 +00:00
9a26352b9c
- Patch #9864 by JonBob: better form validation in menu administration.
2004-08-15 16:42:59 +00:00
0f088b79ca
- Patch #9983 by Stefan: various code style improvements.
2004-08-12 18:00:11 +00:00
f99830a498
- Patch by Al: improved the admin/help pages (first step).
2004-08-10 05:44:17 +00:00
9bbdb71ee4
- Patch #9330 : ucfirst() gives problem when used with multibyte charset.
...
Replaced the use of ucfirst() with a CSS-based solution.
2004-08-06 20:15:32 +00:00
c0f6fccac3
- Patch #7336 by TDobes: in various parts of Drupal, we use the title attribute for links to provide a slightly more detailed explanation as to the purpose of a link or where it goes.
2004-08-03 18:01:48 +00:00
2af5dff6a2
- Patch #9464 by Moshe: menu.module omitted a pair of braces when calling
...
db_next_id().
2004-07-25 18:16:49 +00:00
edc2f13d82
- #9287 : More doxygen/documentation fixes by JonBob
2004-07-22 16:06:54 +00:00
7765fa1f7a
- Patch #9290 by Morbus / JonBob / TDobes: SUBTASK removal patch for menu.inc.
2004-07-15 17:16:58 +00:00
ce8e264382
- Patch #9262 by Ber / JonBob: the menu did not build correctly, thus the additional menu's were never displayed, but were saved. Only the last custom menu was displayed.
2004-07-14 05:46:12 +00:00
f163fa9956
- Patch by JonBob: a significant documentation update for the menu system!
2004-07-10 18:10:36 +00:00
ac5b5616c0
- More tab-improvements by JonBob: improved support for the default tabs!
2004-07-10 15:51:48 +00:00
7bb88809b7
- Patch #9049 by JonBob: fixed a number of tab issues.
2004-07-06 07:33:59 +00:00
9986cb36b5
- Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
2004-07-02 18:46:42 +00:00
60513799a1
- Patch #8941 by JonBob: allow local tasks to be ordered by weight, as well
...
as simplifying the theming of local tasks so they can be more easily
rendered in a non-tab manner.
2004-06-30 20:45:45 +00:00
4e1f368e88
- "" -> ''.
2004-06-20 08:31:45 +00:00
ce45c91a53
- Patch #8652 by Adrian: incorrect implode.
2004-06-20 08:30:57 +00:00
efed4cfc70
- Patch #8679 by asimmonds: fixed spelling mistakes.
2004-06-20 08:27:03 +00:00
1b46d7fcfe
- Patch #8614 by JonBob: better way to display menus.
2004-06-19 14:57:44 +00:00
a42b84e5d6
First tab improvements by Adrian:
...
+ Changed menu.inc to generate two separate lists instead of nested lists:
that seems to be the only alternative to get rid of absolute positioning.
+ Changed the tabs code to be more sexy and put the code in misc/drupal.css
so all themes are automagically updated.
2004-06-19 08:24:14 +00:00
54b77d6435
Tabs patch!
...
CHANGES
-------
+ Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
+ Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
+ Grouped settings. All settings have been grouped under 'administer > settings'.
TODO
----
+ Update core themes: only Xtemplate default supports tabs and even those look ugly. Need help.
+ Update contributed modules. The menu() hook changed drastically. Updating your code adhere the new menu() function should be 90% of the work. Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
fbbf510511
- Patch #8105 by mathias: made the menu system aware of path aliases.
2004-06-01 21:58:46 +00:00
3de9d33e67
- Menu and code improvements by JonBob.
2004-05-08 07:17:47 +00:00
681b26febc
- Patch #7577 by JonBob: various code style improvements to the statistics
...
module.
+ Usages of to print titles have been replaced by proper drupal_set_title()
calls.
+ Many arg() usages dropped in favor of meaningful parameters.
+ Doxygen comments standardized and expanded.
+ Some grammatical corrections to help text.
+ Broken /statistics page linked from page navigation restored.
+ Fixed small bug in menu.inc pertaining to menu callbacks without
arguments.
2004-05-05 21:12:14 +00:00
d4e1b4a74b
- Removed the menu cache. Too many problems with it.
2004-04-27 19:35:10 +00:00
7231c88a32
- Added support for 403 handling. Patch by JonBob. As a side benefit,
...
administrators will be able to define a custom 403 page, just as they
can define 404 pages now.
This needs to be documented in the "Changes since / migrating to ..."
pages.
2004-04-21 13:56:38 +00:00
10bdb51c37
- Patch by JonBob/Jonathan: reworked the menu system so that menus are
...
configurable! Menu items can be disabled, repositioned, added and
so on.
Upgrading to requires you to run update.php.
This functionality depricates some of the 'navigation modules' in the
contributions repository. Furthermore, modules can now 'suggest'
menu items and site adminstrators can choose to enable them. Modules
in the contributions repository should try to take advantage of this.
2004-04-15 20:49:42 +00:00
fdea6a2907
- Fixed two bugs in the menu system: only make a menu collapsable when it has
...
_visible_ children, accept 'foo/0'-style URLs (0 != NULL).
2004-02-15 14:56:50 +00:00
5fa33b2962
- Made l() add 'class="active"' to the active/current URL.
2004-01-12 22:53:43 +00:00
2639c1d42f
- Improved Doxygen documentation.
2003-12-27 21:29:20 +00:00
23c7a4aa5d
- Fixed bug 4703: don't display the help text when the user has no access
...
rights for a page. That is, only return the help text if an active
handler exists.
2003-12-18 21:13:17 +00:00
928c113b82
Patch by Kjartan:
...
- Adds possibility to hide menu item when it has no children. (Fixes the
node/add problem when user doesn't have access to create any node
types.)
- More doxygen comments.
2003-12-17 22:15:35 +00:00
670a292277
- Reworked 404 (page not found) handling. Patch by walkah. You can specify a
...
custom 404 page in the administration page. As a result, error.php could be
removed.
2003-12-16 21:06:34 +00:00
3904790e03
- Tidied up the DoxyGen comments. Patch by Kjartan.
2003-12-08 06:32:19 +00:00
d45bf0f1e7
- Patch 185 by Ax: fixed undefined variables, synchronized xtemplate with sf, etc.
2003-12-04 20:53:19 +00:00
e4d791fe0d
- Menu fix by Jonathan.
2003-11-21 19:08:46 +00:00
92995414b4
- Committed stage 1 of the menu callbacks improvements. Patch by Jonathan.
2003-11-08 09:56:22 +00:00
5d684e108e
- Bugfix: stopped the menu system from generating empty lists (<ul></ul>). Patch
...
by Nick (CodeMonkeyX).
- Bugfix: anonymous users could not change comment settings. Patch by Bart.
- Bugfix: the comment control form always showed "order by date - newest first",
no matter what order you selected. Patch by Bart.
- Small usability improvement: only display comment controls when there are
comments to show. Patch by Bart.
2003-10-14 18:08:33 +00:00
0f44d7d6cd
- Committed part 3 of Michael's help system improvements: removed the $help
...
parameter from the menu() function.
2003-10-09 19:24:09 +00:00
51ddccb1dc
- Fixed typo in menu system. Patch by Jonathan.
2003-10-07 18:46:15 +00:00
32e8d77cd6
- Associate a callback with the menu links! (This callback is not yet being
...
called but will be as soon the remaining links have been transformed to use
the menu system.)
- Made sure the menu does not render links with no callback and no children.
Like this, the 'create content' link is not being shown when the user has
no permission to add any content.
2003-09-28 17:53:04 +00:00
c8b28009cd
- Made sure all menu items can be translated. Path by Goba.
2003-09-28 15:18:55 +00:00
42a987316f
- Fixed bug #3037 : fixed translation issue with menu items.
2003-09-28 13:42:12 +00:00
a5e048a5fd
- Renamed some menu items for clarity and ... added basic phpDoc comments.
2003-09-28 11:08:17 +00:00
2fe79310df
- Rewrote the most of the menu system; this fixes Al's problem with the
...
"create content" link.
- Manually merged the user module's new menu items. Al's patch did not
apply.
- Added some missing t()s.
2003-09-28 10:51:40 +00:00
f104d3cc12
- Committed the admin menu integration patch. Thanks Adrian, Stefan and others.
2003-09-26 10:04:09 +00:00
6ac9f88959
- Bugfix: fix glitch in menu rendering code. Patch #42 by Al.
2003-06-08 08:20:39 +00:00
c2d2fb7309
- Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
...
- Fixed a typo in the MSSQL database scheme. Patch by Michael Frankowski.
- Removed dependency on "register_globals = on"! Patches by Michael Frankowski.
Notes:
+ Updated the patches to use $foo["bar"] instead of $foo['bar'].
+ Updated the INSTALL and CHANGELOG files as well.
- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
81b05c6795
- Don't report duplicate entries - it is an OK thing to do.
2003-04-21 12:31:51 +00:00
a53e34e80e
- Removed the deprecated function menu_add().
2003-04-14 20:29:31 +00:00
3ad7449bc7
- Various improvements to the menu system.
...
- Changed the import and taxonomy module to use better URLs. Patches by
Al.
- Fixed locale module weirdness. Patch by Kjartan.
2003-04-01 06:05:15 +00:00
4ad174c411
- Eliminated system_init(), the session stuff, and made it possible to
...
rebuild the menu.
2003-03-12 21:46:14 +00:00
54ea2de9f3
- Adding $Id$ keyword.
2003-03-12 09:51:30 +00:00
6f6561a8b2
- Fixed some spelling mistakes. Patch by Al.
2003-02-27 22:45:00 +00:00
cff898ffdb
- Fixed bug when an additional parameter is being passed to the callback.
...
Patch by Zbynek.
- Made the menu_tree() function emit CSS tags to identify which menus are
expanded/collapsed/leafs. Patch Zbynek and Al Maw.
2003-02-25 19:48:55 +00:00
277ceae515
- New menu houskeeping. Prototyped by Zbynek.
...
The following modules need updating:
* glossary module
* feed module (Breyten's version)
* mailhandler module
* notify module
* project module
* smileys module
* admin module
* style module
* taxonomy_dhtml module
To avoid unexpected problems menu_add() is deprecated (it will print an
error message when used) and menu() should be used instead.
2003-02-20 22:44:51 +00:00
32989e14db
- Fixed blog.module to accept blog/name URLs as well as blog/id
...
- Changed the RewriteRule in .htaccess.
- Fixed form_select() matching incorrectly.
- Added missing $Id$ to menu.inc
2003-02-12 21:37:56 +00:00
92b5fc369a
- Fixed XHTML glitch in the sitemap. Thanks Moshe and Michael.
2003-01-27 19:15:20 +00:00
a32e3d1408
- Added sitemap feature to administration pages. Requested by various
...
people including Michael and Moshe.
2003-01-26 13:27:59 +00:00
d268783669
- Small improvement to the admin menu based on feedback from Michael.
2003-01-14 20:33:42 +00:00
89b2069e4d
- Clean URL patch.
2003-01-06 19:51:01 +00:00
e97c6a73d6
- Code improvement: menu_tree() will no longer generate empty "<ul></ul>"
...
constructs.
2002-12-30 15:54:06 +00:00
a3ad12a9b6
- We don't have to show the main row anymore.
2002-12-27 14:58:57 +00:00
22fa9ed70a
- Refactored the administration pages.
2002-12-24 15:40:32 +00:00
Gerhard Killesreiter
Steven Wittens
Dries Buytaert
Kjartan Mannes