Commit Graph

245 Commits (46e43ebed12729f42eb52f898f780a45102852b4)

Author SHA1 Message Date
Kjartan Mannes 46e43ebed1 - Fixed cache's handling of HTTP headers (passed all 9 unit tests) 2003-09-29 13:41:22 +00:00
Kjartan Mannes 0c3cc7b487 - Fixing cache logic, the logic was inversed. 2003-09-29 09:32:45 +00:00
Dries Buytaert b8416f613a - Made the check for If-Modified-Since and Etag headers work for non-Apache
webservers.  This will, for example, improve caching on IIS.  Patch by
  Kjartan.
2003-09-28 17:21:57 +00:00
Dries Buytaert 18e840ac66 - Bugfix: fixed string being check_query()-ed twice. Bug #2425. Patch by
Matt.
2003-09-14 08:57:18 +00:00
Dries Buytaert b9633dcded - Patch by Bart Jansen:
<quote>

  This adds session support for anonymous users and fixes a bug/typo.

    1. changed rid for user #0 from 0 to 1 (rid 1 == anonymous user) to make
       inner join work.

    2. replaced "if ($user .." by "if ($user->uid .." because now $user is
       always set (my previous change probably caused this).

    3. db_next_id("user_uid") -> db_next_id("users_uid");
  </quote>

  I repeat:

  "This adds session support for anonymous users and fixes a bug/typo."
2003-09-10 19:30:34 +00:00
Kjartan Mannes 2feb19abc2 - fixing a invaild if that has slipped in. 2003-09-05 13:19:00 +00:00
Dries Buytaert 4d16c7c65b Implemented more suggestions by Keith:
- Made sure the 'Topic' title is only shown above the topics, not the icons.

- Automatically shorten the username when it is too long.  I implemented this
  as part of format_name() and could therefore nuke some code in the
  statistics module.  This is change is somewhat experimental and I'm willing
  to revert or change this if a number of people aren't too happy with this
  behavior.

- Left align the dates and authors: makes it easier/faster to scan.

- Made the little tablesort arrows clickable.
2003-08-22 21:35:25 +00:00
Dries Buytaert 0431f0700f - Committed Jeremy's session patch: this brings us one step closer to having
session for anonymous users.
2003-08-20 19:19:13 +00:00
Dries Buytaert 6ddeae9f5c - Bugfix: fixed problem with "exit" hook not always being called. Reported
by Jeremy.  Patch by Moshe.
2003-08-13 20:44:11 +00:00
Kjartan Mannes 48805032c8 - Applied modified version of almaw's 0064 patch: form item attributes.
- Applied modified version of mathias' 0073 patch: node form name.
  $params["options"] is now an array so some contrib modules might
  need minor changes.

- Applied mathhias' 0074 patch: missing access check on who is new
  block.
2003-08-12 20:37:16 +00:00
Kjartan Mannes 17ef869e3a Applied 0007.almaw.home-link-using-l.patch
- Fix link_page to use l() to generate home link.

Applied 0058.kika.themeable-usermenu.patch
- Modifies user menu be themeable.
2003-08-11 20:41:37 +00:00
Dries Buytaert 39950fe2e2 - Committed a modified version of Ulf's input checking changes. Patch #95.
I added an error message, changed a few things around and fixed tw typos.
2003-08-08 22:24:55 +00:00
Dries Buytaert 3833e4de9d - Cache system improvements by Gerhard: removed some left-overs. 2003-07-23 18:33:12 +00:00
Dries Buytaert 81ea70d101 - Bugfix: the cache wasn't always cleared properly. Patch by Gerhard. 2003-07-23 17:12:37 +00:00
Dries Buytaert 8759ca7368 - Commited the URL aliasing patch. Thanks Matt.
This update requires you to run update.php!
2003-07-16 20:14:26 +00:00
Dries Buytaert 337b3c9de9 - Committed a slightly modified version of Slavica's table prefix patch. 2003-07-10 17:46:44 +00:00
Dries Buytaert e5b392b5d7 - Fixed typo 2003-07-09 22:13:09 +00:00
Dries Buytaert 9fd25fa520 - Some more refinements 2003-07-09 22:07:50 +00:00
Dries Buytaert ae4fe72d17 - Changed the XSS check a little to be slightly more forgiving wrt style
attributes.
2003-07-09 21:48:13 +00:00
Dries Buytaert dc15ba06e0 - Improvement: don't perform XSS checks for trusted users. Trusted users
are those that have the "bypass input data check" permission set.  Should
  address bug #2147.

- Improvement: simplified index.php and modules/admin.module.

- Bugfix: fixed broken links in bloggerapi documentation.  Patch by Chris
  Johnson.  Fixes bug #2030.

- Bugfix: fixed the date shown on a book module preview.  Reported as part
  of bug #2097.

- Bugfix: fixed broken URL in the book module documentation.
2003-07-01 17:54:22 +00:00
Dries Buytaert 886ae2bf15 - Fixed some "search related" bugs introduced by Moshe's latest patch.
Fixes bug #2127.
2003-06-30 19:18:47 +00:00
Dries Buytaert da80e62042 - Removed "link" from the XSS check as well as "font". 2003-06-29 18:21:47 +00:00
Dries Buytaert 646bb31a42 - Improvement: faster regex/checks. Patch by Marco. 2003-06-28 07:05:34 +00:00
Dries Buytaert f4df719502 - Reworked the CXX checking; now, _any_ user input will be checked
and the request will be terminated when something suspicious is
detected.  This will be logged in the watchdog.  With help from Marco.

- Fixed translation issue in the archive module.  Patch by Gerhard.

- Removed dead parameter from variable_get().  Patch by Chris Johnson.
Fixes bug #2111.

- Improved input checking of taxonomy module.  Patch by Gerhard.
Fixes bug #2112.
2003-06-27 17:48:20 +00:00
Dries Buytaert e95aa56e02 - Bugfix: fixed bug in the search module that prevented the title module
from working properly.  Patch by Moshe.  Fixes bug #1852.
2003-06-25 22:10:54 +00:00
Dries Buytaert e756213b33 - Bugfix: fixed the "variables not set" problem (bug #2014). Patch by
Slavica.

  Sorry for the confusion guys - I had it applied on my tree for a couple
  of days now but forgot to commit it.
2003-06-23 07:24:56 +00:00
Dries Buytaert e57faf2192 - Bugfix: fixed problem with changing themes. Didn't apply Al's patch as
the fix was somewhat simpler.  Fixes bug #2003.

- Bugfix: fixed problem with voting on certain poll pages.  Patch #37 by Al.

- Improvement: removed stupid descriptions from profile module.
2003-06-20 17:43:03 +00:00
Dries Buytaert 828ba66500 - Bugfix: fixed utf-8 problem for people that use PHP 4.2.x or below. Patch #33 by Al.
- Bugfix: fixed translation problems in the user module and the block module.  Patch by Stefan.

- Improvement: made it impossible to delete user role #1 and #2.  Patch #38 by Al.

- Improvement: fixed the "Allowed HTML tag" issues.  Makes for better code and improved usability.  Patch #35 by Al.

  NOTE: as soon the compose tips make their way into CVS, most of this code can be removed.
2003-06-19 17:26:27 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert 3e9aabe058 - Moved some CXX checks to a centralized place; less error-prone. 2003-06-14 07:02:32 +00:00
Dries Buytaert 1a2576036b - Bugfix: charset fixes/clean-up. Patch #52 by Al.
- Improvement: renamed some theme functions of the forum module for sake of consistency/readability.  Patch #2 by Kristjan.

- Improvement: usability improvements to the Xtemplate theme.  Patch #3 by Kristjan.

- Improvement: CSS'ified the book module pages.  Patch #3 by Al.  (I simplified the "l
ocation" part.  Al's approach gave you a bit more power but I'm not sure anyone wants
to change that.  Besides, this will change as soon we integrate the menu system so I kept it easy for now.)
2003-06-12 17:24:06 +00:00
Dries Buytaert 3b8c99d91e - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan.
- Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.

- Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:

  <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />

  IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.

- Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.

- Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.

- Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.

- Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.

- Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.

- Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
2003-06-11 18:16:32 +00:00
Dries Buytaert a448f5a9b4 - Charset simpliciations. Patch #46 by Al. 2003-06-08 16:50:05 +00:00
Dries Buytaert aa38097c07 - Dropped check_input(); use check_query() instead.
- Made the statistics module use referer_uri() for security's sake.
2003-06-06 21:37:11 +00:00
Dries Buytaert 17cd7c497d - Added a function check_url() that CSS checks URLs (or parts thereof). 2003-06-06 21:08:35 +00:00
Dries Buytaert de3b0796d2 - Bugfix: better charset support for non-ISO-8859-1 languages. Patch 0029.charset.fixes.patch by Al. Could East Asia test this please.
- Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.

- Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.

- Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.

- Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.

- Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.

- CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.

- Updated the MAINTAINERS file.
2003-06-05 18:09:39 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 05288ac48a - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents
to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.

- Bugfix: the admin module does now import drupal.css prior to admin.css.
Patch by me.

- Bugfix: the admin module was still emitting a <base href=""> tag.  I
removed this as it is been taken care of by theme_head();  Patch by me.

- Bugfix: made the tracker module's pager only consider published pages.
Patch by Moshe.

- Bugfix: cured some typos in the comment module's help function.  Patch by
Marco.

- Bugfix: fixed a typo in the pager_display() that caused optional
attributes to be discarded.

- Bugfix: made the Xtemplate emit empty boxes like any other theme does.
Patch by Al.

- Bugfix: fixed broken link on the statistics module's log page.
Reported by Kjartan.

- CSS improvements: made the HTML output emitted by the tracker module
look nicer.  Patch by Moshe and Al.

- CSS improvements: added CSS classes for form elements.  Patch by Al.

- CSS improvements: added a vertical gap between the last form item and the
submit button.  Patch by Al.  Note that Opera 6 is not picking up this
CSS but apparently others browsers such as Konqueror do.

- Xtemplate improvements: changed the color of the selected day in the
archive module's calendar.  Patch by Al.

- Usability improvements: made the "birthday" field of the profile module
look nicer.  Patch by Al.

------

- TODO: it might be a good idea to emit the following meta tag in the
theme_head() function:

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

Currently, some themes (and modules!) emit this while others don't.  This
would also make it possible to change the charset site-wide.

- TODO: now we added support for td.dark and td.light to drupal.css, maybe
it can be removed from admin.css as well as xtemplate.css?
2003-06-03 18:04:47 +00:00
Dries Buytaert 4582eeccd0 - Another register globals fix. Patch by Kjartan. 2003-06-01 19:51:40 +00:00
Dries Buytaert 82019d89fb - Omit "index.php" when using Apache. Patch by Al. 2003-05-31 13:05:06 +00:00
Dries Buytaert c6f9ca540d - Fixed typo. Patch by Marco. 2003-05-30 11:01:56 +00:00
Dries Buytaert 4499241fa1 - Make sure the HTML filter is applied before any other filter. Patch by
Al.
2003-05-30 05:45:35 +00:00
Dries Buytaert 1fc8a18c2d - Al's CSS patches. This commit improves the themability of some core
components such as lists, form items, removes an ugly hack from the
  archive module and should fix the poll problem (although it doesn't
  Opera/Konqueror).
2003-05-29 10:18:38 +00:00
Dries Buytaert 45d5aad6df - Updated Drupal to use "on output" filters. Derived from Gerhard's patch. 2003-05-24 16:26:13 +00:00
Dries Buytaert 9863dd5a71 - Fixed typo in URL(). Patch by Al.
- Added a filter option to disable/enable the rewrite_old_urls() filter.
  See task #1542.
2003-05-23 21:59:44 +00:00
Dries Buytaert 5bd07f4bb2 - Fixed search module bug. Patch by Michael. 2003-05-23 17:59:25 +00:00
Dries Buytaert b68b2798d2 - Fixed a IIS bug with regard to register globals. This also avoids the
aforementioned ugly hack.  Patch by Moshe.
2003-05-20 04:41:36 +00:00
Dries Buytaert bf28f8709b - Applied Moshe's patch that should make clean URLs work on IIS. I removed
a little hack that sometimes patches the request_uri(); I don't think
  this should trigger in first place.  If it does, let me know the URL of
  the form as well as the referring page.  (If this needs fixing after all,
  fixing this _inside_ request_uri() might be a better solution.)
2003-05-19 18:26:49 +00:00
Dries Buytaert 57c7d7b43b - The page_footer() function was always called twice due to the introduction
of the "footer" hook (and because of the existence of the page module).
  This caused the node view counter to be incremented twice per page view,
  the cache being set twice, etc.  Quite a bug.
2003-05-18 09:48:49 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00