Commit Graph

243 Commits (45fdcf8af83a604ce9c768f13e19cd67bf5f20a3)

Author SHA1 Message Date
Dries Buytaert 7f08110a5e - Improved form handling.
+ Introduced two new functions:
      1. form_set_error($name, $message): files an error against the form
         element with the specified  $name.
      2. form_has_errors(): returns true if errors has been filed against
         form elements.

  + Updated the form handling:
       1. The form_ functions will add 'class="error"' when a form field
          has been found to be erroneous.
       2. The error message is passed to theme_form_element() when the
          particular form field has been found to be erroneous.

  + I updated the user and profile module to take advantage of these new
    functions.

  + IMPORTANT: the _user() hook changed.  The 'validate' case should no
    longer retun an error message when something goes wrong but should
    set it with form_set_error().
2004-05-31 09:40:56 +00:00
Dries Buytaert a77130362b - Patch 7444 (#35) by Pablo. This patch addresses some issues with showing
anonymous usernames in comments.  It does not solve all my problems, but
  others claim it works as advertised.  I'm committing this because it does
  fix some pending issues (even though that might not be the end of it).
2004-05-24 18:49:12 +00:00
Dries Buytaert fdb1fbfced - Simplified the 'anonymous poster settings' of the comment module and
made it possible to enforce a username/e-mail address.  Based on
  James Seng's work there are now 3 radio buttons:

   ( ) Anonymous users may not enter contact information
   ( ) Anonymous users may leave contact information
   ( ) Anonymous users must leave contact information

- Fixed a bug in the default theme_comment_view() function.

- Added permalinks for comments.  Requested by Michael and Christina.
  Maintainers of contributed themes might want to add permalinks too.

TODO:

- Fix the interaction design of the submission form: the page you are
  directed to and the validation of the contact information.

- Changing the comment viewing options appears to be broken?
2004-05-20 10:23:52 +00:00
Dries Buytaert 10c5e95a2f - Made it possible for anonymous users to leave their name, e-mail address
and the URL of their homepage.  Patch by Pablo.
2004-05-18 18:41:46 +00:00
Dries Buytaert 4fad80e538 - Patch #7638 by nereocystis: fixed PostgreSQL (ANSI SQL) compatibility bug in the comment module. 2004-05-10 21:30:31 +00:00
Dries Buytaert 1ad9afb8a7 - Added support for multiple user roles. Patch by Jim Hriggs. 2004-05-10 20:34:25 +00:00
Dries Buytaert bfca088828 - Patch #7504 by bylund: multiple form_radio-function calls is used instead
of a single form_radios-call. This could cause problems when trying to
  style individual form elements.
2004-05-03 17:26:22 +00:00
Dries Buytaert f27d1b7b78 - Bug #7135: fixed saving of comment viewing options in PostgreSQL. Patch by Adrian. 2004-05-01 09:22:16 +00:00
Dries Buytaert bfd184321b - Patch #7482 by Gerhard: double 'edit' in comment_user(). One 'edit' had to be 'validate'. 2004-05-01 08:59:08 +00:00
Dries Buytaert 7231c88a32 - Added support for 403 handling. Patch by JonBob. As a side benefit,
administrators will be able to define a custom 403 page, just as they
  can define 404 pages now.

  This needs to be documented in the "Changes since / migrating to ..."
  pages.
2004-04-21 13:56:38 +00:00
Dries Buytaert 291b56c0cc - Fixed problem with global session variable that caused the wrong page to
be rendered after posting a comment.
2004-04-18 15:17:10 +00:00
Dries Buytaert 10bdb51c37 - Patch by JonBob/Jonathan: reworked the menu system so that menus are
configurable!  Menu items can be disabled, repositioned, added and
  so on.

  Upgrading to requires you to run update.php.

  This functionality depricates some of the 'navigation modules' in the
  contributions repository.  Furthermore, modules can now 'suggest'
  menu items and site adminstrators can choose to enable them.  Modules
  in the contributions repository should try to take advantage of this.
2004-04-15 20:49:42 +00:00
Steven Wittens a083daf841 Truncate UTF-8 patch. Introduced a new function truncate_utf8() for chopping off strings at unsure locations, without risking incomplete UTF-8 data. 2004-04-15 14:07:08 +00:00
Dries Buytaert 754f2ac26a - More profile module improvements:
+ Updated the _user() hook's "$type == 'view'" case to match the
     "$type == 'edit'" case.  That is, both have to return an associtive
     array of the format array('category' => 'fields').

   + Updated the profile pages to group fields by category.  Made possible
     thanks to the above change.

   + Moved logic out of the theme_ functions.
2004-03-21 14:28:15 +00:00
Dries Buytaert 994d9cf55d - Partial patch #6375 by jik: it's -> its 2004-03-20 14:32:21 +00:00
Dries Buytaert 4959584243 - Partial patch #6375 by jik: fixed broken URL in comment help. 2004-03-20 14:30:06 +00:00
Dries Buytaert 7c7251bdf5 - Bug #6595: made the signature's textarea less wide 2004-03-20 14:22:09 +00:00
Dries Buytaert 142dd6ba43 Patch #5588 by bylund: XHTML improvements: <i> -> <em> and <b> -> <strong>. 2004-03-20 13:29:06 +00:00
Dries Buytaert 6e217dd641 - Bugfix: mark new comments when show as 'folded' 2004-03-12 08:09:09 +00:00
Dries Buytaert 2101f6c454 - Rewrote the profile module:
+ Added a 'created' field to the users table and renamed the 'timestamp'
     fied to 'changed' (cfr. node table).  Update.php will try to determine
     a 'created' timestamp for existing users.

   + The profile module no longer uses serialized data but has its own set
     of tables.  Known existing profile data is migrated by these new tables.
       TODO: migrate the birthday field.

   + The profile fields can be grouped, and within each group, profile fields
     can be sorted using weights.

   + The profile pages can be themed.

   + The profiles can be browsed based on certain properties/settings.

   + Change the _user hook: (i) 'private_view' and 'public_view' are merged
     into 'view' as there are no private fields and (ii) 'edit_form' has
     been renamed to 'edit'.

   + Avatar handling has been refactored and is now part of the user module.
     The users table has a dedicted 'picture' field.

   + Simplified the way themes should use display/visualize pictures or
     avatars.

   + Made it possible for administrators to replace or delete avatars.

   + ...

  I hope this make for a good base to build on collectively.
2004-03-11 20:33:59 +00:00
Dries Buytaert 0f980c24bc - Removed broken throttle. 2004-03-01 19:45:33 +00:00
Dries Buytaert c73305f6d6 - Patch #6129 by Goba: fixed dependencies on search module. 2004-02-29 17:16:27 +00:00
Dries Buytaert 4b0b2d02ee - Patch by Steven: removed redundant permission checks. These are no longer
required thanks to the new 404 handling.
2004-02-15 20:09:46 +00:00
Dries Buytaert 350cbdd3cc - Patch #4861 by Moshe/TDobes: made the comment module use the _link hook. 2004-02-15 16:28:33 +00:00
Dries Buytaert b5c18e8a17 - Patch 5592 by Goba: introduced a new function, drupal_map_assoc(). 2004-02-12 19:37:04 +00:00
Dries Buytaert f137b26979 - Patch 4902 by Goba:
+ only adds an optional parameter to url() and l(), so individual links
    can be set to be absolute
  + modifies drupal_goto() to accept the parameters of url() without the
    $absolute parameter, so cleaner invocations can be used
  + rework of some code in node_feed, making it much better to look at
    (the current code uses foreach with an immediate brake to get the first
    key of the associative array, geeeeez)
  + added xml:base to the rss tag generated by node_feed()
  + set all user mail URLs to be absolute
  + fix a small fragmented URL in user.module
2004-02-11 19:21:14 +00:00
Dries Buytaert 6c99c2d86f - Patch #5766 by Moshe: replace getenv() with $_SERVER. 2004-02-10 19:41:57 +00:00
Dries Buytaert 5a8129e0fb - First batch of profile module improvements:
+ Tidied up the profile configuration page: grouped form elements.

   + Tidied up the block configuration settings: removed hard-coded
     table.

   + Changed the profile API to return the preferred group name, and
     changed the user module to group settings.  Modules implementing
     the _user hook will need to be udpated.

   + Removed register_form and register_validate for now.
2004-02-07 16:18:46 +00:00
Dries Buytaert 8c909397d7 - Patch #5501: fixed invalid HTML in the comment and tracker module. 2004-02-07 10:57:27 +00:00
Dries Buytaert 48a4dff897 - Patch by Goba: added form descriptions where appropriate and removed some
duplicated code from the comment module.
2004-01-31 21:16:42 +00:00
Kjartan Mannes df062323b2 - Fixed bug #5479: Default comments per page setting broken. (walkah) 2004-01-29 19:51:39 +00:00
Dries Buytaert 02c622dea1 - Patch 4332 by Goba: eliminate compose tips module. 2004-01-27 22:10:47 +00:00
Dries Buytaert 66190b1787 - Patch #5393 by Goba: changes the search hook return value, and requires an array
containing two elements, the first being the requested title, and the second being
  the result list. Advantages:
    * Cleaner search code in common.inc
    * Po extraction is possible and works fine
    * No hardcoded exceptions for node and comment modules, since any module can
      return results in order of relevance (or another order)
2004-01-26 19:22:22 +00:00
Dries Buytaert b85eb11e11 Patch 5287 by Stefan: multiline help texts should become inside a single $output. 2004-01-23 18:42:43 +00:00
Dries Buytaert 0d35894a0b - Patch 5283 by Stefan: fixed typos in comment module. 2004-01-21 06:42:37 +00:00
Dries Buytaert 2ecc6a606e - Changed some wording 2004-01-19 22:22:08 +00:00
Dries Buytaert bc2348efbb - Comment setting improvements: updated the form descriptions, reorganized the
settings in groups, fixed a warning, rewrote the comments per page settings,
  etc.
2004-01-17 10:32:52 +00:00
Dries Buytaert eee72bfa95 - Patch 4859: new drupal_unpack() consolidates duplicate code and makes it
easy to show avatars next to nodes and comments.  Patch by Moshe.  As a
  showcase, maybe Xtemplate should have an option to enable/disable avatars?
2004-01-13 19:25:37 +00:00
Dries Buytaert a8b8c247db - Patch #5021: clean up URLs in _help texts. Patch by UnConeD. 2004-01-11 20:31:26 +00:00
Dries Buytaert 51ee09cc2e - Patch #4924: made the comment form themeable. Patch by Goba. 2004-01-03 12:32:21 +00:00
Dries Buytaert cfc0a5d175 - Fixed typo: comment_delete_thread() -> _comment_delete_thread(). 2003-12-30 14:19:57 +00:00
Dries Buytaert 21a0e8b904 - Updated code to use new semantics of url() and l(). 2003-12-29 19:49:11 +00:00
Dries Buytaert 80f34e5ab0 - XHTML improvements: <b> -> <strong>. Patch by Stefan. 2003-12-29 17:14:27 +00:00
Dries Buytaert baaa21e131 - Tidied up some inconsistencies in the code: scripts/code-style.sh is your friend. 2003-12-28 10:47:33 +00:00
Dries Buytaert 4c06410d18 - Fixed bug 4710: comment module should use drupal_set_message() correctly.
- Fixed the title and breadcrumb trail of the comment delete page, added
missing cache flush, improved usability and made it so that when you delete
a comment replies are deleted as well.

- Added 'delete comment' links to the comments on node pages.  Hopefully
this will make it easier to maintain old threads such as those attached to
the book pages on drupal.org.

- Comment module maintenance: added missing t() functions and improved
consistency of the calls to drupal_set_message(), used radio buttons instead
of a selection box.
2003-12-24 13:13:07 +00:00
Dries Buytaert d5c8026454 - Updated the calls to menu() to use MENU_HIDE instead of 1 2003-12-17 22:27:23 +00:00
Dries Buytaert cc80cdf215 - Replaced the tables used to structure the threaded comment view by div's.
Patch by Goba.
2003-12-15 19:41:24 +00:00
Dries Buytaert 9bd9540856 - Bugfix: the location of comment submission form was incorrect. Patch by
Bart.
2003-12-09 20:15:18 +00:00
Dries Buytaert 712a30b520 - Improvements by Goba:
+ removes the lots of pagers and indirect pager themeing
  + add the theme_pager() function, which should be called as
    theme("pager", ...) to get a pager.
2003-12-08 18:30:20 +00:00
Dries Buytaert 3904790e03 - Tidied up the DoxyGen comments. Patch by Kjartan. 2003-12-08 06:32:19 +00:00