Commit Graph

2818 Commits (445ea0fe35675f3db3122383fc9d5e149c3ae2dc)

Author SHA1 Message Date
Alex Pott b69a33ede2
Issue #3161223 by andypost, longwave, Hardik_Patel_12, alexpott, jungle, dww: Use PHP 7.0 "spaceship" operator for user sort functions where possible 2021-10-20 10:23:57 +01:00
Alex Pott db660b74e4
Issue #3008138 by mohit_aghera, jncruces, chetanbharambe, Kristen Pol, Lendude: The link url in views must be translatable 2021-10-18 17:38:53 +01:00
Alex Pott 53e5e3382c
Issue #2909370 by Spokje, mfernea, neclimdul, zaporylie, quietone, xjm, osman, BartoszUrbaniak: Fix 'Drupal.Commenting.VariableComment.IncorrectVarType' coding standard 2021-10-18 16:40:04 +01:00
Alex Pott 47c2f348cf
Issue #3116481 by joachim, daffie: Convert EntityViewsDataTest from a unit test to a kernel test 2021-10-18 11:18:40 +01:00
Alex Pott 32eb238f75
Issue #3231861 by Lendude, GuyPaddock: PHP errors when overriding the query settings 2021-10-18 10:56:59 +01:00
catch 789895fdbe Issue #3241280 by alexpott, Lendude: Fix PHP 8.1 deprecations caused by views code 2021-10-08 13:38:41 +01:00
catch 9da1866da4 Issue #3232673 by alexpott, longwave, Berdir, andypost: \Drupal\Core\Entity\EntityInterface::label() can return a NULL 2021-09-30 12:15:17 +01:00
catch a9de16441d Issue #3239313 by alexpott, larowlan: \Drupal\views\Controller\ViewAjaxController causes deprecations on PHP 8.1 2021-09-27 09:53:45 +01:00
Alex Pott eb2ed2340f
Issue #3132145 by mohit_aghera, codersukanta, osab, mashot7, Lendude: Views contextual filter: "allow multiple" doesn't work for user roles filter 2021-09-25 17:58:58 +01:00
catch 8e56a52772 Issue #3236798 by alexpott: \Drupal\Core\Datetime\DateFormatter::formatInterval() causes deprecations in PHP 8.1 2021-09-21 17:31:02 +01:00
catch 1b66ab0cb3 Issue #3130606 by shaktik, mondrake, KapilV, longwave, daffie: MockBuilder::setMethods is deprecated in PHPUnit8 and removed from PHPUnit10 2021-09-13 17:23:15 +01:00
Alex Pott 84fc7490b1
Issue #2938969 by msankhala, dhirendra.mishra, paulocs, TR, MerryHamster, alexpott, jofitz, longwave, Manuel Garcia, tameeshb, boaloysius, Yasiru Nilan, xjm, wturrell, ritzz, ZeiP, darrenwh: Replace drupal_render() in docblock and comments outside of @param, @return, @link, @see and outside of @code - @endcode 2021-09-12 18:18:58 +01:00
Lee Rowlands 1eae8e8ff3
Issue #3230690 by Anul: Incorrect documentation in Drupal\views\Plugin\views\display::viewExposedFormBlocks)() 2021-09-09 09:57:34 +10:00
catch e1ab113380 Issue #2794261 by longwave, andypost, Oleksiy, Mile23, pguillard, sorlov, voleger, jurgenhaas, Chi, borisson_, paulocs, Wim Leers, Berdir: Deprecate render() function in common.inc 2021-09-07 15:46:36 +01:00
catch 6951f4d77a Issue #3225328 by mxr576, Berdir, longwave: Improve page performance by sorting cache contexts/tags on-demand 2021-08-27 12:36:31 +01:00
catch 492b7a181d Issue #2473875 by znerol, alexpott, andypost, kim.pepper, amit.drupal, raman.b, martin107, joachim: Convert uses of $_SESSION to symfony session retrieved from the request 2021-08-18 09:53:24 +01:00
Lauri Eskola 8a40e42714
Issue #3183149 by nod_, droplet, jptaranto: Deprecate jquery.once and use the new once lib 2021-08-10 13:05:02 +03:00
catch 7af1ea2e69 Issue #3139409 by mondrake, nitesh624, ridhimaabrol24, shobhit_juyal, mohrerao, Hardik_Patel_12, paulocs, ravi.shankar, munish.kumar, mrinalini9, alexpott: Replace usages of AssertLegacyTrait::assertRaw, that is deprecated 2021-08-09 21:40:23 +01:00
catch 604fee30da Revert "Issue #3139409 by mondrake, nitesh624, ridhimaabrol24, shobhit_juyal, mohrerao, Hardik_Patel_12, ravi.shankar, munish.kumar, mrinalini9, alexpott: Replace usages of AssertLegacyTrait::assertRaw, that is deprecated"
This reverts commit 71e8db1949.
2021-08-09 14:50:34 +01:00
catch 71e8db1949 Issue #3139409 by mondrake, nitesh624, ridhimaabrol24, shobhit_juyal, mohrerao, Hardik_Patel_12, ravi.shankar, munish.kumar, mrinalini9, alexpott: Replace usages of AssertLegacyTrait::assertRaw, that is deprecated 2021-08-09 11:21:51 +01:00
catch 0aed1298a1 Issue #3226008 by longwave, mondrake: Remove simple uses of t() in assertEquals() calls 2021-08-09 10:29:45 +01:00
catch e33e4c71c4 Issue #3227060 by mondrake, daffie: Replace usages of AssertLegacyTrait::assertNoRaw, that is deprecated 2021-08-06 11:12:32 +01:00
catch a227db1833 Issue #3021833 by pavnish, andypost, munish.kumar, kim.pepper, googletorp, swatichouhan012, daffie, Berdir, alexpott, xjm: Move FILE_STATUS_PERMANENT to \Drupal\file\FileInterface 2021-08-06 08:54:08 +01:00
catch 89da8c8d52 Issue #3170396 by mondrake, longwave: Remove uses of t() in assert(No)Raw() calls 2021-08-06 08:21:30 +01:00
catch 6f48525b43 Issue #3220255 by mondrake, longwave: Convert assertions involving use of xpath on links to WebAssert 2021-08-06 07:52:55 +01:00
catch bcfecbbfa6 Issue #3131900 by mondrake, longwave, xjm, alexpott: Refactor assertions that assign return values to variables 2021-08-05 09:19:46 +01:00
catch 068f00c4c9 Issue #3191935 by mondrake, tedbow, xjm, alexpott, longwave: Replace usages of AssertLegacyTrait::assertNoText, which is deprecated 2021-07-28 14:41:19 +01:00
catch 6335af17b4 Issue #3221312 by Spokje: ->willReturn(...) would make more sense here 2021-07-28 11:57:46 +01:00
catch 686951d3c9 Issue #3153469 by longwave, hmendes, Hardik_Patel_12: Remove uses of t() in clickLink() calls 2021-07-28 08:48:45 +01:00
Alex Pott 1110b04d14
Issue #2347783 by kim.pepper, andypost, almaudoh, gumanist, aleevas, rodrigoaguilera, Berdir, saurabh-2k17, Spokje, dhirendra.mishra, alexpott, paulocs, izus, Wim Leers, KapilV, naveenvalecha, anmolgoyal74, subson, yo30, harsha012, mrinalini9, daffie, voleger, dww, fietserwin, tim.plunkett, joachim, larowlan: Deprecate drupal_get_path() and drupal_get_filename() and replace with ExtensionList::getPath() and ExtensionList::getPathname() 2021-07-15 11:20:33 +01:00
Alex Pott 0926b0cc7c
Issue #3221933 by marcoscano, alexpott, owenbush: PHP Notice when using "left_formula" in views join 2021-07-10 09:58:37 +01:00
Lee Rowlands cffb02aad6
Issue #2571235 by alexpott, claudiu.cristea, dawehner, Wim Leers, gabesullice, IJsbrandy, benjifisher, alisonjo315, larowlan, Berdir, effulgentsia, longwave, herom, dmouse, heddn, catch: [regression] Roles should depend on objects that are building the granted permissions 2021-07-09 14:50:54 +10:00
catch 3fb0eded18 Issue #2560447 by bojanz, longwave: Remove the undocumented, untested views_form_callback API 2021-07-08 08:09:32 +01:00
catch 953fef703f Issue #3222009 by Jaypan: Fix documentation for hook_views_query_alter() 2021-07-05 16:55:19 +01:00
Alex Pott 4e5f54f439
Issue #3195178 by mstrelan, Lendude, Graber, tobiberlin, texas-bronius: Views table format sorting + distinct results in a SQL error on some db engines 2021-07-05 11:23:54 +01:00
effulgentsia 54781848a0 Issue #1551534 by Lendude, vsujeetkumar, neclimdul, b_sharpe, devert, bcn, henkholtrop, heykarthikwithu, richmac, seanB, casey, mishac, alansaviolobo, idebr, lauriii, dawehner, alexpott, BramDriesen, randell, ilya.no, muka, DamienMcKenna, Dom., dnewkerk, tim-diels, natted, slayne40, Spry_Julia, Jibus, cpliakas, pbouchereau, S3b0uN3t, HongPong, rfbrandsma, grantkruger, sanderwind, borisson_, nerdacus, mglaman, mvwensen, jmickela, droplet: Submit buttons themed as <button> element fail to trigger ajax in Views exposed forms 2021-06-30 11:13:20 -07:00
xjm c1179c9377 Issue #3217717 by longwave, mondrake, tim.plunkett, xjm: Replace usages of the at() matcher, which is deprecated 2021-06-28 16:09:48 -05:00
catch d3dabc4603 Issue #2897638 by Spokje, claudiu.cristea, istavros, PaulDinelle, drclaw, Giuseppe87, KapilV, Lendude: Views exposed sort identifiers are not configurable 2021-06-28 13:24:26 +01:00
catch 7a5adddaf1 Issue #3021804 by andypost, scott_euser, YurkinPark, mrinalini9, voleger, Lendude, longwave: Remove optional dependency on menu_ui module in \Drupal\views\Plugin\views\wizard\WizardPluginBase 2021-06-28 13:14:34 +01:00
catch 67bfb63d9a Issue #3220183 by mondrake, longwave: Convert assertions involving use of xpath on labels to WebAssert 2021-06-28 11:57:18 +01:00
catch 33ba45820a Issue #2719649 by Spokje, harsha012, jofitz, vprocessor, nikitagupta, cburschka, rasikap, hitesh-jain, quietone, longwave, mfernea, andypost, klausi, Malevi4, crazyrohila: Fix 'Drupal.Commenting.InlineComment.SpacingBefore' coding standard 2021-06-24 13:35:45 +01:00
catch 9f8f38d82a Issue #2681947 by vasi1186, dan2k3k4, Leksat, Lendude, raman.b, yogeshmpawar, quietone, keszthelyi, Abhijith S, pameeela, claudiu.cristea, alexpott, NickDickinsonWilde: Allow 'Put the exposed form in a block' setting to be used with views block displays 2021-06-24 11:27:42 +01:00
Lee Rowlands b796e3779b
Issue #2511892 by bserem, rachel_norfolk, hussainweb, ravi.shankar, mikeker, catch, vensires, Lendude, alexpott: MissingMandatoryParametersException error on views with menu tab and % in the path 2021-06-22 06:46:30 +10:00
catch 1d5e219f85 Issue #3156396 by TR, pavnish, mondrake, longwave, catch, jungle: Use assertSameSize() to check same size of two countable variables 2021-06-21 12:31:24 +01:00
catch e48dcff470 Issue #2879159 by Spokje, LoMo, ravi.shankar, quietone, mondrake: Some calls to assertEquals have expected/actual parameters reversed 2021-06-21 11:27:34 +01:00
Lee Rowlands 93d251d78a
Issue #2716019 by joseph.olstad, rodrigoaguilera, _Archy_, Lendude, mdupont, anmolgoyal74, mpp, Krzysztof Domański, DamienMcKenna, adityasingh, Skymen, benelori, Suresh Prabhu Parkala, rensingh99, alexpott, paulocs, HeyJo, iiRealXz, dawehner, xjm, 5n00py, tstoeckler, Karsa, dbyers55, idebr: View titles in breadcrumb and metatag title don't get properly translated 2021-06-14 17:28:27 +10:00
Alex Pott 9306f06914
Revert "Issue #3162016 by longwave, andypost, Hardik_Patel_12, catch, alexpott, daffie, Kristen Pol: [Symfony 6] Retrieving a non-string value from "Symfony\Component\HttpFoundation\InputBag::get()" is deprecated"
This reverts commit 8b8fc1eff7.
2021-06-02 17:42:53 +01:00
Alex Pott 8b8fc1eff7
Issue #3162016 by longwave, andypost, Hardik_Patel_12, catch, alexpott, daffie, Kristen Pol: [Symfony 6] Retrieving a non-string value from "Symfony\Component\HttpFoundation\InputBag::get()" is deprecated 2021-05-27 21:07:25 +01:00
catch 3066423e43 Issue #3186661 by Spokje, longwave, mondrake, paulocs, daffie: [May 24, 2021] Remove usage of drupalPostForm 2021-05-24 14:27:52 +01:00
catch f3ad0680a3 Issue #3133162 by jungle, ravi.shankar, Deepak Goyal, Neslee Canil Pinto, anmolgoyal74, xjm, Kristen Pol: Replace the start verb Test with Tests in method comments of tests 2021-05-24 14:26:11 +01:00
Alex Pott 3872f1a8ed
Issue #3139404 by mondrake, munish.kumar, pavnish, longwave: [May 25, 2021] Replace usages of AssertLegacyTrait::assertText, that is deprecated 2021-05-20 22:10:07 +01:00
Alex Pott 4a72cc3169
Issue #3207734 by Spokje, quietone: Fix Drupal.Commenting.InlineVariableComment 2021-05-20 21:47:18 +01:00
Alex Pott 3f75f72de2
Issue #3131281 by mondrake, rahulrasgon, longwave, ridhimaabrol24, naresh_bavaskar, jungle, daffie: [May 17th 2021] Replace assertEqual() with assertEquals() 2021-05-20 00:39:14 +01:00
catch 8db131bd38 Issue #3214412 by bnjmnm, tedbow: Build + prettier not run after yarn dependency update 3210633 2021-05-17 21:30:23 +01:00
catch 13c5855165 Issue #3211838 by mondrake, longwave: Convert assertions involving use of xpath on spans to WebAssert 2021-05-17 20:04:19 +01:00
catch 35021980e1 Issue #2909369 by Spokje, alexpott, longwave, mfernea: Fix 'Drupal.Commenting.VariableComment.WrongStyle' coding standard 2021-05-13 20:26:47 +01:00
Lee Rowlands 1ab0f4844b
Issue #2868258 by joegraduate, Lendude, Jons, dawehner, alexpott, larowlan: Missing View not helpfully reported in preRenderViewElement() 2021-05-12 16:53:45 +10:00
catch f09730b523 Issue #3212521 by Spokje, longwave: cspell dislikes identifer in core/modules/views/src/Plugin/views/filter/FilterPluginBase.php and will fail any patch touching that file 2021-05-06 12:12:26 +01:00
catch 9c2bfa8df0 Issue #3203476 by mondrake, longwave, alexpott: Convert assertions involving use of xpath on divs to WebAssert 2021-04-28 11:08:17 +01:00
catch e7fadb0559 Issue #2937882 by Spokje, RoSk0, longwave, quietone: Fix 'Drupal.Classes.PropertyDeclaration' coding standard 2021-04-26 21:24:04 +01:00
Lee Rowlands 10fc602385
Issue #2823914 by danflanagan8: Render caching in DisplayPluginInterface::buildRenderable is broken when arguments are provided 2021-04-26 18:53:30 +10:00
Lee Rowlands db3ad8f8b2
Issue #2189411 by alexpott, dawehner, longwave, quietone: Remove an unnecessary container rebuild from FunctionalTestSetupTrait 2021-04-26 18:44:34 +10:00
Lee Rowlands cdf0726ead
Issue #3204763 by longwave: Fix mismatched sprintf calls 2021-04-24 13:37:42 +10:00
Nathaniel Catchpole 9a3bb08a41 Issue #3109110 by andypost, KapilV, Lendude: Deprecate request argument for view time cache plugin 2021-04-16 09:35:21 +01:00
catch 21c0c457d6 Issue #3136107 by himanshu_sindhwani, lauriii, Spokje, RoshniPatel.addweb, ranjith_kumar_k_u, Bunty Badgujar, generalredneck, nod_, jcmartinez: Wrapper gets removed while adding html textfield or textarea using replacement patterns 2021-04-13 23:11:04 +01:00
Alex Pott 93084ba962
Issue #3123058 by longwave, jungle, xjm, daffie: Fix 'Drupal.Commenting.DocComment.ParamGroup' coding standard 2021-04-09 00:20:05 +01:00
catch 14d175470c Issue #3207119 by longwave: Fix 'Squiz.WhiteSpace.ScopeKeywordSpacing' coding standard 2021-04-05 08:05:00 +01:00
catch fd3efb7f6b Issue #3207086 by benjifisher, larowlan, mondrake, Spokje: [HEAD BROKEN] Consistent failure in MonthDatePluginTest 2021-04-04 08:56:46 +01:00
Alex Pott 08766c5dee
Issue #2903911 by joshmiller, longwave, anmolgoyal74, ankithashetty, init90, Pooja Ganjage, _gradient_, daffie, borisson_: Fix 'Drupal.Commenting.FunctionComment.ParamMissingDefinition' coding standard 2021-03-29 16:22:14 +01:00
catch 7e922b6dd6 Issue #3201393 by Lendude, dww, imalabya, dawehner, anmolgoyal74, Abhijith S: Filter glossary view by status 2021-03-23 10:22:03 +00:00
catch 7e1043ea1d Issue #3204764 by longwave, mondrake: PHPUnit assertions do not return a value 2021-03-22 10:00:18 +00:00
catch 439c314fa4 Issue #3187113 by longwave: Remove uses of t() in submitForm() calls 2021-03-11 15:03:07 +00:00
Alex Pott aec4b3a15e
Issue #3165784 by johnwebdev, boch, longwave, al.iv: LogicException: Cannot use UTF-8 route patterns without setting the "utf8" option for route 2021-03-05 13:21:54 +00:00
catch 08cddd893a Revert "Issue #3187113 by longwave: Remove uses of t() in submitForm() calls"
This reverts commit febe06ca57.
2021-02-24 16:06:22 +00:00
Nathaniel Catchpole febe06ca57 Issue #3187113 by longwave: Remove uses of t() in submitForm() calls 2021-02-24 15:46:48 +00:00
Alex Pott 203ad064e4
Issue #2723621 by jofitz, mfernea, alexpott, abhisekmazumdar, neclimdul, snehi, Suresh Prabhu Parkala, ankithashetty, anmolgoyal74, anoopjohn, longwave, hgunicamp, empesan, kostyashupenko, Mile23, dawehner, idebr, daffie, catch: Fix Drupal.Commenting.FunctionComment.IncorrectTypeHint and Drupal.Commenting.FunctionComment.InvalidTypeHint 2021-02-20 13:24:51 +00:00
Alex Pott dddfc88551
Issue #2470753 by ayushmishra206, wizonesolutions, Lendude, longwave: Views documentation for views_data is misleading 2021-02-16 10:57:31 +00:00
catch 172e4b5acb Issue #3189607 by Spokje, longwave, Pooja Ganjage, anmolgoyal74: Convert assertions involving use of xpath on checkboxes to WebAssert 2021-02-15 09:53:31 +00:00
Alex Pott 3ac9df1366
Issue #2002514 by dawehner, mondrake, damiankloip, RobLoach, ParisLiakos, joachim, Krzysztof Domański, gaurav.kapoor, chx, alexpott, tim.plunkett, Mile23, daffie: Deprecate debug(); remove references to _drupal_debug_message() 2021-02-15 09:51:17 +00:00
catch 197b2406a5 Issue #3197886 by daffie: The ViewsPluginAnnotationBase does not need to implement the AnnotationInterface 2021-02-12 11:32:46 +00:00
catch 3ce319d6a2 Issue #3187309 by longwave, Spokje, ayushmishra206, adityasingh, mondrake: Convert assertions involving use of xpath on select and option elements to WebAssert 2021-02-12 10:04:12 +00:00
Alex Pott c4d6699d96
Issue #3161983 by catch, longwave, Pooja Ganjage, sanjayk, daffie, Kristen Pol, dww, Gábor Hojtsy: [Symfony 6] Update EventDispatcherInterface type hints in constructors 2021-02-10 09:24:10 +00:00
Alex Pott 33700d0162
Issue #3193163 by mondrake, longwave: Deprecate AssertLegacyTrait::verbose and remove its usage 2021-02-09 16:09:11 +00:00
Alex Pott 9f7b53f058
Issue #3196433 by ayushmishra206, erricha, quietone: Link to php.net datetime formats documentation incorrect in FieldDateTest.php 2021-02-05 19:26:13 +00:00
catch 4f781e8292 Issue #2223195 by Lendude, anmolgoyal74, sulfikar_s, alexpott, larowlan, dpearcefl, dww: Views "Global: Custom text" field handler should not be sortable 2021-01-28 11:49:48 +00:00
catch afd86e7d3c Issue #3193955 by mondrake, daffie, catch: Swap assertEqual arguments in preparation to replace with assertEquals 2021-01-28 09:57:41 +00:00
catch 0b1816c9a3 Issue #3122912 by shaktik, siddhant.bhosale, S_Bhandari, martin107, swatichouhan012, kapilkumar0324, raman.b, paulocs, longwave, quietone, xjm: t() calls should be avoided , use $this->t() instead in Form Builders 2021-01-22 09:36:50 +00:00
catch 4634506480 Issue #3000383 by drunken monkey, mbovan, anushrikumari, alexpott, ravi.shankar: Assert the current path on Views AJAX requests is not set with two leading slashes 2021-01-22 09:23:26 +00:00
catch 6c64763741 Issue #2867959 by mondrake, danielnv18, xjm, ZeiP, daffie: Replace usages of deprecated AssertLegacyTrait::assertIdentical 2021-01-21 10:01:43 +00:00
catch 2ef2387216 Issue #3193600 by ankithashetty, mondrake, daffie: Convert assertEqual() calls involving NULL, TRUE and FALSE to more appropriate PHPUnit assertions 2021-01-20 21:23:44 +00:00
catch d722e9d760 Issue #3192221 by mondrake, daffie, longwave: Swap assertIdentical arguments in preparation to replace with assertSame 2021-01-18 17:35:30 +00:00
catch 39bacf4426 Issue #3192427 by mondrake, daffie: Replace usages of deprecated AssertLegacyTrait::assertNotEqual 2021-01-18 16:16:33 +00:00
catch b7dd784a24 Issue #3192553 by mondrake, longwave: Convert assertIdentical(NULL..) to assertNull(...) 2021-01-15 09:24:13 +00:00
catch 40e34c8bcb Issue #3012704 by raman.b, quicksketch, drclaw, keesje, alexpott, Lendude: "Items per page" checkbox does not stay checked in Views UI when creating a block display 2021-01-11 22:07:45 +00:00
catch e4e0d0b44b Issue #2784739 by slasher13, daffie, miiimooo, voleger, MerryHamster, chanderbhushan, anmolgoyal74, mohit1604, Prashant.c, Meenakshi.g, kostyashupenko, Juterpillar, sylvain lavielle, gawaksh, Lendude, mradcliffe, andypost, alexpott: Fix PostgreSQL operator in views 2021-01-11 20:40:06 +00:00
catch c2e91dccb3 Issue #3191986 by mondrake, daffie: Replace usages of deprecated AssertLegacyTrait::assertNotIdentical 2021-01-11 15:06:17 +00:00
catch 9ac7689b1a Issue #3159788 by mondrake, ravi.shankar, narendra.rajwar27, longwave, Hardik_Patel_12, ankithashetty, sarvjeetsingh, kishor_kolekar: AssertLegacyTrait::assert(No)Text() in functional tests still have a message passed in 2021-01-11 10:24:10 +00:00
catch e92a4080d8 Issue #3162822 by quietone, jungle, Abhijith S, catch, longwave: Fix words with 'reference' 2021-01-08 12:47:14 +00:00
Alex Pott d78e53bb0b
Issue #3189880 by mondrake, raman.b, Pooja Ganjage, daffie, Megha_kundar, dww, S_Bhandari: Use square brackets syntax in sql queries 2021-01-05 15:02:37 +00:00
catch fbabffd441 Issue #2917584 by kristiaanvandeneynde, Spokje, catch, xjm, daffie, larowlan: Some tests only go green because they happen to run as UID1 2021-01-04 09:34:33 +00:00