Commit Graph

71 Commits (408bf86abd18c61bb70ed28b2045d07c599a91b2)

Author SHA1 Message Date
Dries Buytaert 408bf86abd - Usability improvement; the drop-down menu showed the first vocabulary in
the list even though it has not been selected.  Reported by Adam Shand.
2003-01-02 23:26:43 +00:00
Dries Buytaert de95001c92 - Tidied up the use of check_output(). Might make rendering pages a bit
snappier (performance improvement).
2002-12-31 12:34:07 +00:00
Dries Buytaert cc01e61388 - Bugfix: user_save() should not be called for anonymous users. Patch by
Marco.
2002-12-30 09:26:05 +00:00
Dries Buytaert d21ba6b0f1 - Fixed glitch with the "leave shadow" option. 2002-12-21 15:53:30 +00:00
Dries Buytaert 623aaed148 - Made sure the taxonomy module doesn't display warning/error messages
when the taxonomy module is disabled.  Reported by kyvinh.

- Improved forum documentation.  Modified version of Kjartan's patch.

TODO:

- Updating a forum topic through the admin interface, results in a
  duplicate (and incomplete) forum topic.  Also note that "Leave
  shadow?" function is annoying; the status of the checkbox is lost
  when clicking preview.  Also, I think it should be disabled be
  default.
2002-12-18 21:43:03 +00:00
Kjartan Mannes bbcf3c13fd - Forum no longer counts comments from deleted nodes. 2002-12-15 23:24:02 +00:00
Dries Buytaert ad80f143dc - Fixed bug related to recent cache changes. 2002-12-14 23:23:35 +00:00
Dries Buytaert b6b24c28e0 Applied patch by Natrak:
- page_header() now adds Last-Modified and ETag http headers.
- When running PHP as an Apache module page_header() will check the HTTP
  headers for conditional gets, and will only push the content when it
  fails. (Works for html and xml pages as they are all cached). Note:
  this is a PHP limitation, so until PHP makes it work for other web
  servers this won't work for them.
- Added created field to cache database to hold the timestamp when the
  cache was created.
- Changed cache_get() to return an object with ->data and ->created.
- Update forum and locale modules.
2002-12-11 22:00:04 +00:00
Dries Buytaert 7ce686c152 o Permission improvements:
+ Removed the "post content" permission and replaced it by more fine-grained permissions such as "maintain static pages", "maintain personal blog", "maintain stories", etc.

o Usability improvements to teasers:

   + Teaser forms are no more.  Teasers are extracted automatically but can also be instructed using a delimiter "---".  Furthermore, when a post it too short for a teaser, the user won't be bother with teaser stuff anymore.

   + Added an option to set the teaser length, or to disable teasers all together.

   + When previewing a post, both the short (if any) and the full version of a post are shown.  This addresses a common complaint; for example, when writing a book page there was no way you could preview the short version of your post.

   + Forum posts can be teasered now.  This is particularly helpful in the context of drupal.org where we promote forum topics.

o Bugfix: replaced all PHP short tags (<?) with long tags (<?php).

o Bugfix: removed hard-coded dependence on comment module.

o Bugfix: when the queue module was disabled, it was not possible to approve updated book pages.

o Bugfix: applied modified version of Marco's node_teaser() fix.
2002-12-10 20:35:20 +00:00
Dries Buytaert 5b39f6767e * Applied slightly modified version of Marco's taxonomy patch:
- Fixed a bug with get_tree and multiple parents.
 - Fixed 3 wrong caches (this will avoid some queries).
 - Extension to taxonomy_term_count_nodes() (feature #159): "currently
   calling taxonomy_term_count_nodes() returns the amount of nodes in each
   term, would it be possible to extend this function so that it would only
   return the amount of nodes of a certain type under each term.
 - Confirm deleting a vocabulary or a term (requested by Moshe).
 - Use form_weight() in vocabulary and term forms.
 - After submitting a term, we end up at the term page (requested by Moshe).
 - Added status messages when adding, editing and deleting vocabularies and
   terms
 - Minor clean ups

* Made sure all modules use the same link delimiter; "|" for now.
2002-12-02 19:14:41 +00:00
Dries Buytaert 1d63fec89b - Applied Stefan's forum module patch: changed the default settings to ease
configuration.
2002-11-26 20:51:36 +00:00
Dries Buytaert 3d05bf4948 - Fixed the forum block titles such that the username is displayed correctly.
Reported by Jeremy.
2002-11-26 19:54:23 +00:00
Dries Buytaert 9e32c2e960 Patch based on work of Kjartan:
- Changed cache API.

- Fixed caching bug in comment.module.  Odd this hasn't been reported yet.

- Fixed caching bug in forum.module.

- Fixed caching bug in system.module.

- Fixed caching bug in block.module.

- Simplified caching support in forum.module thanks to improved cache API.
2002-11-17 06:42:52 +00:00
Dries Buytaert a6c8b10d8e Applied Moshe's patches:
- Adds more title info to each line in the block: now showing author and number of comments in a unified way accross all modules.

- Added pager support to blog module.

- Blog module now uses standard node view, not its own hack which is more theme friendly (http://www.drupal.org/node.php?id=133).

- Blog module now uses node_feed() function for making RSS feeds. since all feeds are now consolidated, a couple tweaks to node_feed() and format_rss_* would lead us to support new RSS formats easily.

- Fixed bugs where unpublished entries were displayed.
2002-11-11 20:59:28 +00:00
Dries Buytaert 562df8fe43 * Added Jeremy's pager:
"This is a simple, generic pager for Drupal-CVS.  It is designed to be
  easily themeable and expandable.  The code is highly-commented to
  enhance readability."

 "Pagers are constructed by combining the provided pieces (all of which
  can be easily modified to display the text or image you prefer) into
  your custom pager."

* Statistics module fixes by Jeremy:

 - removed superfluous check for existence of watchdog()
 - saving changes in admin page displays status and returns same page
 - no longer return 1971/01/01 in "view statistics" table
 - switched from "!=" to "<>" in SQL queries for ANSI-SQL compliance
 - switched from "MAX(timestamp) as timestamp" to "MAX(timestamp) as
   max_timestamp" moving towards ANSI-SQL compliance.

* Added a "theme_item_list" function to format itemized lists.  Also
  changed a couple of modules to take advantage of it.  Makes for a
  more consistent UI.
2002-11-09 13:59:36 +00:00
Kjartan Mannes 756639bc4b - removed next/prev links when forum node is shown on main page.
- title is no longer modified when shown on main page.
- commented out a chunk of code in forum_view that is no in use.
- coding sytle fixes.
2002-11-08 13:23:29 +00:00
Dries Buytaert 2fe5a68baf - Removed the hard-coded font scaling. 2002-11-08 11:20:55 +00:00
Dries Buytaert cc381c1461 - Fixed glitch in block module: the admin links were not composed
correctly.  Patch by Stefan.

- Added missing t() functions and improved the %x directives for
  better readability and to ease the process of translating your
  site.  Patches by Stefan.

- Made two small additions to the 'code-clean.sh' script; it will
  now remove patch related junk.

NOTES:

- I removed the &middot; related bits.  Let's tackle these later on
  in a separate patch after we got some sort of consensus.

- I removed the 'module_exist("drupal")' check in the user module;
  I *think* it is incomplete and therefore incorrect.

- Stefan, try using quotes in your translations and check whether
  everything still works.  Example: translate the "Create account"
  button to "Create \"haha\" account \'hihi\'" and see if you can
  still create new accounts.  Maybe automate this using a quick
  hack in the locale module ...
2002-11-01 10:47:20 +00:00
Kjartan Mannes 8eed5abd86 - Fixing blocks for forum, queue and statistics. 2002-10-28 19:36:37 +00:00
Dries Buytaert 980f0700a1 - Fixed bug with "jump to recent comment" link.
- Fixed bug with "nex topic" and "previous" topic links.

- Removed "admin"-hook all together.
2002-10-16 18:38:33 +00:00
Dries Buytaert 0c42ca27a0 - Small improvement to the forum module block. 2002-10-16 18:23:39 +00:00
Dries Buytaert 904a6172b0 - Made some usability improvements. Needs more work but I had my take for
today ...
2002-10-13 15:05:35 +00:00
Dries Buytaert b2a5a897cb - Applied Moshe's forum.module patch. 2002-09-17 18:29:47 +00:00
Dries Buytaert 92326261d1 - Commited Marco's new comment module and forum module!!! 2002-09-15 13:00:12 +00:00
Steven Wittens 80a6b15942 Some small corrections to the system descriptions (as discussed in mailinglist) 2002-06-04 11:44:23 +00:00
Kjartan Mannes 4a28077f46 - adding descriptions to modules (thanks Joe + Scott).
- fixed comment flat list view missing 1 comment.
- changed update.php around a bit.
    * security check isn't in effect if the db hasn't been updated.
    * instructions re-organized.
    * fixed some minor updates.
- updated database.mysql done by UnConeD.
- changelog update.
2002-06-01 21:57:29 +00:00
Dries Buytaert 38aaf5f35d - Added missing translations and the like. 2002-05-31 20:29:30 +00:00
Kjartan Mannes 66e1bbfb93 - pending user accounts will not be notified to the site_email.
- fixed access checks on the register form, do this before you enter the
  _save function. If registrations are disabled the register link will
  no longer show (again).
- changed &#187 to &raquo, using the names of entities are better than
  the numbers.
- fixed user information being set when account is registered (properly this
  time, really!)
- reversed the if(!...) commit.
- node_add specifies more defaults.
- added link to blog entries from user page.
2002-05-23 14:14:48 +00:00
Kjartan Mannes 5f6d733b70 - node security fixes.
- fixing the UI to represent what actually happens when you are an admin.
2002-05-22 23:28:48 +00:00
Kjartan Mannes c9871b7814 - updating all nodes to use taxonomy terms.
- updated node modules not to cause errors when taxonomy module is disabled.
- added %date variable to user mail configuration.
- added hyperlinks to admin.php?mod=system (site configuration) for easy access.
- usual coding style and xhtml fixes.
2002-05-19 23:05:05 +00:00
Kjartan Mannes f86a944979 - applied Stevens link patch.
- fixed block permissions.
- fixed user admin page errors: http://www.drupal.org/node.php?id=173.
- cleaned up common.inc a bit: removed format_info, path_img, field_merge.
2002-05-12 15:40:57 +00:00
Kjartan Mannes 69ec1a6996 - making sure the nodes call filter(). 2002-05-04 18:56:43 +00:00
Kjartan Mannes de5b9a168d - bug fixes:
* fixed mails not being parsed properly.
    * tracker now shows user name when you view your own recent
      comments.
    * link to submission queue now points to the right place.
    * fixed jabber module.
    * theme is now activated when changed.
- applied Gerhards coding style patch.
2002-04-22 09:05:36 +00:00
Dries Buytaert 8043cb998f - Applied Marco's big patch, including contributions from Moshe:
+ Changed the db_query() API.

    + Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.

    + XHTML-ified some HTML.

    + Wrapped a lot of text in the administrative pages in a t()
      function.

    + Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().

    + Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
      RSS code).

    + Fixed some bugs in the taxonomy module (eg. tree making bug), added
      new functionality (eg. new APIs for use by other modules), included
      Moshe's taxonomy extensions, and some documentation udpates.

    + ...
2002-04-20 11:52:50 +00:00
Dries Buytaert c1c612b128 - Made the calendar module accept a $date parameter such that you
can jump directly to a certain date in the archives.  Also made
  the calendar link to itself such that it is self-contained.

- Code beautifications: quoted a lot of arrays, removed dead code
  and simplified a few things.

- Replaced the Calendar class by one function "calendar_display":
  using a class (or class instance, or object) doesn't make sense
  in the archives' case.

- Renamed "calendar.module" to "archive.module".

- Fixed a /problem/ with node settings not always being saved like
  expected.

- Reorganized the user menu: renamed a couple of links for clarity
  and structure.

- Fixed a few typos.
2002-01-31 20:23:44 +00:00
Dries Buytaert 47daf7f006 - Added some more explanations. 2002-01-12 12:51:21 +00:00
Dries Buytaert a95c2a68aa - import.module:
+ Improved input filtering; this should make the news items look
      more consistent in terms of mark-up.

    + Quoted all array indices: converted all instances of $foo[bar]
      to $foo["bar"].  Made various other changes to make the import
      module compliant with the coding style.

- theme.inc:

    + Fixed small XHTML glitch

- comment system:

    + Made it possible for users to edit their comments (when certain
      criteria are matched).

    + Renamed the SQL table field "lid" to "nid" and updated the code
      to reflect this change: this is a rather /annoying/ change that
      has been asked for a few times.  It will impact the contributed
      BBS/forum modules and requires a tiny SQL update:

        sql> ALTER TABLE comments CHANGE lid nid int(10) NOT NULL;

    + Moved most (all?) of the comment related logic from node.php to
      comment.module where it belongs.  This also marks a first step
      towards removing/reducing "node.php".

    + Added a delete button to the comment admin form and made it so
      that Drupal prompts for confirmation prior to deleting a comment
      from the database.  This behavior is similar to that of deleting
      nodes.

    + Disabled comment moderation for now.

    + Some of the above changes will make it easier to integrate the
      upcomcing mail-to-web and web-to-mail gateways.  They are part
      of a bigger plan.  ;)

- node system:

    + Made it so that updating nodes (like for instance updating blog
      entries) won't trigger the submission rate throttle.

    + Fixed a small glitch where a node's title wasn't always passed
      to the $theme->header() function.

    + Made "node_array()" and "node_object()" more generic and named
      them "object2array()" and "array2object()".

    + Moved most (all?) of the comment related logic from node.php to
      comment.module where it belongs.  This also marks a first step
      towards removing/reducing "node.php".

- misc:

    + Applied three patches by Foxen.  One to improve performance of
      the book module, and two other patches to fix small glitches in
      common.inc.  Thanks Foxen!
2001-12-30 16:16:38 +00:00
Dries Buytaert e8ca5acdde - Fixed a typo. 2001-12-09 13:01:43 +00:00
Dries Buytaert 110da60f77 - Improved teaser handling. 2001-12-06 12:31:21 +00:00
Dries Buytaert 4205799ba3 - Added the "add new comment" link to the forum module. 2001-12-06 10:33:27 +00:00
Dries Buytaert 2db432e3d3 - Removed Windows line feeds ... 2001-12-05 18:46:24 +00:00
Kjartan Mannes 7d0c316f82 - fixed pass by reference errors. PHP only allows declaration of &$vars, not
passing them that way.
  For more info: http://no.php.net/manual/en/language.references.pass.php
2001-11-26 18:27:34 +00:00
Dries Buytaert ebb14ab94a - A couple of new node updates 2001-11-12 22:17:52 +00:00
Dries Buytaert 6642f2987e - node modules:
+ made some improvements to the node access checks

- queue module:
   + form()-ified the queue module and added some extra information
     or guidelines
   + added a few missing translations
   + ...
2001-11-12 20:15:08 +00:00
Dries Buytaert 234b40b253 - node system:
+ Added the "delete node"-link: apparently it got lost during the last
     commit.  Odd.

   + Changed "Edit node" to "Edit <node_name>" on the 'edit node'-page of
     the admin section.  (There a 4 "Node"s that still need to be removed
     though.)

   + Updated the initial submission page (the old submit.php) to include
     some descriptions.
2001-11-07 18:14:46 +00:00
Dries Buytaert a2e6910902 - Made the node forms support "help texts": it is not possible to configure
Drupal to display submission guidelines, or any other kind of explanation
  such as "NO TEST POSTS", for example.

- Added node versioning: it is possible to create revisions, to view old
  revisions and to roll-back to older revisions.  You'll need to apply a
  SQL update.

  I'm going to work on the book module now, so I might be changing a few
  things to enable collaborative, moderated revisions - but feel free to
  send some first feedback, if you like.

- Added some configuration options which can be used to set the minimum
  number of words a blog/story should consist of.  Hopefully this will
  be usefull to stop the (almost empty) test blogs.

- Various improvements:
   + Fine-tuned new node permission system.
   + Fine-tuned the functions in node.inc.
   + Fine-tuned some forms.
   + XHTML-ified some code.
2001-11-03 18:38:30 +00:00
Dries Buytaert 4d8b485fad - Added error handling support to the <node>_form hook. 2001-11-01 22:54:16 +00:00
Dries Buytaert 23ca7a2d88 - Another batch of updates/improvements:
+ introduced basic node permissions ("create", "delete", "update" and
     "view") at the node level: it's up to the "<$node->type>_module" to
     hide gory details (if any).

   + made the "blog it"-feature in the blog and import module work with
     the new node system, in specific with the new centralized forms.

   + made it possible to update blogs.

   + made the page module work with the new node system.

   + various smaller improvements.
2001-11-01 17:04:20 +00:00
Dries Buytaert 336b713a5f - A large batch of updates, amongst them a rewritten node system. More
information available on the mailing list.
2001-11-01 11:00:51 +00:00
Kjartan Mannes 864c18d4c3 - added the CVS keyword $Id$ to all files to make future version tracking
easier. Also changed the <? tag to <?php in some cases.
2001-10-20 18:57:09 +00:00