Commit Graph

128 Commits (3f2dd954050d3bc9e5762784e9713f56c79766d9)

Author SHA1 Message Date
Dries Buytaert d8f78a7c95 - Removed check_output() from the theme system layer. 2003-05-26 19:50:39 +00:00
Dries Buytaert 45d5aad6df - Updated Drupal to use "on output" filters. Derived from Gerhard's patch. 2003-05-24 16:26:13 +00:00
Dries Buytaert 9c43f5440e - Fixed some PostgreSQL issues. Reported by Michael.
- Removed some dead wood.
2003-05-18 07:01:37 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert 73d5cf8644 *** empty log message *** 2003-05-10 16:13:17 +00:00
Dries Buytaert a31c329735 - Patch by Marco:
+ Fixed bug 1544: comment_mod_matrix() was broken.

   + Emit tables using the table rendering functions.

   + Fixed a typo in the documentation/comments.

(Welcome back Marco!)
2003-05-10 14:43:22 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Dries Buytaert 3c2dc18c82 - Fixed bug #1545: incorrect sequence tables on PostgreSQL. Patch by Neil.
In addition, I have updated update.php so it makes the corresponding
  changes for MySQL users.
2003-04-20 20:33:28 +00:00
Dries Buytaert 2de4c1c643 - Node API improvements by Moshe:
"implemented pieces of kjartan's original nodeAPI patch. the mingling
  of other modules into node.module logic decreases (a good thing). for
  example, the string "taxonomy" now appears nowhere in node.module

  - moved the saving of taxonomy terms when submitting a node out of
  node.module and into taxonomy.module

  - moved the deletion of comments while deleting a node out of
  node.module and into comment.module

  - improved usability of node forms by including node type in the title
  of the box and page"
2003-04-15 19:50:04 +00:00
Dries Buytaert 2efb83ee57 - Changed 'empty()' to '!isset()' to fix a caching bug. Patch by Garry. 2003-04-13 18:33:01 +00:00
Dries Buytaert ec5aff0a0b - Fixed a bug in the "comment votes" _and_ "comment filters" page. Reported
by Paul C.

  TODO: someone should look into 'comment_mod_matrix()' - it uses a global
        variable $rid that is not set anywhere..
2003-03-29 20:05:07 +00:00
Dries Buytaert 4742ba3549 - Fixed some SQL query directives. 2003-03-29 16:30:40 +00:00
Dries Buytaert 59d36699d5 - Fixed 3 typos. 2003-03-16 12:33:18 +00:00
Dries Buytaert 170b674a09 - All LIMIT queries must go through the pager or through db_query_range().
The syntax for db_query_range() was enhanced so it matches db_query(). So
  you may pass extra arguments of the SQL statement which are checked via
  check_query() and then substituted into the SQL statement. After these
  optional arguments, you always pass $from and $count parameters which
  define your range.  Most often, the $from is 0 and the count is the max
  number of records you want returned.  Patch by Moshe.

- The pager_query() function for PEAR was enhanced so that it adds  proper
  GROUP BY statement counting the number of records to be paged. Patch by
  James Arthur.

- MSSQL database scheme by Moshe.
2003-03-16 07:02:20 +00:00
Dries Buytaert dc19b22fb8 - Modified patch of Moshe. Enhances the tracker module so it displayes recent
*nodes* in addition to comments.  This will be helpful for tracking down new
  book nodes, blog posts, news items, and other stuff which isn't interesting
  enough to be promoted to the home page.
2003-03-14 20:41:27 +00:00
Kjartan Mannes 1f81d0e222 - Fixing bug reported by Alastair Maw. My paranoia got a little bit too much
apparently.
2003-03-10 18:13:45 +00:00
Kjartan Mannes 1421c878d1 - Moved moderation logic back into node module.
* After having a chat with Dries we have agreed on the logics (or
      more specifically he told me how its supposed to work). The queue
      module is just a method to make moderation public, but its not
      necessarily the only way. This brings the power back.
- Minor interface tweaks (names, case changes, etc).
- Fixed error that would show when you tried to view the profile of a
  blocked user.
2003-03-09 17:19:50 +00:00
Kjartan Mannes a0deb476fa - Changed _nodeapi("conf") to _nodeapi("settings").
- Changed node settings page to use table().
- Minor code beautification here and there.
2003-03-08 14:35:42 +00:00
Kjartan Mannes 831ee21303 - Renamed "form.admin" to "form admin".
- Added node_admin_settings() to let users set node defaults.
    * Added _nodeapi("conf")
- Modified form_checkbox() to unset options. (Modified the patch from Ax.)
- Removed the _save() hook.
- Fixed a logical flaw in field_get() and field_set() which would break
  moderation.
- Moved some admin menus around and cleaned up some typos.
2003-03-07 22:11:44 +00:00
Dries Buytaert 25c5e5977a - Fixed broken URL in comment form. Patch by Ax. 2003-03-06 08:19:01 +00:00
Dries Buytaert f26d8807fc - Two small fixes. 2003-03-04 17:41:11 +00:00
Dries Buytaert dadf09d8c8 - Fixed bug in comment_num_replies() causing problems in the tracker module
(and potentially in the forum module).
2003-02-26 22:19:24 +00:00
Dries Buytaert 91dfef65af - Fixed some typos spotted by Al Maw. 2003-02-25 19:52:32 +00:00
Dries Buytaert 277ceae515 - New menu houskeeping. Prototyped by Zbynek.
The following modules need updating:
    * glossary module
    * feed module (Breyten's version)
    * mailhandler module
    * notify module
    * project module
    * smileys module
    * admin module
    * style module
    * taxonomy_dhtml module

  To avoid unexpected problems menu_add() is deprecated (it will print an
  error message when used) and menu() should be used instead.
2003-02-20 22:44:51 +00:00
Kjartan Mannes dd329e1d95 - Added function node_invoke_all($hook, &$node, $op, $arg = 0).
- Added a _nodeapi hook that in time will replace the _node hook. Trying
  to make as few changes to existing code as possible until the new api
  is stabilized.
- Modified node_form() to add administration options from other modules
  using the _nodeapi hook.
- Modified node_save() to fetch which fields should be saved to the node
  table from the _nodeapi hook.
- Moved comment and queue options from node_form() and node_save() to
  the modules _nodeapi hooks.
2003-02-16 14:57:35 +00:00
Dries Buytaert 83f5d82876 - Everything is using theme("function") now instead of $theme->function(). 2003-02-15 11:39:56 +00:00
Dries Buytaert e90f3b883b - See http://lists.drupal.org/pipermail/drupal-devel/2003-February/021824.html. 2003-02-11 20:01:17 +00:00
Dries Buytaert e5aae050a7 - Changed '%s' into '%d' such that an empty $user->uid is converted to 0. Required for Drupal to work on new versions of PostgreSQL. Patch by James. 2003-02-09 18:01:32 +00:00
Dries Buytaert 6746ee41f5 - Added some caching. Patch by Moshe. 2003-02-01 20:01:43 +00:00
Dries Buytaert 74a3318ca9 - Bugfix; we got redirected to the wrong URL. 2003-01-29 23:33:50 +00:00
Dries Buytaert 637004c539 - Tidied up XHTML. Patch by Ulf.
- Added missing t() function.  Patch by Stefan.
2003-01-23 09:24:20 +00:00
Dries Buytaert 9a23223e25 - Applied Ori's format_plural() patch; see mailing list for details.
NOTE: some modules in the contributions repository might need to be updated.
2003-01-21 22:44:25 +00:00
Dries Buytaert ef0acbf2dd - A node's comment table is now being emitted by the new table rendering
functions.
2003-01-21 22:38:47 +00:00
Dries Buytaert d268783669 - Small improvement to the admin menu based on feedback from Michael. 2003-01-14 20:33:42 +00:00
Dries Buytaert 81efba930f - Removed depricated function. 2003-01-12 15:29:56 +00:00
Dries Buytaert 87dbb8236e - Minor comment module improvements/fixes. 2003-01-09 21:50:04 +00:00
Dries Buytaert 89b2069e4d - Clean URL patch. 2003-01-06 19:51:01 +00:00
Dries Buytaert 8a63646576 - Added an extra parameter to watchdog() which lets you specifiy an "action"
or "operation" link.

- Made the main page of the administration section show an overview of all
  watchdog entries with such action link.

- Fixed typo in PostgreSQL database scheme.
2003-01-04 11:03:15 +00:00
Dries Buytaert 2b5dfdafa5 Bugfix: when we have to extract a comment's title from the comment's body,
first strip the body's HTML tags or we might get an empty title after all.
2003-01-02 18:34:13 +00:00
Dries Buytaert de95001c92 - Tidied up the use of check_output(). Might make rendering pages a bit
snappier (performance improvement).
2002-12-31 12:34:07 +00:00
Dries Buytaert 1011e87411 CHANGES:
- Usability improvement: made the comment administration pages use the
  new table rendering functions.

- Usability improvement: new comments will also be marked as new in the
  administration pages.

- Code improvement: changed the comment administration pages to use the
  default pager instead of a custom pager.

- Bugfix: "yes" and "no" were not translatable.

- $ diffstat comment.patch
  comment.module |   45 +++++++--------------------------------------
  1 files changed, 7 insertions, 38 deletions

TODO:

- Comment module: remove other custom pagers in the comment module.

- Pager/database: it would be nice if the functions db_query_range()
  and pager_query() would have the same semantic as db_query(); that
  is, using a variable number of arguments that are automatically
  escaped/checked.
2002-12-29 12:44:33 +00:00
Dries Buytaert 22fa9ed70a - Refactored the administration pages. 2002-12-24 15:40:32 +00:00
Dries Buytaert d2927a9064 - Small usability change. 2002-12-10 20:36:03 +00:00
Dries Buytaert eceead1819 - Removed the "comment anchors" in the themes; the anchor is emitted
by the comment module.  Patch by Ax.
2002-12-10 20:14:10 +00:00
Dries Buytaert a10cd273d3 - Avoid empty fields to be displayed. Patch by Moshe. 2002-12-08 08:04:58 +00:00
Dries Buytaert 5b39f6767e * Applied slightly modified version of Marco's taxonomy patch:
- Fixed a bug with get_tree and multiple parents.
 - Fixed 3 wrong caches (this will avoid some queries).
 - Extension to taxonomy_term_count_nodes() (feature #159): "currently
   calling taxonomy_term_count_nodes() returns the amount of nodes in each
   term, would it be possible to extend this function so that it would only
   return the amount of nodes of a certain type under each term.
 - Confirm deleting a vocabulary or a term (requested by Moshe).
 - Use form_weight() in vocabulary and term forms.
 - After submitting a term, we end up at the term page (requested by Moshe).
 - Added status messages when adding, editing and deleting vocabularies and
   terms
 - Minor clean ups

* Made sure all modules use the same link delimiter; "|" for now.
2002-12-02 19:14:41 +00:00
Dries Buytaert 0afe52df9b - Updated the query to put $score in the parameter list. 2002-11-20 21:01:45 +00:00
Dries Buytaert d259cc1973 - Commited Moshe's comment moderation improvements. 2002-11-20 20:59:54 +00:00
Dries Buytaert 9e32c2e960 Patch based on work of Kjartan:
- Changed cache API.

- Fixed caching bug in comment.module.  Odd this hasn't been reported yet.

- Fixed caching bug in forum.module.

- Fixed caching bug in system.module.

- Fixed caching bug in block.module.

- Simplified caching support in forum.module thanks to improved cache API.
2002-11-17 06:42:52 +00:00
Dries Buytaert cc381c1461 - Fixed glitch in block module: the admin links were not composed
correctly.  Patch by Stefan.

- Added missing t() functions and improved the %x directives for
  better readability and to ease the process of translating your
  site.  Patches by Stefan.

- Made two small additions to the 'code-clean.sh' script; it will
  now remove patch related junk.

NOTES:

- I removed the · related bits.  Let's tackle these later on
  in a separate patch after we got some sort of consensus.

- I removed the 'module_exist("drupal")' check in the user module;
  I *think* it is incomplete and therefore incorrect.

- Stefan, try using quotes in your translations and check whether
  everything still works.  Example: translate the "Create account"
  button to "Create \"haha\" account \'hihi\'" and see if you can
  still create new accounts.  Maybe automate this using a quick
  hack in the locale module ...
2002-11-01 10:47:20 +00:00