bb9885135a
#207779 report by meba, patch by myself: missing plural formatting in forum module, and a counter display fix as well
2008-01-09 21:38:57 +00:00
33f455d2df
#153998 by David_Rothstein and myself: clean up permissions in book, blog, blogapi, forum and locale modules
2008-01-09 09:51:35 +00:00
b78a990270
#207569 by ScoutBaker (minor code style): clean up @see usage in phpdoc blocks
2008-01-08 10:35:43 +00:00
19619d9354
#206670 by keith.smith and myself: node type names have their underscores converted to hyphens in node/add links
2008-01-07 13:18:40 +00:00
1279630a3a
#205138 by pwolanin: require node types in forums vocab, fix help text parameter name (outside t())
2008-01-01 18:23:14 +00:00
195fe364d2
#203582 by David_Rothstein: some core hook_access() implementations are not using the passed in account
2008-01-01 17:46:30 +00:00
dde0923ce5
#202967 by catch: kill notice on forum page
2007-12-22 23:11:31 +00:00
789cba51f5
#186546 by bjaspan: fix missing forum vocabulary when people turned on forum module, but never visited any pages in Drupal 5 and they upgrade to Drupal 6 which does this much better
2007-12-20 21:43:01 +00:00
fdce0564d6
#202559 by Pasqualle: just removing some trailing white space from end of lines
2007-12-20 09:35:10 +00:00
4dbfd5e66c
#169987 by Pancho, catch: the missing forum edit permission for consistency
2007-12-20 08:40:19 +00:00
2b811363e8
#99947 by neclimdul, Sutharsan, keith.smith: forum module help text and form description update, removing reference to other forum software as well
2007-12-19 10:31:27 +00:00
02539ac3f8
- Patch #195496 by bjaspan and hunmonk: no 'char' data type in Schema API (and removed spaces).
2007-12-18 10:31:42 +00:00
b6532a4fdb
#200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed
2007-12-14 18:08:50 +00:00
c6d841c096
#197297 by DanW (as GHOP 17), and keith.smith: clean up lots of help texts, update to drag and drop functionality, drupal.module removal, etc
2007-12-13 09:34:40 +00:00
b8264306fc
#176282 by Desbeers: forum taxonomy was required for non-forum node types, when enabled for forum inclusion
2007-12-11 10:52:01 +00:00
5622bce2d5
#198579 by webernet and hswong3i: a huge set of coding style fixes, including:
...
- whitespaces at end of lines
- indentation
- control structure usage
- whitespace in empty lines
- phpdoc comment formatting
2007-12-08 14:06:23 +00:00
e6a88be5d1
#193333 by quicksketch et al: taxonomy drag and drop support
2007-11-26 19:46:52 +00:00
70d494620c
#192242 follow up by catch: unset multiple parent form item on forum term pages
2007-11-21 14:02:23 +00:00
f803a82151
#194075 by neclimdul: nodeapi load should return an array by documentation, and forum's nodeapi load returns an object
2007-11-21 09:31:57 +00:00
ece869b0b2
- Patch #192242 by catch, quicksketch, webchick, keith et all: usability improvements for the vocabulary/term forms.
2007-11-20 13:24:54 +00:00
1cf05b0019
- Patch #89196 by catch, keith, earnie, webchick et al: string massaging.
2007-10-25 15:32:56 +00:00
4e187261ab
#177497 by chx and Desbeers: revive Drupal 5's menu_set_location() functionality by introducing menu_set_item() (for consistency in function naming), thus fixing a regression in the current development code. Also fixing some misuse of menu_set_location() by using drupal_set_breadcrumb() instead.
2007-10-25 08:24:43 +00:00
8cd97cdd7d
#147492 by flobruit: make 'more' links themeable
2007-10-22 09:36:05 +00:00
0ada4f136a
#72487 by chx, pwolanin and moshe weitzman: let node_access() work on arbitrary users, so independent user access checks can be done in a request
2007-10-11 16:37:43 +00:00
f87245c202
#175979 by Desbeers: forum module does not need to call node_prepare anymore, because it is already done
2007-10-08 08:40:26 +00:00
ca8e9a1e18
- Patch #180432 by hunmonk, sun, et al: make comment settings per node type. This is a new feature that slipped in because it is required for the project module on drupal.org.
2007-10-07 19:25:57 +00:00
c4b02c1213
#174343 by Shiny: move JOIN condition to ON clause in forum_nodeapi, so our SQL is standards compatible
2007-09-10 08:06:59 +00:00
531b45d045
- Patch #172643 by chx and fresco: fixed the leave shadow copy functionality.
2007-09-05 08:27:57 +00:00
e310d9e4a4
#6162 by various people: actually point new anchors to the page the first new comment is displayed (in a multipage comment view)
2007-09-02 14:56:18 +00:00
d82fe113bc
#53905 by fax8, Gurpartap Singh and dvessel: give meaningful names to term variables in forum templates and add unique IDs for easier themeing
2007-08-30 18:58:12 +00:00
94c1729eac
#161107 by fwalch and bragon: actually implement the missing forum_term_load to work behind the %forum_term menu item resolving calls
2007-08-29 18:25:51 +00:00
5e73b66f3a
- Patch #168028 by dvessler, merlinofchaos, pwolanin et al: both theme functions and templates may need include files. Flush your caches.
2007-08-26 07:46:11 +00:00
b134b023e1
- Patch #163191 by hswong3i: removed db_num_rows() for compatibility with Oracle and DB2. Also a performance improvement.
2007-08-12 15:55:36 +00:00
3488a1ed44
- Patch #158536 by dvessel: more forum template massaging.
2007-08-03 06:07:52 +00:00
bec12a215d
- Patch #158536 by dvessel: some more gentle massaging of template files. Trying to make it easier to discover the different template files.
2007-07-26 06:48:03 +00:00
af00a845fb
- Patch #161350 by Crell: slicing and dicing the forum.module.
2007-07-24 18:08:54 +00:00
a466354823
- Patch #158536 by merlinofchaos and dvessel: tpl-ified the forum module.
2007-07-22 07:01:07 +00:00
64def7cb3e
#100641 by kkaefer, ChrisKennedy and RobRoy: change 'Submit' buttons to 'Save' to compliy with the desktop metaphor and actually tell what the button does ('we know it submits the form, but what it does?')
2007-07-16 12:43:06 +00:00
b6c069ad7d
- Patch #20295 by pyromanfo, webchick, Gurpartap Singh et al: allow forum topics to be custom node types.
2007-07-02 17:08:36 +00:00
e59852d336
- Rollback of patch #147723 : delete API. Talked to Steven and Gabor and we
...
unanimously agreed to rollback the deletion API. We all support the
features this patch added, yet not its actual design and implementation.
After some talk, we decided that it would be better for Drupal -- in the
long term -- not to go with a solution that isn't 100%. We also recognize
that in the short term, this patch would have been useful addition. So
let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
9e6ef53c2c
#154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array
2007-06-30 19:46:58 +00:00
fe8b35f527
#153781 : Convert all remaining confirm_forms() to deletion api.
2007-06-22 08:32:28 +00:00
38a1300df2
#147723 : Deletion API (by hunmonk). Woop woop.
2007-06-22 05:44:21 +00:00
e629deb94d
- Patch #146667 by Jeff Eaton: form API fixes.
2007-06-04 15:56:34 +00:00
1fe90cba4f
- Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments
2007-06-04 07:22:23 +00:00
3568709803
- Patch #144295 by Gurpartap Singh: forum module fixes.
2007-05-30 08:04:38 +00:00
5d35dbd3d4
- Patch #147034 by webchick: removed redundant dependency checking.
2007-05-28 06:19:05 +00:00
96926ca047
- Patch #146470 by Eaton et al: standardize form API3 hook parameter order.
2007-05-28 06:08:47 +00:00
ac65ff9074
- Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :)
2007-05-14 13:43:38 +00:00
c32e17e3f2
- Patch #141665 by ChrisKennedy: E_ALL fixes.
2007-05-07 17:02:54 +00:00
7d4f2836ba
- Patch #128082 by Goba et al: Allow localization of built-in menu items.
2007-04-30 17:03:29 +00:00
f73610bec6
- Patch #76588 by Gabor: made log messages translatable. Yay.
2007-04-24 13:53:15 +00:00
e675979091
- Patch #134493 by douggreen: getting the Drupal coding standards right in core. Woot. Woot.
2007-04-13 08:56:59 +00:00
dcbb5fa3f4
- Patch #107061 by Steven et al: add jQuery teaser splitter.
2007-04-09 13:58:03 +00:00
5bbbf10ba8
- Patch #130987 by merlinofchaos: added theme registry for easier themability.
2007-04-06 13:27:23 +00:00
b20618aa12
- Patch #128866 by Gabor et al: new language subsystem fixes.
2007-03-28 14:08:23 +00:00
f7440d4d73
#130971 : Kitchen sink (E_NOTICE compliance / Code style / Bugfix in book toc)
2007-03-27 05:13:55 +00:00
eb6b848de6
- Patch #110888 by Eaton: unify hook _alter()
2007-03-26 00:35:59 +00:00
4b635f6d0a
- Patch #128081 by Eaton: remove #base, paving the path for a simpler form API.
2007-03-17 18:30:14 +00:00
7f4e49016a
- Patch #122824 by PMunn: fixed SQL query to be compatible with PostgreSQL.
2007-02-28 20:42:50 +00:00
dc5843bd30
- Patch #111347 by Steven: refactor url() and l().
2007-02-15 11:40:19 +00:00
72501e54df
- Patch #115667 by rotzi: added versioning support to node terms.
2007-02-12 17:47:08 +00:00
a1e6728a46
- Patch #113603 by chx: first crack at re-implementing tabs.
2007-02-11 09:30:51 +00:00
ce358d8c7a
- Patch #113286 by maynich: added missing t() function.
2007-02-01 21:44:36 +00:00
489903a08e
- Patch #113603 by chx: first crack at re-implementing tabs.
2007-01-31 21:26:56 +00:00
1126d5cfe9
- Patch #40575 by Wesley: made it easier to theme the forum overview page.
2007-01-31 16:01:17 +00:00
05a708fb06
- Patch #112715 by chx, webchick, asimmonds, et al: fixing E_ALL notices. Thanks.
2007-01-31 15:49:26 +00:00
3b543c18f5
- Rollback of E_ALL patch. Too much extra breakage.
2007-01-25 22:14:06 +00:00
89c8b3feaf
- Patch #112563 by webchick: prevent double-escaping.
2007-01-25 21:49:32 +00:00
03752e35a4
- Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet.
2007-01-24 14:48:36 +00:00
74e3c74b81
- Always check the username.
2007-01-10 15:17:51 +00:00
365439ffdf
#107015 : Code consistency, capitalization of class names.
2007-01-05 05:32:23 +00:00
3111774ef7
#19891 by edkwh. Make forum and container names links in forum administration.
2006-12-25 22:22:42 +00:00
fdef98345a
- Patch #104882 by dww: fixing forum topic teasers.
2006-12-23 19:30:46 +00:00
bdf5dc9d1d
- Patch #102413 by yched: path node/add/[poll|forum|blog] defined twice.
2006-12-10 20:34:03 +00:00
47f527fbbe
Fixing commit of #100563 (thanks webernet)
2006-12-01 23:17:26 +00:00
0ea4e1c5f6
#100563 : Conditional loading of (some) module.css files
2006-12-01 22:47:53 +00:00
f94622db5d
- Patch #99948 by neclimdul: added some help text.
2006-11-28 09:48:45 +00:00
b5bf8a8f47
#97824 by Gurpartap. Move enclosing elements outside of their t().
2006-11-26 02:20:01 +00:00
0b61aef454
#83190 by webchick. Remove misleading links.
2006-11-25 09:07:26 +00:00
b004f328ee
- Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard.
2006-11-21 20:14:19 +00:00
392041edf6
#72467 by m3avrck. Better display for long book page and forum topic titles.
2006-11-14 06:30:10 +00:00
36d44fbfb0
#84146 : Use 'Sentence capitalization' for menu items, page titles, form items, etc
2006-10-22 08:28:47 +00:00
772d7624ba
#47692 by Wesley Tanaka. Clean up some PHP notices.
2006-10-04 06:07:05 +00:00
030f9741b7
#84076 by edkwh. Interim fix for being able to delete forums and forum containers.
2006-09-23 08:10:40 +00:00
66fe517e0b
#40751 by chx. Redirect back to the forum when logging in from there.
2006-09-05 02:48:33 +00:00
6c406e39a1
- Patch #76742 by beginner, eaton et al: fixed problem with editing container description of forums.
2006-09-03 14:42:12 +00:00
49fa25fb76
- Rollback of patch #68418 : clean up node submit hooks. Needs more thinkering.
...
Restores the old node API.
2006-08-31 21:58:36 +00:00
c64db1da29
- Patch #80952 by earl, webchick, neclimdul et al: .info files
2006-08-31 20:22:37 +00:00
5524604a95
- Patch #68418 by Moshe et al: clean up node submit hooks.
2006-08-29 18:43:26 +00:00
bceaf8f0da
#80574 Eaton and chx. Replace $_POST['edit'] with $_POST.
2006-08-29 09:12:03 +00:00
07ad89db03
#70660 by pwolanin. Forum last post time was considering non-forum items.
2006-08-26 00:19:02 +00:00
6ea9204889
#56093 by webchick. Fix forums.
2006-08-25 08:55:04 +00:00
2d05938082
- Patch #66569 by m3avrck: Consolidate the drupal_add_link() calls.
2006-08-23 07:23:09 +00:00
a58d877108
#66569 by m3avrck. Put all the feed icons in the same place.
2006-08-23 05:55:38 +00:00
55eec8f66f
#79601 : module_exist() -> module_exists()
2006-08-20 05:57:41 +00:00
7de41539df
- Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model.
2006-08-18 18:58:47 +00:00
81938a3cdc
#76802 : Introduce placeholder magic into t()
...
See: http://drupal.org/node/64279#t-placeholders
2006-08-18 12:17:00 +00:00
3cc2b1e3d7
#77183 by m3avrck and timcn, split up drupal.css by module.
2006-08-14 07:14:50 +00:00
ce85b7c7f8
- Patch #74326 by Eaton, Royboy, chx, et al: building $node->body with arrays like FAPI for viewing.
...
Once again, we're paving the path for CCK in core ... :)
2006-08-10 15:42:33 +00:00
729fa6c11b
- Patch #77422 by timcn: corrected various paths in the documentation.
2006-08-07 15:04:16 +00:00
129c8eb18c
#62340 by chx, webchick, Jaza, Eaton, mathieu, and myself. Configurable node types.
2006-08-06 23:00:42 +00:00
5c57a53165
#76339 by pwolanin, allow non-forum category changes while leaving a shadow copy
2006-08-05 01:42:56 +00:00
cd430165d7
#73884 by RobRoy, various code cleanup.
2006-08-05 00:26:36 +00:00
6839ce965f
#76742 by paranojik, fix a bug preventing editing of forums
2006-08-05 00:13:06 +00:00
b138793b68
- Patch #72079 by Earl et al: give Drupal an overall administration page ... :-)
2006-07-31 11:25:55 +00:00
3a7b64ae03
- Patch #61893 by timnc: remove message_na().
2006-07-29 17:56:41 +00:00
eaf5f2e029
#49299 by wtanaka, properly break words
2006-07-11 07:04:34 +00:00
58752cfaa2
- Patch #72284 by me:
...
+ reorganized ?q=admin/settings
+ deprecated the _settings hook
2006-07-10 19:27:52 +00:00
e93f8be871
- Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants.
2006-07-05 11:45:51 +00:00
59aa2ae8e8
#71925 by Steven, remove # prefix from link array keys.
2006-07-04 08:59:05 +00:00
af6c897056
#65024 by killes, remove an extra condition.
2006-06-12 03:44:54 +00:00
226eed7047
- Patch #67146 by webchick: make sure that the forum vocabulary shows up first.
2006-06-06 15:35:39 +00:00
cf3bfe006b
- Patch #18260 by Morbus: fixed taxonomy links.
2006-05-29 12:58:19 +00:00
1b291a2917
- Patch #18260 by Ber, m3averck et al: allow overriding of links returned by modules
2006-05-18 14:58:57 +00:00
e1304697c4
- Patch #62350 by hunmonk: fixed problem with deleting forum containers.
2006-05-08 15:16:16 +00:00
9cff02e91b
#61802 by Zen, Double spaced sentences clean up
2006-05-07 00:08:36 +00:00
d6a164c400
#5371 , drupal_get_destination, pager and tablesort array handling, patch by Steven
2006-04-13 08:25:27 +00:00
9794b5538e
- #55898 : Generic, permissive admin XSS/HTML filtering for mission/footer/...
...
- Clean up some raw output
2006-04-07 15:32:17 +00:00
3000db0d13
#40664 , adding new forum topic, forum not pre-selected in pull down menu., fix by Jonas Kvarnstrom, patch by drumm
2006-04-06 18:36:57 +00:00
be0b774cbc
- #57523 : Make taxonomy delete vocabulary consistent with other taxonomy hook ops
2006-04-06 04:21:12 +00:00
ec04325bb2
- Make forum_hot_topic scale a bit more logical
2006-04-06 04:18:30 +00:00
603a6618ee
#28625 , Forum vocabulary does not handle standard vocabulary features correctly, removed these features by means of formapi, patch by profix898, with some love by dopry and chx
2006-03-31 06:43:46 +00:00
002fee7aae
#56105 , remove title validation, already enforced by #required, patch by Moshe
2006-03-27 18:02:48 +00:00
0ed9f460dc
#55805 , missing {}, patch by Cvbge
2006-03-25 10:52:40 +00:00
717d6e30c5
#54098 , forum "last post" column show oldest, not most recent, patch by Zen.
2006-03-24 10:13:10 +00:00
d11c07502d
#54910 , Forum and taxonomy term delete work only superficially, patch by Zen
2006-03-23 21:46:35 +00:00
40e2a3b379
#51635 , Moving forum post leaving shadow copy results in warning, patch by Zen/webchick
2006-03-08 22:11:54 +00:00
7add598ee2
- Patch #51850 by chx, webchick et al: fixed various problems with db_rewrite_sql, made db_rewrite_sql slightly more robust.
2006-03-08 15:13:20 +00:00
d2865f2a99
- Patch #52850 by Zen: fapi conversion + minor fixes
...
* converts forum_admin to fapi.
* handles invalid terms in hook_menu
* adds comments, fixes typos etc.
* reorganises functions a little bit - moves hook_menu to the top.. groups hooks together and forms together
2006-03-07 19:03:02 +00:00
d7e9371e94
- Removing whitespace
2006-03-03 08:37:47 +00:00
1d865eb4c4
#51613 , forum.module forms ignore proper form submission path, patch by merlinofchaos
2006-02-28 13:36:59 +00:00
19afd2ceb7
- Patch #45850 : it was impossible to create shadow topic. (Today's critical bugfix #2.)
2006-02-23 12:21:15 +00:00
3603fe1bd8
- Patch #49912 : www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
2006-02-21 18:46:54 +00:00
f030164bcb
- Patch #46743 by Morbus: fixed double encoding issue.
2006-02-15 20:47:35 +00:00
91152ba7af
- Patch #46743 by m3avrck: clean up forum topic navigation. Bring it in line with book.module.
2006-02-10 05:05:44 +00:00
88490f6413
- Patch #47691 by Cvbge: quickfix postgresql
2006-02-09 08:52:03 +00:00
a723204ee4
- Patch #47691 by wtanaka: performance improvement for _forum_topics_read.
2006-02-09 08:09:55 +00:00
87f5947e51
- Patch #47868 by wtanaka: performance improvement: active topics block selects an unused column.
2006-02-04 09:56:04 +00:00
31293d5a2e
- Patch #46864 by stmind: fixed problem with node-level permissions and forums.
2006-02-01 14:19:44 +00:00
8c02d4ec93
- Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
...
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
$form[$key]['#weight'] = $count/1000;
}
The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
Consider the following pseudo example:
$form['game_title'] = array(
'#type' => 'textfield',
...
);
$form['game_description'] = array(
'#type' => 'textarea',
...
);
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;
Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
10d7f7731b
- Patch #45281 by chx: made categories with forum topics work again.
2006-01-19 17:55:54 +00:00
e84a98a22b
- Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API.
2006-01-19 08:54:41 +00:00
52507806eb
- Patch #45301 by Morbus: corrected the weight of form item titles of nodes.
2006-01-18 19:29:17 +00:00
92acb92699
- Patch #33747 by Ber and Moshe: bugfix + code improvement: clean up some of the taxonomy loading code.
2006-01-10 12:35:20 +00:00
b170d83d14
- Removed global .
2006-01-09 10:12:30 +00:00
4e35060451
- Patch 42591 by Simon/me: fixed problem with deleting forum and book revisions.
2005-12-31 13:04:40 +00:00
799ceae29b
- Patch #42705 by Cvbge: added missing format_plural().
2005-12-31 11:21:32 +00:00
ea2d791095
- Patch 41169 by Chris: got rid of expensvie object 2 array casts.
2005-12-31 10:48:56 +00:00
79a193a2d2
- #42234 : Use standardized feed icon for RSS
2005-12-29 04:46:40 +00:00
Gábor Hojtsy
Dries Buytaert
Steven Wittens
Neil Drumm
Gerhard Killesreiter