Commit Graph

362 Commits (3701c02e59d7489331e8d298d5c7a7fd51b72b28)

Author SHA1 Message Date
Dries Buytaert ee305ae144 Round 3 of aggregator improvements:
- Added support for new tags:
   + Optinal feed image: <image> tag.
   + Dublin core dates: <dc:date> <dcterms:created>, <dcterms:issued>,
     <dcterms:modified>.
 - Usability improvements:
   + On the administration page, made the feed/bundle titles link
     to the feeds/bundles' pages.  On the feed/bundle's page, made
     the 'Last updated' field link to the administration page.
   + Moved the 'syndication' menu one level down.
 - Updated some content sensitive help.
 - Further improved themeability.
 - Fixed some invalid HTML.
2004-01-11 15:05:21 +00:00
Dries Buytaert bd9064a6ca - Fixed bug #4965: typo in the help text. 2004-01-06 18:35:12 +00:00
Steven Wittens c2151b5248 Committed filter separation patch: all filter-related things are now in filter.module (which is a required module).
To do this cleanly, I reorganised some bits of system.module: there is now a generic handler available for simple variable-get/set based configuration pages. Look at filter_admin() or system_view() for example usage.

(based on the patch by Goba)
2004-01-05 19:19:05 +00:00
Dries Buytaert a9ef18266e - Patch 4916: improved preparation of $node->teaser and $node->body. Patch by
Goba.
2004-01-02 16:30:09 +00:00
Dries Buytaert 01d17d4aca - Patch #4093: only invoke check_output() once for performance's sake. Patch
by Goba.
2004-01-02 09:50:12 +00:00
Steven Wittens 51208885de General filtering improvements
- Re-added STYLE/ON*= filtering (this got lost a while ago due to reorganisation)
- Added form_group's to node.module's filter options
- Fixed incorrect filter usage in poll.module
2003-12-30 14:02:36 +00:00
Dries Buytaert 80f34e5ab0 - XHTML improvements: <b> -> <strong>. Patch by Stefan. 2003-12-29 17:14:27 +00:00
Dries Buytaert 6ab859555c - Usability improvements to the 'create content' section. Patch by Goba. 2003-12-22 11:55:49 +00:00
Dries Buytaert d5c8026454 - Updated the calls to menu() to use MENU_HIDE instead of 1 2003-12-17 22:27:23 +00:00
Dries Buytaert 928c113b82 Patch by Kjartan:
- Adds possibility to hide menu item when it has no children. (Fixes the
    node/add problem when user doesn't have access to create any node
    types.)
  - More doxygen comments.
2003-12-17 22:15:35 +00:00
Kjartan Mannes d8d2d69b82 - Fixed missing pager_display -> theme('pager'). 2003-12-08 19:32:06 +00:00
Dries Buytaert 712a30b520 - Improvements by Goba:
+ removes the lots of pagers and indirect pager themeing
  + add the theme_pager() function, which should be called as
    theme("pager", ...) to get a pager.
2003-12-08 18:30:20 +00:00
Dries Buytaert ea1acde1d5 - Usability improvement: just print a status message after a node
submission/update instead of using a separate page.  Patch 186 by Moshe.
2003-12-08 18:01:41 +00:00
Dries Buytaert 3904790e03 - Tidied up the DoxyGen comments. Patch by Kjartan. 2003-12-08 06:32:19 +00:00
Kjartan Mannes 0c80c55e91 - Fixed node_form() so it doesn't re-run node_validate() when there are no
errors and it has already been checked.
2003-12-06 19:15:38 +00:00
Dries Buytaert dcc3e24188 - Fixed bug #4457: make sure to cut of the teaser after the </p> tag, not
before the </p> tag.
2003-12-04 22:48:06 +00:00
Dries Buytaert 4e2c0b250e - Introduced a drupal_set_message() and drupal_get_message() function.
Contributed themes and modules need to be updated:
   - modules: status() is no more; use drupal_set_message() instead.
   - themes: use drupal_get_message() to check for status messages and
     visualize them.
2003-12-01 13:45:33 +00:00
Dries Buytaert c0494c0a2b - Committed phase 4 of JonBob's menu system changes. 2003-11-25 19:26:21 +00:00
Dries Buytaert 26735ac5dd - Committed phase 3 of JonBob's menu changes. Adds an API for modules to
define titles and breadcrumbs for their pages, and updates the theme
  system to display them.
2003-11-23 10:41:04 +00:00
Dries Buytaert 4bdac4333b - Patch by JonBob:
Phase 2 of the menu system integration project. This unifies the interface
  used by admin and non-admin pages, and deprecates the _page hook in favor of
  explicit callbacks from menu(). Breadcrumbs, titles, and help text go away
  as a result of this patch; they will return in the phase 3 patch, printed
  by the theme.
2003-11-20 21:51:23 +00:00
Dries Buytaert 36bb57555c - table(...) -> theme("table", ...) 2003-11-13 19:52:54 +00:00
Dries Buytaert df44729306 - Made the revisions a separate page/tab. 2003-11-11 16:25:10 +00:00
Dries Buytaert 951b553a98 - Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX. 2003-11-09 23:27:22 +00:00
Dries Buytaert 00ee7f747b - Removed the "return" link from the node submission confirmation page. 2003-11-09 17:25:11 +00:00
Dries Buytaert 432852fbb8 - Bugfix: added missing t() function. Patch by Goba. 2003-11-07 19:26:10 +00:00
Dries Buytaert ef0fa006ed - Usability improvement: replaced many selection boxes by radio buttons.
Patch by Stefan.
2003-11-07 19:03:35 +00:00
Dries Buytaert 00d638ca57 - Usability improvement: replaced many selection boxes by radio buttons.
Patch by Stefan.

- Usability improvement: introduced a form_group() function and updated
  the node and comment module to take advantage of it.  Patch #149 by
  Eric Farris.
2003-11-06 18:27:58 +00:00
Dries Buytaert ec33266795 - Improvement: made it possible to disable the comment controls and reworded some of the configuration settings.
- Improvement: removed a left-over from Drupal 4.2.0 (dead code).

- Improvement: replaced hard-coded XHTML around the XML icons with class="xml-icon".

- Improvement: removed the custom navigation menus shown at the top of the "user information page" and integrated them in the new navigation block.  The "my account" link in the navigation menu will unfold.  Also removed the "delete account" link/functionality (for now).

- Improvement: fix for "magic quotes" settings.  Patch by Steven.  I also removed check_php_settings().

- Improvement: block themability improvements.  Modified patch from Ax and Steve/CodeMonkeyX.

- Fixed bug #2617: editing user information does not work.  Patch by Kjartan.
2003-10-31 19:34:03 +00:00
Dries Buytaert 8f9a19b340 - Bugfix: fixed problem with queue module. Fixes bug #3839. 2003-10-29 17:42:11 +00:00
Dries Buytaert 0a59c41f8c - Bugfix: corrected broken HTML in the documentation. 2003-10-23 15:04:13 +00:00
Dries Buytaert 72ae2d3995 - Bugfix: renamed the 'statistics' table to 'node_counter' as 'statistics' is
a reserved SQL keyword.  Required for both PostgreSQL and MSSQL.  Patch by
  Adrian.

- Bugfix: renamed the 'path' table to 'url_alias' as 'path' is a reserved SQL
  keyword.  Required for both PostgreSQL and MSSQL.  Patch by Adrian.
2003-10-22 20:20:35 +00:00
Dries Buytaert 742410aafd - Bugfix: prefix not prepended to sequences. Fixes bug #3639.
Make sure to write:

    db_next_id({table}_field);

  instead of:

    db_next_id(table_field);
2003-10-22 13:03:32 +00:00
Dries Buytaert 1fb82a6ebc - Bugfix/improvement: the revision table was not using table(). Fixes bug
#3635.
2003-10-21 18:34:54 +00:00
Dries Buytaert 2977a8cd3d - Some documentation fixes by Mark Coady. 2003-10-15 15:07:47 +00:00
Dries Buytaert e688dfe6db - Fixed prefix problem with the book module. Patch by Moshe.
- Usability improvements to the user module: removed some redundant menu
  items by taking advantage of the column sorting, added status messages
  and so on.  Patch by Moshe plus some fixes.

- Made the profile module use the table() function.  Patch by Moshe.

- Fixed breadcrumb spacing.  Patch by Moshe.

- Fixed colspan problem with node overview table.  Patch by Stefan.

- Fixed inconsistency with table sorting.  Patch 0122 by Al.
2003-10-13 19:18:39 +00:00
Dries Buytaert 1a5fcacdd9 - Committed part 3 of Michael's help system improvements: removed the $help
parameter from the menu() function.
2003-10-09 18:53:22 +00:00
Dries Buytaert 9d501cf822 - Removed duplicate information. Fixes bug 3511. 2003-10-08 17:35:19 +00:00
Dries Buytaert 22c889e7c0 - Help system improvements: eliminated the _system hook. Patch by Michael.
- Bloggerapi module fixes.  Patch by Kjartan.

- Coding style fixes.  Patch by Michael.
2003-10-07 18:16:41 +00:00
Dries Buytaert 058971c33b - Help improvements and translation improvements from Michael. Thanks! 2003-10-03 14:55:27 +00:00
Kjartan Mannes 463ccb4df6 - Fixed bug #3398: Error in SQL query in node.module (syndicate block) 2003-10-01 13:06:48 +00:00
Dries Buytaert 5a667eb580 - Url aliasing improvements. Patch by Matt. See mailing list for more
information.
2003-09-30 17:01:34 +00:00
Dries Buytaert 32e8d77cd6 - Associate a callback with the menu links! (This callback is not yet being
called but will be as soon the remaining links have been transformed to use
  the menu system.)

- Made sure the menu does not render links with no callback and no children.
  Like this, the 'create content' link is not being shown when the user has
  no permission to add any content.
2003-09-28 17:53:04 +00:00
Dries Buytaert c8b28009cd - Made sure all menu items can be translated. Path by Goba. 2003-09-28 15:18:55 +00:00
Dries Buytaert cc3ec29e87 - Committed Goba's translation fixes. 2003-09-28 14:11:49 +00:00
Dries Buytaert fe09d5a786 - Committed Al's new admin link texts. Remarks:
1) As explained by Al, there is still a glitch with the 'create content'
     menu.
  2) The user module part of the patch did not apply due to Kjartan's earlier
     patch.
2003-09-27 06:00:43 +00:00
Dries Buytaert f104d3cc12 - Committed the admin menu integration patch. Thanks Adrian, Stefan and others. 2003-09-26 10:04:09 +00:00
Dries Buytaert 586455b56e - Added a pubDate for each item. Patch by Neil. 2003-09-24 19:08:27 +00:00
Dries Buytaert 027f52541b - Rollback of some node API changes. Patch by Jonathan. 2003-09-23 17:57:26 +00:00
Dries Buytaert a4bc9fff9f - Rollback of some node API changes. Patch by Jonathan. 2003-09-23 16:54:19 +00:00
Dries Buytaert 00a62647bc - Committed Nick's _content improvements. 2003-09-20 15:11:41 +00:00
Dries Buytaert 2fbc7fcf27 - Committed a partial administration page integration patch. 2003-09-19 07:41:55 +00:00
Dries Buytaert e20f59d99a - Jonathan's "HTML filter" improvements.
> If turning on both filters is bad, we shouldn't allow the user to
> select both, should we? The attached patch folds the Escape HTML option
> into the same dropdown as the Filter HTML option, preventing both from
> being activated.
2003-09-16 18:34:39 +00:00
Dries Buytaert 62f939944f - Added 'escape HTML' option to the filters. Patch by Gabor Hojtsy. 2003-09-16 17:35:02 +00:00
Dries Buytaert d9cb4522bd - Book module improvements. This commit changes the behavior of the "view"
hook.  See mailing list for details; search for a mail with the subject:
  '[IMPORTANT] behavior of "view" hook changed'.  Modified patch from Nick.
2003-09-15 15:58:20 +00:00
Dries Buytaert 9fbab016f9 - Tidied up the usage of module_invoke() and module_invoke_all(). Patch by
Jonathan Chaffer.
2003-09-14 18:33:16 +00:00
Dries Buytaert 36a553c6e3 - Remove node_invoke_all as it has a misleading name and is redundant with
module_invoke_all.  Patch by Jonathan Chaffer.
2003-09-13 14:52:59 +00:00
Dries Buytaert ee35d9136e - Made the forum module's breadcrumb navigation fully themable. Patch by Nick.
- Changed 'pubdate' to 'pubDate'.  Patch by Kristjan.

- Fixed in Xtemplate theme; don't use return value of node_url() raw and uncut.
  Patch by me.
2003-09-12 18:13:22 +00:00
Dries Buytaert b9633dcded - Patch by Bart Jansen:
<quote>

  This adds session support for anonymous users and fixes a bug/typo.

    1. changed rid for user #0 from 0 to 1 (rid 1 == anonymous user) to make
       inner join work.

    2. replaced "if ($user .." by "if ($user->uid .." because now $user is
       always set (my previous change probably caused this).

    3. db_next_id("user_uid") -> db_next_id("users_uid");
  </quote>

  I repeat:

  "This adds session support for anonymous users and fixes a bug/typo."
2003-09-10 19:30:34 +00:00
Dries Buytaert e406d3054e - Added support for the optional <pubdate> element in our node RSS feeds. This
could help reduce the number of HTTP requests and fixes some annoyances with
  RSS clients.
2003-09-09 19:05:08 +00:00
Dries Buytaert 8e657f64ef - Gerhard's uid 0 patches. These patches bring various performance
improvements.  Requires a database update.
2003-09-09 18:18:43 +00:00
Dries Buytaert 6f4e902e3b - Corrected the form description of the URL aliasing; don't add a trailing
slash.  Reported by Stefan.
2003-08-30 07:40:19 +00:00
Dries Buytaert 93fb265d47 - Removed a debug statement. 2003-08-26 07:13:08 +00:00
Dries Buytaert 8a6ba5f1d0 - More mass-operation fixes. 2003-08-26 07:12:06 +00:00
Dries Buytaert f58a88dd26 - Fixed a couple of bugs with the mass node operations. 2003-08-26 07:05:11 +00:00
Dries Buytaert e98fe741a9 - Updated the node module to take advantage of the new help system. Patch by
Michael.
2003-08-23 18:25:35 +00:00
Dries Buytaert 4e2ee96d4c - Removed left-overs from the rating module. Patch by Gerhard. Updated the
PostgreSQL and MSSQL database scheme as well.

- Made sure the update script updates the correct tables when database
  prefixing is enabled.  Patch by Bart Jansens.

- Improved the breadcrumb navigation of the book and the forum module as per
  Keith Instone's suggestions.

- Updated page titles (or block titles) and links to match.  Suggested by
  Keith Instone.

- Added missing 'thread' field to the comment table of the MySQL database scheme.
  Fixes bug #2590.
2003-08-22 17:06:44 +00:00
Dries Buytaert 2bc440112b - Forgot to remove a debug statement. Thanks Bart. 2003-08-21 17:42:00 +00:00
Dries Buytaert 8d013b1666 - Applied Moshe's tablesort patch! Note that I changed the arrow images
because those of Moshe where not identical.
2003-08-21 15:47:50 +00:00
Kjartan Mannes 48805032c8 - Applied modified version of almaw's 0064 patch: form item attributes.
- Applied modified version of mathias' 0073 patch: node form name.
  $params["options"] is now an array so some contrib modules might
  need minor changes.

- Applied mathhias' 0074 patch: missing access check on who is new
  block.
2003-08-12 20:37:16 +00:00
Dries Buytaert 442f5b0757 - Added missing translation functions. Patch #78 by Stefan. Merged by hand
as the patch no longer applied.

- Fixed broken "view post" URL on administration page.  Reported by Bart.
2003-08-12 19:09:44 +00:00
Dries Buytaert d42158ce66 - Added more filters and support for "mass-operations" to the node overview page
in the admin section.  Comments?
2003-08-02 06:49:32 +00:00
Dries Buytaert 498f13c002 - If $node->path has been initialized (via a form for example), node_url will return it. This is not good because path could still be null (empty). Patch by Matt Westgate. 2003-07-31 09:56:29 +00:00
Dries Buytaert 869d8c6707 - Fixed broken links in the versioning system. Patch by Bart Jansens. 2003-07-31 09:50:33 +00:00
Dries Buytaert e278e46f49 - Applied Moshe's 007 patch: "read more" and author optimizations. 2003-07-26 13:18:49 +00:00
Dries Buytaert c39562ae03 - Fixed node_save() and user_save() bug introduced by table prefix changes.
Modified patches from Gerhard.

- Changed the order of the checks in node_teaser().  Patch from Kobus.
2003-07-21 15:36:05 +00:00
Dries Buytaert 8759ca7368 - Commited the URL aliasing patch. Thanks Matt.
This update requires you to run update.php!
2003-07-16 20:14:26 +00:00
Dries Buytaert 1252d51264 - Changed some INNER JOINs back to LEFT JOINs. Patch by Gerhard. Not tested
by me.
2003-07-16 07:58:02 +00:00
Dries Buytaert 22b6d2f30c - Performance improvement: changed a fair amount of "left joins" to "inner
joins".  Patch by Gerhard.
2003-07-12 22:21:55 +00:00
Dries Buytaert 337b3c9de9 - Committed a slightly modified version of Slavica's table prefix patch. 2003-07-10 17:46:44 +00:00
Dries Buytaert d017514eba - Improvement: made it possible to translate the forum module. Patch #53 by Stefan.
- Improvement: some small changes to the user module to ease translation and to make things slightly more consistent.  This should be a better alternative for patch #54.

- Improvement: increase the maxlength of the node title.  This should fix bug #2018 and #2176.
2003-07-02 17:09:09 +00:00
Dries Buytaert dc15ba06e0 - Improvement: don't perform XSS checks for trusted users. Trusted users
are those that have the "bypass input data check" permission set.  Should
  address bug #2147.

- Improvement: simplified index.php and modules/admin.module.

- Bugfix: fixed broken links in bloggerapi documentation.  Patch by Chris
  Johnson.  Fixes bug #2030.

- Bugfix: fixed the date shown on a book module preview.  Reported as part
  of bug #2097.

- Bugfix: fixed broken URL in the book module documentation.
2003-07-01 17:54:22 +00:00
Dries Buytaert 886ae2bf15 - Fixed some "search related" bugs introduced by Moshe's latest patch.
Fixes bug #2127.
2003-06-30 19:18:47 +00:00
Dries Buytaert f4df719502 - Reworked the CXX checking; now, _any_ user input will be checked
and the request will be terminated when something suspicious is
detected.  This will be logged in the watchdog.  With help from Marco.

- Fixed translation issue in the archive module.  Patch by Gerhard.

- Removed dead parameter from variable_get().  Patch by Chris Johnson.
Fixes bug #2111.

- Improved input checking of taxonomy module.  Patch by Gerhard.
Fixes bug #2112.
2003-06-27 17:48:20 +00:00
Dries Buytaert 1f91ef891e - Bugfix: fixed bug #1627. 2003-06-24 18:26:32 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert d95499bf03 - Bugfix: small Xtemplate fixes. Patch by Ax. (Slightly modified.)
- Bugfix: block patch fix.  Patch by Gerhard.

- Bugfix: fixed broken URL in ping.  Patch by Gerhard.

  (This should fix the problems shown on http://www.blo.gs/info.php?id=1515.)

- Improvement: added better password generator.  Patch #1 by Al.  Fixes bug
  #1935.

- Improvement: performance improvement to the blog module.  Patch by Marco.
2003-06-13 17:34:18 +00:00
Dries Buytaert 643d2731e7 - Fixed two broken links in the "administration > content management >
post overview" page.
2003-06-08 17:40:13 +00:00
Dries Buytaert a448f5a9b4 - Charset simpliciations. Patch #46 by Al. 2003-06-08 16:50:05 +00:00
Dries Buytaert 8f783f69dd - Removed a redundant check_query().
- Removed a bogus check_input().
2003-06-06 21:06:08 +00:00
Dries Buytaert de3b0796d2 - Bugfix: better charset support for non-ISO-8859-1 languages. Patch 0029.charset.fixes.patch by Al. Could East Asia test this please.
- Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.

- Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.

- Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.

- Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.

- Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.

- CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.

- Updated the MAINTAINERS file.
2003-06-05 18:09:39 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 3151a1cb71 - Usability improvements to the node form. Patch by Al. Will incorporate
some of Moshe's node form work later on.

TODO:

- I just spotted a problem with the promote field; it does not seem to be
  "sticky" when you click the preview button.  I checked and this was also
  the case prior to applying this patch.
2003-06-03 20:33:56 +00:00
Dries Buytaert 882c3f6d2d Removed node_get_node_from_nid() and modified node_load() to take an optional 2nd arguments to return a specified revision. Patch be Kjartan. 2003-06-01 06:32:55 +00:00
Dries Buytaert b7a0a744c6 - Committed Al's rollback fixes and the title improvements. Thanks again. 2003-05-31 12:34:11 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Dries Buytaert c7bc17103a - Fixed braino. Reported by Remco as bug #1787. 2003-05-28 15:07:25 +00:00
Dries Buytaert b9e8016fc1 - Fixed validate problem. Patch by Ax. 2003-05-26 21:31:18 +00:00
Dries Buytaert d8f78a7c95 - Removed check_output() from the theme system layer. 2003-05-26 19:50:39 +00:00
Dries Buytaert 102cbe5ee2 - Undid Kjartan's latest change (it breaks the feeds) and fixed it properly. 2003-05-25 07:08:21 +00:00
Kjartan Mannes 94fd74096c - Moved the theme("header") call in node_page outside the access check so the
page renders properly when a user does not have access to content.
2003-05-24 23:13:58 +00:00