Commit Graph

75 Commits (355d25e73d90f3174db459a5a380193e0505ada4)

Author SHA1 Message Date
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Kjartan Mannes b5ba5e22e1 - Added another security layer.
- Modified some moderation logic to make it more workable.
2003-03-10 12:01:26 +00:00
Kjartan Mannes 1421c878d1 - Moved moderation logic back into node module.
* After having a chat with Dries we have agreed on the logics (or
      more specifically he told me how its supposed to work). The queue
      module is just a method to make moderation public, but its not
      necessarily the only way. This brings the power back.
- Minor interface tweaks (names, case changes, etc).
- Fixed error that would show when you tried to view the profile of a
  blocked user.
2003-03-09 17:19:50 +00:00
Kjartan Mannes a0deb476fa - Changed _nodeapi("conf") to _nodeapi("settings").
- Changed node settings page to use table().
- Minor code beautification here and there.
2003-03-08 14:35:42 +00:00
Kjartan Mannes 831ee21303 - Renamed "form.admin" to "form admin".
- Added node_admin_settings() to let users set node defaults.
    * Added _nodeapi("conf")
- Modified form_checkbox() to unset options. (Modified the patch from Ax.)
- Removed the _save() hook.
- Fixed a logical flaw in field_get() and field_set() which would break
  moderation.
- Moved some admin menus around and cleaned up some typos.
2003-03-07 22:11:44 +00:00
Kjartan Mannes dd329e1d95 - Added function node_invoke_all($hook, &$node, $op, $arg = 0).
- Added a _nodeapi hook that in time will replace the _node hook. Trying
  to make as few changes to existing code as possible until the new api
  is stabilized.
- Modified node_form() to add administration options from other modules
  using the _nodeapi hook.
- Modified node_save() to fetch which fields should be saved to the node
  table from the _nodeapi hook.
- Moved comment and queue options from node_form() and node_save() to
  the modules _nodeapi hooks.
2003-02-16 14:57:35 +00:00
Dries Buytaert 83f5d82876 - Everything is using theme("function") now instead of $theme->function(). 2003-02-15 11:39:56 +00:00
Dries Buytaert e90f3b883b - See http://lists.drupal.org/pipermail/drupal-devel/2003-February/021824.html. 2003-02-11 20:01:17 +00:00
Dries Buytaert 73d46a64c3 - Tidied up some SQL queries. 2003-01-20 20:18:06 +00:00
Dries Buytaert 0d384c8ead - Fixed "clean URL" glitch in queue module. Patch by Ax.
- Small improvement to url().  Patch by Ax.
2003-01-11 10:46:11 +00:00
Dries Buytaert 89b2069e4d - Clean URL patch. 2003-01-06 19:51:01 +00:00
Dries Buytaert de95001c92 - Tidied up the use of check_output(). Might make rendering pages a bit
snappier (performance improvement).
2002-12-31 12:34:07 +00:00
Dries Buytaert 7ce686c152 o Permission improvements:
+ Removed the "post content" permission and replaced it by more fine-grained permissions such as "maintain static pages", "maintain personal blog", "maintain stories", etc.

o Usability improvements to teasers:

   + Teaser forms are no more.  Teasers are extracted automatically but can also be instructed using a delimiter "---".  Furthermore, when a post it too short for a teaser, the user won't be bother with teaser stuff anymore.

   + Added an option to set the teaser length, or to disable teasers all together.

   + When previewing a post, both the short (if any) and the full version of a post are shown.  This addresses a common complaint; for example, when writing a book page there was no way you could preview the short version of your post.

   + Forum posts can be teasered now.  This is particularly helpful in the context of drupal.org where we promote forum topics.

o Bugfix: replaced all PHP short tags (<?) with long tags (<?php).

o Bugfix: removed hard-coded dependence on comment module.

o Bugfix: when the queue module was disabled, it was not possible to approve updated book pages.

o Bugfix: applied modified version of Marco's node_teaser() fix.
2002-12-10 20:35:20 +00:00
Dries Buytaert 1b733dc98a - Fix blocks of throttle and queue module. Patch by Gerhard. 2002-11-27 18:43:49 +00:00
Kjartan Mannes 8eed5abd86 - Fixing blocks for forum, queue and statistics. 2002-10-28 19:36:37 +00:00
Dries Buytaert a3a5dd45a7 - Fixed bug with queue module not displaying comments. Patch by Moshe. 2002-09-18 05:06:33 +00:00
Kjartan Mannes 9c23d8ae42 - cosmetics mostly. 2002-06-15 17:48:54 +00:00
Kjartan Mannes 28a7179a22 - fixing the moderation result block so both author and voters can see it. 2002-06-09 11:11:27 +00:00
Kjartan Mannes 5d36c70449 - improved module descriptions.
- removed admin options for queue and comment module if the modules are not
  loaded.
- nodes are now auto promoted when queue module isn't enabled.
- moderation result block is now visible by the node author.
2002-06-08 16:17:29 +00:00
Kjartan Mannes 4a28077f46 - adding descriptions to modules (thanks Joe + Scott).
- fixed comment flat list view missing 1 comment.
- changed update.php around a bit.
    * security check isn't in effect if the db hasn't been updated.
    * instructions re-organized.
    * fixed some minor updates.
- updated database.mysql done by UnConeD.
- changelog update.
2002-06-01 21:57:29 +00:00
Kjartan Mannes c1f617a3ab - fixing bug #181. 2002-05-16 09:32:01 +00:00
Kjartan Mannes 8c0d452d37 - added access checking to queue block.
- fixed queue block not showing up when it supposed to.
2002-05-12 20:12:23 +00:00
Kjartan Mannes f86a944979 - applied Stevens link patch.
- fixed block permissions.
- fixed user admin page errors: http://www.drupal.org/node.php?id=173.
- cleaned up common.inc a bit: removed format_info, path_img, field_merge.
2002-05-12 15:40:57 +00:00
Kjartan Mannes a4b5005640 - merged block and box modules. modules/box.module should be removed
or disabled as it will cause errors otherwise.

  - split status into status and custom. Status will turn the block
    on/off, and custom defined if the user can change the status.
    Requires sql update.

  - reintroduced user page to configure blocks.
2002-05-02 19:13:45 +00:00
Kjartan Mannes de5b9a168d - bug fixes:
* fixed mails not being parsed properly.
    * tracker now shows user name when you view your own recent
      comments.
    * link to submission queue now points to the right place.
    * fixed jabber module.
    * theme is now activated when changed.
- applied Gerhards coding style patch.
2002-04-22 09:05:36 +00:00
Dries Buytaert 8043cb998f - Applied Marco's big patch, including contributions from Moshe:
+ Changed the db_query() API.

    + Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.

    + XHTML-ified some HTML.

    + Wrapped a lot of text in the administrative pages in a t()
      function.

    + Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().

    + Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
      RSS code).

    + Fixed some bugs in the taxonomy module (eg. tree making bug), added
      new functionality (eg. new APIs for use by other modules), included
      Moshe's taxonomy extensions, and some documentation udpates.

    + ...
2002-04-20 11:52:50 +00:00
Dries Buytaert d8cd54969c - Added Marco's long-awaited taxonmy module and patches - a replacement
for the meta system.  The patches add some extra functionality to the
  comment system (for example, comments can be set read-only) and fix a
  couple of small problems.

  + I integrated the required SQL updates from the varius *.mysql files
    into the "update.php" script.  Upgrading should be easy ...

  + I did not apply/commit the "user.diff" as requested by Marco ...

  + I didn't know what to do with "forum.module" and "forum2.module":
    what do you want me to do with it Marco?  Which one should go in?

  + Can we remove "node_index()" now; both from "node.module" and the
    themes?

  + Thanks Marco!
2002-04-14 20:46:41 +00:00
Kjartan Mannes 7dfd5f0b7e - my editor got set up to insert tabs instead of spaces. Cleaning up. 2002-04-05 18:11:42 +00:00
Kjartan Mannes edfc930a41 - queued nodes can now be viewed by the author and the people who voted
for it.
- comments are shown below the queued node, can be disabled in the admin /
  settings and filters.
2002-03-20 20:04:23 +00:00
Dries Buytaert c1c612b128 - Made the calendar module accept a $date parameter such that you
can jump directly to a certain date in the archives.  Also made
  the calendar link to itself such that it is self-contained.

- Code beautifications: quoted a lot of arrays, removed dead code
  and simplified a few things.

- Replaced the Calendar class by one function "calendar_display":
  using a class (or class instance, or object) doesn't make sense
  in the archives' case.

- Renamed "calendar.module" to "archive.module".

- Fixed a /problem/ with node settings not always being saved like
  expected.

- Reorganized the user menu: renamed a couple of links for clarity
  and structure.

- Fixed a few typos.
2002-01-31 20:23:44 +00:00
Dries Buytaert d988dae61f - Applied Natrak's module improvements. 2002-01-30 18:15:02 +00:00
Dries Buytaert f9a508d5dd - Fixed more than 30 HTML and XML well-formedness errors. 2002-01-27 14:58:45 +00:00
Kjartan Mannes 8c672011a2 - moved user block from theme.inc to user.module.
* only problem is that the admin.php link is not available until the
      admin enables the block.
    * $theme->user is obsolete, will patch the themes properly in a
      later patch.
- moved moderation block from theme.inc to queue.module.
    * removed theme_moderation_results().
- updated database/database.mysql.
2002-01-21 17:31:13 +00:00
Dries Buytaert c71e133958 - Added about 50 title tags. 2002-01-07 22:08:52 +00:00
Dries Buytaert ad0401f806 - improved the watchdog messages 2001-11-23 19:26:49 +00:00
Dries Buytaert e641cacd01 queue.module:
- small visual bugfix
2001-11-18 20:47:53 +00:00
Dries Buytaert cc4d9fbe3f Experimental change:
- Blog entries get queued in the moderation queue for promotion.
2001-11-17 22:22:18 +00:00
Dries Buytaert ebb14ab94a - A couple of new node updates 2001-11-12 22:17:52 +00:00
Dries Buytaert 6642f2987e - node modules:
+ made some improvements to the node access checks

- queue module:
   + form()-ified the queue module and added some extra information
     or guidelines
   + added a few missing translations
   + ...
2001-11-12 20:15:08 +00:00
Dries Buytaert db47bac35e - node.module:
+ Changed node_form() to use good ol' tables instead of div/CSS-tags.

   + Revised the "revision API": I think we have both an easy and powerful
     API now that should make everyone happy.

   + Improved the usability of the rollback functionality a bit.

   + Removed the "view node" link from the "node overview" page in the
     admin section and added a "delete node" link instead.

   + Added a few missing translations; there might be missing more
     translations though.

- book.module:

   + Made the book module use the "revision API" instead of having it poke
     and use the innards and underlying details of the revision system.

- queue.module:

   + Made the queue module use the improved revision number.

- module.inc:
   + Applied Moshe's patch: added more arguments to module_invoke()

- mail-to-sql.pl:
   + Added support for more header fields and for folded fields

Notes:

- no database updates required
2001-11-05 22:59:11 +00:00
Dries Buytaert f88cfaa2dd - Another batch of updates. The most important bit is that the moderation
queue should be functional again.  It's not ready yet but I'll be tuning
  it for the next two evenings or so.
2001-11-04 23:30:39 +00:00
Dries Buytaert 23ca7a2d88 - Another batch of updates/improvements:
+ introduced basic node permissions ("create", "delete", "update" and
     "view") at the node level: it's up to the "<$node->type>_module" to
     hide gory details (if any).

   + made the "blog it"-feature in the blog and import module work with
     the new node system, in specific with the new centralized forms.

   + made it possible to update blogs.

   + made the page module work with the new node system.

   + various smaller improvements.
2001-11-01 17:04:20 +00:00
Dries Buytaert 336b713a5f - A large batch of updates, amongst them a rewritten node system. More
information available on the mailing list.
2001-11-01 11:00:51 +00:00
Kjartan Mannes 864c18d4c3 - added the CVS keyword $Id$ to all files to make future version tracking
easier. Also changed the <? tag to <?php in some cases.
2001-10-20 18:57:09 +00:00
Dries Buytaert 33a3502dfe - Removed a node's link ID (lid) as discussed on the mailing list. See
'updates/3.00-to.x.xx.mysql' for the required MySQL updates.

- Renamed some "author" fields to "uid" fields for sake of consistency.

- Fixed the coding style of some PHP files.

- Fixed the moderation queue (fairly untested though).

- Re-introduced the temporary SQL table in _node_get().

- Added a missing 'auto_increment' to 'updates/3.00-to-x.xx.mysql'.
2001-10-16 20:13:22 +00:00
Dries Buytaert b8c2f7f017 - replaced a header("Location: xxx") by a drupal_goto() 2001-10-12 18:20:19 +00:00
Dries Buytaert f1932821be - PEAR-ification of Drupal by claw: you can now host Drupal on a wide
range of databases including MySQL, PostgreSQL, MSSQL, and others.

  For additional information and an 'how to upgrade', check the mails
  sent to the mailing list.
2001-10-09 21:01:47 +00:00