Commit Graph

246 Commits (338130736750ab090a49b67130d3642a79195617)

Author SHA1 Message Date
Kjartan Mannes 3381307367 - Changed field_get/set() to be more efficent. 2001-06-24 18:33:13 +00:00
Dries Buytaert 0743b2cdbc - XHTML-ified search-related code. 2001-06-24 16:47:20 +00:00
Dries Buytaert d29684a664 - Added simple referer module, for sake of fun. 2001-06-24 11:38:08 +00:00
Dries Buytaert 5ff9dd653f - Made it possible to enter longer username such as 'Gerhard K*llesreit'.
- Updated database.mysql.
2001-06-23 14:59:15 +00:00
Dries Buytaert 72065fb835 - Added a brand-new access.module which allows you to manage 'roles'
(groups) and 'permissions' ... (inspired by Zope's system).

    + Once installed, click the help-link for more information.

    + See updates/2.00-to-x.xx.sql for the SQL updates.

- Modified loads of code to use our new access.module.  The system
  still has to mature though: new permissions have to be added and
  existing permissions need stream-lining.  Awaiting suggestions.

- As a direct result of the new access system, I had to rewrite the
  way the top-level links in admin.php are rendered and displayed,
  and xhtml-ified admin.php while I was at it.

TODO

- Home-brewed modules need updating, home-brewed themes not.
  (Examples: file.module, trip_link.module)

- As soon we *finished* the refactoring of the user system (KJ has
  been working on this refactoring already) we should consider to
  embed this role and permission code into account.module ...
2001-06-20 20:00:40 +00:00
Dries Buytaert d67486f79b - Changed '?meta=' to 'index.php?meta='. Patch by Simone. 2001-06-19 19:13:17 +00:00
Dries Buytaert 29e0e0fc66 - Made it so that usernames can contain spaces. Like that, people can
use their full name as their username.
2001-06-19 06:55:19 +00:00
Kjartan Mannes 8367d662fc Changes
- Modifed form_select() to accept an optional 6th parameter which is appeneded
  to the select tag. $value can now also be an array. This allows for multiple
  selects:
  form_select($header, $name, $values, $options, $help, "multiple=\"true\" size=\"10\"");
- Updated account.module to use the extended form_select() functionality.
2001-06-18 20:51:58 +00:00
natrak 6e64691450 Changes
- Moved account_password() and account_validate() to user.inc.
- Greatly reduced the number of SQL calls in account_save() when editing an
  account. Now uses one db_query() call instead of 1 + (2 * # of access
  granted).
- Fixed access not being saved when account was added.
- Should now be possible to edit and add accounts. There were certain bugs
  before that would cause odd errors.
2001-06-18 20:29:36 +00:00
Dries Buytaert 3d73a48edc - Merged "system settings" and "module settings" into one page. IMHO
it wasn't a good idea to split them up in first place, and it turned
  out to be quite hard to decide where to put some variables.

  Also moved some variables around and even renamed a few variables
  while doing so.

- Added a page_header() and page_footer() to all top-level .php pages.
2001-06-17 20:35:48 +00:00
Dries Buytaert 03c06a86eb Oops, a rather large commit:
- Changed meta.module, node.module and index.php to use comma-seperated
  lists of attributes rather then "foo=a,bar=b" lists.  This makes it a
  a lot easier to use both modules.  In addition, error handling can be
  discarded as it can't be made any simpler, really ...

  It fits rather nicely in Drupal's design so I'm getting more and more
  happy with this meta.module (but we are not 100% there yet).

- node.module, node.inc:

   + Improved the node-related admin interface so that navigating back
     and forth the administrative menus is made both easier and faster.

   + Removed some redundant database fields from the node table.  See
     2.00-to-x.xx.sql!

   + Added 2 news hooks called "node_insert" and "node_update".  Just
     like this is the case with the existing hook "node_delete" these
     new hooks will automatically get called when a node has been
     inserted or udpated.  Note that this is an optional call-back that
     only needs to be implemented when required.  With the addition of
     these two hooks, the node mechanism (version 1) is pretty well
     completed.

- watchdog.module:
   + Fixed bug whit the 'regular messages' query in the watchdog.module.

- book.module:
   + Fixed bug in book.module: the 'parent' was not set properly when
     updating a book page.
   + Made it so that older versions of a book page are automatically
     reactived upon deletion of the most recent version, i.e. when
     doing a version roll-back.

- comment.inc:
   + Undid Remco's patch to comment.inc; it does not work in some cases.


- conf.module:
   + Fine-tuned some of the options in conf.module a bit.

- marvin.theme:
   + Visual changes to make it look better on Windows browsers.  Mind
     to give some feedback on this?
   + Fixed 3 HTML typos/bugs.
   + XHTML-ified the theme at a best effort basis; I didn't carry the
     XHTML specification with me.
   + Made use of the theme_slogan variable to display the site's slogan.
   + As soon we have at least one valid XHTML theme we can wonder on how
     to integrate other XML namespaces (cfr. MathML story at drop.org).

- database.mysql:
   + Updated database.mysql so that it contains all the latest "database
     patches".
2001-06-17 18:31:25 +00:00
natrak d388033eb2 - Minor bug fix in node_links(). 2001-06-17 13:25:52 +00:00
natrak a7fddeb85a Changes
- Modified comment.inc to use form_*() functions. Might have some
  side-effects I haven't found yet. Report any problems.
2001-06-15 12:09:37 +00:00
Kjartan Mannes 7f58ef2970 Changes
- Added a conf option to disable/enable user registrations.
- Added a add account feature to account.module.
- Moved some functions from account.php to account.module.

Todo
- Move most (all?) of account.php to account.module.
2001-06-15 11:34:05 +00:00
natrak abcef73d19 - Fixed an error in variable_get(). If a variable was set to 0 it would return the
default value instead.
2001-06-15 10:41:18 +00:00
Dries Buytaert 96576a6ef7 - Added meta.module, an improved index.module that allows you to
associate different collections - think "combobox" here - with
  different content types, all hardcoded references to "section"
  have been removed and the admin-friendliness of the meta admin
  section has been slightly improved.

  I'll keep working on it during the weekend - if time allows me
  to.  Moreover, I'll focus on the usability/user-friendlines of
  the meta admin section as well as graceful input-checking, and
  error-handling.

  Requires an SQL update, see updates/2.00-to-x.xx.sql!

  Index.module will be removed, or meta.module will be renamed as
  soon we can ditch one of them.  For now, having both coexist is
  not going to harm your setup and is useful to make a comparison
  and / or to migrate from index.module to meta.module.

  Index.module is de-coupled form the rest of the system so you
  will have to use meta.module after having upgraded.  You have
  been warned.

- Updated CHANGELOG.
2001-06-15 07:30:44 +00:00
Dries Buytaert db92d73b6e - Improved watchdog and submission throttle: removed redundant code,
streamlined the existing code, added new watchdog type called "httpd"
  for Apache errors.  The latter should make it easier to add watchdog
  filters later on.

- Clarified some watchdog messages.
2001-06-13 21:37:19 +00:00
Dries Buytaert 67cfb7808f - Fixed typo; missing ". 2001-06-13 10:19:38 +00:00
Dries Buytaert 2285afd1e0 - Applied Remco's patch:
the <LI>-bullets were not valid HTML and did only take up space.
2001-06-13 08:48:47 +00:00
Dries Buytaert a7f9a38acf - Applied Remco's patch, but added a closing </LI>-tag as well. 2001-06-13 08:47:35 +00:00
Dries Buytaert 9c5cd7e2ab - Added missing </TD>.
(Patched by Remco.)
2001-06-13 06:34:44 +00:00
Steven Wittens 9e5878ae45 - Fixed "administer" not being locale'd. (req. by Gerhard) 2001-06-12 20:24:11 +00:00
Dries Buytaert c56ee67e29 - Changed field_set(), field_get() and field_merge() to use ',' and
'=' instead of ';' and ':'.  It is considered to be more readable.
  --> A _first_ step towards and improved index.module.  Stay tuned
      for more.

  + Important:
     If you update from CVS - apply the queries in 2.00-to-x.xx.sql!

- Changed all 'attribute' to 'attributes'.

  + Important:
     If you update from CVS - apply the queries in 2.00-to-x.xx.sql!

  + Important:
     This might require to ieni-wieni small update to your custom
     themes and/or node-related modules:
      - themes: node_index($node->attribute) -> node_index($node)
      - node modules: attribute -> attributes
2001-06-11 20:01:13 +00:00
natrak 83542a1b01 Changes
- fixed the trailing | in some cases.
- removed theme_morelinks().
- added node_links().
- simplified BaseTheme->links().
- updated themes.

Notes
- the new links system is taking form, but concider it beta. There might still
  be some major changes ahead so I suggest waiting a little longer before
  modifying your theme to take advantage of it.
2001-06-11 17:42:52 +00:00
Kjartan Mannes 8f7eddbed6 Changes
- fixed the trailing | in some cases.
- removed theme_morelinks().
- added node_links().
- simplified BaseTheme->links().
- updated themes.

Notes
- the new links system is taking form, but concider it beta. There might still
  be some major changes ahead so I suggest waiting a little longer before
  modifying your theme to take advantage of it.
2001-06-11 17:42:51 +00:00
Dries Buytaert d397bbe935 This a rather large commit that needs a lot of fine-tuning. If you
update, you'll break your site as you need switching from structure
to index.module: so this can be considered an intermediate commit.

If you upgrade, and you are welcome to, just create a collection
called "section" (for now) and assign your nodes some attributes
in the described format.

Feedback and bugreports are welcomed.  Questions will be answered.

CHANGES:

- comment system:
   + when replying to a node (rather then to a comment), that
     node is displayed above the reply form.
   + when replying to a comment (rather then to a node), that
     comment is displayd above the reply form.

- removed structure.inc, removed structure.module.

- node.inc:
   + added 2 new node functions called 'node_attribute_edit()' and
     'node_attribute_save()' used to 'hook in' any indexing system
    including your home-brewed stuff if you'd want to.  Currently,
    index.module is the facto default index system.

    See story.module for usage.

- book.module, story.module, poll.module, page.module, forum.module:
   + added preview functionality to administration section (via node
     module).
   + removed all references to structure.inc (category, topic).

- moderate.module:
   + removed all references to structure.inc (category, topic).

- book.module, story.module, page.module, forum.module:
   + increased the sizes of some textareas.

- submit.php:
   + removed all references to structure.inc (category, topic).

- marvin.theme:
   + removed dead code: function story() was depricated.

- unconed.theme:
   + removed hardcoded references to drop.org.

- marvin.theme, unconed.theme, jeroen.theme, yaroon.theme, example.theme:
   + removed all references to structure.inc (category, topic).

TODO:

- file.module, trip_link.module:
   + update preview functionality:
       see story.module for example.
   + remove references to 'cid' and 'tid', use 'attribute' instead:
       see story.module for example.

- extend and build upon index.module as well as making it configurable
2001-06-10 15:01:20 +00:00
Kjartan Mannes 9e4984588c Changes
- created a BaseTheme class in theme.inc.
- added links($links = array(), $status = 0, $node = 0) to BaseTheme.
- modified all themes to extend from BaseTheme.
- modiefied theme_link() to take advantage of $theme->links().
- theme_morelink() does not require a $theme argument.

Todo
- add the other standard variables and functions to BaseTheme.
- some themes could use some more modifications.

Weird
- marvin.theme still has a story() function.
2001-06-10 13:53:44 +00:00
Dries Buytaert f92981251f - Fixed inconsistent behavior of 'node_save()' and simplified the
algorithm a bit. --> Needs testing!  I improved this last night
  and only got around to testing this rather briefly/quickly.  It
  was to late already. ;-)

  (This is part of a larger set of changes I'm slowly working on
  which I will feed to CVS in steps after more testing.)

- Added 2 new node functions called 'node_attribute_edit()' and
  'node_attribute_save()' used to 'hook in' any indexing system
  including your home-brewed stuff if you'd want to.
2001-06-07 16:33:55 +00:00
Kjartan Mannes c94d9a063b - Updated the $themes array to include all the themes. 2001-06-07 10:57:41 +00:00
Dries Buytaert 4ba91a779a - Improved db_fetch_array() to return an associative array only:
passing around arrays should be less expensive.
2001-06-06 18:57:41 +00:00
Kjartan Mannes 949d4d956a - Modified error_handler() to ignore errors when @function() is used to
suppress errors. If ya suppress them you normally have a good reason to do
  so :-)
2001-06-04 19:02:38 +00:00
Dries Buytaert c75057bb0f CHANGES:
- Added improved node scheduler:

   + Automatically post node at date 'xx/xx/xx, xx:xx'.

   + Automatically queue node at date 'xx/xx/xx, xx:xx'.

   + Automatically dump node at date 'xx/xx/xx, xx:xx'.

  Requires a database update, see ./updates/2.00-to-x.xx.sql!

- Refactored the admin interface of node.module.  It is only a start
  but it should show the direction we are going.

   + The new interface is easier to extend with new functionality
     and operations.  New "edit xxx" links can easily be added on
     our way.

   + The new interface tries to cover all content- or node-related
     functions.  Thus making a special admin interface for each new
     node type redundant.  To demonstrate this, I removed the admin
     hook from page.module and forum.module.  This removes quite a
     bit of logic from the invidual modules which is a good sign if
     you ask me.

     A centralized GUI or interface covering all node-related
     administration should make Drupal easier to administer.

TODO:

- All node-related nodes need updating.  This should be trivial and
  I'll hapilly tackle this later tonight.

- There will be bugs, and I'm still working on this but I would like
  to get some feedback (from Natrak et all) on both user-friendliness
  and usability of this new interface.  I'm still working on it as we
  speak ...
2001-06-04 15:40:39 +00:00
Kjartan Mannes 6563382974 - Changed form_select() to return NULL if called without $options. This should
not have any impact, and makes things look nicer imo.
2001-06-04 15:06:47 +00:00
Dries Buytaert b0c349e247 - Moved most of the options in structure.module to node.module. The
structure.module either needs work, or replacement by index.module:
  see "admin > node > node settings".

  It will do for now and it can always made better when we can think
  of a better solution; it is the best I could think of.   Now what?
  index.module or structure.module?  I'm currently pro index.module.

- Drastically simplified "variable.inc".

- Removed most dependecies on structure.module from all content related
  modules.  Thus making our modules more modular.  ;)

- Fixed calculation glitch in queue.module.

- Fixed potential function name clash/conflict in rating.module, and
  simplified some code on my way.

- Started removing all global variables $status and $rstatus.  Global
  variables are "yucky" so in near future, we will replace all global
  $status variables by a call to node_status().  Originally, $status
  was only introduced as a temporary hack and nothing is as permanent
  as a temporary hack so I took it out when still possible.

- Changed the watchdog messages a bit.
2001-06-02 22:12:35 +00:00
Kjartan Mannes 3d0875fade CHANGES
- Modified check_mail() to allow '+' characters in mail addresses.

TODO
- Extend the regular expression to allow addresses valid in the RFC's.
  Currently IP domains are banned, and so are many other extensions of RFC
  822. This is not a priority since we currently support 96% of all addresses.
2001-06-02 06:05:56 +00:00
Dries Buytaert 255c56cc2b - Made the code generated by include/common.inc XHTML 1.0 compliant: all
forms should now be XHTML compliant. Just trying to get used to XHTML:
  :).
2001-05-31 18:47:43 +00:00
Kjartan Mannes 4152156260 - Fixed an extra <P> in form_file(). 2001-05-30 06:45:17 +00:00
Dries Buytaert 1a888395b9 - Removed a few lines of dead code. 2001-05-29 21:11:20 +00:00
Dries Buytaert 0b32787a9c - Added a experimental index.module to try out some of the discussed
techniques.  It does not work yet, nor is it integrated with the
  rest of the code.
2001-05-25 16:03:02 +00:00
Dries Buytaert bfc897d533 - Improved the rating module: made it possible to define "weights"
for the different content types.  These weights are used when
  calculating each user's gravity.  This is a required step before
  we can even think of "nodifying" the diary or headline module.

- Polished a bit more on the other modules' crons.
2001-05-24 21:49:10 +00:00
Dries Buytaert b0288a46d8 - Fixed small glitch in check_preview().
- Updated CHANGELOG.
2001-05-24 08:53:07 +00:00
natrak 886f653e21 - Fixed a "bug" with in_array. Behaves strangely when the key is of type long.
When $field was 0 it would return true, causing SQL errors. Seems to
  convert the string its being matched with to a numeric, normally 0. Forced
  $field to be treated as a string by enclosing it in quotes.
2001-05-23 18:36:12 +00:00
Dries Buytaert 532233a979 - Removed includes/timer.inc: it has been integrated in common.inc.
- Fixed a bug in node.php: UnConeD forgot to update 1 node_get_object().

- I changed the look of theme_morelink() a bit: it might not look better,
  but at least the output is "correct".

- Various small improvements.
2001-05-20 19:30:39 +00:00
Dries Buytaert 4f1cf00f9e - Improved node_get() so that it will try to skip one additional query
if possible (ie. to reduce the number of queries).

- Automatically removed tabs and trailing spaces from the poll.module.
2001-05-20 17:36:55 +00:00
Steven Wittens 27496c4620 - Changed the node_get_object() and node_get_array() functions to allow multiple conditions
- Added the "delete" hook for node-modules. When called, a module should do additional clean-up if necessary.

- Updated all node-modules
2001-05-20 16:47:50 +00:00
Dries Buytaert db2a569749 - Improved node_preview(). Fixes a problem with poll.module. 2001-05-20 16:06:48 +00:00
Dries Buytaert 20397ad3d9 CHANGES
- Redid settings.module and even renamed it to conf.module.
    * Settings are now grouped in basic categories like "system
      settings", "module settings" and "filters".
  * Added new settings to make Drupal easier to configure and
  to make some aspects like the watchdog scale better.

- Renamed includes/settings.php to includes/conf.php.

- Added filter support to conf.module and introduced filter hooks so
  modules can implement and export new filters.  Example filters are
  an HTML filter (implemented), a profanity filter, an url converter,
  ASCII smileys to images filter and so on ...

- Reworked the check_* functions: user contributed content/input is
  only verified and filtered once in its lifespan.

NOTES

- Altough this is a large commit, no database changes are required.
2001-05-20 13:51:40 +00:00
Dries Buytaert 34af2a3a8e CHANGES:
- Rewrote the cron system.  Removed cron.module and moved all cron
  related options to settings.module.  Cron was a confusing thing:
  it has been made simpler both in terms of code and configuration.

   + You had to rehash your modules to make the cron show up in
     the list.  This is no longer required.

   + You couldn't tell what cron "watchdog" or cron "story" were
     up to.  Instead, we now display a clear description message
     for every cron involved.

   + The user interface of setting.module - and the admin section
     in general, looks a bit ackward but I couldn't care less and
     don't want to see this improve at the time being.

- Improved setting.module:
   + Now uses variable_set().
   + Added some help and documentaition on how to setup cron.

- Improved ./export.

- Updated CHANGELOG.


TODO:

- I'm now going to look into UnConeD's question with regard to
  check_output() and $theme->node(), as well as the filter and
  macro stuff.  I'll probably be fine-tuning setting.module a
  bit more on my way.
2001-05-19 13:41:52 +00:00
Steven Wittens e7c727a634 Oops, I used sort() instead of asort(), which destroys the keys in associative arrays. 2001-05-18 22:03:05 +00:00
Steven Wittens 507b2a8cd1 Made module_list() return an alphabetically sorted list.
On Windows machines (not sure about *nix boxes) it's not always pre-sorted by the filesystem. It has no effect code-wise, but it will cause all module-lists in Drupal to be sorted alphabetically (e.g. the links in admin.php).
2001-05-18 21:57:52 +00:00