Commit Graph

366 Commits (2df7214a09fd2c38123d7767c29ed130b5c42052)

Author SHA1 Message Date
Dries Buytaert af5bc7cdef - Made the Xtemplate theme degrade gracefully when CSS is disabled. 2003-11-24 22:39:48 +00:00
Dries Buytaert 26735ac5dd - Committed phase 3 of JonBob's menu changes. Adds an API for modules to
define titles and breadcrumbs for their pages, and updates the theme
  system to display them.
2003-11-23 10:41:04 +00:00
Dries Buytaert 980637265c - Block and theme improvements. Patch by Ax.
+ block_list() (in block.module): returns an array of block objects for
     $region.
   + theme_blocks() (in theme.inc): uses block_list() and theme("block") to
     actually render them.

  Advantages:
   + Decouples blocks content and layout, allows block_list() to be used
     for non-output purposes (think "pull").
   + Unifies naming in theme.inc: render_blocks()) didn't really fit there.
   + Puts block_list() in blocks.module where it logically belongs.

- Removed some cruft from the Xtemplate theme.  Patch by Ax.
2003-11-19 16:13:07 +00:00
Dries Buytaert 3198d786a1 Xtemplate improvements. Patch #154 by CodeMonkeyX.
* Made all theme functions return their output.

 * Removed sidebar configuration options. (Sidebar placement is not configured
   through the block configuration screen.)
2003-11-19 06:39:46 +00:00
Dries Buytaert faed7168e1 - Theme marvin improvements by CodeMonkeyX. Patch #155:
* Made all functions return their output.
   * Made theme compatible with three column layouts.
   * Fixed problem where blocks were not being rendered properly.
2003-11-19 06:21:35 +00:00
Dries Buytaert a0640e66b7 - Improved module loading when serving cached pages. Moshe's bootstrap patch.
- Used legend and fieldset tags for the configuration page.
2003-11-18 19:44:36 +00:00
Dries Buytaert e27df450ab - Fixed FOUC problem using link tag. Patch by Eric Scouten. 2003-11-16 20:04:46 +00:00
Dries Buytaert ca7d8c0221 - Fixed typo in theme Marvin. Patch by Goba. 2003-11-14 20:31:05 +00:00
Dries Buytaert 00666649e8 - Removed the output buffering from the Xtemplate theme. 2003-11-11 13:01:45 +00:00
Dries Buytaert 951b553a98 - Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX. 2003-11-09 23:27:22 +00:00
Dries Buytaert 1f273dac01 - Committed stage 1 of the theme system improvements.
Some TODO's:
   * The sidebars of theme Marvin and theme UnConeD look unstyled.
   * CSS-ify theme UnConeD so we can remove the class around the functions.
   * Rewrite theme_init() not to use a class and simplify theme()
     accordingly.
2003-11-08 11:56:33 +00:00
Dries Buytaert ec33266795 - Improvement: made it possible to disable the comment controls and reworded some of the configuration settings.
- Improvement: removed a left-over from Drupal 4.2.0 (dead code).

- Improvement: replaced hard-coded XHTML around the XML icons with class="xml-icon".

- Improvement: removed the custom navigation menus shown at the top of the "user information page" and integrated them in the new navigation block.  The "my account" link in the navigation menu will unfold.  Also removed the "delete account" link/functionality (for now).

- Improvement: fix for "magic quotes" settings.  Patch by Steven.  I also removed check_php_settings().

- Improvement: block themability improvements.  Modified patch from Ax and Steve/CodeMonkeyX.

- Fixed bug #2617: editing user information does not work.  Patch by Kjartan.
2003-10-31 19:34:03 +00:00
Dries Buytaert ad4e4ccb2b - Bugfix: made theme UnConeD call theme_footer(). Patch by Gordon. 2003-10-20 17:13:07 +00:00
Kjartan Mannes c52185b680 - taxo_link always returns array().
- Remove dead code from Marvin theme.
- cleaner node html in Marvin.
2003-10-06 12:21:04 +00:00
Kjartan Mannes 9c0fd0149c - Fixed calling links() error if a node doesn't have any terms defined. 2003-10-06 10:03:14 +00:00
Dries Buytaert 5a667eb580 - Url aliasing improvements. Patch by Matt. See mailing list for more
information.
2003-09-30 17:01:34 +00:00
Dries Buytaert 949a7014df - As of now, the default placement of the Xtemplate theme's sidebar will be
on the left.  This is what people seem to expect.
2003-09-28 15:12:08 +00:00
Dries Buytaert 645d026e09 - Added $Id$ tags. Patch by Chris. 2003-09-25 07:27:22 +00:00
Dries Buytaert 8382ea5459 - Xtemplate improvements by Kristjan:
> no changes in presentation, just a structure changes
>
> - removed inline styles from .xtmpl
> - removed duplicated #header class reference, renamed second one to #content as context$
> - simplified some CSS selectors (tested on IE and mozilla, please test on Opera, if pos$
> - some .class -> #class

Note: tested on Opera; couldn't spot any differences.
2003-09-13 11:23:28 +00:00
Dries Buytaert ee35d9136e - Made the forum module's breadcrumb navigation fully themable. Patch by Nick.
- Changed 'pubdate' to 'pubDate'.  Patch by Kristjan.

- Fixed in Xtemplate theme; don't use return value of node_url() raw and uncut.
  Patch by me.
2003-09-12 18:13:22 +00:00
Dries Buytaert 9113a1ae28 - Fixed bug with taxonomy handling. Bug #2831. Port of patch by Jonathan
Chaffer.
2003-09-11 21:57:39 +00:00
Dries Buytaert 81591038cb - Added a "alt" attribute to the logo for sake of accessibility. 2003-09-10 19:27:49 +00:00
Dries Buytaert accebe358c - Commited Moshe's Xtemplate patch (slighty modified). 2003-09-07 17:51:50 +00:00
Dries Buytaert 1ed2329261 - Xtemplate improvements from Ax: "i find it annoying to have two empty blocks
(a blue - message - and a grey - footer - one) if my site doesn't have neither
  of them set."
2003-08-28 05:35:26 +00:00
Dries Buytaert c485b54555 - Fixed a number of small user experience inconsistencies pointed out by
Keith.
2003-08-23 10:11:10 +00:00
Dries Buytaert 4e2ee96d4c - Removed left-overs from the rating module. Patch by Gerhard. Updated the
PostgreSQL and MSSQL database scheme as well.

- Made sure the update script updates the correct tables when database
  prefixing is enabled.  Patch by Bart Jansens.

- Improved the breadcrumb navigation of the book and the forum module as per
  Keith Instone's suggestions.

- Updated page titles (or block titles) and links to match.  Suggested by
  Keith Instone.

- Added missing 'thread' field to the comment table of the MySQL database scheme.
  Fixes bug #2590.
2003-08-22 17:06:44 +00:00
Dries Buytaert 71ff873d7d - Added path aliasing support to the Xtemplate theme. Patch 98 by Matthias. 2003-08-16 06:31:49 +00:00
Dries Buytaert 5c40037c8e 1) Bugfix: changed INNER JOIN to LEFT JOIN to make forum topics with no comments show on the topic overview page.
2) Beautified the forum module views; rewritten to use the table() rendering functions, X HTML-ified the emitted code, added additional CSS tags, and removed hard-coded markup.  This improves themeabality; it should be able to mimic the view and color scheme of, say, http://www.phpbb.com/.

3) Reorganized forms and links (interactive elements) to improve usability.  Also ensured that the link names and page titles match.

4) Temporary removed container functionality: this simplified the work and eliminated some usability issues.
2003-08-15 15:17:23 +00:00
Kjartan Mannes 48805032c8 - Applied modified version of almaw's 0064 patch: form item attributes.
- Applied modified version of mathias' 0073 patch: node form name.
  $params["options"] is now an array so some contrib modules might
  need minor changes.

- Applied mathhias' 0074 patch: missing access check on who is new
  block.
2003-08-12 20:37:16 +00:00
Dries Buytaert b59094355a - Made the tracker module link to your own posts. Patch 79 from Gerhard.
- Added a permalink to the Xtemplate theme.  Requested by Scott.

- Added pager support to the locale module.
2003-07-09 18:39:46 +00:00
Dries Buytaert 34a859b96c - Bugfix: the message bog was no longer shown because of the "Default front
page" changes.  Patch by Ax.
2003-06-22 06:43:51 +00:00
Dries Buytaert 25081b2103 - Improvement: CSS improvements for the calendar block in theme UnConeD.
Patch #40 by Al.
2003-06-20 05:07:39 +00:00
Dries Buytaert 2f149c56e7 - Fixed some link colors. Patch by Kristjan. 2003-06-18 20:52:24 +00:00
Dries Buytaert 70d1edd8bd - Improvement: more CSS improvements to the Xtemplate theme. Thanks Kristjan
and Al.
2003-06-18 17:40:51 +00:00
Dries Buytaert ec428637a4 - More XHTML-ifications from GmbH. 2003-06-17 21:26:51 +00:00
Dries Buytaert 00baac2c4f - Improvement: made theme Marvin's calendar look better. Patch #16 by Al.
Thanks!
2003-06-16 17:13:33 +00:00
Dries Buytaert ef8735614f - Improvements: XHTML-ifications. Patch by GmbH. See feature #1813. 2003-06-16 17:09:23 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert d95499bf03 - Bugfix: small Xtemplate fixes. Patch by Ax. (Slightly modified.)
- Bugfix: block patch fix.  Patch by Gerhard.

- Bugfix: fixed broken URL in ping.  Patch by Gerhard.

  (This should fix the problems shown on http://www.blo.gs/info.php?id=1515.)

- Improvement: added better password generator.  Patch #1 by Al.  Fixes bug
  #1935.

- Improvement: performance improvement to the blog module.  Patch by Marco.
2003-06-13 17:34:18 +00:00
Dries Buytaert 1a2576036b - Bugfix: charset fixes/clean-up. Patch #52 by Al.
- Improvement: renamed some theme functions of the forum module for sake of consistency/readability.  Patch #2 by Kristjan.

- Improvement: usability improvements to the Xtemplate theme.  Patch #3 by Kristjan.

- Improvement: CSS'ified the book module pages.  Patch #3 by Al.  (I simplified the "l
ocation" part.  Al's approach gave you a bit more power but I'm not sure anyone wants
to change that.  Besides, this will change as soon we integrate the menu system so I kept it easy for now.)
2003-06-12 17:24:06 +00:00
Dries Buytaert f60135d2d6 - The calendar block was somewhat cramped compared to the rest of the site's layout. Adding a small padding. 2003-06-07 16:02:00 +00:00
Dries Buytaert 7f95b768ff Usability improvements to the Xtemplate theme by Kristjan and Al:
- added a subtle lineheight to nodes and #message

- removed specific link colors for taxonomy terms and node links. Found it confusing, specially in context with a:visited color.

- added a gray background, border and padding for <pre> tag, to make Drupal documentation pages more nicer.

- nested search form into <div>s in order to validate as XHTML Strict. Modified patch by Alastair.

- incorporated all of Alastair's patches to replace px-based padidngs with em-ones

- fixed the footer font size and Y-centered it

- removed class from seach <form>, put it in the surrounding <div> instead

- added class for submit

- simplified the search box's CSS, it is looking much more cleaner now
2003-06-06 18:11:40 +00:00
Dries Buytaert 3998bfad45 - Bugfix: the Xtemplate theme didn't check whether the taxonomy was enabled.
Patch by Ax.
2003-06-06 17:24:24 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 05288ac48a - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents
to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.

- Bugfix: the admin module does now import drupal.css prior to admin.css.
Patch by me.

- Bugfix: the admin module was still emitting a <base href=""> tag.  I
removed this as it is been taken care of by theme_head();  Patch by me.

- Bugfix: made the tracker module's pager only consider published pages.
Patch by Moshe.

- Bugfix: cured some typos in the comment module's help function.  Patch by
Marco.

- Bugfix: fixed a typo in the pager_display() that caused optional
attributes to be discarded.

- Bugfix: made the Xtemplate emit empty boxes like any other theme does.
Patch by Al.

- Bugfix: fixed broken link on the statistics module's log page.
Reported by Kjartan.

- CSS improvements: made the HTML output emitted by the tracker module
look nicer.  Patch by Moshe and Al.

- CSS improvements: added CSS classes for form elements.  Patch by Al.

- CSS improvements: added a vertical gap between the last form item and the
submit button.  Patch by Al.  Note that Opera 6 is not picking up this
CSS but apparently others browsers such as Konqueror do.

- Xtemplate improvements: changed the color of the selected day in the
archive module's calendar.  Patch by Al.

- Usability improvements: made the "birthday" field of the profile module
look nicer.  Patch by Al.

------

- TODO: it might be a good idea to emit the following meta tag in the
theme_head() function:

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

Currently, some themes (and modules!) emit this while others don't.  This
would also make it possible to change the charset site-wide.

- TODO: now we added support for td.dark and td.light to drupal.css, maybe
it can be removed from admin.css as well as xtemplate.css?
2003-06-03 18:04:47 +00:00
Dries Buytaert c9bdea34e3 - Made all CSS definitions look alike. 2003-06-01 18:11:27 +00:00
Dries Buytaert 39f6a9e79a - CSS improvements to the calendar of the archive module. Updated the Xtemplate
theme and theme Marvin to take advantage of this.  Patch by Al.  Pretty stuff.
2003-05-31 12:42:02 +00:00
Dries Buytaert d00c957113 - Import the theme specific stylesheet after importing drupal.css. 2003-05-30 07:33:37 +00:00
Dries Buytaert 514a1a96ed - Remove the <base href="">-tags from the themes; these are being added by
theme_head().
2003-05-30 05:49:57 +00:00
Dries Buytaert f7e11d3bb7 - The check_output()s slipped back in. Removing them again. 2003-05-29 10:16:11 +00:00