Commit Graph

333 Commits (27716da3073515eb3749413152e55bf763e6f3fc)

Author SHA1 Message Date
Dave Long 86bd3d1299
Issue #3263668 by omkar-pd, Wim Leers, hooroomoo: Re-enable inline form errors in assessActiveTextEditorAfterBuild function 2024-01-12 12:16:27 +00:00
catch eb98cb83e8 Issue #3413933 by Spokje: Remove astray $session->getPage(); from CKEditor5FragmentLinkTest::testFragmentLink 2024-01-11 20:54:20 +00:00
catch 4ca4dbaabe Issue #3328456 by xjm, dimitriskr, murilohp, smustgrave: Replace substr($a, 0, $i) with str_starts_with() 2024-01-08 10:48:04 +00:00
Lee Rowlands 9add7f71ff
Issue #3399373 by mstrelan, xjm, longwave, quietone: Add declare(strict_types=1) to all Unit tests 2024-01-03 15:25:34 +10:00
Lauri Eskola 49175bf5c0
Issue #3410104 by ravi kant, Wim Leers, KlemenDEV: [10.2 regression] CKEditor 5 image button is missing icon 2023-12-22 10:59:47 +02:00
Lee Rowlands 60a38dae9e
Issue #3388985 by kim.pepper, Wim Leers: Make CKEditor5ImageController reuse FileUploadHandler 2023-12-22 11:19:19 +10:00
catch ffc56d52d5 Issue #3406732 by longwave, lauriii, Wim Leers: Update CKEditor 5 to 40.2.0 2023-12-13 09:52:17 +00:00
Lee Rowlands 5247e64236
Issue #3400018 by mstrelan, xjm: Add declare(strict_types=1) to all Functional JavaScript tests 2023-12-13 08:27:06 +10:00
xjm b70dfff449
Issue #3401994 by mstrelan, dww, xjm, smustgrave, nicxvan: Add declare(strict_types=1) to all test traits 2023-12-09 08:40:55 -06:00
Dave Long bcf5a9159e
Issue #3396628 by Wim Leers, smustgrave, lauriii, xjm, catch: Fix <ol start> → native CKEditor 5 functionality and fix bug in SourceEditingRedundantTagsConstraintValidator that allowed it to slip by 2023-11-28 22:29:53 +00:00
Alex Pott 007c0c776c
Issue #3401883 by Wim Leers, phenaproxima, alexpott, borisson_, bircher: Introduce Mapping::getValidKeys(), ::getRequiredKeys() etc 2023-11-23 14:13:19 +00:00
Lee Rowlands 83752e6bc0
Issue #3396310 by longwave, Spokje, smustgrave: Use autowiring for core controllers 2023-11-20 08:15:53 +10:00
Lauri Eskola e8d2c22ac1
Issue #3347721 by Wim Leers, dabley, lauriii, smustgrave, witeksocha, Reinmar, thatipudir: [Style] Warn the user about styles for unsupported elements 2023-11-17 13:24:29 +02:00
Lauri Eskola 2a95e3fd3e
Issue #3316274 by Wim Leers, catch, nod_, alexpott, longwave, bnjmnm: Stabilize FunctionalJavascript testing AJAX: add ::assertExpectedAjaxRequest() 2023-11-16 15:56:19 +02:00
xjm 35cfa70992
Issue #3399754 by mstrelan, smustgrave, xjm: Fix strict type errors in functional JavaScript tests 2023-11-15 13:22:04 -06:00
Dave Long 54862ffce4
Issue #3400791 by Spokje, Wim Leers: Update CKEditor 5 to 40.1.0 2023-11-15 17:00:35 +00:00
xjm 8a739dc5a2
Issue #3379495 by quietone, xjm, smustgrave: Convert enable/disable to install/uninstall in hook_help() 2023-11-12 11:53:44 -06:00
Dave Long 5f533ca660
Issue #3017054 by alexpott, deviantintegral, percoction, mattwith, ankithashetty, Wim Leers, jwilson3, longwave, bircher: Consistently sort filter formats to simplify config exports 2023-11-11 12:38:56 +00:00
Dave Long 66716dc920
Issue #3342874 by star-szr, Wim Leers, DamienMcKenna: Allow inline HTML comments in CKEditor 5 2023-11-11 12:12:12 +00:00
catch 8c351e0298 Issue #3393557 by Wim Leers, Spokje, catch, smustgrave, niegowski, witeksocha: [upstream] Update CKEditor 5 to 40.0.0 2023-11-03 13:24:57 +00:00
nod_ 928eba018a
Issue #3397115 by longwave, quietone: Upgrade eslint and prettier 2023-11-03 10:17:39 +01:00
Dave Long c09c0e59d4
Issue #3390969 by quietone, Shyam_Bhatt, smustgrave: Cleanup cspell directives 2023-10-18 11:47:46 +02:00
Lauri Eskola 116c87e47e
Issue #3378890 by Wim Leers, mikesimmons, smustgrave, pmkanse, witeksocha: Add the "Show Blocks" functionality that existed in CKEditor 4 and was added to CKEditor 5 38.1.0 2023-10-11 09:47:42 +03:00
Lauri Eskola 8b0a91f602
Issue #3351600 by andrew.farquharson, Ranjit1032002, Anybody, sanduhrs, gmateos, smustgrave, Wim Leers, ant1, catch: ckeditor5.dialog.fix.js throws "Uncaught TypeError: event.target.classList is undefined" in Firefox in Drupal 10 with the editor in a modal 2023-10-11 08:47:12 +03:00
Alex Pott 6118e0dc37
Issue #3389282 by quietone, smustgrave, alexpott: Fix spelling for words that are only misspelled in comments 2023-10-08 09:34:52 +01:00
Alex Pott ae55070f94
Issue #3391268 by quietone: Fix spelling of words only misspelled in tests, part 4 2023-10-05 16:21:57 +01:00
Alex Pott 201ae2e354
Issue #2441811 by longwave, daffie, andypost, edurenye, lauriii, joseph.olstad, Wim Leers, smustgrave, effulgentsia, alexpott, larowlan, chx, jibran: Upgrade filter system to HTML5 2023-10-04 09:39:17 +01:00
Lauri Eskola c669e40652
Issue #3388505 by catch: CKEditor 5's Functional JS tests take a long time to run 2023-09-29 13:08:03 +03:00
Lauri Eskola f638625bb0
Issue #3390341 by quietone, smustgrave: Remove words removed from file but still in cspell:ignore lines 2023-09-29 10:26:24 +03:00
Lauri Eskola 43169249b6
Issue #3389839 by catch: Mark some more tests #slow 2023-09-28 22:52:16 +03:00
Lauri Eskola e1fc76a1d2
Issue #3273986 by ifrik, xurizaemon, rpayanm, Wim Leers, Charles Belov, jonathan_hunt: Third option for the CKEditor 5 "Language" button: site_configured (in addition to un and all) 2023-09-28 12:00:06 +03:00
Lauri Eskola 22576037d7
Issue #3264940 by star-szr, jungle, smustgrave, lauriii: Add optional parameter to Nightwatch drupalInstallModule command to enable module dependencies 2023-09-27 20:19:52 +03:00
Lauri Eskola b00c941076
Issue #3362386 by JeroenT, Wim Leers, smustgrave: CKEditor 5 should respect <textarea disabled> 2023-09-27 19:28:32 +03:00
Lee Rowlands 6d93485084
Issue #3386458 by catch, quietone, alexpott, larowlan: Add GenericModuleTestBase and use it to test general module things 2023-09-26 09:14:17 +10:00
Lee Rowlands 0af9348ce7
Issue #3388365 by catch, larowlan, bbrala, smustgrave: Distribute @group #slow tests between test runners and mark more tests 2023-09-26 07:27:04 +10:00
Lauri Eskola d59acaf826
Issue #3381557 by nmangold, lauriii, Wim Leers, joshuami: [DrupalMedia] Formatting lost when attempting to edit media within a list item in CKEditor 5 2023-09-25 08:24:50 +03:00
effulgentsia 4401dc2d71 Issue #3382453 by Wim Leers, smustgrave, borisson_: \Drupal\Tests\ckeditor5\Kernel\ValidatorsTest::test() obscures 2nd, 3rd etc violation message for the same property path 2023-09-22 11:21:17 -07:00
catch 531383c170 Issue #3384764 by fjgarlin, longwave: ImageUrlTest fails on GitlabCI integration 2023-09-04 17:54:57 +01:00
Lauri Eskola 67360f2abd
Issue #3341682 by Wim Leers, phenaproxima, borisson_, catch, alexpott: New config schema data type: required_label 2023-08-17 12:29:30 +03:00
Lauri Eskola 1b920b2966
Issue #3368509 by Spokje, Wim Leers, quietone: [Random test failure] Random failure in CKEditor5AllowedTagsTest::testMediaElementAllowedTags 2023-08-16 20:40:51 +03:00
Dave Long 5cc339ea60
Issue #3380637 by lauriii, Wim Leers: Update CKEditor 5 to 39.0.1 2023-08-16 16:11:02 +01:00
Lauri Eskola 2014af7eed
Issue #3326261 by juanolalla, Wim Leers, lauriii, smustgrave, witeksocha, jwilson3, ChrisSnyder, ericras, Reinmar, jds1, Luke.Leber: [Style] Add tests for inability to apply styles to <div>, <ul>, <ol>, <table> etc. in CKEditor 5 — and <a> allows applying it to all elements 2023-08-16 15:05:25 +03:00
Dave Long f5de3b7a40
Issue #3377562 by Wim Leers, Spokje, Reinmar, witeksocha: Update CKEditor 5 to 39.0.0 2023-08-04 11:56:11 +01:00
Lauri Eskola a9199caf7c
Issue #3362456 by NickDickinsonWilde, Wim Leers, borisson_: Fix all ExtensionExistsConstraint constraint violations in tests 2023-08-01 20:08:47 +03:00
Lauri Eskola f13ad693c8
Issue #3361534 by Wim Leers, borisson_, longwave, catch: KernelTestBase::$strictConfigSchema = TRUE and BrowserTestBase::$strictConfigSchema = TRUE do not actually strictly validate 2023-07-26 20:30:33 +03:00
Dave Long 224c67343b
Issue #2921133 by quietone, VladimirAus, xjm, ankithashetty, longwave, Prem Suthar, smustgrave, benjifisher, AaronMcHale: Remove "Please" from the codebase 2023-07-23 17:33:54 +01:00
Dave Long 44cc4df762
Issue #3136459 by ranjith_kumar_k_u, dishabhadra, Gauravvvv, priyanka.sahni, smustgrave, sheldonreed3: Filter tips disappear when changing of text format is cancelled 2023-07-22 15:32:35 +02:00
Adam G-H 6f3215938f Issue #3373653 by phenaproxima, Wim Leers, borisson_, penyaskito, andypost, lauriii, smustgrave, larowlan: Add a `langcode` data type to config schema 2023-07-21 21:58:09 +00:00
catch 3d4e3fc793 Issue #3264148 by neclimdul, Wim Leers, xjm: remove inner _add_ajax_listeners_to_plugin_inputs and _add_attachments_to_editor_update_response function definitions 2023-07-19 12:30:32 +01:00
Dave Long 69333763c3
Issue #3224941 by andypost, Akram Khan, ravi.shankar, SandeepSingh199, Spokje, catch, xjm, alexpott: Remove usage of setAccessible() when core requires PHP 8.1 2023-07-18 16:45:43 +01:00
Lauri Eskola 91609efdee
Issue #3372922 by Spokje, darvanen, msbtterswrth, Wim Leers: Regression: infinite height prevention disables scrolling in Source view 2023-07-11 20:13:36 +03:00
Dave Long b5bff58343
Issue #3364378 by Wim Leers, borisson_: Tighten CKEditor 5 kernel tests 2023-07-05 23:10:03 +01:00
Dave Long 93aa6832a5
Issue #3324225 by BramDriesen, Wim Leers, Emil Stoianov, smustgrave, pmagunia, lauriii, Graber: Support CKEditor 5's table properties and cell properties plugins in Full HTML 2023-07-05 22:49:41 +01:00
Lauri Eskola d80291c275
Issue #3326455 by el7cosmos, lauriii, joshuami, zenimagine, Wim Leers, smustgrave: [drupalMedia] When media is embedded in a view mode whose display is configured to link elsewhere, that link should not be clickable in CKEditor 2023-06-28 21:17:56 +03:00
Lee Rowlands 79c7666a86
Issue #3221793 by kim.pepper, larowlan, smustgrave, Wim Leers, joachim, gabesullice: Move file upload validation from file.module to constraint validators 2023-06-23 12:28:23 +10:00
Lauri Eskola dd9c718324
Issue #3356929 by Wim Leers, kevinquillen: Provide an upgrade path from "codesnippet" contrib CKEditor 4 plugin to "CodeBlock" core CKEditor 5 plugin 2023-06-20 14:56:38 +03:00
Lauri Eskola 9c505099c7
Issue #3367204 by JeroenT, smustgrave, neclimdul: [CKEditor5] Missing dependency on drupal.ajax 2023-06-20 09:07:27 +03:00
catch 8053a61b67 Issue #3367433 by Spokje: [random test failure] \Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testViewMode random fail 2023-06-19 13:57:40 +01:00
Lauri Eskola fc024f3520
Issue #3309585 by Mingsong, Wim Leers, Chi: CKEditor 5 Style plugin configuration tab does not appear 2023-06-15 08:04:31 +03:00
catch cd8430a3a6 Issue #3366081 by Spokje: [random test failure] MediaTest:: testEditableCaption() 2023-06-14 14:35:06 +01:00
catch b83467eabc Issue #3325557 by longwave, mondrake, kim.pepper: Enable more service autowiring by adding interface aliases to core modules 2023-06-14 13:59:48 +01:00
catch d838d8c084 Issue #3366633 by Spokje: Uncomment assertions in StyleTest related to https://github.com/ckeditor/ckeditor5/issues/11709 2023-06-14 10:32:23 +01:00
Lauri Eskola 3b6179f198
Issue #3332456 by Spokje, jastraat: [random test failure] MediaTest::testLinkManualDecorator() 2023-06-13 21:41:34 +03:00
catch 6ef863a2a3 Issue #3354382 by mondrake: [PHPUnit 10] Provide a static viable alternative to $this->prophesize() in data providers 2023-06-07 09:37:15 +01:00
Lauri Eskola 30a54c92ec
Issue #3348603 by lauriii, joelpittet, Wim Leers, catch, smustgrave, witeksocha: CKEditor 5 resizes images with % width instead of px width (the CKEditor 4 default): breaks image captions *and* is a regression 2023-05-24 17:32:23 +03:00
Dave Long 47c4939fec
Issue #3361800 by Wim Leers, neclimdul, smustgrave: Update CKEditor 5 to 38.0.0 2023-05-22 22:34:10 +01:00
catch dd5a5b712e Issue #2962088 by yogeshmpawar, jvsouto, Rassoni, Prashant.c, bhanuprakashnani, quietone, cilefen, longwave, drumm, smustgrave: Convert drupal.org to example.com in tests 2023-05-11 13:53:48 +01:00
Lauri Eskola bd5f9c01a3
Issue #3227354 by JeroenT, bnjmnm, Wim Leers, jungle, VladimirAus, lauriii, RenatoG, nmangold, Gábor Hojtsy, el7cosmos, catch, mandclu, freelock, ckrina, witeksocha, Reinmar: Add support for ckeditor5-autoformat 2023-05-09 10:54:14 +03:00
catch 609e7442cb Issue #3353658 by mondrake, smustgrave: [PHPUnit 10] Provide a static alternative to randomMachineName() and implement in data providers 2023-05-04 13:31:39 +01:00
catch 0c59ee88d4 Issue #3282233 by alexverb, Wim Leers, mherchel, lauriii, Tanuj.: Ability to configure additional languages (e.g. "bash" or "SQL") for CKEditor 5 CodeBlock plugin 2023-04-27 13:04:00 +01:00
catch 8e47435768 Issue #3355358 by Wim Leers, lauriii, bnjmnm, smustgrave: Update CKEditor 5 to 37.1.0 2023-04-25 09:58:15 +01:00
Lauri Eskola 8f9e0bd083
Issue #2911932 by bnjmnm, arnaud-brugnon, EthanT, leslie.cordell, smustgrave, nod_: Correct vertical tab does not focus on form validation 2023-04-24 09:59:33 +03:00
Lauri Eskola 1996c9d44d
Issue #857312 by bnjmnm, tim.plunkett, yched, swentel, nod_, nick_schuch, smustgrave: Add a "changes not applied until saved" warning when changing widget/formatter settings 2023-04-20 19:10:52 +03:00
bnjmnm bf91219364 Issue #3343212 by markconroy, andy-blum, bnjmnm, longwave, alexpott, lauriii, codexmas, harsha012, rpayanm, occupant, Mukeysh, leahtard, joelpittet: Update Core CSS to use double-colon for pseudo elements 2023-04-17 13:22:55 -04:00
Dave Long 99492c0288
Issue #3351095 by Spokje, daffie, longwave, xjm: Fix PHPStan L1 errors "@covers value foo references an invalid class or function." 2023-04-16 22:56:57 +01:00
catch c0cc344fb6 Issue #3336780 by diegors, schlaukopf, xjm, fabiansierra5191: Correctly capitalize "url" in documentation only, part 2 2023-04-12 15:28:50 +01:00
Lee Rowlands 492594cb05
Issue #3347212 by miikamakarainen, sakthi_dev, Yogesh Sahu, lauriii, Nikhil_110, Wim Leers, smustgrave, borisson_: "Add or select media" not translated 2023-04-03 17:03:05 +10:00
Dave Long 56a7a8e28c
Issue #3351596 by dww, catch: Skip Drupal\Tests\ckeditor5\FunctionalJavascript\MediaLibraryTest 2023-03-31 20:04:56 +01:00
Lee Rowlands e64297eef2
Issue #3341737 by acbramley, lauriii, gordon, jptaranto, Wim Leers: CKEditor 5 content squashed in off-canvas sidebar 2023-03-31 10:59:07 +10:00
catch 1f7aa7ac83 Issue #3351218 by Spokje: Fix PHPStan L1 errors "@covers value \Foo\Bar::baz() references an invalid method." 2023-03-30 16:22:57 +01:00
catch 821cc64ae6 Issue #3351067 by Spokje: Fix PHPStan L1 errors "Class already @covers \Foo\Bar so the method @covers is redundant." 2023-03-29 21:18:34 +01:00
catch 9a527be34d Issue #3344083 by longwave, lauriii, Wim Leers, smustgrave: Update CKEditor 5 to 36.0.1 2023-03-24 09:41:54 +00:00
catch b3fac4a09f Issue #3328454 by xjm, Bhanu951, jidrone, smustgrave: Replace most strpos() !== FALSE or === FALSE with str_contains() 2023-03-18 11:30:09 +00:00
catch 4e655558a4 Issue #3231322 by Wim Leers, pradhumanjainOSL, smustgrave, lauriii: Fix a @todo: move a form alteration to the CKEditor 5 plugin's subform definition 2023-03-17 12:22:51 +00:00
Lauri Eskola 982b97a48b
Issue #3331548 by longwave, smustgrave: Remove obsolete user-modify CSS property 2023-03-17 09:46:02 +02:00
Dave Long de09fc95c5
Issue #3322743 by Spokje, mondrake: Fix PHPStan L2 errors "Parameter $foo of method Foo::bar() has invalid type Foo\Baz." and "Method Foo::bar() has invalid return type Foo\Baz. " 2023-03-12 19:15:58 +00:00
bnjmnm 778bdaa6db Issue #3331835 by Spokje, znerol, smustgrave, murilohp, bircher: Some JavaScript errors are not recorded during test runs 2023-02-15 07:27:18 -05:00
Lauri Eskola c3a9cde83a
Issue #3273755 by frega, Dom., glynster, mherchel, claudiu.cristea, nayana_mvr, ifrik, Wim Leers, Reinmar, saidatom, catch: CKEditor 5 should not grow to infinite height 2023-02-13 15:09:42 +02:00
Lee Rowlands 9fbbf6e52e
Issue #3339400 by gxleano, royalpinto007, VladimirAus, fjgarlin, longwave: Incorrect use of FormattableMarkup in logger messages 2023-02-11 08:14:21 +10:00
xjm 1b41f3bade
Issue #3099878 followup by Wim Leers, ricksta, mark_fullmer 2023-02-07 18:11:49 -06:00
catch 652709e400 Issue #3328443 by xjm, rpayanm, alexpott, catch, longwave: Replace most strpos() === 0 or !== 0 with str_starts_with() 2023-01-27 12:37:01 +00:00
xjm 66ac2064fe
Issue #3185640 by lucienchalom, jungle, smustgrave, ravi.shankar, andregp, xjm, quietone, sergiogsanchez: Fix or ignore words that start with "v", excluding real non-English words 2023-01-16 10:36:05 -06:00
catch d496172480 Issue #3306597 by Wim Leers, Anchal_gupta, _utsavsharma, smustgrave: Improve usability of the "Enable image uploads" checkbox 2023-01-06 10:06:41 +00:00
Alex Pott 6e2e2cd055
Issue #3326778 by Graber, Wim Leers, Web-Beest, catch: TypeError: Drupal\ckeditor5\HTMLRestrictions::__construct(): Argument #1 ($elements) must be of type array, Drupal\ckeditor5\HTMLRestrictions given 2023-01-05 18:56:02 +00:00
Lauri Eskola eddae13734
Issue #3241295 by mherchel, glynster, _utsavsharma, Emil Stoianov, rkoller, Wim Leers, gaurav-mathur, DeepaliJ, geek-merlin, tgoeg, ckrina, mgifford, zcht, Dom., smustgrave, nod_, mstrelan, RgnYLDZ: CKEditor 5 isn't respecting field widgets row settings 2022-12-29 16:29:43 +02:00
xjm 2fc4938710
Issue #3099878 by Martijn de Wit, lauriii, mel-miller, _utsavsharma, eric.chenchao, phenaproxima, seanB, xjm, Sivaji_Ganesh_Jojodae, idebr, ckaotik, morganlyndel: Media Library: Default value for data-align attribute should not be center 2022-12-21 14:20:33 -06:00
xjm 36a8edd987
Issue #3327853 by Spokje, bbrala, longwave: Don't allow {@inheritDoc} annotation in PHPDocBlocks 2022-12-19 17:16:19 -06:00
catch 5443367eb8 Issue #3326896 by longwave, lauriii, Wim Leers, effulgentsia, catch, xjm: Update CKEditor 5 to 35.4.0 2022-12-14 11:05:53 +00:00
Alex Pott a266ba6e62
Issue #3247795 by heddn, Graber, ravi.shankar, yogeshmpawar, Anchal_gupta, Wim Leers, Fabianx, alexpott, benmorss, catch: Add text filter plugin to support <img loading="lazy"> and remove it from editor_file_reference 2022-11-30 16:33:11 +00:00
catch f8fad5fee1 Issue #3324540 by alexpott, longwave: PHPCS fails on Drupal 10 & 9 2022-11-30 13:47:28 +00:00