Commit Graph

177 Commits (2639c1d42f58fd6db6035f88b6860c2e6931af74)

Author SHA1 Message Date
Dries Buytaert 2dcb890477 - Fixed bug #4771: variable_get(site_name, ...) -> variable_get('site_name', ...); 2003-12-22 22:54:59 +00:00
Dries Buytaert 770174b299 - Updated documentation, small bug fix and small improvements to the <label>
tags.

  To be discussed and investigated: when a form element has no title an empty
  <label> tag will be emitted (eg. "remember me" checkbox).  This doesn't make
  sense but is our best option for now.
2003-12-22 15:38:07 +00:00
Dries Buytaert 54a74abaa3 - Accessibility improvements: made the <label>-tags use the 'for'-attribute. 2003-12-22 14:45:00 +00:00
Dries Buytaert aa2f6162b2 - Fixed typo: $outpout -> $output. Fixed bug 4690. 2003-12-18 05:54:59 +00:00
Kjartan Mannes 3e3f397202 - Type in comment block. 2003-12-16 21:18:51 +00:00
Dries Buytaert 670a292277 - Reworked 404 (page not found) handling. Patch by walkah. You can specify a
custom 404 page in the administration page.  As a result, error.php could be
  removed.
2003-12-16 21:06:34 +00:00
Dries Buytaert 67fe17164a - Bugfix: removed incorrect print statements from theme.inc. 2003-12-13 17:52:50 +00:00
Dries Buytaert 4d54978a4b - Small change to the default theme. 2003-12-13 17:46:44 +00:00
Dries Buytaert 3904790e03 - Tidied up the DoxyGen comments. Patch by Kjartan. 2003-12-08 06:32:19 +00:00
Dries Buytaert d45bf0f1e7 - Patch 185 by Ax: fixed undefined variables, synchronized xtemplate with sf, etc. 2003-12-04 20:53:19 +00:00
Dries Buytaert 70fe2520bc Fixed typo. Patch by Manuel. 2003-11-27 13:31:13 +00:00
Dries Buytaert b55975d61c - Doxygen improvements. Patch by Ax. 2003-11-26 16:17:13 +00:00
Dries Buytaert c0494c0a2b - Committed phase 4 of JonBob's menu system changes. 2003-11-25 19:26:21 +00:00
Dries Buytaert 2df7214a09 - Rollbacked Ax's theme.inc changes as they failed to apply correctly. 2003-11-24 22:54:49 +00:00
Dries Buytaert 06045ff7fc Patch by Ax to fixe and improve to the core doxygen PHPdoc:
* fixes all doxygen warnings [#]_ in the current code base
    + changes @param style from phpDocumentor (@param type $var desc) to doxygen (@param $var desc)
    + documents all undocumented parameters
    + escapes / fixes html warnings
    + fixes @defgroup in theme.inc
  * adds more groupings [#]_
    + drupal_{set|get}_title, drupal_{set|get}_breadcrumb
    + pager.inc: pager_api (pager_query(), pager_display()), pager pieces
  * adds a new group "themeable" which contains all themeable functions.
2003-11-24 22:46:03 +00:00
Dries Buytaert af5bc7cdef - Made the Xtemplate theme degrade gracefully when CSS is disabled. 2003-11-24 22:39:48 +00:00
Dries Buytaert 26735ac5dd - Committed phase 3 of JonBob's menu changes. Adds an API for modules to
define titles and breadcrumbs for their pages, and updates the theme
  system to display them.
2003-11-23 10:41:04 +00:00
Dries Buytaert 980637265c - Block and theme improvements. Patch by Ax.
+ block_list() (in block.module): returns an array of block objects for
     $region.
   + theme_blocks() (in theme.inc): uses block_list() and theme("block") to
     actually render them.

  Advantages:
   + Decouples blocks content and layout, allows block_list() to be used
     for non-output purposes (think "pull").
   + Unifies naming in theme.inc: render_blocks()) didn't really fit there.
   + Puts block_list() in blocks.module where it logically belongs.

- Removed some cruft from the Xtemplate theme.  Patch by Ax.
2003-11-19 16:13:07 +00:00
Dries Buytaert 7a2514e789 - Small improvement to the default style emitted by theme_form_element(). 2003-11-17 19:24:39 +00:00
Dries Buytaert fff2f548ac - Improved form items: added <label> tags to improve accessibility and added
theme_form_element() function to improve themeability.  I left form_item()
  and the calls to form_item() intact for now.
2003-11-17 19:16:55 +00:00
Dries Buytaert 36bb57555c - table(...) -> theme("table", ...) 2003-11-13 19:52:54 +00:00
Kjartan Mannes 22d3f6bd06 - Spell checked the comments. 2003-11-10 09:49:05 +00:00
Dries Buytaert 36da307e45 - Improvement: made sure that the example theme uses the misc/drupal.css stylesheet. 2003-11-10 09:03:53 +00:00
Dries Buytaert 951b553a98 - Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX. 2003-11-09 23:27:22 +00:00
Dries Buytaert c79eb8c990 - Bugfix: made theme_footer() call theme_closure() instead of itself. Patch by Bart. 2003-11-09 17:11:26 +00:00
Dries Buytaert 1f273dac01 - Committed stage 1 of the theme system improvements.
Some TODO's:
   * The sidebars of theme Marvin and theme UnConeD look unstyled.
   * CSS-ify theme UnConeD so we can remove the class around the functions.
   * Rewrite theme_init() not to use a class and simplify theme()
     accordingly.
2003-11-08 11:56:33 +00:00
Dries Buytaert ed774ccdee - Improvement: better HTML/CSS for the example theme. Patch by Adrian Simons. 2003-11-04 19:05:14 +00:00
Dries Buytaert ec33266795 - Improvement: made it possible to disable the comment controls and reworded some of the configuration settings.
- Improvement: removed a left-over from Drupal 4.2.0 (dead code).

- Improvement: replaced hard-coded XHTML around the XML icons with class="xml-icon".

- Improvement: removed the custom navigation menus shown at the top of the "user information page" and integrated them in the new navigation block.  The "my account" link in the navigation menu will unfold.  Also removed the "delete account" link/functionality (for now).

- Improvement: fix for "magic quotes" settings.  Patch by Steven.  I also removed check_php_settings().

- Improvement: block themability improvements.  Modified patch from Ax and Steve/CodeMonkeyX.

- Fixed bug #2617: editing user information does not work.  Patch by Kjartan.
2003-10-31 19:34:03 +00:00
Dries Buytaert 17e92817c5 - Bugfix: added missing . which stopped the Example theme's DOCTYPE from being
emitted.  Reported by Robert Castelo.
2003-10-19 20:38:58 +00:00
Dries Buytaert 00a62647bc - Committed Nick's _content improvements. 2003-09-20 15:11:41 +00:00
Dries Buytaert 796a70de15 - XHTML fixes in the base theme. Patch by Chris Johnson. 2003-09-18 14:03:08 +00:00
Dries Buytaert d9cb4522bd - Book module improvements. This commit changes the behavior of the "view"
hook.  See mailing list for details; search for a mail with the subject:
  '[IMPORTANT] behavior of "view" hook changed'.  Modified patch from Nick.
2003-09-15 15:58:20 +00:00
Dries Buytaert d81f159c63 - Committed Nick's path improvements; you can now control the look and feel
of the breadcrumb navigation.
2003-09-11 17:53:45 +00:00
Dries Buytaert 337b3c9de9 - Committed a slightly modified version of Slavica's table prefix patch. 2003-07-10 17:46:44 +00:00
Dries Buytaert f7a6c42eba - Bugfix: do not escpae slashes in block path. Patch #50 by Gerhard.
(This accompanies the recent block module documentation update, right?)
2003-06-26 19:26:27 +00:00
Dries Buytaert ef8735614f - Improvements: XHTML-ifications. Patch by GmbH. See feature #1813. 2003-06-16 17:09:23 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert d95499bf03 - Bugfix: small Xtemplate fixes. Patch by Ax. (Slightly modified.)
- Bugfix: block patch fix.  Patch by Gerhard.

- Bugfix: fixed broken URL in ping.  Patch by Gerhard.

  (This should fix the problems shown on http://www.blo.gs/info.php?id=1515.)

- Improvement: added better password generator.  Patch #1 by Al.  Fixes bug
  #1935.

- Improvement: performance improvement to the blog module.  Patch by Marco.
2003-06-13 17:34:18 +00:00
Dries Buytaert 3b8c99d91e - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan.
- Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.

- Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:

  <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />

  IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.

- Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.

- Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.

- Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.

- Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.

- Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.

- Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
2003-06-11 18:16:32 +00:00
Dries Buytaert a448f5a9b4 - Charset simpliciations. Patch #46 by Al. 2003-06-08 16:50:05 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 7f2ce4acea - Fixed the order in which the CSS gets loaded. Patch by Al. 2003-05-30 05:10:35 +00:00
Dries Buytaert 1fc8a18c2d - Al's CSS patches. This commit improves the themability of some core
components such as lists, form items, removes an ugly hack from the
  archive module and should fix the poll problem (although it doesn't
  Opera/Konqueror).
2003-05-29 10:18:38 +00:00
Dries Buytaert d8f78a7c95 - Removed check_output() from the theme system layer. 2003-05-26 19:50:39 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Dries Buytaert 9a62873a4b - Added <base href=""> to default theme. Patch by Al, though I had to add
a 'global $base_url;'.  Fixes bug #1533.
2003-05-07 20:39:27 +00:00
Dries Buytaert 31d8b14969 - A one line patch to theme.inc which adds a missing page title variable to
the header() function.  Patch by Moshe.
2003-04-25 20:10:36 +00:00
Dries Buytaert b505b5ab65 - Committed Gordon's htmlarea patch. 2003-04-21 13:56:09 +00:00
Dries Buytaert 7a88330d9d - Committed slightly modified version of Kjartan's theme.inc patch: Drupal
will now barf when trying to instantiate a non-existing theme class.
  This should help to identify broken themes, and to track down theme system
  related bugs.
2003-03-11 23:08:01 +00:00