Commit Graph

399 Commits (1df994459b9f47b89a214ec69a41dd33d41e3d11)

Author SHA1 Message Date
Nathaniel Catchpole c5b88d8048 Issue #2917653 by markcarver, bojan_dev, dww, idebr, lauriii: toolbar_preprocess_html() converts attributes from array to Attribute object 2019-02-22 12:17:02 +00:00
Lee Rowlands 211c6641f8
Issue #2135445 by dww, Sam152, jessebeach, Mile23, Kristen Pol, Wim Leers, larowlan: Toolbar displays Manage tab even if the user is not permitted to see it 2019-02-06 20:04:17 +10:00
Lee Rowlands 5ba43aecde
Issue #3025839 by dww: Change toolbar's permission label to 'Use the toolbar' 2019-02-04 18:50:42 +10:00
Lauri Eskola b3aef2bced
Issue #3024505 by alexpott, markconroy: Add quote standards to Stylelint config 2019-01-14 17:55:33 +02:00
Alex Pott d2989e4366
Issue #2952626 by Daniel Korte, tstoeckler, romainj, John Pitcairn: Toolbar tab click potentially accessing wrong element due to JavaScript event delegation 2018-12-26 20:37:48 +01:00
Nathaniel Catchpole d078c928b4 Issue #3002741 by hardikpandya, tstoeckler, Chi: toolbar.menu_tree service does not consume all defined dependencies 2018-10-08 13:25:44 +01:00
xjm fa6b3d95dd Revert "Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase"
This reverts commit 69501f3062.
2018-08-16 18:12:22 -05:00
Nathaniel Catchpole 69501f3062 Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase 2018-08-15 19:55:23 +09:00
Lauri Eskola e742590eed
Issue #2981652 by ApacheEx, corbacho, drpal, dawehner, xjm, alexpott, lauriii: Format core JavaScript using recently add Prettier 2018-08-09 18:49:18 +03:00
Lauri Eskola 258a27b635 Issue #2983373 by ApacheEx, drpal, m1r1k: JS codestyle: no-restricted-globals 2018-07-16 09:00:57 +03:00
Alex Pott 27740c26de
Issue #2942900 by Mixologic, vaplas, jibran, dawehner, Lendude, martin107, alexpott, tedbow, tacituseu, tstoeckler, heddn: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver 2018-07-04 15:36:57 +01:00
Alex Pott ff99cb2133
Revert "Issue #2942900 by Mixologic, vaplas, jibran, Lendude, martin107, alexpott, dawehner, tedbow, tacituseu, tstoeckler, heddn: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver"
This reverts commit f55d974612.
2018-07-04 08:20:33 +01:00
Alex Pott f55d974612
Issue #2942900 by Mixologic, vaplas, jibran, Lendude, martin107, alexpott, dawehner, tedbow, tacituseu, tstoeckler, heddn: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver 2018-07-04 08:16:25 +01:00
Lauri Eskola a26816d190 Issue #2974066 by leolando.tan, andrewmacpherson: Missing whitespace makes some toolbar dropbuttons sound strange in screen readers 2018-06-07 12:36:29 +03:00
Gábor Hojtsy f16ee05a6e Issue #2916781 by timmillwood, tedbow, drpal, lauriii, Adita, andrewmacpherson, yoroy, amateescu, borisson_, ckrina: Allow off-canvas dialog to be rendered at the top of the page 2018-05-29 18:12:49 +02:00
Alex Pott 3bfc5a384b
Issue #2938970 by MerryHamster, surbz, msankhala, alexpott, Jo Fitzgerald, Yasiru Nilan, Manuel Garcia, ZeiP, boaloysius, xjm, wturrell, tameeshb, darrenwh, ritzz: Replace drupal_render() in @param, @return, @see, @link, etc 2018-05-03 17:58:24 +01:00
Nathaniel Catchpole d90ac78f3e Issue #2798891 by ankitjain28may, trobey, TR: Define project dependencies in core module .info files 2018-04-06 13:13:01 +01:00
Alex Pott 7d2f3a3b76 Issue #2946603 by drpal, alexpott, dawehner: JS codestyle: no-use-before-define 2018-03-05 09:14:08 +00:00
Nathaniel Catchpole ae262e1192 Issue #2899392 by idebr, neclimdul, rgpublic: user_hook_toolbar() makes all pages uncacheable 2018-02-19 12:21:13 +00:00
Alex Pott 845ab36958 Issue #2866801 by harsha012, joelpittet, BrightBold, droplet, Akshay kashyap, arunkumark, bmx269: Update stylelint rules color-hex-length to be consistent with Drupal's CSS standards 2018-02-11 23:27:54 +00:00
Lee Rowlands 4a7b4e262a
Issue #2936368 by gaurav.kapoor: Duplicate css property in toolbar module 2018-01-29 09:35:14 +10:00
Alex Pott 0013e901fe Issue #2866810 by BrightBold, harsha012, joelpittet: Update stylelint rule function-comma-space-after to be consistent with Drupal's CSS standards 2018-01-09 18:38:49 +00:00
Alex Pott d540d6426f Issue #2866799 by cwells: Update stylelint rule at-rule-empty-line-before to be consistent with Drupal's CSS standards 2018-01-05 09:37:45 +00:00
webchick f1e33ca3d8 Issue #2925064 by drpal, dawehner, droplet, xjm, webchick, justafish: [1/2] JS codestyle: no-restricted-syntax 2018-01-03 15:27:55 -08:00
Lee Rowlands ed45b4d5dc
Issue #2840257 by kiamlaluno: The documentation makes reference to a function that doesn't exist 2017-12-31 08:21:22 +10:00
xjm dcfee314ad Revert "Issue #2925064 by drpal, dawehner, xjm, justafish, droplet: [1/2] JS codestyle: no-restricted-syntax"
This reverts commit b0a4d7e017.
2017-12-01 13:28:53 -06:00
webchick b0a4d7e017 Issue #2925064 by drpal, dawehner, xjm, justafish, droplet: [1/2] JS codestyle: no-restricted-syntax 2017-11-28 15:40:07 -08:00
xjm 9032c68faa Issue #2916154 by drpal, droplet, dawehner, alexpott, xjm: JS codestyle: no-multi-assign 2017-10-24 07:42:16 -05:00
Alex Pott 27266234c2 Revert "Issue #2916154 by drpal, dawehner, xjm: JS codestyle: no-multi-assign"
This reverts commit 169e867159.
2017-10-21 21:49:45 +01:00
Alex Pott 169e867159 Issue #2916154 by drpal, dawehner, xjm: JS codestyle: no-multi-assign 2017-10-21 21:46:43 +01:00
xjm db5e8289f2 Issue #2572787 by alexpott, mfernea, attiks, andriyun, andypost, RoSk0, hussainweb, klausi, martin107: Fix 'Drupal.WhiteSpace.CloseBracketSpacing' coding standard 2017-10-13 12:43:15 -05:00
Nathaniel Catchpole 64fa6ad712 Issue #2901744 by mfernea: Fix 'PSR2.Namespaces' coding standard 2017-10-10 16:09:51 +01:00
Nathaniel Catchpole 4577185c9b Issue #2572791 by Mile23, andriyun, attiks, RoSk0: Fix 'Drupal.WhiteSpace.OpenBracketSpacing' coding standard 2017-09-22 12:16:23 +01:00
Nathaniel Catchpole d9247c2ee0 Issue #2863318 by martin107, naveenvalecha, Lendude, Jo Fitzgerald: Cache: Convert system functional tests to phpunit 2017-08-05 00:49:42 +09:00
webchick 478ddd3118 Issue #2894283 by droplet, drpal: Improve Toolbar Height calculation to accommodate jQuery 3.0 changes 2017-07-17 13:54:37 -07:00
Lauri Eskola 612c1fa68c Issue #2880007 by drpal, nod_, droplet: Auto-fix ESLint errors and warnings 2017-07-06 09:21:40 +03:00
Lauri Eskola b5a3346f32 Issue #2891236 by droplet, krina.addweb: Regression in #2542050: Toolbar menus always expanded 2017-07-03 18:13:34 +03:00
Lauri Eskola b67adf08f5 Issue #2542050 by droplet, nod_, dpacassi, Wim Leers, Sam152, andrewmacpherson, tameeshb, jonathanshaw, lokapujya, Daniel Schaefer, Chi, geerlingguy, tarekdj: Toolbar implementation creates super annoying re-rendering 2017-06-19 19:37:48 +03:00
Nathaniel Catchpole f3cf9c43b5 Issue #2880560 by alexpott, droplet: Fix comment added to top of .js files by build process 2017-05-23 15:31:29 +01:00
Alex Pott 8287017e03 Issue #2818825 by drpal, nod_, droplet, cilefen: Rename all JS files to *.es6.js and compile them 2017-05-19 23:12:53 +01:00
Chris McCafferty ef1db63d7b Issue #2878548 by alexpott, droplet, Cottser, idebr, joelpittet, xjm, martin107: Fix CSS whitespace issues 2017-05-19 12:46:41 -04:00
Nathaniel Catchpole 477fbfd292 Issue #2863597 by Lendude, Jo Fitzgerald, michielnugter, nlisgo, dawehner: Convert web tests to browser tests for toolbar module 2017-04-28 13:28:52 -04:00
Nathaniel Catchpole 01f8bd64ed Issue #2854529 by alexpott, xjm, klausi, Chi, Mixologic: Fix Drupal.Scope.MethodScope - all methods should have scopes 2017-03-06 11:25:01 +00:00
xjm 72d65cc85c Issue #2857822 by alexpott, klausi: Fix coding standards issues introduced mostly by array syntax conversion 2017-03-04 08:02:01 -06:00
xjm 52e3eec616 Issue #2776975 by joelpittet, dawehner, tim.plunkett, xjm, pfrenssen: March 3, 2017: Convert core to array syntax coding standards for Drupal 8.3.x RC phase 2017-03-03 19:20:24 -06:00
Nathaniel Catchpole 4c64f7b840 Issue #2770921 by dawehner, klausi, Mile23, mpdonadio, xjm, claudiu.cristea: Feb 21st: Convert chunk of WTB to BTB by just moving classes, changing use statements adding traits 2017-02-21 12:07:44 +00:00
Chris McCafferty 91736cadcb Issue #2665152 by alexpott, Andrej Galuf, tfranz, longwave, andypost, jsimonis, bojanz: Simplify module form structure and fix bugs when Suhosin is used 2017-02-10 16:55:04 -05:00
Nathaniel Catchpole a90e686658 Revert "Issue #2665152 by alexpott, Andrej Galuf, tfranz, longwave, jsimonis, andypost, bojanz: Certain modules can't be enabled when Suhosin is used"
This reverts commit 7f37114aca.
2017-02-09 21:40:11 +00:00
Nathaniel Catchpole 7f37114aca Issue #2665152 by alexpott, Andrej Galuf, tfranz, longwave, jsimonis, andypost, bojanz: Certain modules can't be enabled when Suhosin is used 2017-02-09 16:09:22 +00:00
Scott Reeves 85aea4e650 Issue #2551785 by roland.molnar, nod_, MattA: Unable to scroll toolbar menu items or show contextual links on mobile browsers 2016-09-01 22:25:45 -04:00
Nathaniel Catchpole f6ae58526c Issue #2572801 by alexpott, vprocessor, andriyun, andypost, chishah92, Mile23, attiks, hussainweb, klausi, dawehner, pfrenssen: Fix 'Drupal.WhiteSpace.ScopeIndent' coding standard 2016-08-28 18:16:36 +01:00
Alex Pott c2b28643f6 Issue #2745953 by dawehner, tim.plunkett, Wim Leers: AjaxBasePageNegotiator should not require _theme: ajax_base_page to be specified 2016-06-22 16:01:50 +02:00
Alex Pott df0425cfe1 Issue #2721909 by anoopjohn: Fix Drupal.Commenting.FunctionComment.ReturnCommentIndentation 2016-06-02 15:20:55 +01:00
Alex Pott 899f647387 Issue #2716661 by anoopjohn: Fix 'Drupal.Commenting.FunctionComment' coding standard - Issues related to @see references 2016-05-08 17:42:30 -05:00
Alex Pott 133c212ed9 Issue #2719695 by alexpott, Mile23: Fix 'Drupal.Classes.ClassDeclaration.CloseBraceAfterBody' coding standard 2016-05-08 10:05:38 -05:00
Alex Pott 70f58860c8 Issue #2716685 by Mile23: Part 2: Fix several errors in the 'Drupal.Commenting.DocComment' coding standard 2016-05-05 12:32:19 +01:00
Alex Pott d5d0d6ce87 Issue #2572777 by andypost, alexpott, attiks, andriyun: Fix 'Squiz.Strings.ConcatenationSpacing' coding standard 2016-05-05 12:07:19 +01:00
Alex Pott 6098437ef5 Issue #2572793 by attiks, andypost: Fix 'Drupal.WhiteSpace.OperatorSpacing' coding standard 2016-04-29 12:02:20 +01:00
Alex Pott 7aab1f5c39 Issue #2711963 by jibran: Modernized ToolbarIntegrationTest 2016-04-26 19:40:26 +01:00
Alex Pott 904b0de0d3 Issue #2700661 by anoopjohn: Ensure core compliance to Drupal.Commenting.FunctionComment.ParamCommentIndentation (part 1). 2016-04-16 13:17:32 +01:00
Alex Pott bfde6d3423 Issue #2665992 by alexpott, klausi, heykarthikwithu, xjm, tstoeckler: @file is not required for classes, interfaces and traits 2016-04-09 15:48:39 +01:00
Alex Pott ca48ed6d92 Issue #2469713 by dawehner, pfrenssen, alexpott, elachlan, Mixologic, larowlan, hussainweb, benjy, jibran, Wim Leers, isntall: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary 2016-04-07 12:25:35 +01:00
Alex Pott e8ae668964 Revert "Issue #2469713 by dawehner, pfrenssen, alexpott, elachlan, Mixologic, larowlan, hussainweb, benjy, jibran, Wim Leers, isntall: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary"
This reverts commit 9c9fae71c2.
2016-03-16 17:28:57 +00:00
Alex Pott 9c9fae71c2 Issue #2469713 by dawehner, pfrenssen, alexpott, elachlan, Mixologic, larowlan, hussainweb, benjy, jibran, Wim Leers, isntall: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary 2016-03-16 16:37:02 +00:00
Alex Pott 11d0d76ed3 Revert "Issue #2469713 by dawehner, pfrenssen, elachlan, Mixologic, larowlan, alexpott, hussainweb: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary"
This reverts commit e6f491d8f9.
2016-03-15 15:14:07 +00:00
Alex Pott e6f491d8f9 Issue #2469713 by dawehner, pfrenssen, elachlan, Mixologic, larowlan, alexpott, hussainweb: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary 2016-03-15 13:12:34 +00:00
Jennifer Hodgdon d87ade36a4 Issue #2572643 by alexpott, attiks, Jelle_S, jhodgdon: Fix Drupal.Commenting.FileComment coding standard 2016-02-11 12:54:33 -08:00
Alex Pott 9f4034ac98 Issue #2642236 by TR: Various setUp() and tearDown() methods are not protected (the sequel) 2016-01-05 10:53:08 +00:00
Alex Pott 970cfb3a98 Issue #2603988 by heykarthikwithu: Unnecessary ternary condition in toolbar JS 2015-11-12 22:46:06 +00:00
Alex Pott 9e826723b3 Issue #2609400 by tim.plunkett, effulgentsia, benjamin.merkley: menu.html.twig says that menu_name is an available variable, but it's not 2015-11-12 15:19:54 +00:00
Alex Pott 6dd4b186ad Issue #2400197 by pwolanin, fgm, znerol, neclimdul, mpdonadio, thekevinday, Fabianx: Harden the security where hash values are compared 2015-10-25 20:57:21 -07:00
xjm cd569936a7 Issue #2598500 by krknth, nicrodgers: Remove unused variables from core/modules/toolbar/src/Tests/ToolbarAdminMenuTest.php 2015-10-23 19:57:46 -07:00
webchick 8f487d2806 Issue #2544176 by lauriii, joelpittet: Remove drupal_render_children() usage in Drupal\toolbar\Element\Toolbar 2015-10-22 17:03:11 -07:00
Alex Pott b0e82e5871 Issue #2548195 by nod_, JohnAlbin, madhavvyas, sriharsha.uppuluri: Only use single quotes in JavaScript and update .eslintrc 2015-10-13 23:37:56 +01:00
Nathaniel Catchpole 8b65164c5a Issue #2533800 by alexpott: Remove all unused use statements from core 2015-10-08 20:46:26 +01:00
effulgentsia bb8be56e67 Issue #1832946 by Sutharsan, Jose Reyero, Gábor Hojtsy, Wim Leers, vijaycs85: Runtime translation download fallback works different from installer translation download fallback 2015-10-05 15:39:44 -07:00
webchick 2b8e559040 Issue #2503755 by Wim Leers, bobrov1989, webchick, dcrocks, andypost, emma.maria, catch, Bojhan, dawehner, Gábor Hojtsy, alexpott, tstoeckler, yoroy: Switch from user login block to login menu link and search block in standard profile 2015-10-05 14:46:10 -07:00
webchick 105518a28e Issue #2547159 by mdrummond, mortendk, davidhernandez, lauriii, joelpittet, Wim Leers, Cottser: menu class generating should be in the template not in a function 2015-09-30 14:00:27 -07:00
Alex Pott ede4d4ace0 Issue #2341267 followup by nod_: Bind event handlers for future multiple toolbars 2015-09-28 00:16:55 +02:00
Alex Pott e8b5f46813 Issue #2341267 by tohesi, nod_, gaas, gendoas, droplet, DuaelFr, bartvig: Bind event handlers for future multiple toolbars 2015-09-27 16:31:53 +02:00
webchick b89752c124 Issue #2546196 by andriyun, neclimdul, hussainweb, mgifford, Wim Leers, TR, andypost: Toolbar's orientation-toggling arrows broken by #2173527 2015-09-22 09:10:53 -07:00
Alex Pott 7a25f513f5 Issue #2560783 by stefan.r, joelpittet, lauriii, Cottser, Sutharsan, kgoel, justAChris, Gábor Hojtsy, dawehner, jhodgdon, effulgentsia, xjm, andypost, googletorp: Replace !placeholder with :placeholder for URLs in hook_help() implementations 2015-09-21 12:38:19 +01:00
webchick a937892097 Issue #2531688 by kekkis, nod_, eiriksm, evilfurryone: JSDoc toolbar module 2015-08-31 09:15:48 -07:00
Nathaniel Catchpole a7fc1a2728 Issue #2557871 by alexpott: Remove all usages SafeMarkup::checkPlain() from template preprocess functions and attributes 2015-08-27 15:43:18 +01:00
Nathaniel Catchpole 98e2b931b3 Issue #2552013 by Wim Leers: Follow-up for #2481453: ensure the 'url.query_args': MainContentViewSubscriber::WRAPPER_FORMAT cache context is set 2015-08-20 16:22:26 +01:00
Alex Pott 5f79d63431 Issue #2548027 by nod_: Follow-up add back aria-label to toolbar tray 2015-08-09 01:08:09 +01:00
Alex Pott fad555c2eb Issue #2545826 by JohnAlbin, nod_: Update.eslintrc to work with eslint 1.0.0 2015-08-07 15:08:23 +01:00
Alex Pott 184d4b42b8 Issue #2173527 by idflood, scresante, rpayanm, mgifford, Sam152, Wim Leers: The Menu-Toolbar area should be refactored so that Tray items are nested in the same container as their associated parent Toolbar item 2015-08-06 15:28:50 +01:00
Alex Pott 0c810aa1a0 Issue #2535118 by longwave, Wim Leers, borisson_, effulgentsia: Toolbar subtrees not working on admin pages due to lack of theme negotiation on Toolbar's custom JSONP route 2015-07-29 09:12:30 +01:00
Alex Pott 37c1ee8c47 Issue #2056089 by BarisW, TR, mgifford, rodvolpe, Dom., nambisolo, nod_, katewelling, Manjit.Singh, jhodgdon, Bojhan, Wim Leers: UI problems on the Modules/Extend page 2015-07-27 13:03:51 +01:00
webchick a28e94b3bc Issue #2532490 by tim.plunkett, dawehner, Wim Leers, Crell, mtift: Unrouted URLs break toolbar but are hidden by caching 2015-07-17 15:27:09 -07:00
Alex Pott 0feb1b692e Issue #2534830 by Wim Leers: Toolbar subtrees not working 2015-07-17 09:46:05 +01:00
Alex Pott 7fb23ea26c Issue #2534856 by Dave Reid: Remove unused _toolbar_get_user_cid() 2015-07-17 09:07:05 +01:00
webchick 756dc7bbae Issue #2424805 by mdrummond, YesCT, vijaycs85, xjm, marcoscano, ifrik, joelpittet, Jelle_S, attiks, lauriii: Toolbar can no longer switch horizontal and vertical -- expects breakpoints ordered from smallest to largest; responsive images need largest to smallest 2015-07-15 12:53:14 -07:00
Nathaniel Catchpole cbcbfc15e6 Issue #2217985 by Berdir, Wim Leers: Replace the custom menu caching strategy in Toolbar with Core's standard caching 2015-07-14 12:34:15 +01:00
Alex Pott 68d4f0be10 Issue #2511472 by Wim Leers, Fabianx, dawehner: Refactor all usages of drupal_render()/Renderer::render() that break #2450993 2015-06-24 16:31:20 -05:00
Nathaniel Catchpole 5756615df3 Issue #2498625 by jhedstrom, larowlan: Write tests that ensure hook_update_N is properly run 2015-06-12 12:31:10 +01:00
Jennifer Hodgdon 38833e0f83 Issue #2493683 by nod_, dawehner, eiriksm, Wim Leers: JSDoc for JS using Backbone 2015-06-06 08:55:42 -07:00
webchick ea37327b42 Issue #2498689 by lauriii, Wim Leers, David_Rothstein: "Back to site" link no longer appears in the toolbar 2015-06-02 19:34:52 -07:00
Nathaniel Catchpole 5c8a50ed7f Issue #2254865 by Wim Leers, lauriii, borisson_, JeroenT, alexpott, Fabianx: toolbar_pre_render() runs on every page and is responsible for ~15ms/17000 function calls 2015-06-01 17:49:02 +01:00