Commit Graph

334 Commits (1a68f48c30cc02030d2a0e1035bb5b70c82b7816)

Author SHA1 Message Date
Neil Drumm af6c897056 #65024 by killes, remove an extra condition. 2006-06-12 03:44:54 +00:00
Dries Buytaert 226eed7047 - Patch #67146 by webchick: make sure that the forum vocabulary shows up first. 2006-06-06 15:35:39 +00:00
Dries Buytaert cf3bfe006b - Patch #18260 by Morbus: fixed taxonomy links. 2006-05-29 12:58:19 +00:00
Dries Buytaert 1b291a2917 - Patch #18260 by Ber, m3averck et al: allow overriding of links returned by modules 2006-05-18 14:58:57 +00:00
Dries Buytaert e1304697c4 - Patch #62350 by hunmonk: fixed problem with deleting forum containers. 2006-05-08 15:16:16 +00:00
Neil Drumm 9cff02e91b #61802 by Zen, Double spaced sentences clean up 2006-05-07 00:08:36 +00:00
Gerhard Killesreiter d6a164c400 #5371, drupal_get_destination, pager and tablesort array handling, patch by Steven 2006-04-13 08:25:27 +00:00
Steven Wittens 9794b5538e - #55898: Generic, permissive admin XSS/HTML filtering for mission/footer/...
- Clean up some raw output
2006-04-07 15:32:17 +00:00
Gerhard Killesreiter 3000db0d13 #40664, adding new forum topic, forum not pre-selected in pull down menu., fix by Jonas Kvarnstrom, patch by drumm 2006-04-06 18:36:57 +00:00
Steven Wittens be0b774cbc - #57523: Make taxonomy delete vocabulary consistent with other taxonomy hook ops 2006-04-06 04:21:12 +00:00
Steven Wittens ec04325bb2 - Make forum_hot_topic scale a bit more logical 2006-04-06 04:18:30 +00:00
Gerhard Killesreiter 603a6618ee #28625, Forum vocabulary does not handle standard vocabulary features correctly, removed these features by means of formapi, patch by profix898, with some love by dopry and chx 2006-03-31 06:43:46 +00:00
Gerhard Killesreiter 002fee7aae #56105, remove title validation, already enforced by #required, patch by Moshe 2006-03-27 18:02:48 +00:00
Gerhard Killesreiter 0ed9f460dc #55805, missing {}, patch by Cvbge 2006-03-25 10:52:40 +00:00
Gerhard Killesreiter 717d6e30c5 #54098, forum "last post" column show oldest, not most recent, patch by Zen. 2006-03-24 10:13:10 +00:00
Gerhard Killesreiter d11c07502d #54910, Forum and taxonomy term delete work only superficially, patch by Zen 2006-03-23 21:46:35 +00:00
Gerhard Killesreiter 40e2a3b379 #51635, Moving forum post leaving shadow copy results in warning, patch by Zen/webchick 2006-03-08 22:11:54 +00:00
Dries Buytaert 7add598ee2 - Patch #51850 by chx, webchick et al: fixed various problems with db_rewrite_sql, made db_rewrite_sql slightly more robust. 2006-03-08 15:13:20 +00:00
Dries Buytaert d2865f2a99 - Patch #52850 by Zen: fapi conversion + minor fixes
* converts forum_admin to fapi.
    * handles invalid terms in hook_menu
    * adds comments, fixes typos etc.
    * reorganises functions a little bit - moves hook_menu to the top.. groups hooks together and forms together
2006-03-07 19:03:02 +00:00
Dries Buytaert d7e9371e94 - Removing whitespace 2006-03-03 08:37:47 +00:00
Gerhard Killesreiter 1d865eb4c4 #51613, forum.module forms ignore proper form submission path, patch by merlinofchaos 2006-02-28 13:36:59 +00:00
Dries Buytaert 19afd2ceb7 - Patch #45850: it was impossible to create shadow topic. (Today's critical bugfix #2.) 2006-02-23 12:21:15 +00:00
Dries Buytaert 3603fe1bd8 - Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.) 2006-02-21 18:46:54 +00:00
Dries Buytaert f030164bcb - Patch #46743 by Morbus: fixed double encoding issue. 2006-02-15 20:47:35 +00:00
Dries Buytaert 91152ba7af - Patch #46743 by m3avrck: clean up forum topic navigation. Bring it in line with book.module. 2006-02-10 05:05:44 +00:00
Dries Buytaert 88490f6413 - Patch #47691 by Cvbge: quickfix postgresql 2006-02-09 08:52:03 +00:00
Dries Buytaert a723204ee4 - Patch #47691 by wtanaka: performance improvement for _forum_topics_read. 2006-02-09 08:09:55 +00:00
Dries Buytaert 87f5947e51 - Patch #47868 by wtanaka: performance improvement: active topics block selects an unused column. 2006-02-04 09:56:04 +00:00
Dries Buytaert 31293d5a2e - Patch #46864 by stmind: fixed problem with node-level permissions and forums. 2006-02-01 14:19:44 +00:00
Dries Buytaert 8c02d4ec93 - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:

# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
  $form[$key]['#weight'] = $count/1000;
}

The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).

Consider the following pseudo example:

$form['game_title'] = array(
    '#type' => 'textfield',
    ...
    );
$form['game_description'] = array(
    '#type' => 'textarea',
    ...
    );
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;

Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).

The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
Dries Buytaert 10d7f7731b - Patch #45281 by chx: made categories with forum topics work again. 2006-01-19 17:55:54 +00:00
Dries Buytaert e84a98a22b - Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API. 2006-01-19 08:54:41 +00:00
Dries Buytaert 52507806eb - Patch #45301 by Morbus: corrected the weight of form item titles of nodes. 2006-01-18 19:29:17 +00:00
Dries Buytaert 92acb92699 - Patch #33747 by Ber and Moshe: bugfix + code improvement: clean up some of the taxonomy loading code. 2006-01-10 12:35:20 +00:00
Dries Buytaert b170d83d14 - Removed global . 2006-01-09 10:12:30 +00:00
Dries Buytaert 4e35060451 - Patch 42591 by Simon/me: fixed problem with deleting forum and book revisions. 2005-12-31 13:04:40 +00:00
Dries Buytaert 799ceae29b - Patch #42705 by Cvbge: added missing format_plural(). 2005-12-31 11:21:32 +00:00
Dries Buytaert ea2d791095 - Patch 41169 by Chris: got rid of expensvie object 2 array casts. 2005-12-31 10:48:56 +00:00
Steven Wittens 79a193a2d2 - #42234: Use standardized feed icon for RSS 2005-12-29 04:46:40 +00:00
Dries Buytaert 1ef56e36a0 - Patch #42343 by wulff: added 2 missing t() functions. 2005-12-26 11:26:21 +00:00
Dries Buytaert 544aefad8a - Modified patch #40534: improved themability of forum icons (makes it possible to use animated gifs) + removed forum setting. 2005-12-11 12:44:39 +00:00
Dries Buytaert 99e27195e8 - Patch #40664 by Gerhard: assign default forum when adding a forum topic from within a forum. 2005-12-10 19:58:40 +00:00
Dries Buytaert 32d9af4916 - Patch #39598 by Gerhard: fixed problem with taxonomy terms not being selected. 2005-12-06 12:20:24 +00:00
Dries Buytaert c4c5ce122d - Patch #31323 by Gerhard: delete extra data when a revision is deleted. 2005-12-05 16:07:18 +00:00
Dries Buytaert 28fdb3975e - Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick. 2005-12-05 09:11:33 +00:00
Dries Buytaert 94f290c8ee - Patch #38849 by wtanaka: forum icon does not display as locked (aka closed) if comments are "disabled" instead of "read only". 2005-12-03 10:02:23 +00:00
Dries Buytaert 272c6b95fa - Patch #39667 by killes: fixed typo in function call: _forum_get_vid -> _forum_get_vid(). 2005-12-02 15:38:58 +00:00
Dries Buytaert 26bd449860 - Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'. 2005-12-02 15:21:01 +00:00
Dries Buytaert 90535c33aa - Patch #38854 by wtanaka: fixed XHTML validation problem. 2005-11-26 19:45:31 +00:00
Dries Buytaert d4692d569c - Patch #35644 by webchick: fixed the sizes of the textareas on the node edit forms. 2005-11-23 16:18:28 +00:00