Commit Graph

3317 Commits (144c1abb587f7a66e9f03b242ef359d4e0e670f5)

Author SHA1 Message Date
Steven Wittens 72155f8bbf Using drupal_specialchars() instead of htmlentities(). htmlentities() is not UTF-8 safe. 2004-06-27 22:09:12 +00:00
Dries Buytaert 7ebcac265a - Removed left-over instance of _user_profile(). 2004-06-27 19:41:55 +00:00
Dries Buytaert 1b1c47025a I refactored quite a bit of the user.module:
$ diffstat user.patch
database/database.mysql |    4
database/database.pgsql |    2
database/updates.inc    |   10 -
modules/block.module    |   20 +-
modules/locale.module   |    9
modules/profile.module  |  108 +++++++----
modules/system.module   |    8
modules/user.module     |  456 +++++++++++++++++++-----------------------------
8 files changed, 289 insertions(+), 328 deletions(-)

More functionality, less code.  Here is a list of the changes:

- Some user API changes:
   + When $type is 'form', you have to return an associative array of groups.  In turn, each group is an array with a 'title', 'data' and 'weight'.
   + A new $type has been added, namely 'categories'.  User settings can be organized in categories.  Categories can be sorted, as can the groups within a category.  (Ordering 'categories' is somewhat broken due to a bug in the menu system.)

- The 'my account > edit' page will use subtabs for each 'category'.  Read: you can break down the account settings into multiple subpages.

- Profile module improvements:
   + Added support for private fields to the profile module!
   + Improved workflow of profile administration pages.
   + Improved the form descriptions.

- Code improvements:
   + Unified user_edit() and user_admin_edit().
   + Unified and cleaned up the validation code.  Fixed some validation glitches too.
2004-06-27 19:10:52 +00:00
Steven Wittens 83851509f6 - Tweak for sticky patch: ANSI SQL does not allow ordering on a column which is not part of the selected fields. 2004-06-27 18:10:39 +00:00
Dries Buytaert 47e3055f56 - More updates 2004-06-27 16:04:35 +00:00
Dries Buytaert 0a35280978 - Patch #8603 by TDobes: added support for sticky forum topics to the blog
and forum module.
2004-06-27 16:02:31 +00:00
Dries Buytaert d4e7affba8 - Bugfix: made it possible for administrators to edit the values of custom
profile fields of users.
2004-06-24 22:12:36 +00:00
Dries Buytaert ea676b3a1c - Patch #8785 by Morbus Iff (modified): with the acceptance of "anonymous-but-named" comments, anonymous users can leave behind their names as opposed to the 'anonymous' setting. These names are shown as "$name (not verified)" on regular nodes. This change provides the same display for forums (assuming anonymous commenting on forums is allowed). 2004-06-24 05:11:28 +00:00
Dries Buytaert 3468310a61 - Patch #8778 by Morbus Iff: with the tabs patch, user/login, user/register, and user/password now show all three forms, as opposed to just the requested relevance. The attached patch implements a quick workaround: three new callbacks, and a cheapy modification of user_page where I use a ternary to test whether arg(2) exists (as it would in the case of user/nnn/edit). If it does, we set that to $op, and if it doesn't (in the case of user/login, etc.), we set arg(1). 2004-06-24 05:07:55 +00:00
Dries Buytaert 9f4a335887 - Taxonomy fix by Matt. 2004-06-23 20:52:46 +00:00
Dries Buytaert 23142e0efb - Patch #8757 by Morbus Iff: fixed redirection after comment moderation. 2004-06-23 05:41:16 +00:00
Dries Buytaert ae6aa4e59e - Patch #8758 by Morbus Iff: allow users to modify their profile under
the new tabs system.
2004-06-23 05:11:35 +00:00
Dries Buytaert fa2be0b8f0 - Fixed administration pages being broken due to tabs changes, improved form
handling and form descriptions and fixed an incorrect title.
2004-06-22 20:33:12 +00:00
Dries Buytaert e288b4ddb1 - Patch #8747 by JonBob: extended and standardized node.module Doxygen
comments, and made formatting and quote usage more consistent.
2004-06-22 20:24:27 +00:00
Dries Buytaert 0ee30cbca2 - Fixed broken URLs in the user module (access rules) due the the recent
tabs patch.
2004-06-22 20:21:13 +00:00
Dries Buytaert 81bebc01fd - Patch #8500 by jseng (modified/simplified): improved usability of editing
URL aliases.
2004-06-22 18:26:24 +00:00
Dries Buytaert f6b7f75512 - Patch #8733 by Morbus Iff: fixed statistics module. 2004-06-22 18:13:04 +00:00
Dries Buytaert 0be1e6cff7 - Issue #8735 by njivy: made the pager code ignore EOLs. 2004-06-22 05:45:15 +00:00
Dries Buytaert 7f06d092a5 - Patch #8708 (modified) by Stefan: refactored the 'add new block' form a but. 2004-06-21 21:11:36 +00:00
Dries Buytaert 77ec01f592 - Patch #8344 by Kjartan: drupal_http_request() did not always handle EOLs
correctly.
2004-06-21 20:14:41 +00:00
Dries Buytaert 090743bdba - Patch #8670 by asimmonds: more spelling fixes. 2004-06-21 20:05:37 +00:00
Dries Buytaert bfa7d178a9 - Patch #8713 by stefan: changed some 'node's to 'post's. Usability improvement. 2004-06-21 20:01:49 +00:00
Dries Buytaert ad3c6f345e - Patch #8681 by asimmonds: more help text updates 2004-06-21 08:26:20 +00:00
Dries Buytaert e30fdce6cb - Patch #8617 by TDobes: changes all gifs to pngs for better consistency (and
to get of proprietary formats).
2004-06-20 20:19:59 +00:00
Dries Buytaert bd49f9d1b3 - Patch #8681 by Stefan: more help fixes. 2004-06-20 20:12:00 +00:00
Dries Buytaert b713e3d489 - Patch #8617 by TDobes: changes all gifs to pngs for better consistency (and
to get of proprietary formats).

- Added forum-sticky.png.  Made by Steven.
2004-06-20 20:04:28 +00:00
Dries Buytaert c2d7419f23 - Patch #8681 by stefan: fixed some broken URLs and help texts. 2004-06-20 19:49:14 +00:00
Dries Buytaert 4b449a7e5d - Patch #8670 by asimmonds: spelling fixes. 2004-06-20 19:43:28 +00:00
Dries Buytaert 4e1f368e88 - "" -> ''. 2004-06-20 08:31:45 +00:00
Dries Buytaert ce45c91a53 - Patch #8652 by Adrian: incorrect implode. 2004-06-20 08:30:57 +00:00
Dries Buytaert efed4cfc70 - Patch #8679 by asimmonds: fixed spelling mistakes. 2004-06-20 08:27:03 +00:00
Dries Buytaert 1b46d7fcfe - Patch #8614 by JonBob: better way to display menus. 2004-06-19 14:57:44 +00:00
Dries Buytaert d2ff1ca54e Changed 'static' back to 'sticky' ... ;-) 2004-06-19 10:45:06 +00:00
Dries Buytaert cbc230a36c - Patch #7696 by TDobes: renamed 'static' to 'sticky' which is a more
logical name.  Requires a database upgrade.
2004-06-19 10:39:36 +00:00
Dries Buytaert c51805aa8a - Patch #8602 by TDobes: changed some 'sticky's back to 'static'. 2004-06-19 10:33:27 +00:00
Dries Buytaert 151acbb331 - Added a note about the tabs. 2004-06-19 10:29:02 +00:00
Dries Buytaert 71c99bb213 - Patch #8619 by TDobes: fixed typo in watchdog message. 2004-06-19 10:10:11 +00:00
Dries Buytaert c3a6f3dc54 - Patch #8632 by Mohse: made the taxonomy select menus more flexible.
Specifically, it lets you edit more than one node's taxonomy within
  the same form.

  This patch also removes the behavior where taxonomy remembers your
  last choice for a given vocab and automatically selects it for you.
  That is poor behavior.  If someone changes a date or author in a
  node, he is likely to inadvertently add taxo terms using with this
  'feature'.
2004-06-19 09:57:13 +00:00
Dries Buytaert a42b84e5d6 First tab improvements by Adrian:
+ Changed menu.inc to generate two separate lists instead of nested lists:
    that seems to be the only alternative to get rid of absolute positioning.

  + Changed the tabs code to be more sexy and put the code in misc/drupal.css
    so all themes are automagically updated.
2004-06-19 08:24:14 +00:00
Dries Buytaert a9c560282b - Patch #8598 by cetron: fixed typo in the help text: 'shuold' -> 'should' 2004-06-18 22:20:36 +00:00
Dries Buytaert 54b77d6435 Tabs patch!
CHANGES
-------

 + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.

 + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.

 + Grouped settings. All settings have been grouped under 'administer > settings'.

TODO
----

 + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.

 + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
Dries Buytaert 5ad73c8eb6 - Partial patch #8284 by jseng: made the RSS auto-discovery URL absolute even though that is not strictly necessary. 2004-06-17 18:46:41 +00:00
Dries Buytaert 3a8c1d6780 - Patch #8548 by Moshe: fixed warning when creating new vocabulary. 2004-06-17 18:10:05 +00:00
Dries Buytaert 7d19e3dc8e - Patch #8553 by Moshe: hide the 'add new comment' link when showing the
comment form.
2004-06-17 18:06:11 +00:00
Dries Buytaert bb961e2523 - Patch #8405 by Adrian:
+ Fixed duplicated view.
   + Fixed node types not being picked up correctly.
   + Improved error handling in case a particular node has not been found.
2004-06-15 19:47:42 +00:00
Dries Buytaert 5ba08f61c2 - Patch #8418 by Axel: don't insert tid=0's in the database 2004-06-15 18:41:25 +00:00
Dries Buytaert d80d2d6e2d - Patch #8477 by Goba: fixes issues of newline handling in filters, unifying what newline should a filter expect, and fixes the missing title filter tip issue. 2004-06-15 18:02:52 +00:00
Dries Buytaert 6f48727a9a - Patch #8357 by Ax: added support for mt.getRecentPostTitles to the
blogapi module.  Used by ecto.  I changed '$titles_only' to '$bodies'
  as the patch favored '!$titles_only'.
2004-06-15 17:45:44 +00:00
Dries Buytaert 624ffd1510 - Patch #8444 by jhriggs: creating new users was broken due to recent changes. 2004-06-14 17:32:51 +00:00
Steven Wittens 4d91449dd9 Quick improvement to autoteaser generation:
added double-width dot and comma, and right-to-left question mark as sentence boundaries.
2004-06-10 14:40:55 +00:00