Commit Graph

484 Commits (1239197d6af5b4db2cfa80284c369c8f928beccb)

Author SHA1 Message Date
Nathaniel Catchpole 01f8bd64ed Issue #2854529 by alexpott, xjm, klausi, Chi, Mixologic: Fix Drupal.Scope.MethodScope - all methods should have scopes 2017-03-06 11:25:01 +00:00
xjm 47ec7f7d4f Issue #2600836 by balagan, Sagar Ramgade, Chi, anil280988, joshi.rohit100, Jo Fitzgerald, vaplas, dawehner, alexpott, klausi: Make protected Simpletest test methods public for consistency 2017-03-04 12:27:34 -06:00
xjm 52e3eec616 Issue #2776975 by joelpittet, dawehner, tim.plunkett, xjm, pfrenssen: March 3, 2017: Convert core to array syntax coding standards for Drupal 8.3.x RC phase 2017-03-03 19:20:24 -06:00
xjm 6cca8a6da0 Issue #2751325 by damiankloip, Grayside, dawehner, Wim Leers, catch, tedbow, alexpott, himanshu-dixit, Jo Fitzgerald, xjm, andrewbelcher, skyredwang, effulgentsia, hampercm, eelkeblok: All serialized values are strings, should be integers/booleans when appropriate 2017-02-28 10:13:35 -06:00
Nathaniel Catchpole 9bd08a0024 Issue #2825347 by Wim Leers: 'Accept' header still is used for determining response format of error responses, ?_format= has no effect AND serialization module's exception subscriber does not support status code 500 error responses 2017-02-27 15:09:11 +00:00
Nathaniel Catchpole 55a4f988c1 Issue #2854830 by Wim Leers: Move rest/serialization module's "link manager" services to HAL module 2017-02-27 12:22:01 +00:00
Nathaniel Catchpole d837f01c58 Issue #2808335 by hchonov, tstoeckler, anish.a, Wim Leers, catch, Berdir: Changed time not updated when only non-translatable fields are changed on a translated entity 2017-02-22 16:45:04 +00:00
Nathaniel Catchpole ef4f88376b Issue #2561115 by michaellenahan, alexpott, Lendude, cilefen, lomasr, amit.drupal, Gábor Hojtsy, ifrik, dawehner: Rollback: Use 'Filter' for exposed filter button text in new views and new installations (instead of 'Apply') 2017-02-22 12:37:49 +00:00
Alex Pott 22d186866f Issue #2775479 by Wim Leers, klausi, dawehner: Try to remove the "map HEAD to GET" logic in \Drupal\rest\RequestHandler::handle() 2017-02-21 17:18:53 +00:00
Alex Pott 9f2371f26e Issue #2580935 by vaplas, maijs: DisplayPluginBase::applyDisplayCachablityMetadata() method has typo in it's name 2017-02-21 15:56:40 +00:00
Alex Pott 89b381fe40 Issue #2851746 by Berdir, Wim Leers: Support xdebug header in ResourceTestBase and move htttpClient property to right place 2017-02-18 09:23:01 +00:00
Alex Pott 1816bcd998 Issue #2852992 by arshadcn: EntityResourceTestBase: only assert presence of Link headers for entity types that have link templates 2017-02-18 09:07:59 +00:00
Nathaniel Catchpole 8b46fee4cd Issue #2853296 by Wim Leers: Follow-up for #2820743: address remaining @todo 2017-02-16 21:30:18 +00:00
Alex Pott d2fdd97d11 Issue #2827084 by damiankloip, Wim Leers, dawehner, prics, larowlan, catch, darrenwh: EntityNormalizer::denormalize should not throw UnexpectedValueException, but \Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException, so we get a 422 response instead of 400 2017-02-14 14:09:58 +00:00
xjm f2c2531c52 Issue #2848933 by Wim Leers, tstoeckler: SerializationLinkManagerTest should not enable the rest_test module (because it implicitly enables the rest module) 2017-02-13 04:03:07 -06:00
xjm ce118a0085 Issue #2834848 by tedbow, Wim Leers, alexpott: REST test fails depending on local testing URL 2017-02-12 15:58:36 -06:00
xjm 5f178e351d Revert "Issue #2832859 by webflo, harings_rob, Wim Leers: Write EntityResourceTestBase subclasses for: MenuLinkContent"
This reverts commit ef0a8723e4.
2017-02-11 19:23:50 -06:00
Alex Pott ef0a8723e4 Issue #2832859 by webflo, harings_rob, Wim Leers: Write EntityResourceTestBase subclasses for: MenuLinkContent 2017-02-12 00:30:08 +00:00
Alex Pott 34a37704c8 Issue #2851678 by efrainh, jhodgdon: rest.install and other .install files have malformed @defgroup doc blocks 2017-02-11 23:44:38 +00:00
xjm 6ca61afd59 Issue #2851510 by klausi: Fix phpcs regressions by running phpcbf 2017-02-10 16:17:15 -06:00
Alex Pott 172e9e38cc Issue #2815845 by dawehner, Wim Leers, alexpott, tedbow, Berdir, swentel, webflo: Importing (deploying) REST resource config entities should automatically do the necessary route rebuilding 2017-02-10 10:45:01 +00:00
Alex Pott 1fcd3d5c56 Issue #2808233 by gnuget, dawehner, Wim Leers, tedbow, Chi, dysrama: REST 403 responses don't tell the user *why* access is not granted: requires deep Drupal understanding to figure out 2017-02-09 19:56:28 +00:00
Nathaniel Catchpole 4417b82c97 Issue #2849474 by Wim Leers: \Drupal\Tests\rest\Functional\CookieResourceTestTrait::initAuthentication() should use the current test format, and should not send an Accept header 2017-02-08 15:04:49 +00:00
Nathaniel Catchpole 0a3fb0a8a2 Issue #2838144 by arshadcn, Wim Leers, drpal: Update "bundle missing" error message in entity denormalization to indicate which field is actually missing 2017-02-08 13:02:14 +00:00
effulgentsia bfaf6b6e0f Issue #2758897 by Wim Leers, damiankloip, larowlan: Move rest module's "link manager" services to serialization module 2017-01-30 21:53:34 -08:00
effulgentsia 0bc54981d2 Issue #2113345 by dawehner, tedbow, Wim Leers, kristiaanvandeneynde, Crell, Grayside, klausi: Define a mechanism for custom link relationships 2017-01-30 12:29:33 -08:00
Nathaniel Catchpole 5394f9f01e Issue #2840974 by alexpott, Wim Leers, axot: CookieResourceTestTrait test should send Content-Type request header 2017-01-30 14:50:11 +00:00
Alex Pott 98e7ac3f66 Issue #2838949 by damiankloip: HttpException Handling Does Not Pass Headers to Responses — results e.g. in missing Allow header for 405 responses 2017-01-25 18:40:27 +00:00
Alex Pott 5ce4fce14f Issue #2813853 by Wim Leers: RequestHandler has its own error handling rather than leaving it to KernelEvents::EXCEPTION event subscribers 2017-01-25 18:02:58 +00:00
Nathaniel Catchpole 3d72d4be83 Issue #2194783 by Berdir, vprocessor, andypost, Antonnavi, tim.plunkett, Crell, Mile23, catch: Rename EntityTypeInterface::isSubclassOf() to ::entityClassImplements() 2017-01-11 22:06:48 +00:00
Alex Pott 51d3d8a984 Issue #2805281 by Wim Leers, damiankloip: ?_format=hal_json error responses are application/json, yet should be application/hal+json 2017-01-11 15:32:48 +00:00
Alex Pott fb3389418b Issue #2835683 by dawehner, Wim Leers: Remove HTML from EntityResource validation 422 exception message 2017-01-11 14:14:33 +00:00
Alex Pott ce7cf174eb Issue #2561115 by michaellenahan, Lendude, cilefen, lomasr, amit.drupal, Gábor Hojtsy, dawehner, ifrik: Use 'Filter' for exposed filter button text in new views and new installations (instead of 'Apply') 2017-01-05 21:51:09 +00:00
Alex Pott efb8f715f6 Issue #2739617 by dawehner, Wim Leers, neclimdul, chx: Make it easier to write on4xx() exception subscribers 2017-01-05 13:07:02 +00:00
Alex Pott 6b7acf7d3c Issue #2838954 by damiankloip: Ignore 'Transfer-Encoding' header in EntityResourceTestBase::testGet 2017-01-03 12:08:34 +00:00
Alex Pott badbcd334b Issue #2813755 by Wim Leers, dawehner, tedbow, damiankloip: JSON responses encoded inconsistently: make them all RFC4627-compliant 2016-12-20 11:31:00 +00:00
Alex Pott c1325daed9 Issue #2830333 by Wim Leers, tedbow: All REST update path test coverage fixtures contain no-op code and other mistakes 2016-12-09 21:54:04 +00:00
Nathaniel Catchpole 9d095b9455 Issue #2717969 by Wim Leers, benelori, dawehner: REST views: Views field is not displayed as token, if exclude flag is set and the display is RestExport 2016-12-06 11:09:47 +00:00
Alex Pott 67c7387fd9 Issue #2789315 by amateescu, timmillwood, claudiu.cristea, sandervd, GroovyCarrot, catch, Wim Leers, Berdir, pfrenssen, twistor, xjm: Create EntityPublishedInterface and use for Node and Comment 2016-12-02 22:18:44 +00:00
Alex Pott f7aed2076c Issue #2832013 by Wim Leers, michielnugter, catch: CommentResourceTestBase::testPostDxWithoutCriticalBaseFields() always fails on PHP 5.6 & MySQL 5.5 (works fine on other PHP versions) 2016-12-02 13:11:34 +00:00
Alex Pott 79569a7503 Revert "Issue #2712647 by klausi, catch, slasher13, jibran, Manuel Garcia, alexpott, naveenvalecha, neclimdul, dawehner, Wim Leers, pounard: Update Symfony components to ~3.1"
This reverts commit a55b8ef19e.
2016-12-02 11:05:17 +00:00
Nathaniel Catchpole 8f53fb1430 Issue #2824576 by Wim Leers: Delete old REST test coverage: (Read|Create|Update|Delete)Test, deprecate RESTTestBase 2016-12-01 15:55:55 +00:00
Alex Pott a55b8ef19e Issue #2712647 by klausi, catch, slasher13, jibran, Manuel Garcia, alexpott, naveenvalecha, neclimdul, dawehner, Wim Leers, pounard: Update Symfony components to ~3.1 2016-12-01 11:00:20 +00:00
Nathaniel Catchpole 6e26b862de Issue #2828319 by mradcliffe, Wim Leers, neclimdul: [regression] REST in Drupal 8.2.x does not allow HTTP methods other than GET/PATCH/POST/DELETE: OPTIONS, PUT, et cetera all fail 2016-11-30 20:57:35 +00:00
Nathaniel Catchpole 319076780b Issue #2737719 by Wim Leers, dawehner: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method 2016-11-30 16:28:46 +00:00
Nathaniel Catchpole 3c4e905762 Revert "Issue #2737719 by Wim Leers, dawehner: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method"
This reverts commit 59781ffc44.
2016-11-29 13:19:15 +00:00
Nathaniel Catchpole 59781ffc44 Issue #2737719 by Wim Leers, dawehner: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method 2016-11-29 12:46:11 +00:00
Alex Pott ee23c1875a Revert "Issue #2789315 by amateescu, timmillwood, claudiu.cristea, sandervd, GroovyCarrot, catch, Wim Leers, pfrenssen, Berdir, twistor, xjm: Create EntityPublishedInterface and use for Node and Comment"
This reverts commit d2af11699a.
2016-11-28 14:48:43 +00:00
Alex Pott d2af11699a Issue #2789315 by amateescu, timmillwood, claudiu.cristea, sandervd, GroovyCarrot, catch, Wim Leers, pfrenssen, Berdir, twistor, xjm: Create EntityPublishedInterface and use for Node and Comment 2016-11-28 14:27:42 +00:00
Alex Pott 0f3f279238 Issue #2807501 by Wim Leers, dawehner, tstoeckler: ResourceResponse::$responseData is serialized, but is never used: unserializing it on every Page Cache hit is a huge performance penalty 2016-11-15 09:56:57 +00:00
Nathaniel Catchpole 1f1f20fe0a Issue #2815063 by leeotzu, shruti1803, minakshiPh, lomasr, Yogesh Pawar, Chi: Typo in EntityResource::delete() 2016-10-21 16:49:25 +01:00
Nathaniel Catchpole 6ddd0ba55c Issue #2810381 by timmillwood, plach: Add generic status field to ContentEntityBase 2016-10-20 13:33:59 +01:00
Alex Pott 5233c3d2b8 Issue #2815063 by minakshiPh: Typo in EntityResource::delete() 2016-10-13 11:24:47 +01:00
Alex Pott eaaea5db8b Revert "Issue #2664322 by dawehner, benjifisher, almaudoh: key_value table is only used by a core service but it depends on system install"
This reverts commit 5571193f80.
2016-09-28 17:22:20 +01:00
Alex Pott d27d6c3dd9 Issue #1841474 by dawehner, lokapujya, gnuget, mradcliffe, lluvigne, Wim Leers, klausi: Convert REST tests to Guzzle (would also help with core moving from WTB to BTB) 2016-09-28 13:18:20 +01:00
Nathaniel Catchpole 5571193f80 Issue #2664322 by dawehner, benjifisher, almaudoh: key_value table is only used by a core service but it depends on system install 2016-09-28 11:38:34 +01:00
Alex Pott f8f39839d3 Issue #2772537 by dawehner, Wim Leers, jacov: REST Views override existing REST GET routes 2016-09-25 12:19:48 +01:00
Alex Pott 713d4e9874 Issue #2773185 by Wim Leers, effulgentsia, dawehner: Fix nits in \Drupal\rest\Entity\ConfigDependencies 2016-09-22 17:38:32 +01:00
Alex Pott 676f38d8c7 Issue #2795965 by Wim Leers, neclimdul: REST requests with invalid X-CSRF-Token header get "missing " mesage 2016-09-22 14:50:25 +01:00
Alex Pott 7f43b7ba67 Issue #2794735 by harings_rob: Wrong documentation on Drupal\rest\Plugin\rest\resource\EntityResource 2016-09-22 14:25:13 +01:00
Nathaniel Catchpole fabc088e57 Issue #2803179 by Wim Leers, MKorostoff, Berdir, dawehner: [regression] rest_update_8201() can fail and break things 2016-09-21 14:23:53 +01:00
Alex Pott 0cf01aef92 Issue #2801741 by zsofi.major, penyaskito: Fix typo in 'RestExport.php' 2016-09-19 16:15:28 +01:00
Alex Pott e38299552e Issue #2787657 by dawehner, alexpott: \Drupal\Tests\rest\Unit\EntityResourceValidationTraitTest::testValidate 2016-08-29 10:32:38 -05:00
Alex Pott a7b67e7af1 Issue #2721901 by Mile23, anoopjohn: Fix Drupal.Commenting.FunctionComment.MissingParamName 2016-08-29 06:50:59 -05:00
Nathaniel Catchpole 2a43f31fb7 Issue #2779807 by jhedstrom: Bring RestExport::buildResponse into line with Feed::buildResponse 2016-08-29 08:04:46 +01:00
Nathaniel Catchpole f6ae58526c Issue #2572801 by alexpott, vprocessor, andriyun, andypost, chishah92, Mile23, attiks, hussainweb, klausi, dawehner, pfrenssen: Fix 'Drupal.WhiteSpace.ScopeIndent' coding standard 2016-08-28 18:16:36 +01:00
Alex Pott 2e5e060c53 Issue #2783395 by Mile23: Fix 'Drupal.Commenting.FunctionComment.InvalidReturn' coding standard 2016-08-28 06:25:45 -05:00
Alex Pott 08b7a3fbc8 Issue #2783393 by Mile23: Fix 'Drupal.Commenting.FunctionComment.IncorrectParamVarName' coding standard 2016-08-18 10:38:31 +01:00
Nathaniel Catchpole e1ef487b8d Issue #2513534 by tim.plunkett, lokapujya, tedbow, LewisNyman, Manjit.Singh, alexpott, Maninders, Bojhan: Remove the 'disabled' region from Block UI 2016-08-08 13:16:02 +01:00
Alex Pott f0fe2a07f3 Issue #2780255 by klausi: Replace incorrect EntityTypeBundleInfo type hints with interface 2016-08-08 10:47:34 +01:00
Nathaniel Catchpole ad76a96a40 Issue #2723607 by valthebald, deepakaryan1988: Remove entity_load* usage for dynamic entity types 2016-08-05 09:29:20 +01:00
effulgentsia 79dfc068a0 Issue #2291055 by marthinal, tedbow, Wim Leers, kylebrowning, m1r1k, clemens.tolboom, jlbellido, vivekvpandya, snehal.brahmbhatt, dawehner, klausi, droti, alexpott, cloudbull, Berdir, heykarthikwithu, claudiu.cristea: REST resources for anonymous users: register 2016-08-03 10:28:52 -07:00
Nathaniel Catchpole a0a530fd4f Issue #1920902 by neclimdul, larowlan, alexpott, chx, sun, jthorson, damiankloip, Berdir, Mixologic, YesCT, hussainweb, rcaracaus, cweagans, catch, jibran, msonnabaum, dawehner, webchick, anavarre, heyrocker: Add a Drupal Yaml wrapper so we can default to PECL Yaml component if it is available 2016-08-01 18:52:00 +01:00
Alex Pott 2ec23349fc Issue #2664780 by Wim Leers, tedbow, dawehner, klausi: Remove REST's resource- and verb-specific permissions for EntityResource, but provide BC and document why it's necessary for other resources 2016-08-01 17:35:53 +01:00
Alex Pott 23ed767a23 Revert "Issue #2664780 by Wim Leers, tedbow, dawehner, klausi: Remove REST's resource- and verb-specific permissions for EntityResource, but provide BC and document why it's necessary for other resources"
This reverts commit 85d755a992.
2016-08-01 17:35:08 +01:00
Alex Pott 85d755a992 Issue #2664780 by Wim Leers, tedbow, dawehner, klausi: Remove REST's resource- and verb-specific permissions for EntityResource, but provide BC and document why it's necessary for other resources 2016-08-01 15:09:47 +01:00
Nathaniel Catchpole 3700d9fd91 Issue #2427637 by Mile23, keopx, naveenvalecha, marvin_B8: Remove usages of deprecated entity_get_bundles() 2016-07-31 21:20:40 +01:00
Alex Pott 3de79990b3 Issue #2681911 by garphy, Wim Leers, gabesullice: REST requests without X-CSRF-Token header: unhelpful response significantly hinders DX, should receive a 401 response 2016-07-29 16:11:36 +01:00
Alex Pott 776613979d Issue #2752325 by Wim Leers, marthinal, dawehner, ericpugh: Automatically provide HEAD support when a REST resource supports GET 2016-07-29 15:52:16 +01:00
Alex Pott af80cb499a Issue #2659070 by Wim Leers, dawehner, tic2000, Crell: REST requests without Content-Type header: unhelpful response significantly hinders DX, should receive a 415 response 2016-07-29 00:32:38 +01:00
effulgentsia 3a13f94634 Issue #2721595 by Wim Leers, dawehner: Simplify REST configuration 2016-07-26 14:57:39 -07:00
Nathaniel Catchpole 62b7392dee Issue #2753681 by tedbow, Wim Leers, dawehner, neclimdul, catch: Move CSRF header token out of REST module so that user module can use it, as well as any contrib module 2016-07-25 13:47:47 +01:00
Alex Pott 2bb0468847 Issue #2662284 by Wim Leers, swim, tedbow, dawehner: Return complete entity after successful PATCH 2016-07-19 11:29:44 +01:00
Nathaniel Catchpole cc6885bde6 Issue #2755843 by alexpott, xjm: The order in which config is saved affects dependency calculations 2016-07-04 12:55:53 +01:00
Nathaniel Catchpole d97b4131da Issue #2756527 by chgasparoto, Wim Leers: Move test coverage for rest_update_8202() from core/modules/views to core/modules/rest 2016-06-30 12:03:23 +01:00
Alex Pott 5987069eea Issue #2228141 by juampynr, eiriksm, dawehner, almaudoh, lokapujya, mohit_aghera, clemens.tolboom, manojapare, Lendude, Sonal.Sangale, Wim Leers, alexpott, damiankloip, andypost: Add authentication support to REST views 2016-06-25 15:33:37 +02:00
Alex Pott b3d0a73198 Issue #2419825 by marthinal, Wim Leers, bigjim, dawehner, klausi: Make serialization_class optional 2016-06-23 13:00:46 +02:00
Alex Pott 871da5e4f7 Issue #2308745 by Alumei, dawehner, Wim Leers, larowlan, Arla, alexpott, g.oechsler, R.Muilwijk, Berdir, catch, klausi, clemens.tolboom, MattA, Crell: Remove rest.settings.yml, use rest_resource config entities 2016-06-19 14:41:10 +01:00
Alex Pott 6a16932c8d Issue #2724823 by tedbow, dawehner, Wim Leers, clemens.tolboom: EntityResource: read-only (GET) support for configuration entities 2016-06-17 11:45:44 +01:00
Alex Pott 4b6d125f1c Issue #2653318 by Wim Leers, aneek, marthinal, dawehner: While in maintenance mode, REST routes respond with HTML instead of XML/JSON/… 2016-06-16 18:10:50 +01:00
Nathaniel Catchpole 22c915f33f Issue #2502865 by claudiu.cristea: Remove all remaining usages of the drupal_ajax accept header 2016-06-14 16:25:25 +01:00
Alex Pott edad386212 Issue #2567133 by Wim Leers: getTypes in TypeLinkManager doesn't work with the null cache back end 2016-06-02 13:48:41 +01:00
Alex Pott 6749853b33 Issue #2631774 by Wim Leers, marthinal, dawehner, tedbow, tyler.frankenstein, gabesullice, valthebald: Impossible to update Comment entity with REST (HTTP PATCH): bundle field not allowed to be updated, but EntityNormalizer::denormalize() requires it 2016-05-31 00:44:39 +01:00
Alex Pott 491554b180 Issue #1996130 by dawehner, damiankloip, dagmar, marthinal, clemens.tolboom, Nitesh Sethia: REST views: not adding dependencies on Serializer providers 2016-05-27 12:13:13 +01:00
Nathaniel Catchpole 8c570329bb Issue #2626298 by marthinal, borisson_, Wim Leers, dawehner: REST module must cache only responses to GET requests 2016-05-26 08:47:51 +01:00
Nathaniel Catchpole e039fa2dac Issue #2579235 by kylebrowning, willzyx: Resource plugin manager needlessly calls wrong method to instantiate plugins 2016-05-10 11:29:16 +01:00
Nathaniel Catchpole df74821d4e Issue #2718545 by e0ipso, naveenvalecha: Refactor \Drupal\rest\RequestHandler::handle() into smaller methods 2016-05-10 11:18:40 +01:00
Alex Pott 133c212ed9 Issue #2719695 by alexpott, Mile23: Fix 'Drupal.Classes.ClassDeclaration.CloseBraceAfterBody' coding standard 2016-05-08 10:05:38 -05:00
Alex Pott d5d0d6ce87 Issue #2572777 by andypost, alexpott, attiks, andriyun: Fix 'Squiz.Strings.ConcatenationSpacing' coding standard 2016-05-05 12:07:19 +01:00
Alex Pott 3eeaeb6490 Issue #2707371 by Mile23: Fix several errors in the 'Drupal.Commenting.DocComment' coding standard 2016-04-30 14:52:19 +01:00