Commit Graph

482 Commits (0ff3dada280f172289a45793e50494a4a0730264)

Author SHA1 Message Date
Alex Pott 0c9c57f14c
Issue #2911527 by harsha012, b_sharpe, Chris Burge, Manav, jibran, Waldoswndrwrld, christinlepson, vacho, mttsmmrssprks, nicholasThompson, Wim Leers, othermachines, Sutharsan: Allow dashes in Styles dropdown's element names 2020-07-31 18:22:24 +01:00
Alex Pott 610682e945
Issue #3099662 by jibran, dpi, jptaranto, larowlan, nod_: Allow ckeditor_stylesheets to refer to a Drupal root URL 2020-07-31 15:19:13 +01:00
Alex Pott f7277d249b
Issue #3156266 by longwave, jungle, siddhant.bhosale, alexpott: Fix 70 spelling mistakes 2020-07-16 13:53:59 +01:00
xjm de32f3ca2d Issue #3133033 by munish.kumar, xjm, Hardik_Patel_12, daffie, swatichouhan012: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the drupalCreateUser() test method 2020-06-21 16:39:19 -05:00
Alex Pott 0955fd0458
Issue #3123068 by longwave: Fix 'Drupal.Semantics.FunctionT.ConcatString' coding standard 2020-05-29 15:41:42 +01:00
Alex Pott 81e9500d67
Issue #3138718 by sja112, longwave, dww, xjm, alexpott: Convert British English spellings to American English, for the umpteenth time 2020-05-29 12:25:47 +01:00
xjm 11387380d5 Issue #3139218 by mondrake, daffie: Replace usages of AssertLegacyTrait::assertResponse(), which is deprecated 2020-05-24 08:33:20 -05:00
xjm 0f66cce399 Issue #2937513 by eltori, longwave, klausi, catch, idebr: Fix 'Drupal.Commenting.DocComment.TagGroupSpacing' coding standard 2020-05-20 17:11:54 -05:00
catch 421c588c16 Issue #3131343 by mondrake, dww, jungle: Replace assertions involving calls to in_array() with assertContains()/assertNotContains() 2020-05-11 09:10:55 +01:00
Alex Pott 6b54e9534f
Issue #2778917 by kiamlaluno, jungle, elaman, dawehner, alexpott, tvb, vadim.hirbu, ravi.shankar, quietone: Use the second parameter of \Drupal::state()->get() instead of checking the method didn't return any value 2020-05-02 13:07:36 +01:00
Alex Pott 3f87e0d805
Issue #3132745 by jungle, longwave, xjm, swatichouhan012, daffie: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the $modules test property 2020-05-02 12:34:00 +01:00
xjm 767d453d30 Issue #3100251 by Hardik_Patel_12, longwave: Several code comments have incorrect namespaces for classes or interfaces they reference 2020-05-01 20:23:15 -05:00
xjm 9ea59d229e Issue #3126957 by Suresh Prabhu Parkala, Neslee Canil Pinto, Kristen Pol, jungle: Add missing curly brackets around @inheritdoc 2020-04-29 17:45:17 -05:00
catch 27515dc255 Issue #3130811 by mondrake, jungle, longwave: Remove redundant $message from assert(Not)InstanceOf calls 2020-04-27 10:35:37 +01:00
catch 4d02fe7c25 Issue #3128746 by mondrake, longwave, dww: Replace assertions involving calls to strpos() with more accurate string assertions 2020-04-27 10:02:44 +01:00
catch 4fe0b034a9 Issue #3128905 by jungle, longwave, Kristen Pol, mondrake: Replace assert* involving an instanceof operator with assertInstanceOf()/assertNotInstanceOf() 2020-04-24 21:27:52 +01:00
Alex Pott 3ea981a11f
Issue #3128814 by longwave, jungle, dww: Replace assert* involving count() and an equality operator with assertCount() 2020-04-20 10:21:24 +01:00
catch 8e9db42930 Issue #3070745 by AndyF, ravi.shankar, olli, tedbow, samuel.mortenson, droplet, alexpott: Off canvas filling up localStorage's quota, causing errors 2020-04-17 17:59:46 +01:00
Alex Pott 6bf02d966d
Issue #2822382 by voleger, pfrenssen, erozqba, jungle, RytoEX, borisson_, jofitz, shashikant_chauhan, sidharthap, dawehner, xjm, kiamlaluno, catch, daffie, klausi: Make every $modules property protected on classes extending BrowserTestBase and KernelTestBase 2020-04-13 12:05:00 +01:00
Alex Pott 0dc28534c8
Issue #3107732 by mondrake, longwave, swatichouhan012, salah1, xjm, catch, alexpott, Berdir: Between April 13 and April 17, 2020: Add return typehints to setUp/tearDown methods in concrete test classes 2020-04-13 09:56:30 +01:00
Alex Pott 221b7aed06
Issue #3108006 by mondrake, ravi.shankar, longwave: Replace assertInternalType() calls with dedicated methods 2020-04-11 06:35:50 +01:00
Alex Pott 458e132a8c
Issue #3115088 by lauriii, bnjmnm, tim.plunkett: Remove Classy as a base theme of core themes 2020-02-26 17:39:33 +00:00
xjm a94383585b Issue #3108181 by bnjmnm, lauriii, tedbow, xjm: Decouple Classy libraries from Bartik 2020-01-31 16:53:19 -05:00
Alex Pott 4577772da0
Issue #3101543 by lauriii, bnjmnm, ravi.shankar, alexpott: Update core JavaScript dependencies listed in package.json 2020-01-30 09:08:38 +00:00
Alex Pott 5b657b15b8
Revert "Issue #3101543 by lauriii, bnjmnm, ravi.shankar: Update core JavaScript dependencies listed in package.json"
This reverts commit 2dadb738bf.
2020-01-28 13:14:16 +00:00
Alex Pott 2dadb738bf
Issue #3101543 by lauriii, bnjmnm, ravi.shankar: Update core JavaScript dependencies listed in package.json 2020-01-28 11:36:14 +00:00
Alex Pott b28a392ece
Issue #3073261 by oknate, phenaproxima, Wim Leers: Improve CKEditorTestTrait 2020-01-14 15:30:11 +00:00
Alex Pott f68812c39a
Issue #2571371 by shubham.prakash, Berdir, ytsurk, Wim Leers, tstoeckler, Gábor Hojtsy: Editor settings cannot be translated 2019-11-27 09:16:42 +00:00
catch ea29d9824b Issue #3094047 by dww: @see links in ckeditor module point to deprecated version of docs 2019-11-22 09:51:28 +00:00
Alex Pott bed9f2553a
Issue #2888723 by fenstrat, Petr Illek, kim.pepper, johnennew, Wim Leers, alexpott: ckeditor_stylesheets cache busting: use system.css_js_query_string 2019-11-15 12:32:42 +00:00
Lauri Eskola 7bb0757c8b
Issue #2986147 by Wim Leers, mroycroft, rp7, sacarney, dkontorovsky: Autogrow for non-admin users causes CKEditor grow past the viewport when there is a lot of content in the CKEditor 2019-11-14 16:56:24 +02:00
catch 19f9474b9b Issue #2742585 by ZeiP, alexpott, mondrake, klausi, tomasnagy, Krzysztof Domański, sokru, kristiaanvandeneynde, dawehner, jeroenbegyn: Deprecate dangerous assertTrue/False() compatibility overrides in PHPUnit Kernel, Functional and FunctionalJavascript tests 2019-11-08 13:53:52 +00:00
catch 32d95eccd7 Issue #3082655 by Wim Leers, alexpott, iyyappan.govind, dww, lauriii: Specify the $defaultTheme property in all functional tests 2019-11-08 13:39:33 +00:00
Lauri Eskola 4fb98eb269
Issue #3064049 by zrpnr, lauriii, bnjmnm, finnsky, alexpott, tedbow, phenaproxima, Wim Leers, xjm, Berdir, sasanikolic, justafish, larowlan: Replace jQuery UI sortable with Sortable js 2019-11-01 02:21:14 +02:00
Gábor Hojtsy bb8122c42c Issue #3089472 by zrpnr, nod_, bnjmnm: Remove matchmedia in Drupal 9 2019-10-31 14:35:42 +01:00
Gábor Hojtsy 5a143e77f9 Issue #3041076 by alexpott, shaal, Gábor Hojtsy, lauriii, Wim Leers, catch, Cottser, jibran, andypost, znerol, xim, joelpittet, effulgentsia: Update Drupal 9 to Twig 2 2019-10-31 13:39:18 +01:00
catch e37031e09a Issue #3072702 by alexpott, Wim Leers, mikelutz, xjm, catch, Berdir, tedbow, webchick, shaal, Mixologic, heddn: Core extensions should not need to specify the new core_version_requirement in *.info.yml files so that 9.0.x can be installed 2019-10-15 15:34:52 +01:00
catch 5be2df421d Issue #2940189 by Vlad Bo, claudiu.cristea, alexpott, NightHunterSV, andypost, almaudoh, voleger, Berdir: Deprecate system_get_info() 2019-10-07 14:46:33 +01:00
Lauri Eskola 67dd0adb63
Issue #3071713 by oknate, Wim Leers, bnjmnm, phenaproxima, lauriii: Make error messages for embedded media themeable 2019-10-04 20:14:31 +03:00
catch e17bb0091c Issue #3076609 by oknate: \Drupal\Tests\ckeditor\FunctionalJavascript\CKEditorIntegrationTest fails on Sqlite 2019-08-22 21:47:35 +01:00
Lee Rowlands ef0147848f
Issue #2819731 by tim.plunkett, Wim Leers: Text Editor plugins are coupled to editor_form_filter_format_form_alter() 2019-08-13 07:36:15 +10:00
webchick 6280478a1a Issue #2994699 by Wim Leers, oknate, ckrina, legovaer, phenaproxima, webchick, seanB: Create a CKEditor plugin to select and embed a media item from the Media Library 2019-08-12 10:25:03 -07:00
effulgentsia f5b124ab5e Issue #2994696 by oknate, Wim Leers, phenaproxima, starshaped, lauriii, andrewmacpherson, ckrina, a.milkovsky, John Pitcairn, artis, cs_shadow, duncan.moo, Berdir, JamesK, Ambidex, BartK, idflood, Dave Reid, CTaPByK, Reinmar, kmoll, webflo, thenchev, wrd, yched, kkrzton, slashrsm, root_brute, Ruuds, MobliMic, ls206, marcoscano, pixelmord, narnua: Render embedded media items in CKEditor 2019-08-06 23:11:04 -07:00
catch 012b0c73a0 Issue #3002933 by alexpott, Mile23, Wim Leers: Fix "The Drupal\editor\Plugin\EditorBase::settingsFormSubmit method is deprecated since version 8.3.x and will be removed in 9.0.0." and friends 2019-07-18 11:20:37 +01:00
catch c12498bd9e Issue #2776031 by fgm, andypost, voleger, yogeshmpawar, Berdir, joachim: Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage 2019-07-12 14:15:04 +01:00
catch 84df3bb393 Issue #3063020 by mpp: Support translation of the list of styles in CKEditor 2019-07-11 15:48:37 +01:00
catch 9791614b78 Issue #2731817 by mikelutz, ashishdalvi, Sonal.Sangale, dbt102, andypost, jhodgdon, martin107, roderik: Replace all calls to the deprecated Drupal::url() function in Core 2019-04-16 14:38:27 +09:00
Lauri Eskola 9a4a499f07
Issue #3024527 by alexpott, markconroy, waako, occupant: Add and configure stylelint-order 2019-04-01 20:16:16 +03:00
Lauri Eskola 96800b2e0a
Issue #2952390 by tedbow, bnjmnm, samuel.mortenson, alwaysworking, Wim Leers, phenaproxima, lauriii, xjm, bendeguz.csirmaz, effulgentsia, AaronMcHale: Off-canvas styles override CKEditor's reset and theme 2019-03-25 20:15:55 +02:00
Lauri Eskola 6eb60a3669
Issue #3001029 by frob, Wim Leers: Improve the documentation of the @CKEditorPlugin plugin type annotation 2018-10-05 14:19:50 +03:00
Alex Pott 2dabd1de10
Issue #2829185 by vaplas, Jo Fitzgerald, anmolgoyal74, chipway, gaurav.kapoor, mark_fullmer, amit.drupal, cilefen, longwave, xjm, wturrell, anavarre: Fix spelling errors in Drupal core comments 2018-09-20 17:12:38 +01:00
Alex Pott 7254e79e8e
Issue #2916589 by wengerk, Wim Leers: Extend the CKEditorIntegrationTest for DrupalImageCaption 2018-09-20 11:32:31 +01:00
Alex Pott cab7a12733
Issue #2912399 by wengerk, tedbow, Wim Leers: Extend the CKEditorIntegrationTest for DrupalImage 2018-09-12 14:14:49 +02:00
xjm fa6b3d95dd Revert "Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase"
This reverts commit 69501f3062.
2018-08-16 18:12:22 -05:00
Nathaniel Catchpole 69501f3062 Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase 2018-08-15 19:55:23 +09:00
Lauri Eskola e742590eed
Issue #2981652 by ApacheEx, corbacho, drpal, dawehner, xjm, alexpott, lauriii: Format core JavaScript using recently add Prettier 2018-08-09 18:49:18 +03:00
Alex Pott 8c5075ad69
Issue #2985147 by eliclaggett, msankhala, neclimdul: Correct copy pasted plugin constructor documentations 2018-07-24 16:18:58 +01:00
Lauri Eskola 258a27b635 Issue #2983373 by ApacheEx, drpal, m1r1k: JS codestyle: no-restricted-globals 2018-07-16 09:00:57 +03:00
Alex Pott 5a80703c4c
Issue #2983371 by ApacheEx, drpal: JS codestyle: no-else-return 2018-07-05 16:50:52 +01:00
Alex Pott 27740c26de
Issue #2942900 by Mixologic, vaplas, jibran, dawehner, Lendude, martin107, alexpott, tedbow, tacituseu, tstoeckler, heddn: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver 2018-07-04 15:36:57 +01:00
Nathaniel Catchpole cb67958df8 Issue #2557299 by alexpott, Manuel Garcia, borisson_, phenaproxima, swentel, Berdir, larowlan, mbovan, martin107, LKS90, segi, tim.plunkett, giancarlosotelo: Any AJAX call disregards machine name verification when AJAX is used and leads to a fatal error 2018-07-04 12:48:07 +01:00
Alex Pott ff99cb2133
Revert "Issue #2942900 by Mixologic, vaplas, jibran, Lendude, martin107, alexpott, dawehner, tedbow, tacituseu, tstoeckler, heddn: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver"
This reverts commit f55d974612.
2018-07-04 08:20:33 +01:00
Alex Pott f55d974612
Issue #2942900 by Mixologic, vaplas, jibran, Lendude, martin107, alexpott, dawehner, tedbow, tacituseu, tstoeckler, heddn: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver 2018-07-04 08:16:25 +01:00
Lee Rowlands 0d6d22af0b
Issue #2926120 by idebr, zaporylie, borisson_: @var tag must not end with a full stop 2018-05-15 06:49:38 +10:00
Alex Pott be6d515cad
Issue #2572613 by Malevi4, idebr, pfrenssen, Mile23, RajeevK: Fix 'Drupal.Array.Array.CommaLastItem' coding standard 2018-05-11 10:40:33 +01:00
Nathaniel Catchpole d90ac78f3e Issue #2798891 by ankitjain28may, trobey, TR: Define project dependencies in core module .info files 2018-04-06 13:13:01 +01:00
Alex Pott 7d2f3a3b76 Issue #2946603 by drpal, alexpott, dawehner: JS codestyle: no-use-before-define 2018-03-05 09:14:08 +00:00
Alex Pott 66f7227799 Issue #2939940 by bmx269, joelpittet: Update stylelint rules color-hex-case to be consistent with Drupal's CSS standards 2018-01-28 08:18:54 +00:00
Alex Pott f0272d5fa6 Issue #2866818 by harsha012, BrightBold, brahmjeet789, joelpittet: Update stylelint rule number-leading-zero to be consistent with Drupal's CSS standards 2018-01-28 08:11:52 +00:00
Alex Pott 0013e901fe Issue #2866810 by BrightBold, harsha012, joelpittet: Update stylelint rule function-comma-space-after to be consistent with Drupal's CSS standards 2018-01-09 18:38:49 +00:00
Alex Pott 5616f9b877 Issue #2866808 by BrightBold, pk188, idebr: Update stylelint rule declaration-block-trailing-semicolon to be consistent with Drupal's CSS standards 2018-01-05 09:56:09 +00:00
Alex Pott c5654de7aa Issue #2866809 by BrightBold: Update stylelint rule declaration-colon-space-after to be consistent with Drupal's CSS standards 2018-01-05 09:45:13 +00:00
webchick f1e33ca3d8 Issue #2925064 by drpal, dawehner, droplet, xjm, webchick, justafish: [1/2] JS codestyle: no-restricted-syntax 2018-01-03 15:27:55 -08:00
Nathaniel Catchpole 0b67173a1f Issue #2929464 by tedbow, mpdonadio: Tests under "core/modules/ckeditor/tests/modules/src/Kernel" are in the wrong folder and do not get tested 2017-12-13 16:00:18 +00:00
xjm dcfee314ad Revert "Issue #2925064 by drpal, dawehner, xjm, justafish, droplet: [1/2] JS codestyle: no-restricted-syntax"
This reverts commit b0a4d7e017.
2017-12-01 13:28:53 -06:00
webchick b0a4d7e017 Issue #2925064 by drpal, dawehner, xjm, justafish, droplet: [1/2] JS codestyle: no-restricted-syntax 2017-11-28 15:40:07 -08:00
xjm 7fbb5e990e Issue #2916294 by dawehner: JS codestyle: no-useless-escape 2017-10-24 12:07:10 -05:00
xjm 9032c68faa Issue #2916154 by drpal, droplet, dawehner, alexpott, xjm: JS codestyle: no-multi-assign 2017-10-24 07:42:16 -05:00
xjm 90c4ab5c2f Revert "Issue #2912399 by wengerk, Wim Leers: Extend the CKEditorIntegrationTest for DrupalImage"
This reverts commit 1136b5980d.
2017-10-24 07:07:54 -05:00
Alex Pott e9c9ee5282 Issue #2912399 by wengerk, Wim Leers: Extend the CKEditorIntegrationTest for DrupalImage 2017-10-23 19:53:46 +01:00
Alex Pott 27266234c2 Revert "Issue #2916154 by drpal, dawehner, xjm: JS codestyle: no-multi-assign"
This reverts commit 169e867159.
2017-10-21 21:49:45 +01:00
Alex Pott 169e867159 Issue #2916154 by drpal, dawehner, xjm: JS codestyle: no-multi-assign 2017-10-21 21:46:43 +01:00
Nathaniel Catchpole 2fc85e7f0f Issue #2901572 by Jo Fitzgerald, bluccas, mfernea, klausi: Fix 'Drupal.Commenting.PostStatementComment' coding standard 2017-10-13 13:43:02 +01:00
Nathaniel Catchpole ee0f806896 Issue #2873696 by nvexler, wengerk, gido, Jo Fitzgerald, xjm: Add @internal to core classes, methods, properties to Form Classes 2017-10-12 16:15:53 +01:00
Lauri Eskola 29cd930e59 Issue #2914946 by drpal, dawehner, droplet: JS codestyle: no-var 2017-10-12 10:10:10 +03:00
Alex Pott 336d30dc4d Issue #2914719 by nod_, droplet: JS codestyle: newline-per-chained-call 2017-10-11 15:40:35 +01:00
Nathaniel Catchpole 64fa6ad712 Issue #2901744 by mfernea: Fix 'PSR2.Namespaces' coding standard 2017-10-10 16:09:51 +01:00
Nathaniel Catchpole f659d6ca8e Issue #2901726 by mfernea, gmario, finn.lewis, robertoperuzzo, rachel_norfolk: Fix 'Squiz.Functions.MultiLineFunctionDeclaration' coding standard 2017-10-10 15:43:06 +01:00
Nathaniel Catchpole 4577185c9b Issue #2572791 by Mile23, andriyun, attiks, RoSk0: Fix 'Drupal.WhiteSpace.OpenBracketSpacing' coding standard 2017-09-22 12:16:23 +01:00
xjm 44a5c4cbe0 Issue #2901739 by andriyun, Jo Fitzgerald, mfernea, xjm: Fix 'Squiz.Arrays.ArrayDeclaration' coding standard 2017-09-15 16:52:14 -05:00
xjm da9c5ba24d Issue #2902728 by mfernea: Fix 'Drupal.Semantics.FunctionT.BackslashSingleQuote' coding standard 2017-09-13 21:47:52 -05:00
Lauri Eskola 612c1fa68c Issue #2880007 by drpal, nod_, droplet: Auto-fix ESLint errors and warnings 2017-07-06 09:21:40 +03:00
Nathaniel Catchpole f3cf9c43b5 Issue #2880560 by alexpott, droplet: Fix comment added to top of .js files by build process 2017-05-23 15:31:29 +01:00
Alex Pott 8287017e03 Issue #2818825 by drpal, nod_, droplet, cilefen: Rename all JS files to *.es6.js and compile them 2017-05-19 23:12:53 +01:00
Chris McCafferty ef1db63d7b Issue #2878548 by alexpott, droplet, Cottser, idebr, joelpittet, xjm, martin107: Fix CSS whitespace issues 2017-05-19 12:46:41 -04:00
Alex Pott e9de540006 Issue #2878529 by c.nish2k3, joachim: broken @see in docs for hook_ckeditor_plugin_info_alter() 2017-05-16 15:16:38 +01:00
Lauri Eskola 7e3527ed2f Issue #2869570 by AdamPS: Missing dependency of drupal.ckeditor on drupal.displace 2017-04-24 23:03:23 +03:00
Alex Pott 40d1faf887 Issue #2863996 by nlisgo, Jo Fitzgerald, scuba_fly, dawehner: Convert web tests to browser tests for ckeditor module 2017-04-18 09:09:34 +01:00
Alex Pott 8a62fc2281 Issue #2852886 by Wim Leers, pdenooijer, lauriii: Comment improvement CKEditorPluginButtonsInterface 2017-04-17 09:43:42 +01:00
Alex Pott 956497377e Issue #2843693 by droplet, michielnugter, xjm, Mixologic, klausi: Random test failure in CKEditor AjaxCss 2017-03-28 14:19:58 +01:00