Commit Graph

461 Commits (0e38c5f41e1ea8cd7c5f7e7edd918b62cf1780cd)

Author SHA1 Message Date
Lee Rowlands f06e188e2f
Issue #3318549 by smustgrave, mstrelan, larowlan, rkoller, AaronMcHale, acbramley: Rename Custom Block terminology in the admin UI 2023-04-17 18:50:08 +10:00
Dave Long 596b3d38f1
Issue #3351236 by Spokje, mondrake, smustgrave: Fix PHPStan L1 errors "Missing call to parent::setUp()/tearDown() method." 2023-04-16 22:50:09 +01:00
Dave Long 7710bd6098
Issue #3268809 by quietone, Spokje, Rishabh Vishwakarma, ravi.shankar, mrinalini9, Medha Kumari, JatinGupta40, smustgrave, xjm, longwave, catch: Fix class comment doc blocks in tests for 'Drupal.Commenting.DocComment.ShortSingleLine' 2023-04-12 15:50:34 +01:00
catch f88694094f Revert "Issue #3268809 by quietone, Rishabh Vishwakarma, ravi.shankar, Medha Kumari, mrinalini9, JatinGupta40, smustgrave, xjm, longwave: Fix class comment doc blocks in tests for 'Drupal.Commenting.DocComment.ShortSingleLine'"
This reverts commit b4829d2ff7.
2023-04-05 11:25:49 +01:00
Dave Long b4829d2ff7
Issue #3268809 by quietone, Rishabh Vishwakarma, ravi.shankar, Medha Kumari, mrinalini9, JatinGupta40, smustgrave, xjm, longwave: Fix class comment doc blocks in tests for 'Drupal.Commenting.DocComment.ShortSingleLine' 2023-04-05 09:56:11 +01:00
Lee Rowlands 8a924f778d
Issue #3264195 by quietone, joshua1234511, phenaproxima, smustgrave: Move non-migration tests to Forum in preparation for deprecation 2023-03-28 14:57:42 +10:00
catch b3fac4a09f Issue #3328454 by xjm, Bhanu951, jidrone, smustgrave: Replace most strpos() !== FALSE or === FALSE with str_contains() 2023-03-18 11:30:09 +00:00
Lauri Eskola e47f5e759b
Issue #2843992 by smustgrave, jasonawant, moshnoi, alexpott: Block page visibility paths are not validated, using path a without leading forward slash does not work 2023-03-17 10:47:14 +02:00
catch f247d598cb Issue #3341098 by quietone: Move non-migrations tests to Statistics 2023-02-25 09:46:08 +00:00
Dave Long cfe5c87764
Issue #3061266 by smustgrave, Grimreaper, ridhimaabrol24, nod_, pavnish, ithom, Hardik_Patel_12, Webbeh, alexpott: Prefix block machine name suggestions with the theme machine name 2023-02-24 13:45:44 +00:00
Alex Pott f979f42ec0
Issue #3323209 by Spokje, mondrake, smustgrave, alexpott, xjm: Deprecate calling Drupal\block\Plugin\migrate\process\BlockTheme::_construct() with the $migration argument 2023-02-22 21:38:00 +00:00
Dave Long 3789efb326
Issue #3265616 by jungle, lucassc, xjm, nicrodgers, kkalashnikov, Akram Khan, Rishabh Vishwakarma, mrinalini9, jidrone, smustgrave, catch, longwave: Re-word "An illegal choice has been detected" message to remove legality suggestion 2023-02-17 16:31:59 +00:00
catch a386abdf41 Revert "Issue #3265616 by jungle, lucassc, xjm, nicrodgers, kkalashnikov, Akram Khan, Rishabh Vishwakarma, jidrone, smustgrave: Re-word "An illegal choice has been detected" message to remove legality suggestion"
This reverts commit 66c8012275.
2023-02-17 10:14:32 +00:00
catch 66c8012275 Issue #3265616 by jungle, lucassc, xjm, nicrodgers, kkalashnikov, Akram Khan, Rishabh Vishwakarma, jidrone, smustgrave: Re-word "An illegal choice has been detected" message to remove legality suggestion 2023-02-17 09:54:10 +00:00
Dave Long c187cc6339
Issue #3153468 by mondrake, mohrerao, mallezie, smustgrave, meena.bisht, naresh_bavaskar, hash6, ravi.shankar, Hardik_Patel_12, longwave, xjm: Strip HTML tags when using assertEquals() to compare markup 2023-02-07 14:48:42 +00:00
Lee Rowlands 529550a4b2
Issue #2920682 by phenaproxima, alexpott, Sam152, borisson_, Wim Leers, larowlan: Add config validation for plugin IDs 2023-01-10 09:00:04 +10:00
Dave Long 85eeb1bde1
Issue #3324801 by Spokje, mondrake: Fix PHPStan L2 error "Property Foo::$bar has unknown class Baz as its type." 2022-12-07 11:22:31 +00:00
Alex Pott b5b2951668
Issue #2779321 by nedjo, Akram Khan, smustgrave, catch, Meenakshi_j, pooja saraah, Berdir, alexpott: Submitting empty block layout form results in breakage for all block entities 2022-12-01 00:18:28 +00:00
Alex Pott e2d4dcfdf2
Issue #3319582 by mondrake, Spokje, longwave, mallezie: Fix calls to methods with too many parameters passed in 2022-11-29 11:38:06 +00:00
catch e95548becf Issue #2779321 by nedjo, Akram Khan, smustgrave, Meenakshi_j, pooja saraah, alexpott: Submitting empty block layout form results in breakage for all block entities 2022-11-28 12:03:48 +00:00
Alex Pott c900c8d35c
Issue #3265574 by mondrake: Convert remaining assertions involving use of xpath to WebAssert, where possible 2022-10-05 22:56:32 +01:00
Alex Pott fdaf5636e4
Issue #3295880 by Spokje, longwave: ->willReturn(...) would make more sense here 2022-10-03 15:41:01 +01:00
Alex Pott 2c468a0049
Issue #3264947 by Niklan, quietone, ravi.shankar, longwave, TR, xjm: [Sep 12, 2022] Add missing docblocks for test methods ::setUp() and ::tearDown() 2022-09-27 13:28:52 +01:00
Alex Pott 803da73c0b
Issue #2937515 by Spokje, quietone, idebr, longwave, SherFengChong, anweshasinha, borisson_, mfernea, xjm, bbrala, daffie, Berdir: Fix Drupal.Array.Array.[ArrayClosingIndentation, ArrayIndentation] coding standard 2022-09-27 11:11:12 +01:00
catch ffdecfadf6 Issue #3274474 by mondrake, longwave, andypost, Spokje, catch, alexpott: Fix 'Access to an undefined property' PHPStan L0 errors 2022-09-13 12:32:43 +01:00
catch 6c087ced8e Issue #3308987 by lauriii, Spokje, quietone, bnjmnm: Remove references to Stable 2022-09-13 11:13:31 +01:00
Alex Pott 509179528e
Issue #3061148 by vsujeetkumar, Ramya Balasubramanian, raman.b, ankithashetty, pmagunia, lauriii, karishmaamin, priyanka.sahni, quietone, Anishnirmal, Akhildev.cs, mitthukumawat, joachim, xjm: a disabled block's admin title gets double-escaped 2022-08-03 12:45:43 +01:00
catch 33db9ff6f1 Issue #3105880 by peterkokot, Spokje, smustgrave: Remove unused TestContextAwareBlockInterface 2022-07-28 17:49:31 +09:00
catch 5b23a5ea8c Issue #3281427 by quietone, nod_, deviantintegral, Spokje: Update Block and Theme setting migrations to not use Bartik and Seven 2022-07-27 21:39:31 +09:00
catch 763577f8bd Issue #3281429 by tinto, nod_, deviantintegral, lauriii: Update Block non-Migration tests to not use Bartik and Seven 2022-07-26 11:31:48 +09:00
Alex Pott 5d4b6b4a87
Issue #3283602 by urvashi_vora, eleonel, mrinalini9, ankithashetty, alexpott, Munavijayalakshmi: Fix repeated words 2022-07-17 09:58:52 +01:00
catch e44f94f3d3 Issue #3278124 by catch, nod_, andregp, quietone, deviantintegral, alexpott: Convert various tests that use bartik/seven to olivero/claro 2022-07-14 14:33:24 +09:00
Alex Pott 386d79e2e0
Issue #3283794 by mondrake, longwave: Fix 'should return {type} but return statement is missing' PHPStan L0 errors in test code 2022-06-14 14:10:16 +01:00
Alex Pott b8a325c351
Issue #2430133 by JeroenT, znerol, mgifford: BlockLanguageTest tests non-existing pages 2022-06-14 11:20:00 +01:00
Alex Pott f88b4a9a8a
Issue #3271507 by danflanagan8, nod_: Block tests should not rely on Classy 2022-04-25 17:11:11 +01:00
Alex Pott 8ecb3da5dd
Issue #3173159 by sardara, JeroenT: Block add form ajax callback implementation issues 2022-04-08 13:16:47 +02:00
Alex Pott 39b12c461c
Issue #3264122 by Spokje, Taran2L, ankithashetty, quietone, catch, xjm, daffie: Move all non migration aggregator tests to the module in preparation of removal in d10 2022-03-17 14:05:52 +00:00
catch c40c2c9f1a Issue #3259928 by tstoeckler, Berdir, m4olivei, marcoscano, Gábor Hojtsy: Change various tests that test with "all themes" to also include Olivero 2022-03-02 12:13:28 +00:00
catch 9a877cfb78 Issue #3265483 by quietone, danflanagan8, daffie: Handle block migration for modules moved to contrib 2022-03-02 09:51:40 +00:00
catch 0cec48668c Issue #3263654 by Spokje, bbrala, daffie, Kristen Pol, longwave: Move all HAL tests to the module in preparation of removal in D10 2022-02-20 14:43:28 +00:00
Alex Pott 42630422b9
Issue #3261486 by catch, longwave, dww: Remove core updates added prior to 9.3.0 and adjust test coverage 2022-02-08 12:16:18 +00:00
Gábor Hojtsy d0d5dd1efc Issue #3257407 by tstoeckler, catch: Use "content" region in BlockCreationTrait::placeBlock() instead of "sidebar_first" 2022-01-28 09:56:31 +01:00
catch eacb05b19f Issue #3212346 by longwave, Spokje, alexpott: Avoid hundreds of unnecessary installs when testing config entities 2022-01-24 17:25:00 +00:00
Alex Pott ff2d2ea1d9
Issue #3210129 by quietone, murilohp, xjm: Fix spelling for words used once, beginning with 'a' -> 'd', inclusive 2022-01-01 13:52:01 +00:00
Alex Pott 09795b6e93
Issue #3131348 by Spokje, jungle, mondrake, vsujeetkumar, sja112, kishor_kolekar, Hardik_Patel_12, mrinalini9, yogeshmpawar, daffie: Replace assertions involving calls to empty() with assertEmpty()/assertNotEmpty()/assertArrayNotHasKey() 2021-12-30 13:40:35 +00:00
catch cfd8517353 Issue #3182103 by TR, dan2k3k4, longwave, mondrake, Sweetchuck, Kristen Pol: Ensure correct signature for setUp(), tearDown(), setUpBeforeClass(), and assertPostConditions() methods 2021-12-14 12:05:17 +00:00
catch 92836c436b Issue #3138078 by mondrake, larowlan, longwave, xjm: [D9.3 beta - w/c Nov 8, 2021] Add a 'void' return typehint to custom assert* methods 2021-11-22 15:25:32 +00:00
Lee Rowlands a83a7a7836
Issue #3231781 by longwave, mondrake, Feuerwagen, larowlan, TR, nlisgo, xxAlHixx, DuaelFr, GoZ, benjy, no_angel, Mac_Weber: [D9.3 beta - w/c Nov 8, 2021] Remove remaining uses of t() in tests 2021-11-15 12:46:09 +10:00
Lee Rowlands 6d39cdeeb4
Issue #3222769 by bbrala, alexpott, longwave, Matroskeen: [November 8, 2021] Replace all list (array destructuring) assignment to the array syntax 2021-11-15 12:35:55 +10:00
catch e40f6d17d6 Issue #2852557 by bircher, alexpott, longwave, nedjo, dww: Config export key order is not predictable, use config schema to order keys for maps 2021-10-25 10:54:41 +01:00
Alex Pott 57d91dbea0
Issue #3209934 by quietone, alexpott, longwave: Fix spelling for 46 migrate related words 2021-10-18 09:13:24 +01:00
catch 9da1866da4 Issue #3232673 by alexpott, longwave, Berdir, andypost: \Drupal\Core\Entity\EntityInterface::label() can return a NULL 2021-09-30 12:15:17 +01:00
catch e420029e40 Issue #3239292 by alexpott: Missing configuration in KernelTests causes deprecations in PHP 8.1 2021-09-28 16:53:23 +01:00
catch 1b66ab0cb3 Issue #3130606 by shaktik, mondrake, KapilV, longwave, daffie: MockBuilder::setMethods is deprecated in PHPUnit8 and removed from PHPUnit10 2021-09-13 17:23:15 +01:00
catch 6951f4d77a Issue #3225328 by mxr576, Berdir, longwave: Improve page performance by sorting cache contexts/tags on-demand 2021-08-27 12:36:31 +01:00
catch 7af1ea2e69 Issue #3139409 by mondrake, nitesh624, ridhimaabrol24, shobhit_juyal, mohrerao, Hardik_Patel_12, paulocs, ravi.shankar, munish.kumar, mrinalini9, alexpott: Replace usages of AssertLegacyTrait::assertRaw, that is deprecated 2021-08-09 21:40:23 +01:00
catch 604fee30da Revert "Issue #3139409 by mondrake, nitesh624, ridhimaabrol24, shobhit_juyal, mohrerao, Hardik_Patel_12, ravi.shankar, munish.kumar, mrinalini9, alexpott: Replace usages of AssertLegacyTrait::assertRaw, that is deprecated"
This reverts commit 71e8db1949.
2021-08-09 14:50:34 +01:00
catch 71e8db1949 Issue #3139409 by mondrake, nitesh624, ridhimaabrol24, shobhit_juyal, mohrerao, Hardik_Patel_12, ravi.shankar, munish.kumar, mrinalini9, alexpott: Replace usages of AssertLegacyTrait::assertRaw, that is deprecated 2021-08-09 11:21:51 +01:00
catch e33e4c71c4 Issue #3227060 by mondrake, daffie: Replace usages of AssertLegacyTrait::assertNoRaw, that is deprecated 2021-08-06 11:12:32 +01:00
catch 89da8c8d52 Issue #3170396 by mondrake, longwave: Remove uses of t() in assert(No)Raw() calls 2021-08-06 08:21:30 +01:00
catch 6f48525b43 Issue #3220255 by mondrake, longwave: Convert assertions involving use of xpath on links to WebAssert 2021-08-06 07:52:55 +01:00
catch 068f00c4c9 Issue #3191935 by mondrake, tedbow, xjm, alexpott, longwave: Replace usages of AssertLegacyTrait::assertNoText, which is deprecated 2021-07-28 14:41:19 +01:00
catch 686951d3c9 Issue #3153469 by longwave, hmendes, Hardik_Patel_12: Remove uses of t() in clickLink() calls 2021-07-28 08:48:45 +01:00
Lee Rowlands cffb02aad6
Issue #2571235 by alexpott, claudiu.cristea, dawehner, Wim Leers, gabesullice, IJsbrandy, benjifisher, alisonjo315, larowlan, Berdir, effulgentsia, longwave, herom, dmouse, heddn, catch: [regression] Roles should depend on objects that are building the granted permissions 2021-07-09 14:50:54 +10:00
Alex Pott 0f22eb1c63
Issue #1932810 by Berdir, jibran, joegraduate, joelpittet, JeroenT, RenatoG, tim.plunkett, tedbow, andypost, paulocs, hugronaphor, ankithashetty, Meenakshi_j, chr.fritsch, Beanjammin, nikitagupta, EclipseGc, dawehner, xjm, alexpott, fago, tstoeckler, catch, seanB, larowlan: Add entity bundles condition plugin for entities with bundles 2021-07-08 10:22:26 +01:00
webchick adb24cf8a8 Issue #2839558 by tim.plunkett, mohit_aghera, tkoleary, webchick, guilhermevp: Blocks do not have a "remove" contextual link 2021-06-28 12:12:11 -07:00
catch 1d5e219f85 Issue #3156396 by TR, pavnish, mondrake, longwave, catch, jungle: Use assertSameSize() to check same size of two countable variables 2021-06-21 12:31:24 +01:00
catch 3066423e43 Issue #3186661 by Spokje, longwave, mondrake, paulocs, daffie: [May 24, 2021] Remove usage of drupalPostForm 2021-05-24 14:27:52 +01:00
catch f3ad0680a3 Issue #3133162 by jungle, ravi.shankar, Deepak Goyal, Neslee Canil Pinto, anmolgoyal74, xjm, Kristen Pol: Replace the start verb Test with Tests in method comments of tests 2021-05-24 14:26:11 +01:00
Lee Rowlands 24494c2e0b
Issue #3189463 by quietone, Wim Leers, adityasingh, ayushmishra206: all translation/localization migrations should depend on the 'language' migration 2021-05-23 07:26:24 +10:00
Alex Pott 3872f1a8ed
Issue #3139404 by mondrake, munish.kumar, pavnish, longwave: [May 25, 2021] Replace usages of AssertLegacyTrait::assertText, that is deprecated 2021-05-20 22:10:07 +01:00
Alex Pott 4a72cc3169
Issue #3207734 by Spokje, quietone: Fix Drupal.Commenting.InlineVariableComment 2021-05-20 21:47:18 +01:00
Alex Pott 3f75f72de2
Issue #3131281 by mondrake, rahulrasgon, longwave, ridhimaabrol24, naresh_bavaskar, jungle, daffie: [May 17th 2021] Replace assertEqual() with assertEquals() 2021-05-20 00:39:14 +01:00
catch 9c2bfa8df0 Issue #3203476 by mondrake, longwave, alexpott: Convert assertions involving use of xpath on divs to WebAssert 2021-04-28 11:08:17 +01:00
Alex Pott 4b08fbad5f
Issue #3160629 by raman.b, tim.plunkett, Berdir: BlockPluginTrait cannot call ::addContextAssignmentElement() itself 2021-04-01 00:00:08 +01:00
Lee Rowlands cc0730d1bf
Revert "Issue #3199730 by mohit_aghera, Abhijith S, AJV009, Gauravmahlawat, shriaas2898, pameeela, roman-yrv, ranjith_kumar_k_u, Kumar Ashutosh, ilgnerfagundes: Views block description is double-escaped if display name is set"
This reverts commit fd9f7081cb.
2021-03-17 09:32:33 +10:00
Lee Rowlands fd9f7081cb
Issue #3199730 by mohit_aghera, Abhijith S, AJV009, Gauravmahlawat, shriaas2898, pameeela, roman-yrv, ranjith_kumar_k_u, Kumar Ashutosh, ilgnerfagundes: Views block description is double-escaped if display name is set 2021-03-17 07:56:42 +10:00
catch 39e442948d Issue #3198400 by mondrake, daffie, alexpott, longwave: Convert assertions involving use of xpath on input tags to WebAssert 2021-03-08 12:15:37 +00:00
catch afd86e7d3c Issue #3193955 by mondrake, daffie, catch: Swap assertEqual arguments in preparation to replace with assertEquals 2021-01-28 09:57:41 +00:00
catch 543caad097 Issue #3191490 by quietone, huzooka, Wim Leers: Migrate d6 and d7 block (configs) with title "<none>" with "label_display" set to "0" 2021-01-26 10:18:07 +00:00
catch 6c64763741 Issue #2867959 by mondrake, danielnv18, xjm, ZeiP, daffie: Replace usages of deprecated AssertLegacyTrait::assertIdentical 2021-01-21 10:01:43 +00:00
catch d722e9d760 Issue #3192221 by mondrake, daffie, longwave: Swap assertIdentical arguments in preparation to replace with assertSame 2021-01-18 17:35:30 +00:00
catch b7dd784a24 Issue #3192553 by mondrake, longwave: Convert assertIdentical(NULL..) to assertNull(...) 2021-01-15 09:24:13 +00:00
Alex Pott 77480bee49
Issue #3187263 by quietone, huzooka: Block configuration translation migrations should be defined in "config_translation", not in "content_translation" 2021-01-12 14:09:33 +00:00
catch 9ac7689b1a Issue #3159788 by mondrake, ravi.shankar, narendra.rajwar27, longwave, Hardik_Patel_12, ankithashetty, sarvjeetsingh, kishor_kolekar: AssertLegacyTrait::assert(No)Text() in functional tests still have a message passed in 2021-01-11 10:24:10 +00:00
Alex Pott 21bd33d6ce
Issue #3186582 by tim.plunkett, raman.b, dead_arm, alexpott, Lendude: Replace the word "master" with "default" in Views 2020-12-22 22:08:17 +00:00
catch cf64091c38 Issue #3132919 by mondrake, pavnish, tvb, jungle, msuthars, ridhimaabrol24, Hardik_Patel_12, mrinalini9, Suresh Prabhu Parkala, longwave, ravi.shankar: Replace assert*() involving equality comparison operators with assert(Not)(Equals|Same) 2020-12-18 12:15:57 +00:00
catch 32f249ae69 Issue #2916376 by rlmumford, Sweetchuck, tim.plunkett: The @ContextDefinition annotation always kills the label and the description 2020-12-06 20:21:38 +00:00
catch 9e8c0511f9 Issue #3184493 by longwave, ravi.shankar, Pooja Ganjage, mondrake: Remove use of concatenated t() in assertions 2020-12-06 20:00:40 +00:00
catch 86c7ed07ab Issue #3183673 by jonathan1055, longwave: Fix 'Drupal.Commenting.DocComment.ShortFullStop' coding standard - part 1 auto-fixes 2020-11-30 18:10:49 +00:00
catch dee581d3fa Issue #3128815 by mondrake, jungle, sja112, Spokje, shobhit_juyal, jameszhang023, nikitagupta, mrinalini9, xjm, longwave, dww: Replace assert*() involving greater/less comparison operators with assert(Greater|Less)Than(OrEqual) 2020-11-24 09:57:55 +00:00
catch e0b3795f58 Issue #3176200 by msuthars, adityasingh, Pooja Ganjage, ravi.shankar, mondrake, longwave: Remove more uses of t() in assertNoText() 2020-11-24 09:37:15 +00:00
catch 96d4338074 Issue #3168375 by mondrake, manishsaharan29497, longwave: Convert calls to drupalPostForm(NULL, ...) to submitForm 2020-11-23 14:35:28 +00:00
catch 783e7eb88e Issue #3145005 by longwave, mondrake, cburschka, raman.b, Lal_, dww, xjm: [November 9, 2020] Remove uses of t() in drupalPostForm() calls 2020-11-16 16:51:39 +00:00
catch 5939e6b5f8 Issue #3145418 by longwave, paulocs, shetpooja04, Spokje, nikitagupta, mondrake, ravi.shankar, sarvjeetsingh, mrinalini9: [November 9, 2020] Remove uses of t() in assertText() calls 2020-11-13 11:06:01 +00:00
catch 652efc720a Issue #3139429 by mondrake, rahulrasgon, mohrerao, siddhant.bhosale, paulocs, longwave, jungle, cburschka, munish.kumar: Replace usages of AssertLegacyTrait::assert(No)FieldByXPath, that is deprecated 2020-11-11 16:24:44 +00:00
catch 7dbdbcb1fa Issue #3166450 by mondrake, longwave, snehalgaikwad: Split assertTrue using && into multiple assertions 2020-11-09 12:07:29 +00:00
Alex Pott 8e416f130c
Issue #2918149 by harpreet16, tim.plunkett, raman.b, anil.gangwal, dalin, grndlvl, nikunjkotecha, kalyansamanta, paulocs, ranjith_kumar_k_u, froboy: "This block is broken or missing..." should only be shown to users that have access to do something about it 2020-10-22 12:34:11 +01:00
catch a14e48a157 Issue #3139406 by mondrake, mohrerao, longwave, rahulrasgon, Suresh Prabhu Parkala, jungle, ravi.shankar, Hardik_Patel_12, Bunty Badgujar, paulocs: Replace usages of AssertLegacyTrait::assert(No)FieldByName, that is deprecated 2020-09-25 09:22:28 +01:00
catch 71813a859c Issue #3139407 by pavnish, mohrerao, mondrake, shaktik, rahulrasgon, durgeshs, shetpooja04, paulocs, ravi.shankar, ankithashetty, anmolgoyal74, munish.kumar, jungle, longwave, daffie: Replace usages of AssertLegacyTrait::assert(No)FieldById, that is deprecated 2020-09-24 10:58:32 +01:00