Commit Graph

272 Commits (0ce88217344e335489f541d1ad2cfc686bc16048)

Author SHA1 Message Date
Alex Pott 169e867159 Issue #2916154 by drpal, dawehner, xjm: JS codestyle: no-multi-assign 2017-10-21 21:46:43 +01:00
xjm 5d01c25222 Issue #2917303 by alexpott: JS codestyle: padded-blocks revisited 2017-10-19 15:14:17 -05:00
webchick 18f322a212 Issue #2764931 by tedbow, tim.plunkett, nod_, drpal, droplet, dawehner, Wim Leers, phenaproxima: Contextual links don't work with 'use-ajax' links 2017-10-16 18:15:27 -04:00
Nathaniel Catchpole 4577185c9b Issue #2572791 by Mile23, andriyun, attiks, RoSk0: Fix 'Drupal.WhiteSpace.OpenBracketSpacing' coding standard 2017-09-22 12:16:23 +01:00
Lee Rowlands 5c31080600
Issue #2821724 by tedbow, tim.plunkett: Create Javascript Tests for Contextual Links 2017-09-21 07:48:05 +10:00
Nathaniel Catchpole 69edc2a364 Issue #2903908 by mfernea, martin107: Fix 'Drupal.Commenting.FunctionComment.ParamCommentIndentation' coding standard 2017-09-05 14:19:41 +01:00
Lee Rowlands 50a541b97f
Issue #2551373 by drpal, danlinn, ruthleopold, Berdir, droplet, Wim Leers, prajaankit: contextual.js and quickedit.js should fail gracefully, with useful error messages, when Twig templates forget to print attributes 2017-08-07 18:27:31 +10:00
Lauri Eskola 279b57d1ad Issue #2892942 by Wim Leers, Chi, tedbow: Contextual links support options but not use them to generate links
(cherry picked from commit 4c8c5e1f0f)
2017-08-01 23:18:02 +03:00
xjm b7fff873d9 Revert "Issue #2892942 by Chi: Contextual links support options but not use them to generate links"
This reverts commit f06b26b760.
2017-07-11 14:17:17 -05:00
Gabor Hojtsy f06b26b760 Issue #2892942 by Chi: Contextual links support options but not use them to generate links 2017-07-11 17:22:02 +02:00
Lauri Eskola 612c1fa68c Issue #2880007 by drpal, nod_, droplet: Auto-fix ESLint errors and warnings 2017-07-06 09:21:40 +03:00
Lauri Eskola 7f27bbaba1 Issue #2704871 by pepegarciag, Mile23, Manuel Garcia, ieguskiza, snehi, gaurav.pahuja, dimaro, rajeshwari10, gargsuchi, pashupathi nath gajawada, penyaskito, xjm, ZeiP, Wim Leers, alexpott: Replace usages of deprecated method drupal_render() 2017-07-03 18:35:13 +03:00
Nathaniel Catchpole 193bab81f7 Issue #2863222 by dmsmidt, tedbow, drpal, tim.plunkett: Contextual Accessibility: Announcement broken after enabling editing mode a second time 2017-06-14 15:05:21 +01:00
Nathaniel Catchpole f3cf9c43b5 Issue #2880560 by alexpott, droplet: Fix comment added to top of .js files by build process 2017-05-23 15:31:29 +01:00
Alex Pott 8287017e03 Issue #2818825 by drpal, nod_, droplet, cilefen: Rename all JS files to *.es6.js and compile them 2017-05-19 23:12:53 +01:00
Alex Pott 0022c5e115 Issue #2869903 by martin107: ContextualController: remove ContainerAwareTrait 2017-04-30 00:04:05 +01:00
Alex Pott 488a6b142a Issue #2650910 by drpal, Anishnirmal, markdorison, Tom Robert, psend, yannickoo, rachel_norfolk, Wim Leers, droplet: Contextual links button is always rendered even when no links are available (with warm client-side cache) 2017-03-28 15:25:09 +01:00
Chris McCafferty 8cc93d064b Issue #2794289 by GoZ, droplet, chiranjeeb2410: add `type=button` to toolbar tab buttons 2017-03-06 20:13:44 -05:00
Nathaniel Catchpole 01f8bd64ed Issue #2854529 by alexpott, xjm, klausi, Chi, Mixologic: Fix Drupal.Scope.MethodScope - all methods should have scopes 2017-03-06 11:25:01 +00:00
xjm 52e3eec616 Issue #2776975 by joelpittet, dawehner, tim.plunkett, xjm, pfrenssen: March 3, 2017: Convert core to array syntax coding standards for Drupal 8.3.x RC phase 2017-03-03 19:20:24 -06:00
xjm e223ebe5f7 Revert "Issue #2704871 by pepegarciag, ieguskiza, snehi, gaurav.pahuja, rajeshwari10, dimaro, gargsuchi, pashupathi nath gajawada, penyaskito, Manuel Garcia, Mile23: Replace usages of deprecated method drupal render()"
This reverts commit ae3ee31751.
2016-12-12 13:03:21 -06:00
xjm ae3ee31751 Issue #2704871 by pepegarciag, ieguskiza, snehi, gaurav.pahuja, rajeshwari10, dimaro, gargsuchi, pashupathi nath gajawada, penyaskito, Manuel Garcia, Mile23: Replace usages of deprecated method drupal render() 2016-12-12 12:49:03 -06:00
Scott Reeves 6316f21245 Issue #2655772 by Anishnirmal, andrewmacpherson, pbuyle, BarisW, mgifford, LaravZ: Remove unneeded role="button" attribute from <button> elements 2016-07-31 11:28:06 -04:00
Alex Pott c2b28643f6 Issue #2745953 by dawehner, tim.plunkett, Wim Leers: AjaxBasePageNegotiator should not require _theme: ajax_base_page to be specified 2016-06-22 16:01:50 +02:00
Alex Pott cf1a9f8a4c Issue #576296 by no_angel, joachim, dagmar, jhodgdon, coderintherye, yoroy, xjm: Remove redundant description for some permissions 2016-06-08 10:41:18 +01:00
Alex Pott 133c212ed9 Issue #2719695 by alexpott, Mile23: Fix 'Drupal.Classes.ClassDeclaration.CloseBraceAfterBody' coding standard 2016-05-08 10:05:38 -05:00
Alex Pott 6098437ef5 Issue #2572793 by attiks, andypost: Fix 'Drupal.WhiteSpace.OperatorSpacing' coding standard 2016-04-29 12:02:20 +01:00
Alex Pott bfde6d3423 Issue #2665992 by alexpott, klausi, heykarthikwithu, xjm, tstoeckler: @file is not required for classes, interfaces and traits 2016-04-09 15:48:39 +01:00
Alex Pott 0db5b13892 Issue #2686207 by Berdir: Convert simpletest kernel tests in modules A-I to phpunit 2016-03-28 19:36:47 +01:00
Nathaniel Catchpole 92161a9b76 Issue #2650246 by swentel, Wim Leers: Only emit Contextual Links data- attributes when actually necessary 2016-03-21 10:48:39 +09:00
Alex Pott 2d76033105 Issue #2588373 by chhavik, Cottser: Remove unused image files from core 2015-12-10 16:18:25 +00:00
Nathaniel Catchpole 9ed49f24dd Issue #2568387 by nod_, TJacksonVA, cosmicdreams, dcrocks: Update JS lib: Modernizr to 3.1 2015-10-16 11:34:24 +01:00
Alex Pott b0e82e5871 Issue #2548195 by nod_, JohnAlbin, madhavvyas, sriharsha.uppuluri: Only use single quotes in JavaScript and update .eslintrc 2015-10-13 23:37:56 +01:00
Nathaniel Catchpole 8b65164c5a Issue #2533800 by alexpott: Remove all unused use statements from core 2015-10-08 20:46:26 +01:00
Alex Pott f3f0555e9c Revert "Issue #2570681 by juanse254, AndreaD, giancarlosotelo, lucastockmann, edurenye: when admin toolbar-oriented vertically a div is over the options"
This reverts commit 2acfed878b.
2015-09-30 15:04:54 +01:00
Alex Pott 2acfed878b Issue #2570681 by juanse254, AndreaD, giancarlosotelo, lucastockmann, edurenye: when admin toolbar-oriented vertically a div is over the options 2015-09-29 12:02:33 +01:00
Alex Pott 7599b055c7 Issue #2493475 by ifrik, walangitan, XaviP, jhodgdon, batigolix: Fix online docs references in Help to conform to our standards 2015-09-26 16:01:27 +02:00
Alex Pott c2563f6b59 Issue #2568743 by bruvers: Administrative toolbar edit button text not visible in Stark 2015-09-26 15:50:28 +02:00
Alex Pott 7a25f513f5 Issue #2560783 by stefan.r, joelpittet, lauriii, Cottser, Sutharsan, kgoel, justAChris, Gábor Hojtsy, dawehner, jhodgdon, effulgentsia, xjm, andypost, googletorp: Replace !placeholder with :placeholder for URLs in hook_help() implementations 2015-09-21 12:38:19 +01:00
Alex Pott afffe84a4f Issue #2569279 by dawehner, izus: Replace remaining !placeholder for Non-URL HTML outputs only in contextual.module 2015-09-18 00:15:05 +01:00
Nathaniel Catchpole 2ea19c7158 Issue #2559969 by alexpott: Make SafeStringInterface extend \JsonSerializable so we don't have to do so much string casting 2015-08-31 13:04:27 +01:00
webchick a7326f8ebe Issue #2514894 by eiriksm: JSDoc contextual module 2015-08-28 23:24:55 -07:00
Nathaniel Catchpole 9bee458886 Issue #2311393 by tim.plunkett: Remove hook_element_info() and all references to it 2015-08-28 22:30:43 +01:00
effulgentsia 764890d629 Issue #2349819 by amateescu, swentel, Leksat, larowlan, dawehner, Gábor Hojtsy, mpdonadio, benjy, jmuzz, yched, jibran, marthinal, dmsmidt: String field type doesn't consider empty string as empty value 2015-08-20 12:15:48 -07:00
Alex Pott fad555c2eb Issue #2545826 by JohnAlbin, nod_: Update.eslintrc to work with eslint 1.0.0 2015-08-07 15:08:23 +01:00
Alex Pott 6e95f0060e Issue #2078803 by Wim Leers, aspilicious, wmortada, Sumit kumar, mrjmd, John Cook: Change contextual links background color to match the styleguide 2015-07-28 16:08:48 +01:00
Alex Pott 4b12bbf0db Issue #2338081 by pwolanin, dawehner, effulgentsia, kgoel, vijaycs85, mpdonadio, chx, brandon.holtsclaw, alexpott, Gábor Hojtsy, Fabianx, catch, YesCT, JvE: Local Tasks, Actions, and Contextual links mark strings from derivatives (or alter hooks) as safe and translated 2015-07-24 22:09:33 +01:00
Nathaniel Catchpole d3c33d5821 Issue #2506581 by alexpott, Wim Leers, Fabianx, xjm, joelpittet, Cottser, dawehner: Remove SafeMarkup::set() from Renderer::doRender 2015-07-20 16:15:11 +01:00
webchick 79c2dc4c4d Issue #2494063 by tohesi, trwad, dcmul, droplet, nod_, naveenvalecha: Update Backbone to 1.2.1 2015-07-02 00:09:51 -07:00
Alex Pott 1f53649bfb Issue #1392754 by tss, justAChris, jhodgdon: Comply with new documentation standards for @file for namespaced class files 2015-06-26 21:53:33 +01:00
Alex Pott 68d4f0be10 Issue #2511472 by Wim Leers, Fabianx, dawehner: Refactor all usages of drupal_render()/Renderer::render() that break #2450993 2015-06-24 16:31:20 -05:00
Nathaniel Catchpole 30ca0d1de6 Issue #2481453 by dawehner, pwolanin, rteijeiro, neclimdul, znerol: Implement query parameter based content negotiation as alternative to extensions 2015-06-08 11:11:09 +01:00
xjm 2f903e47ac Issue #2273925 by larowlan, aneek, lauriii, mikey_p, joelpittet, dimaro, Fabianx, xjm, jaredsmith, effulgentsia, lokapujya, iMiksu, chx, YesCT, googletorp, dawehner, Wim Leers, Cottser: Ensure #markup is XSS escaped in Renderer::doRender() 2015-06-07 13:34:39 -05:00
Jennifer Hodgdon c3cb303173 Issue #2493691 by nod_, eiriksm, dawehner: Add JSDoc for core modules JS 2015-06-05 13:17:55 -07:00
Nathaniel Catchpole 5c8a50ed7f Issue #2254865 by Wim Leers, lauriii, borisson_, JeroenT, alexpott, Fabianx: toolbar_pre_render() runs on every page and is responsible for ~15ms/17000 function calls 2015-06-01 17:49:02 +01:00
xjm 088f8b357a Issue #2491155 by mikeburrelljr, Mac_Weber, opdavies: Update drupal.org and kernel.org URLs in core modules (Follow-up to 2489912) 2015-05-24 15:08:46 -05:00
Jennifer Hodgdon 6477492ee6 Issue #2473105 by ifrik, jhodgdon, lostkangaroo, opratr, LinL: Update hook_help texts that link to modules that can be uninstalled 2015-05-20 07:25:07 -07:00
Alex Pott 0b1a9a3d12 Issue #2488940 by plach: Contextual links are broken on multilingual sites 2015-05-18 14:55:26 +01:00
xjm 4f2257113e Issue #2383865 by mgifford, pguillard, rpayanm, alexpott, jhodgdon: Spellchecking Drupal - Javascript 2015-05-12 16:54:27 -07:00
Alex Pott 74802813c8 Issue #2453931 by pjonckiere: ContextualDynamicContextTest follow up 2015-05-03 17:29:54 +01:00
Alex Pott b676df9303 Issue #2031641 by aburrows, lauriii, nlisgo, Pol, redsquid, tuutti, LewisNyman, akalata, agviu, kallehauge, _nolocation, rpayanm, saki007ster, mdrummond, RavindraSingh, brahmjeet789: Change active class to is-active 2015-04-16 16:25:55 +02:00
Alex Pott 22ef398d2b Issue #2154475 by tarekdj, neelam.chaudhary, droplet, nod_, lanchez, Poornima3, jamin_melville: Convert position selectors to be compatible with with jQuery native-API selector 2015-04-15 09:59:36 +02:00
Alex Pott d48d9c9271 Issue #2448605 by martin107, willzyx, tim.plunkett, klausi, dpopdan: Replace usages of drupal_get_destination() with the redirect destination service 2015-04-09 15:56:37 +01:00
Alex Pott f3b8d0714e Issue #2457781 by prateekMehta, stefan.r, AjitS, hussainweb: Use Utility\Html class instead of Utility\String for decodeEntities() function 2015-03-30 10:20:36 +01:00
Alex Pott 28e35f6517 Issue #2414539 by webflo, vijaycs85: Simplify schema definition for sequence 2015-03-09 08:23:40 +00:00
webchick da571c5aa3 Issue #2419943 by martin107: Add inheritdoc to FieldPluginBase extending classes 2015-02-11 14:49:56 -08:00
webchick 5b8809b782 Issue #2421373 by mortendk, Wim Leers: rename *.icons.css files to *.icons.theme.css 2015-02-11 14:43:41 -08:00
Alex Pott 7b5e5a95e9 Issue #2404603 by mpdonadio, dawehner, larowlan, RavindraSingh: Add proper support for Url objects in FieldPluginBase::renderAsLink(), so we can remove EntityInterface::getSystemPath() 2015-02-11 13:49:32 +00:00
webchick 94c7316aff Revert "Issue #1945262 by nod_: Replace custom weights with dependencies in library declarations"
Broke testing UI. Reverted.

This reverts commit dc5ef576fb.
2015-02-06 12:02:46 -08:00
webchick dc5ef576fb Issue #1945262 by nod_: Replace custom weights with dependencies in library declarations 2015-02-06 09:17:06 -08:00
Alex Pott a3efcb6fb3 Issue #2389515 by nod_: Update ESLint rules 2015-01-10 01:36:01 +00:00
Alex Pott fdec77fca1 Issue #2382543 by rpayanm, ianthomas_uk: Remove usage of drupal_html_class() and drupal_clean_css_identifier() 2014-12-12 10:08:12 +01:00
webchick 6ec9c1ff7b Issue #2384165 by tibbsa: Clean-up Contextual module test members — ensure property definition and use of camelCase naming convention 2014-12-01 10:21:45 -08:00
Alex Pott 2fd994921d Issue #2371457 by DuaelFr: Replace inappropriate translatatable string in core/modules/contextual/contextual.module. 2014-11-09 15:38:43 -08:00
Alex Pott 32913b0f12 Issue #2361789 by rpayanm, jamesdixon, javivf: Remove usage of decode_entities(). 2014-11-02 22:19:56 +00:00
Nathaniel Catchpole 6cbb5d9e1e Issue #2350949 by Wim Leers: Add hook_page_attachments(_alter)() and deprecate hook_page_build/alter(). 2014-10-16 13:36:06 +01:00
webchick 816c9c596a Issue #2352857 by thamas, tkoleary: Fixed Improve the display of trigger icon (pencil). 2014-10-13 21:57:36 -07:00
webchick e36f35c193 Revert "Issue #2352857 by thamas: Fixed Improve the display of trigger icon (pencil)."
Needs more discussion.

This reverts commit b983fad158.
2014-10-10 08:33:58 -07:00
webchick b983fad158 Issue #2352857 by thamas: Fixed Improve the display of trigger icon (pencil). 2014-10-09 11:38:58 -07:00
Alex Pott 195d49998a Issue #2347465 by tim.plunkett, dawehner, cilefen: Convert all instances of #type link/links to convert to use routes. 2014-10-09 07:39:37 +01:00
Alex Pott 42ceecab8f Issue #2350301 by mitrpaka: Replace extend of deprecated DrupalUnitTestBase with KernelTestBase in Contextual. 2014-10-08 12:26:17 +01:00
Alex Pott 3b2e57f0c6 Issue #2326409 by Berdir, tim.plunkett: Annotate render element plugins. 2014-10-05 11:31:26 +02:00
Alex Pott 81e675a570 Issue #2341313 by dawehner: Convert all t() calls to $this->t() in views. 2014-09-24 00:05:54 +01:00
webchick a3f0d471a4 Issue #2325477 by tim.plunkett, almaudoh: Convert contextual_element_info() into Element classes. 2014-09-22 22:46:49 -07:00
Alex Pott 52a101bc1d Issue #2328411 by dawehner, geerlingguy, herom: Convert all permissions to yml files and permission callbacks. 2014-09-18 08:41:29 +01:00
Alex Pott 360af27e0e Issue #1664268 by droplet, G-raph, csakiistvan: Drop some browser specific prefixes. 2014-09-11 17:57:14 +01:00
Alex Pott 7ea1cd958e Issue #2221433 by damiankloip, dawehner: Clean up views rendering. Move stuff from template_preprocess_views_view(), into a #pre_render callback. 2014-09-11 17:08:26 +01:00
webchick 777bc650e4 Issue #2327373 by dawehner: Standardize view entity route names. 2014-08-28 23:53:38 -07:00
Alex Pott 0463b81a08 Issue #2322889 by sun: Fixed Various setUp() and tearDown() methods are not protected. 2014-08-18 16:50:50 +01:00
Alex Pott e24723a934 Issue #2091311 by mparker17, minneapolisdan, benjf, er.pushpinderrana, wzoom, jhodgdon, batigolix | ifrik: Update hook_help for Contextual Link module. 2014-08-13 20:50:32 -07:00
Alex Pott cd8986c2d7 Issue #2278567 by kgoel, azinck, dawehner | Crell: Standardize node route names by relationship. 2014-08-12 11:23:01 -07:00
Dries fc5e111aca Issue #2225353 by tim.plunkett: Convert to an object and provide methods like setError(). 2014-07-30 20:50:42 -04:00
Alex Pott b01522995b Issue #2309137 by longwave, sqndr | LewisNyman: Remove quotes from all background-image: url() properties. 2014-07-29 11:01:33 +01:00
Alex Pott f2b6aa7a75 Issue #2291137 by cilefen | webchick: Rename various *links.yml files to improve DX. 2014-07-15 12:29:14 +01:00
webchick 30c2afed20 Issue #697760 by sun: Replace getInfo() in tests with native phpDoc + annotations (following PHPUnit). 2014-07-10 20:50:37 -07:00
Alex Pott 9e4300f7ad Issue #2298039 by lauriii, LewisNyman: Remove all PNG fallbacks for SVG. 2014-07-08 19:27:08 +01:00
webchick 9c16305b36 Issue #2212283 by nod_: Auto-format JS files. 2014-07-02 11:48:06 -07:00
webchick 94e0188a10 Issue #2294129 by xjm, tim.plunkett: Switch hook_help() to use RouteMatch instead of Request. 2014-06-29 20:33:08 -07:00
webchick d0d3e53361 Issue #2247991 by xjm, typhonius, donquixote: [May 27] Move all module code to PSR-4. 2014-05-27 19:43:20 -07:00
Alex Pott 59fee1922b Issue #2264241 by _nod: Fix ESLint errors and fix js bugs. 2014-05-24 14:59:54 +01:00