Commit Graph

683 Commits (096309b327b0cf9e8637aadac494860774dc7549)

Author SHA1 Message Date
Dries Buytaert 3f052180dc - Patch #66264 by boombatower: comment approval displayed on node view of comment. Comes with tests and everything. 2008-06-03 16:30:20 +00:00
Dries Buytaert 8cc4aaeeae - Patch #258171 by Senpai: code cleanup. 2008-05-14 13:12:41 +00:00
Dries Buytaert 11aeff6016 - Patch #145242 by douggreen et al: refactor node_rank to modules can add scoring factors. 2008-05-14 11:10:54 +00:00
Dries Buytaert 2e18cb8924 - Patch #221964 by chx, dopry, webernet, moshe, webchick, justinrandall, flobruit
et al.  Can you say 'registry'?  Drupal now maintains an internal registry of
  all functions or classes in the system, allowing it to lazy-load code files as
  needed (reducing the amount of code that must be parsed on each request). The
  list of included files is cached per menu callback for subsequent loading by
  the menu router. This way, a given page request will have all the code it needs
  but little else, minimizing time spent parsing unneeded code.
2008-05-06 12:18:54 +00:00
Dries Buytaert 159bb6dd08 - Rollback. 2008-04-25 18:34:05 +00:00
Dries Buytaert d7f3c18d17 - Patch #250729 by R.Muilwijk: performance improvement. 2008-04-25 17:59:36 +00:00
Dries Buytaert 21576021bf - Patch #249546 by pwolanin: rip menu access inheritance -- was already committed to D6. 2008-04-23 20:01:56 +00:00
Dries Buytaert 46546ef478 - Patch #175841 by catch et al: remove comment controls for users. Yowza. 2008-04-16 11:26:29 +00:00
Dries Buytaert 56d2664a90 - Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators. 2008-04-14 17:48:46 +00:00
Dries Buytaert 79b016d915 - Patch #216072 by recidive, David Rothstein, ptalindstrom et al: switched from numeric block IDs to string IDs.
The short explanation is that Drupal uses a lot of numeric deltas in the block system; blocks are identified by the 'module' and the 'delta'. In early Drupal, delta was numeric, but somewhere along the line it was changed to be possibly a string. In modern Drupal, block overrides are easily done via block-MODULE-DELTA.tpl.php.  The primary motivation to switch to string IDs everywhere is to make these deltas friendlier to themers:

    block-user-0.tpl.php --> block-user-navigation.tpl.php
    block-user-1.tpl.php --> block-user-login.tpl.php

  You get the picture.
2008-04-10 10:28:23 +00:00
Dries Buytaert 23602afbe1 - Patch #195072 by webchick and coltrane: make _comment_load() a public API function by renaming it to comment_load(). 2008-04-10 10:13:57 +00:00
Dries Buytaert 91824358be - Patch #216504 by webchick et al: added missing table alias in comment_render function. 2008-04-10 01:45:38 +00:00
Dries Buytaert 1dfd1717c1 - Patch #240387 by matt2000 et al: move 'content types' to 'site building' per the UMN usability study results. 2008-04-06 18:50:12 +00:00
Dries Buytaert 6030a5b2e4 - Patch #81931 by keith.smith: improved wording of help text. 2008-02-23 08:02:48 +00:00
Dries Buytaert 657935c263 - Patch #81931 by webchick et al: made the recent comments block configurable. Somme minor changes by me. 2008-02-21 19:38:07 +00:00
Dries Buytaert 584f3e886a - Patch #30984 by webchick, keith.smith, kkaefer, Crell et al: provide descriptions for permissions on the permission administration page. 2008-02-20 13:46:43 +00:00
Dries Buytaert b8a1eab1fb - Patch #210131 by dvessel, catch, John, et al: updated jQuery library. 2008-02-06 19:38:28 +00:00
Gábor Hojtsy 85cae0d01a #204411 by chx, slightly modified: heal a possible MySQL import error when the anonymous user becomes broken 2008-01-25 16:19:13 +00:00
Gábor Hojtsy c5aa55b38e #204705 by pwolanin: abort user_save on SQL errors, to avoid data corruption 2008-01-10 15:03:53 +00:00
Gábor Hojtsy b78a990270 #207569 by ScoutBaker (minor code style): clean up @see usage in phpdoc blocks 2008-01-08 10:35:43 +00:00
Gábor Hojtsy 258b576020 #199809 by theborg: comment templates were not checking status properly (fix notice, allows themes to theme in-preview comments differently) 2008-01-04 19:24:24 +00:00
Gábor Hojtsy a555202276 #195161 follow up by keith.smith: fix typo in code comment 2008-01-04 15:11:59 +00:00
Gábor Hojtsy 9bc7c07cb7 #195161 by mcarbone with some modifications: only show 'login to post comments' if logging in actually lets you post comments 2008-01-04 11:34:19 +00:00
Dries Buytaert a88c178b91 - Patch #204221 by webernet: code style fixes. 2007-12-28 12:02:52 +00:00
Gábor Hojtsy 1d4fc1b1af #202473 by keith.smith: pre-RC1 spell checking on hopefully final text 2007-12-19 21:40:05 +00:00
Gábor Hojtsy fcbd175337 #189878 by O Govinda, keith.smith: comment module help updates, removing help on features which are not there, and adding help on Drupal 6's new per content type comment settings 2007-12-19 19:17:20 +00:00
Gábor Hojtsy b7a2becd15 #197314 by vitezslav.smid (as GHOP 39): improve/add/update phpdoc in aggregator, comment and system modules 2007-12-16 21:01:45 +00:00
Gábor Hojtsy b6532a4fdb #200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed 2007-12-14 18:08:50 +00:00
Gábor Hojtsy c6d841c096 #197297 by DanW (as GHOP 17), and keith.smith: clean up lots of help texts, update to drag and drop functionality, drupal.module removal, etc 2007-12-13 09:34:40 +00:00
Gábor Hojtsy 5622bce2d5 #198579 by webernet and hswong3i: a huge set of coding style fixes, including:
- whitespaces at end of lines
 - indentation
 - control structure usage
 - whitespace in empty lines
 - phpdoc comment formatting
2007-12-08 14:06:23 +00:00
Gábor Hojtsy d83289f857 #196667 (GHOP 45) by fberci: add '@ingroup themeable' to all themeable functions 2007-12-06 09:58:34 +00:00
Gábor Hojtsy 259e2f5c7e #195678 by catch: standardise on Save and Preview button terminology (for comments) and button placement for comments and nodes, so Save is always the leftmost button, and there is no guessing to find it 2007-11-29 11:54:37 +00:00
Gábor Hojtsy c856eac135 #191104 by keith.smith: (usability) change occurances of node to 'post' and 'content' as appropriate 2007-11-12 19:06:33 +00:00
Dries Buytaert beb7cfa80e - Patch #190483 by webernet et al: tiny code cleanup. 2007-11-09 07:46:10 +00:00
Gábor Hojtsy e9f7072edd #186749 by Rob Loach and myself: (regression) only override comment submitter name with anonymous name, if it was not provided already 2007-11-05 14:25:58 +00:00
Gábor Hojtsy d1c46eadeb #187391 by jrbeeman, catch: redirect user to proper node comment page after submitting a new comment 2007-11-04 16:11:33 +00:00
Gábor Hojtsy 510bb1a42f #93425 by bjaspan: remove pre-Drupal 4.6 era destination handling cruft carried over in comment module 2007-11-04 15:15:47 +00:00
Dries Buytaert b99aab8381 - Patch #163499 by Crell et al: split up comment module. 2007-10-31 17:50:47 +00:00
Gábor Hojtsy b036bef620 #185867 by hunmonk: (usability) add node title to comment overview page for easier identification 2007-10-25 10:28:05 +00:00
Gábor Hojtsy 4e187261ab #177497 by chx and Desbeers: revive Drupal 5's menu_set_location() functionality by introducing menu_set_item() (for consistency in function naming), thus fixing a regression in the current development code. Also fixing some misuse of menu_set_location() by using drupal_set_breadcrumb() instead. 2007-10-25 08:24:43 +00:00
Gábor Hojtsy b94f2716cf #184867 by deekayen, catch and keith.smith: fix some spelling errors in our source code and messages printed 2007-10-21 18:59:02 +00:00
Gábor Hojtsy b64adf07c8 #182645 by scor: clean up concatenations to be in line with core coding standards 2007-10-19 10:19:03 +00:00
Gábor Hojtsy 6417a6ade4 #55277 by catch and JirkaRybka: when flat comment view is used, order comments by cid (ie. original submission order) instead of timestamp (ie. last editing time order) to avoid comments jumping around when being edited 2007-10-16 14:22:00 +00:00
Gábor Hojtsy 0a61aff251 #183390 by hunmonk: forms should use form_state['redirect'] for redirection, not drupal_goto() - fix this in comment_admin_overview_submit() 2007-10-15 15:57:15 +00:00
Dries Buytaert b274bf87f3 - Patch #182950: fieldset massaging for usability. 2007-10-12 14:10:18 +00:00
Gábor Hojtsy 09e2701892 #181088 by fajerstarter, catch and JirkaRybka: rename 'access control' to 'permissions' for usability reasons 2007-10-12 10:41:48 +00:00
Gábor Hojtsy 1a2bf588e6 #63990 by several people: fix comment submission on nodes where a form is displayed 2007-10-08 14:22:31 +00:00
Dries Buytaert ca8e9a1e18 - Patch #180432 by hunmonk, sun, et al: make comment settings per node type. This is a new feature that slipped in because it is required for the project module on drupal.org. 2007-10-07 19:25:57 +00:00
Gábor Hojtsy 071d4b010e #180559 by hunmonk: do not try to display the comment addition form at th end of comments, if we are already on the page, so it is displayed anyway 2007-10-03 17:59:50 +00:00
Gábor Hojtsy b03af772d7 #174233 by webernet: fix notices when editing comments and also fix a moderation bug along the way 2007-09-28 17:15:04 +00:00
Gábor Hojtsy cd517f16e9 #177927 by chx: use path=/ in PHP comment settings cookie creation, so cookies set around the site are available in other 'directories' 2007-09-25 14:58:43 +00:00
Gábor Hojtsy ac7637bc9b #172773 by numerous contributors: Make the actions interface usable by mere mortals (including rename of actions.module to trigger, but keeping the actions themselfs).
Complete previous history of actions module:
 - #148410 by jvandyk: added rewrite of the actions module!
 - #155986 by Uwe: fixed typos.
 - #155828 by Eaton, pwolanin and jvandyk: let actions live even if actions.module is not turned on
2007-09-11 14:50:05 +00:00
Gábor Hojtsy 67e5859a7f #172376 by ChrisKennedy: fix 8 E_ALL issues in comment module and fix approval queue 2007-09-06 12:21:39 +00:00
Dries Buytaert ab1715750a - Patch #172961 by webernet: code style cleanup. 2007-09-05 08:42:02 +00:00
Dries Buytaert 2db2c039fb - Patch #172950 by webernet: code style fixes. 2007-09-04 21:10:45 +00:00
Gábor Hojtsy e310d9e4a4 #6162 by various people: actually point new anchors to the page the first new comment is displayed (in a multipage comment view) 2007-09-02 14:56:18 +00:00
Dries Buytaert 00181ecb39 - Removing whitespace. 2007-08-30 19:54:22 +00:00
Gábor Hojtsy 4e0071fb8a #111127 rollback by chx, slightly extended: roll back node_load cache, it needs more thought and discussion, so postponed until at least Drupal 7 2007-08-30 15:31:46 +00:00
Gábor Hojtsy d8b17c9f19 #156475 by Christoph C. Cemper and greggles: actually call the publish op on hook_comment when a comment is first (automatically) published 2007-08-29 17:01:33 +00:00
Dries Buytaert 5e73b66f3a - Patch #168028 by dvessler, merlinofchaos, pwolanin et al: both theme functions and templates may need include files. Flush your caches. 2007-08-26 07:46:11 +00:00
Gábor Hojtsy 801756e7e6 #111127 by chx: cache node_load(), so heavy operations loading data from external sources and only invoked once (note that you should do everything dynamic in the view op, not the load op) 2007-08-25 09:25:49 +00:00
Dries Buytaert c17499b6fe - Patch #163191 by hswong3i: removed db_num_rows() for compatibility with Oracle and DB2. Also a performance improvement. (Correct version this time.) 2007-08-12 16:12:00 +00:00
Dries Buytaert b134b023e1 - Patch #163191 by hswong3i: removed db_num_rows() for compatibility with Oracle and DB2. Also a performance improvement. 2007-08-12 15:55:36 +00:00
Dries Buytaert a5fcb369fb - Patch #166205 by hswong3i: improved database compatibility of db_result(). Makes it work with DB2, Oracle, etc. 2007-08-11 14:14:46 +00:00
Dries Buytaert d746d35a8f - Patch #163073 by Robert Douglas: removing dead code. 2007-07-30 21:27:34 +00:00
Gábor Hojtsy f180790bb7 #161979 noticed by bboyjay, patch by myself: kill noticedisplayed when no comments were selected for the mass operation 2007-07-25 14:57:58 +00:00
Dries Buytaert 7d0cf742f7 - Patch #160589 by dvessel: tpl-ify the comment module's theme functions. 2007-07-20 08:51:13 +00:00
Dries Buytaert 0ddff5ee26 - Patch #160491 by dvessel: fixed E_NOTICE warnings. 2007-07-20 08:39:00 +00:00
Dries Buytaert a771c6c45a - Patch #57106 by Steven et al: future timestamps break search indexing. 2007-07-15 10:05:18 +00:00
Gábor Hojtsy 51b789c0d3 #156778 by asimmonds: revert node and comment deletions to the pre-deletion API state 2007-07-13 20:04:47 +00:00
Dries Buytaert 4ff46202cb - Patch #157773 by pwolanin: remove node/%/% from comment_menu. 2007-07-09 17:05:49 +00:00
Gábor Hojtsy 806d0a3dee #156910 by asimmonds: fix code indentation problems introduced with new code in this development cycle; only whitespace changes 2007-07-05 08:48:58 +00:00
Gábor Hojtsy 1b503eaac9 #128165 by joshk and webchick: missing db_rewrite_sql() calls in comment queries 2007-07-04 22:24:40 +00:00
Dries Buytaert ee701b3336 - Patch #155986 by Uwe: fixed typos. 2007-07-02 14:41:37 +00:00
Gábor Hojtsy 3409019929 #146386 by kbahey: refactor 'submitted by user - date' themeing and make it more verbose to translate 2007-07-01 23:15:41 +00:00
Dries Buytaert e59852d336 - Rollback of patch #147723: delete API. Talked to Steven and Gabor and we
unanimously agreed to rollback the deletion API.  We all support the
  features this patch added, yet not its actual design and implementation.
  After some talk, we decided that it would be better for Drupal -- in the
  long term -- not to go with a solution that isn't 100%. We also recognize
  that in the short term, this patch would have been useful addition. So
  let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
Gábor Hojtsy 9e6ef53c2c #154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array 2007-06-30 19:46:58 +00:00
Dries Buytaert 2348e7de6f - Patch #148410 by jvandyk: added rewrite of the actions module!
This is a very important patch, but one that is merely an enabler.
  Hopefully we'll see more people submitting "action patches" in the
  near future.

  Thanks for the hard work and persistence, John.  *If* you decide
  to update the Drupal Pro Development book to Drupal 6, make sure
  to add a chapter on actions. ;)
2007-06-29 18:06:51 +00:00
Steven Wittens 7093495f7c #154046: Optimize confirm_form syntax for common usage (and fix some $form_state bugs). 2007-06-24 10:09:53 +00:00
Steven Wittens 028c8e6050 #148678: Fix notices/warnings on invalid paths like 'node/zzz'. (chx/pwolanin/webernet) 2007-06-24 00:38:40 +00:00
Steven Wittens 38a1300df2 #147723: Deletion API (by hunmonk). Woop woop. 2007-06-22 05:44:21 +00:00
Dries Buytaert 0d5e968823 - Patch #82526 by Moshe: simplified APIs -- use form_alter now. 2007-06-15 07:10:47 +00:00
Dries Buytaert 42667a6328 - Patch #142829 by webchick and gurpartap singh: pave the path to allow comment-.tpl.php. 2007-06-11 14:56:40 +00:00
Dries Buytaert 27388f6655 - Patch #149176 by chx, David et al: getting rid of the sequences table, using db_last_insert_id() instead of db_next_id(). 2007-06-05 12:13:23 +00:00
Dries Buytaert 2a3744c572 - Patch #149339 by Ted: removed unnecessary heavy query. 2007-06-05 09:22:22 +00:00
Dries Buytaert e629deb94d - Patch #146667 by Jeff Eaton: form API fixes. 2007-06-04 15:56:34 +00:00
Dries Buytaert 1fe90cba4f - Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments 2007-06-04 07:22:23 +00:00
Dries Buytaert 556ef56c52 - Patch #147417 by robertDouglas: only save cookie for anonymous users. 2007-05-29 06:27:37 +00:00
Dries Buytaert 96926ca047 - Patch #146470 by Eaton et al: standardize form API3 hook parameter order. 2007-05-28 06:08:47 +00:00
Dries Buytaert 4a6f5869e5 - Patch #142773 by kbahey: made Drupal work correctly when behind a reverse proxy. 2007-05-25 15:04:42 +00:00
Dries Buytaert b86d106e0e - Patch #141131 by mfer: fixed UTF-8 problem. 2007-05-20 07:30:03 +00:00
Dries Buytaert d1e28d4273 - Patch #141131 by mfer: remember anonyous comment posters. 2007-05-17 20:57:19 +00:00
Dries Buytaert ac65ff9074 - Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :) 2007-05-14 13:43:38 +00:00
Dries Buytaert 7d4f2836ba - Patch #128082 by Goba et al: Allow localization of built-in menu items. 2007-04-30 17:03:29 +00:00
Dries Buytaert 29055d34d6 - Patch #137236 by merlinofchaos: provide a way to secure the theme variables system. 2007-04-27 07:42:54 +00:00
Gábor Hojtsy 359ace36e6 #76588 patch by alienbrain: some localization-unfriendly watchdog() calls 2007-04-24 18:23:48 +00:00
Dries Buytaert e675979091 - Patch #134493 by douggreen: getting the Drupal coding standards right in core. Woot. Woot. 2007-04-13 08:56:59 +00:00
Dries Buytaert b9b015ff19 - Patch #130366 by webchick and Steven: make signatures pretty. 2007-04-09 13:41:10 +00:00
Dries Buytaert 5bbbf10ba8 - Patch #130987 by merlinofchaos: added theme registry for easier themability. 2007-04-06 13:27:23 +00:00
Steven Wittens f3cd2da113 #130991: Custom menu items, part 1 2007-04-06 04:39:51 +00:00