Commit Graph

297 Commits (061433ad6dc2af3a2be73d3c01452e7136dabad2)

Author SHA1 Message Date
Dries Buytaert f83368fdf5 - Patch #92630 by RobRoy: simplify adding new blocks. 2007-01-23 16:44:58 +00:00
Dries Buytaert ca7e9c8c25 - Patch #107447 by webchick: code style fixes. 2007-01-11 08:54:44 +00:00
Dries Buytaert 28f907c46a - Patch #103717 by profix88: unable to edit blocks for administration theme when it is not enabled. 2006-12-18 21:49:39 +00:00
Steven Wittens 293b12cc21 #102604: Document BLOCK_REGION_NONE constant 2006-12-11 23:00:09 +00:00
Steven Wittens b86f45b1e6 #100516: CSS preprocessor to cache and compress all .css files. Benchmarks show up to 40% faster page loads. 2006-12-10 09:54:35 +00:00
Dries Buytaert e90e2f2aa2 - Patch #101196 by webchick and matt: corrected information in block.module help. 2006-12-08 16:23:45 +00:00
Steven Wittens 0ea4e1c5f6 #100563: Conditional loading of (some) module.css files 2006-12-01 22:47:53 +00:00
Dries Buytaert d172bad559 - Patch #98390 by Heine: correcting the help text. 2006-11-28 11:12:38 +00:00
Neil Drumm 3ee7ed6a66 #98078 by Heine. Fix double escaping on admin/build/blocks. 2006-11-27 01:26:31 +00:00
Neil Drumm b5bf8a8f47 #97824 by Gurpartap. Move enclosing elements outside of their t(). 2006-11-26 02:20:01 +00:00
Neil Drumm 599fe08929 #98384 by RobRoy. Add a space between two sentences. 2006-11-25 08:46:31 +00:00
Dries Buytaert 827f064deb - Patch # #98366 by webchick and ac: simplified strings for translators. 2006-11-24 10:18:24 +00:00
Dries Buytaert b004f328ee - Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard. 2006-11-21 20:14:19 +00:00
Dries Buytaert 01191f7230 - Patch #63267 by profix et al: trim the content of the 'pages' setting so it can be evaluated properly. 2006-11-08 19:49:13 +00:00
Dries Buytaert 42530dc6e3 - Patch #91906 by kkaefer and RobRoy: usability improvement to the block administration interface. 2006-11-08 19:27:59 +00:00
Dries Buytaert 9321ee109d - Patch #93536 by Gabor: eliminate remaining bluemarine traces from core code. 2006-11-08 19:24:11 +00:00
Neil Drumm 0accf8fe1e #90508 by Heine and the security team. Every form gets a token. 2006-10-31 08:06:18 +00:00
Steven Wittens 36d44fbfb0 #84146: Use 'Sentence capitalization' for menu items, page titles, form items, etc 2006-10-22 08:28:47 +00:00
Dries Buytaert 8a478d5068 - Patch #87057 by chx and profix898: fixed problem with not being able to configure blocks per theme. 2006-10-08 06:34:12 +00:00
Neil Drumm 5ba0c5969d #42514 by wtanaka and dopry. More thoroughly delete custom blocks. 2006-09-05 02:53:01 +00:00
Neil Drumm 208090eeb0 #82336 by jvandyk. Set the default input format if we don't have one. 2006-09-05 02:36:02 +00:00
Dries Buytaert c64db1da29 - Patch #80952 by earl, webchick, neclimdul et al: .info files 2006-08-31 20:22:37 +00:00
Neil Drumm 4c5b53040a #68187 by Zen. Blovk visibity by path checks both aliased and non-aliased paths. 2006-08-31 08:52:11 +00:00
Dries Buytaert f2f3416549 - Patch #80934 by timnc: more t() fixes. 2006-08-27 12:43:18 +00:00
Neil Drumm 9f641766a4 #80352 by Zacker. Manually created blocks now appear in block listing. 2006-08-25 23:54:18 +00:00
Neil Drumm 02b3898e8f #80150 by webchick. Cleanup from #76666. 2006-08-23 04:44:36 +00:00
Neil Drumm 28feea3cc5 #80079 by drewish, fix some double placeholdering and other bugs with using t(). 2006-08-23 04:40:57 +00:00
Dries Buytaert 4936f4df12 - Patch #76666 by hunmonk: custom block titles. 2006-08-22 07:43:33 +00:00
Dries Buytaert a2be462995 - Use consistent terminology: placement -> region. 2006-08-21 09:18:46 +00:00
Dries Buytaert c27f564e07 - Patch #77924 by RobRoy: fixed race condition in block administration that might have caused data loss. 2006-08-20 06:49:15 +00:00
Steven Wittens 55eec8f66f #79601: module_exist() -> module_exists() 2006-08-20 05:57:41 +00:00
Dries Buytaert 7de41539df - Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model. 2006-08-18 18:58:47 +00:00
Steven Wittens 81938a3cdc #76802: Introduce placeholder magic into t()
See: http://drupal.org/node/64279#t-placeholders
2006-08-18 12:17:00 +00:00
Neil Drumm 3cc2b1e3d7 #77183 by m3avrck and timcn, split up drupal.css by module. 2006-08-14 07:14:50 +00:00
Dries Buytaert ce85b7c7f8 - Patch #74326 by Eaton, Royboy, chx, et al: building $node->body with arrays like FAPI for viewing.
Once again, we're paving the path for CCK in core ... :)
2006-08-10 15:42:33 +00:00
Dries Buytaert 729fa6c11b - Patch #77422 by timcn: corrected various paths in the documentation. 2006-08-07 15:04:16 +00:00
Dries Buytaert b138793b68 - Patch #72079 by Earl et al: give Drupal an overall administration page ... :-) 2006-07-31 11:25:55 +00:00
Neil Drumm 451f44c4f0 #71772 by Bart Jansens, fix various php warnings 2006-07-02 20:06:31 +00:00
Dries Buytaert 02fa0d85b2 - Patch #18018 by dww, nedjo, tostinne, luke et al: block visibility by role. 2006-05-26 09:21:10 +00:00
Neil Drumm 134314a327 #62262 by dww, fix block help text. 2006-05-23 02:14:26 +00:00
Neil Drumm 9cff02e91b #61802 by Zen, Double spaced sentences clean up 2006-05-07 00:08:36 +00:00
Gerhard Killesreiter 7c941aa5dc #60563, missing block name in delete dialoge, patch by Steve McKenzie 2006-04-26 21:53:24 +00:00
Dries Buytaert d071f99172 - Removing trailing whitespace. 2006-04-17 20:48:26 +00:00
Steven Wittens 21585f66a5 #56813: Simplify admin/block code, and fix sorting of blocks in the listing 2006-04-04 23:32:40 +00:00
Dries Buytaert a9ff6cd372 - Patch #52381 by Zen:
* Converts the block administration page to the fapi model.
    * Removes some 'type=markup' elements.
    * Adds a form_render($form['form_id']); in the theme function. Adding a form_render($form) just outputs an unthemed form. I suspect this is because of the heavy nesting of form elements and the rather dodgy array declaration, but I'm unsure.
    * Documentation/language fixes.
2006-03-04 17:54:58 +00:00
Dries Buytaert 3603fe1bd8 - Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.) 2006-02-21 18:46:54 +00:00
Dries Buytaert 583d5a4ee9 - Patch #48622 by adrian: remove drupal_goto from _submit functions. 2006-02-10 05:25:57 +00:00
Dries Buytaert 15ff8c8e32 - Patch #46827 by wulff: fixed incorrect links. 2006-01-29 07:50:45 +00:00
Dries Buytaert e54db453e0 - Patch #36029 by asimmonds/dopry: fixed critical bug in block administration. 2006-01-26 09:06:23 +00:00
Dries Buytaert 2fa3490ebf - Patch #46106 by markus: usability improvement: moved the block description textfield up. 2006-01-24 08:38:29 +00:00
Dries Buytaert 8c02d4ec93 - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:

# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
  $form[$key]['#weight'] = $count/1000;
}

The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).

Consider the following pseudo example:

$form['game_title'] = array(
    '#type' => 'textfield',
    ...
    );
$form['game_description'] = array(
    '#type' => 'textarea',
    ...
    );
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;

Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).

The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
Dries Buytaert e84a98a22b - Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API. 2006-01-19 08:54:41 +00:00
Dries Buytaert 47ae354ef5 - Patch #44163 by m3avrck: fixed typo in permission and fixed incorrect description. 2006-01-12 10:01:15 +00:00
Steven Wittens 1b66966a4b - #43495: Separate permission for PHP-based block visibility 2006-01-08 03:33:31 +00:00
Dries Buytaert 6c20d333d2 - Patch #35667 by Crell: bug fix: on ?q=admin/block style.css was imported twice. 2006-01-06 07:25:44 +00:00
Dries Buytaert 764f1177ef - Patch #40631 by Chris Johnson: is_array() slower than isset() or empty(). 2005-12-14 20:10:45 +00:00
Dries Buytaert 28fdb3975e - Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick. 2005-12-05 09:11:33 +00:00
Dries Buytaert 26bd449860 - Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'. 2005-12-02 15:21:01 +00:00
Dries Buytaert 8b02851fee - Patch #37714 by asimmonds: fixed saving of blocks. 2005-11-16 22:07:48 +00:00
Dries Buytaert c8f6a2421b - Patch #35524 by asimmonds / drewish: converted the custom block forms code to the forms API's execute model. 2005-11-13 08:26:01 +00:00
Dries Buytaert aeed4cd8e4 - Patch #35644 by webchick: forms API simplificiations. 2005-11-12 11:26:16 +00:00
Dries Buytaert 7bd728ef4a - Patch #36029 by asimmonds: fixed typo that prevents 'admin - block - configure' from working. 2005-11-03 15:39:37 +00:00
Dries Buytaert a8b218827a - Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! / 2005-11-01 10:17:34 +00:00
Dries Buytaert f6764cfbd8 - Patch #30930 by m3avrck/deekayen: cured PHP5 warnings. 2005-10-22 15:14:46 +00:00
Dries Buytaert 75fe6b6c0a - Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes. 2005-10-11 19:44:35 +00:00
Dries Buytaert a1ae4da70b - Removing tabs and trailing whitespaces. 2005-10-07 06:51:43 +00:00
Dries Buytaert 7e1527ee61 - Patch #29465: new form API by Adrian et al.
TODO:
  + The contact.module was broken; a new patch for contact.module is needed.
  + Documentation is needed.
  + The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
Dries Buytaert da74bce9bc - Patch #30801 by Allie Micka, m3avrck, 1uv4t4r et al: fixed block problems. 2005-09-14 21:37:11 +00:00
Dries Buytaert 6ea4bc6caa - Patch #30801 by Allie Micka and m3avrck: performance improvements: improved the database scheme and queries of the block.module. 2005-09-12 18:26:59 +00:00
Dries Buytaert 7b8a409675 - Patch #29385 by chx: no ?> add end of files. 2005-08-25 21:14:17 +00:00
Dries Buytaert 26fa7c730f - Patch #16216 by nedjo: multiple block regions! 2005-08-16 18:06:18 +00:00
Dries Buytaert 273d7f59b6 - Patch #27713 by tostinni: fixed two problems on the block add page:
+ description field isn't marked as requiered
   +when the field isn't unique, an error is displayed, but the wrong text field is set as erronous.
2005-08-07 15:30:03 +00:00
Steven Wittens e4096e1418 - #27551: Rename check_output() to check_markup(). Needs contrib updates! 2005-07-29 21:06:33 +00:00
Dries Buytaert 7ab84f9fcf - Patch #26217 by HellRaider: fixed problem <front> setting in presence of slashes. 2005-07-20 11:44:40 +00:00
Dries Buytaert 8e0b516022 - Patch #26233 by Goba: fixed problem with block regions being buggy. 2005-07-03 15:27:52 +00:00
Dries Buytaert 2c10ff4b5f - Fixed problems with filter formats and problem with XML-RPC server. 2005-06-29 19:53:14 +00:00
Dries Buytaert 58aee8cdad - Patch #25603 by Stefan: made the sizes of forms consistent.
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
Dries Buytaert 2abaae6baf - Patch #22192 by tostinne: fixed invalid XHTML code 2005-05-22 12:48:47 +00:00
Dries Buytaert 2debcfb1ef - Patch #15595 by Stefan and Djun: improved status messages.
TODO: we should write down a couple guidelines for these document them in
        the PHPDoc code of drupal_set_message()!  .
2005-05-05 22:22:46 +00:00
Dries Buytaert cf1224d57b - Patch #21939 by Usability Poobah Chris: added missing </p> tag. 2005-05-05 11:24:21 +00:00
Dries Buytaert 8bfcf2c2e4 - Patch #21445 by Goba: added missing t() function. 2005-05-01 18:37:18 +00:00
Dries Buytaert a93cf89665 - Patch #21353 by chx: implemented PHP-mode for blocks. 2005-04-30 18:16:38 +00:00
Dries Buytaert a76a1e1f3f - Patch 20910 by chx: centralize print theme page. 2005-04-24 16:34:36 +00:00
Dries Buytaert 199aab5ff5 - Improved consistency. 2005-04-18 20:31:50 +00:00
Dries Buytaert f33f9a5fcd - Patch #19965 by Robin Monks: fixed problem with duplicate block titles. 2005-04-12 18:52:47 +00:00
Dries Buytaert c7c33cc174 - Modified patch #19694 by chx: makes sure that block.module deals by default only with regions 0 and 1 as it does now but lets you use block_list with any region you define. This opens many possibilites. You may do a multi region module, with your admin UI using the blocks table as storage and the block_list matcher. Or you may do a sections module using the block matcher without cluttering the current blocks list. 2005-04-04 12:27:05 +00:00
Steven Wittens be14203534 - #18817: Clean up plain-text checking (see drupal-devel!) 2005-03-31 09:25:33 +00:00
Steven Wittens c3f1f7345e - #18939 (Stefan): Always use paragraph tags around page help text. 2005-03-18 07:07:04 +00:00
Dries Buytaert 9a47bc4e7e - Renamed some more 'region's to 'sidebar's 2005-03-06 15:06:19 +00:00
Dries Buytaert 344f33f6af - Patch by Neil: fixed typo. 2005-03-05 23:00:32 +00:00
Dries Buytaert 11dd94bde5 - Patch #18382 by Neil: usability improvement: organized the blocks on the block administration page by region. (I wanted to do that myself!) 2005-03-05 09:09:07 +00:00
Steven Wittens 198ec98f75 #18329: Unify confirmation messages (and make them themable) 2005-03-03 20:51:27 +00:00
Steven Wittens 4a9b9f4aca - Block admin usability: display block title if no description was given. 2005-03-03 05:54:25 +00:00
Steven Wittens d4f1b435a1 - #17868: Remove hardcoded align="center" 2005-02-27 02:48:57 +00:00
Steven Wittens d5db06d5e9 #17216: Restore missing "delete" link for blocks. 2005-02-22 06:16:06 +00:00
Dries Buytaert bb4dff0c92 - Patch #16399 by James: fixed typo in block.module. 2005-01-28 15:24:16 +00:00
Steven Wittens 07acc7920f Typos. 2005-01-27 22:53:35 +00:00
Steven Wittens ffcf5ab71b - Code style 2005-01-27 19:55:22 +00:00
Dries Buytaert 1f91662123 - Patch #16074 by Andre Molnar: add configuration option to show blocks only on pages of certain node type. 2005-01-27 19:41:01 +00:00
Steven Wittens 9d6253374d #15185: Fix front page handling of blocks 2005-01-06 01:17:31 +00:00