Commit Graph

242 Commits (04711e23f19760ac0d712fcd3acab6a37013d7ac)

Author SHA1 Message Date
Alex Pott f0272d5fa6 Issue #2866818 by harsha012, BrightBold, brahmjeet789, joelpittet: Update stylelint rule number-leading-zero to be consistent with Drupal's CSS standards 2018-01-28 08:11:52 +00:00
Nathaniel Catchpole 601593f06e Issue #2935617 by alexpott, chr.fritsch: Move User module's temp stores to core 2018-01-12 10:04:36 +00:00
Alex Pott 7bf384b29c Issue #2866816 by harsha012, BrightBold, cwells, joelpittet, idebr: Update stylelint rule length-zero-no-unit to be consistent with Drupal's CSS standards 2018-01-10 10:55:17 +00:00
Lee Rowlands 128cb26225
Issue #2856950 by dmsmidt, marcvangend, tim.plunkett, andrewmacpherson, Lendude, tameeshb, Berdir, xjm, tedbow, Gábor Hojtsy, Sutharsan: Add a possibility to disable inline form errors for a complete form 2018-01-06 17:33:07 +10:00
Alex Pott c5654de7aa Issue #2866809 by BrightBold: Update stylelint rule declaration-colon-space-after to be consistent with Drupal's CSS standards 2018-01-05 09:45:13 +00:00
webchick f1e33ca3d8 Issue #2925064 by drpal, dawehner, droplet, xjm, webchick, justafish: [1/2] JS codestyle: no-restricted-syntax 2018-01-03 15:27:55 -08:00
effulgentsia 7f00c34194 Issue #2926483 by plach, amateescu, effulgentsia, xjm, Sam152, timmillwood, jibran, larowlan, Gábor Hojtsy: Add API methods for determining whether an entity object is the latest (translation-affecting) revision 2018-01-02 13:23:23 -08:00
Nathaniel Catchpole 522ed00526 Issue #2914938 by timmillwood, RajabNatshah, xjm, Manuel Garcia, amateescu, Wim Leers: Preview of content - Notice: Undefined offset: 0 in _quickedit_entity_is_latest_revision() (line 196 of core/modules/quickedit/quickedit.module) 2017-12-18 14:08:10 +00:00
xjm dcfee314ad Revert "Issue #2925064 by drpal, dawehner, xjm, justafish, droplet: [1/2] JS codestyle: no-restricted-syntax"
This reverts commit b0a4d7e017.
2017-12-01 13:28:53 -06:00
webchick b0a4d7e017 Issue #2925064 by drpal, dawehner, xjm, justafish, droplet: [1/2] JS codestyle: no-restricted-syntax 2017-11-28 15:40:07 -08:00
xjm 5951ea0d1b Issue #2914713 by droplet, drpal, dawehner, nod_: JS codestyle: no-throw-literal 2017-10-25 12:08:30 -05:00
xjm 7fbb5e990e Issue #2916294 by dawehner: JS codestyle: no-useless-escape 2017-10-24 12:07:10 -05:00
xjm 9032c68faa Issue #2916154 by drpal, droplet, dawehner, alexpott, xjm: JS codestyle: no-multi-assign 2017-10-24 07:42:16 -05:00
Alex Pott 27266234c2 Revert "Issue #2916154 by drpal, dawehner, xjm: JS codestyle: no-multi-assign"
This reverts commit 169e867159.
2017-10-21 21:49:45 +01:00
Alex Pott 169e867159 Issue #2916154 by drpal, dawehner, xjm: JS codestyle: no-multi-assign 2017-10-21 21:46:43 +01:00
xjm 7655c87004 Issue #2914718 by droplet, alexpott, nod_, dawehner: JS codestyle: no-empty 2017-10-13 19:10:51 -05:00
Nathaniel Catchpole ee0f806896 Issue #2873696 by nvexler, wengerk, gido, Jo Fitzgerald, xjm: Add @internal to core classes, methods, properties to Form Classes 2017-10-12 16:15:53 +01:00
Alex Pott e113f8fbab Issue #2914723 by droplet, dawehner: JS codestyle: no-mixed-operators 2017-10-12 11:20:47 +01:00
Lauri Eskola 29cd930e59 Issue #2914946 by drpal, dawehner, droplet: JS codestyle: no-var 2017-10-12 10:10:10 +03:00
Alex Pott 844b6d3bf6 Issue #2914716 by droplet: JS codestyle: no-lonely-if 2017-10-11 15:44:48 +01:00
Alex Pott 4d263489bf Issue #2914711 by droplet: JS codestyle: no-useless-concat 2017-10-11 12:08:39 +01:00
Nathaniel Catchpole f659d6ca8e Issue #2901726 by mfernea, gmario, finn.lewis, robertoperuzzo, rachel_norfolk: Fix 'Squiz.Functions.MultiLineFunctionDeclaration' coding standard 2017-10-10 15:43:06 +01:00
Gabor Hojtsy deac2594b1 Issue #2911164 by mfernea, Jo Fitzgerald: Undo accidental commenting of message in MetadataGeneratorTest 2017-10-10 09:45:05 +02:00
Lauri Eskola 4dee1624c7 Issue #2910005 by catch, samuel.mortenson: JavaScript errors thrown when viewing non-latest default revision of entity 2017-09-30 15:52:51 +03:00
Nathaniel Catchpole 2e18fe9373 Issue #2715485 by harsha012, mfernea, malavya, himanshu-dixit, vprocessor, tameeshb, Mile23, RajeevK, Jo Fitzgerald, tiago.urbano, xjm, klausi: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard 2017-09-25 14:14:30 +01:00
xjm cc30270e9a Revert "Revert "Revert "Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard"""
This reverts commit b06757615a.
2017-09-16 14:24:44 -05:00
xjm b06757615a Revert "Revert "Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard""
This reverts commit 964954e1f3.
2017-09-16 12:02:55 -05:00
xjm 964954e1f3 Revert "Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard"
This reverts commit 2df73e2c00.
2017-09-16 12:02:42 -05:00
xjm 2df73e2c00 Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard 2017-09-16 11:19:25 -05:00
Nathaniel Catchpole bf31e8cb98 Issue #2903524 by timmillwood, Sam152, amateescu, yoroy: Don't add quickedit to displays where entities have a forward revision 2017-08-28 11:14:30 +01:00
Lee Rowlands 50a541b97f
Issue #2551373 by drpal, danlinn, ruthleopold, Berdir, droplet, Wim Leers, prajaankit: contextual.js and quickedit.js should fail gracefully, with useful error messages, when Twig templates forget to print attributes 2017-08-07 18:27:31 +10:00
Lauri Eskola 612c1fa68c Issue #2880007 by drpal, nod_, droplet: Auto-fix ESLint errors and warnings 2017-07-06 09:21:40 +03:00
Nathaniel Catchpole f3cf9c43b5 Issue #2880560 by alexpott, droplet: Fix comment added to top of .js files by build process 2017-05-23 15:31:29 +01:00
Alex Pott 8287017e03 Issue #2818825 by drpal, nod_, droplet, cilefen: Rename all JS files to *.es6.js and compile them 2017-05-19 23:12:53 +01:00
Chris McCafferty ef1db63d7b Issue #2878548 by alexpott, droplet, Cottser, idebr, joelpittet, xjm, martin107: Fix CSS whitespace issues 2017-05-19 12:46:41 -04:00
Nathaniel Catchpole 01f8bd64ed Issue #2854529 by alexpott, xjm, klausi, Chi, Mixologic: Fix Drupal.Scope.MethodScope - all methods should have scopes 2017-03-06 11:25:01 +00:00
xjm 9ee87105b9 Issue #2856364 by drpal, Wim Leers: Reposition Quickedit overlay on toolbar orientation change 2017-03-04 14:01:37 -06:00
xjm 52e3eec616 Issue #2776975 by joelpittet, dawehner, tim.plunkett, xjm, pfrenssen: March 3, 2017: Convert core to array syntax coding standards for Drupal 8.3.x RC phase 2017-03-03 19:20:24 -06:00
Nathaniel Catchpole 9bd08a0024 Issue #2825347 by Wim Leers: 'Accept' header still is used for determining response format of error responses, ?_format= has no effect AND serialization module's exception subscriber does not support status code 500 error responses 2017-02-27 15:09:11 +00:00
xjm d85cf06daa Issue #2267621 by tameeshb, Wim Leers, himanshu-dixit, mpdonadio, xjm, Alan Evans, tim.plunkett: Deprecate and rename EditEntityFieldAccessCheck now that the module is named Quick Edit 2017-02-24 15:33:42 +00:00
Alex Pott 1fcd3d5c56 Issue #2808233 by gnuget, dawehner, Wim Leers, tedbow, Chi, dysrama: REST 403 responses don't tell the user *why* access is not granted: requires deep Drupal understanding to figure out 2017-02-09 19:56:28 +00:00
Alex Pott 10210c7731 Issue #2787471 by omitsis, darketaine, thpoul, Wim Leers: Don't append 'js-quickedit-page-title' class when user doesn't have 'access in-place editing' permission 2017-01-14 11:55:45 +00:00
Alex Pott a7b67e7af1 Issue #2721901 by Mile23, anoopjohn: Fix Drupal.Commenting.FunctionComment.MissingParamName 2016-08-29 06:50:59 -05:00
Alex Pott c2b28643f6 Issue #2745953 by dawehner, tim.plunkett, Wim Leers: AjaxBasePageNegotiator should not require _theme: ajax_base_page to be specified 2016-06-22 16:01:50 +02:00
Nathaniel Catchpole bc084e183c Issue #2327941 by Wim Leers, Sonal.Sangale: Simplify in-place editor selection (Was: Refactor PlainTextEditor/WysiwygEditor/Editor in-place editors now that text fields no longer have configurable filteredness) 2016-06-15 11:17:42 +01:00
Nathaniel Catchpole 22c915f33f Issue #2502865 by claudiu.cristea: Remove all remaining usages of the drupal_ajax accept header 2016-06-14 16:25:25 +01:00
Nathaniel Catchpole 899cb5239b Issue #2723591 by marvin_B8: Remove entity_load* usage for entity_test, entity_test* entity types 2016-05-17 10:40:48 +01:00
Alex Pott 0f3964dd14 Issue #2490136 by timmillwood, Manjit.Singh, xjm, webchick, dixon_, Bojhan, googletorp, dawehner, cilefen, jstoller, mikeburrelljr, naveenvalecha, giorgio79, platinum1, Crell, markdorison, skwashd, moshe weitzman, amateescu, jhedstrom, nateswart: Enable revisions by default 2016-05-13 17:22:02 -05:00
Alex Pott 133c212ed9 Issue #2719695 by alexpott, Mile23: Fix 'Drupal.Classes.ClassDeclaration.CloseBraceAfterBody' coding standard 2016-05-08 10:05:38 -05:00
Alex Pott d5d0d6ce87 Issue #2572777 by andypost, alexpott, attiks, andriyun: Fix 'Squiz.Strings.ConcatenationSpacing' coding standard 2016-05-05 12:07:19 +01:00
Alex Pott 1b3ffe2ab8 Issue #2572707 by attiks, alexpott: Fix 'Drupal.Files.EndFileNewline' coding standard 2016-04-27 11:05:37 +01:00
Alex Pott 0018b94fa1 Issue #2456477 by Berdir, dawehner, heddn, pguillard: Convert deprecated \Drupal\simpletest\KernelTestBase tests to KernelTestBaseNG 2016-04-26 14:57:14 +01:00
Alex Pott bfde6d3423 Issue #2665992 by alexpott, klausi, heykarthikwithu, xjm, tstoeckler: @file is not required for classes, interfaces and traits 2016-04-09 15:48:39 +01:00
Scott Reeves fa5efed870 Issue #2528498 by Wim Leers, Jacine, mortendk: Only emit Quick Edit data- attributes when actually necessary 2016-03-04 13:43:24 -05:00
Nathaniel Catchpole 00606660c8 Issue #2672200 by Sweetchuck, gauravjeet: Wrap Drupal with closure variable 2016-02-29 12:25:57 +09:00
Nathaniel Catchpole 1d75784abe Issue #2672604 by saurabh.tripathi.cs: Replace deprecated usage of entity_create('taxonomy_term') and entity_create('taxonomy_vocabulary') with a direct call to Term::create() and Vocabulary::create() 2016-02-24 13:17:21 +09:00
Alex Pott 98d39d1bdb Issue #2669400 by jungle, dimaro, rakesh.gectcr, lluvigne, Mile23: Replace deprecated usages of entity_create('type') with a direct call to <EntityType>::create() 2016-02-20 10:55:26 +05:30
Nathaniel Catchpole 9040dc8002 Issue #2664466 by dawehner, alexpott, kostyashupenko: url_alias table is only used by a core service but it depends on system install 2016-02-17 16:11:37 +09:00
Nathaniel Catchpole e825a16a3c Issue #2503379 by Mac_Weber, DuaelFr, lluvigne, naveenvalecha, jmolivas: Replace deprecated usage of entity_create('filter_format') with a direct call to FilterFormat::create() 2016-02-17 09:42:55 +09:00
Nathaniel Catchpole 8e4fe5c0f9 Issue #2641584 by Mac_Weber, heykarthikwithu, legovaer: Replace deprecated usage of entity_create('field_config') with a direct call to FieldConfig::create() 2016-02-16 20:13:36 +09:00
Nathaniel Catchpole d4e7281f28 Issue #2641586 by Mac_Weber, marvin_B8: Replace deprecated usage of entity_create('field_storage_config') with a direct call to FieldStorageConfig::create() 2016-02-09 08:52:18 +09:00
Alex Pott 2c03b9f0ff Issue #2572789 by attiks, andriyun: Fix 'Drupal.WhiteSpace.Comma' coding standard 2015-12-23 14:28:29 +00:00
Alex Pott b0e82e5871 Issue #2548195 by nod_, JohnAlbin, madhavvyas, sriharsha.uppuluri: Only use single quotes in JavaScript and update .eslintrc 2015-10-13 23:37:56 +01:00
Nathaniel Catchpole 8b65164c5a Issue #2533800 by alexpott: Remove all unused use statements from core 2015-10-08 20:46:26 +01:00
Alex Pott 97823b5a54 Issue #2429191 by claudiu.cristea, amateescu, yched, nlisgo, Berdir, alexpott, klausi, Wim Leers, xjm, catch: Deprecate entity_reference.module and move its functionality to core 2015-10-06 12:02:22 +01:00
Nathaniel Catchpole 72b0180f59 Issue #2454649 by Aki Tendo, dawehner: Cache Optimization and hardening -- [PP-1] Use assert() instead of exceptions in Cache::merge(Tags|Contexts) 2015-10-05 14:12:02 +01:00
webchick e36c84dea0 Issue #2568099 by Wim Leers, mdrummond, mortendk: Follow-up for #2407739: Remove the js-quickedit-main-content class that was added in favor of relying on <main> 2015-10-05 00:11:17 -07:00
effulgentsia 35fa967664 Issue #2559955 by Wim Leers, swentel, mdrummond: Ensure that Quick Edit relies less on the structure of the HTML 2015-10-03 21:51:11 -07:00
webchick 0e4c0f30d4 Issue #2576037 by unqunq, er.manojsharma, sdstyles, martins.kajins, Devaraj johnson, cilefen, Bojhan, Wim Leers: "Sorry" in user-facing errors violates the User Interface Standards 2015-10-02 14:43:24 -07:00
Alex Pott 1844088377 Issue #2554771 by Mile23, Wim Leers: Remove deprecated drupal_process_attached() 2015-10-02 13:03:26 +01:00
Alex Pott 5c0eb9b7a5 Issue #2090983 by plach, Berdir, yched: ContentEntityInterface::getTranslation() should throw an exception when an invalid language is specified 2015-10-02 12:23:54 +01:00
effulgentsia 708ce0a998 Issue #2576533 by alexpott, stefan.r, Wim Leers, dawehner, xjm, effulgentsia, catch: Rename SafeStringInterface to MarkupInterface and move related classes 2015-10-01 16:25:03 -07:00
Alex Pott e686c9d183 Issue #2550225 by swentel, yched, Wim Leers, aspilicious: quickedit_test_entity_view_alter() creates a non compliant field render array 2015-09-22 10:14:42 +02:00
Alex Pott 7a25f513f5 Issue #2560783 by stefan.r, joelpittet, lauriii, Cottser, Sutharsan, kgoel, justAChris, Gábor Hojtsy, dawehner, jhodgdon, effulgentsia, xjm, andypost, googletorp: Replace !placeholder with :placeholder for URLs in hook_help() implementations 2015-09-21 12:38:19 +01:00
Alex Pott 22cd7b8f85 Issue #2407739 by mortendk, davidhernandez, rteijeiro, lduerig, sivaji@knackforge.com: Remove classes from system templates r*.html.twig 2015-09-10 12:17:38 +01:00
Alex Pott 887b1e4c35 Issue #2551105 by Dave Reid: BaseCommand should not be in the quickedit namespace, useful for anything 2015-09-09 14:21:11 +01:00
Alex Pott c5d6d65f56 Issue #2560733 by stefan.r: Remove a few problematic t() calls from tests 2015-09-02 11:12:23 +01:00
Nathaniel Catchpole 2ea19c7158 Issue #2559969 by alexpott: Make SafeStringInterface extend \JsonSerializable so we don't have to do so much string casting 2015-08-31 13:04:27 +01:00
Nathaniel Catchpole 9f0bb4f807 Issue #2551263 by Berdir, nod_: Deleting entity/field models when markup is removed can result in JS error 2015-08-31 12:21:11 +01:00
webchick b6ed6e74cd Issue #2530764 by eiriksm: JSDoc quickedit module 2015-08-28 23:33:28 -07:00
Alex Pott 6c8fe4bdb4 Issue #2214241 by mortendk, mdrummond, lauriii, galooph, ShaunDychko, jjcarrion, b0unty, joelpittet, scor, amitgoyal, aboros, Manuel Garcia, hkirsman, BLadwin, hussainweb, sushilkr, emma.maria, nlisgo, yched, LewisNyman, davidhernandez, mikl, camoa, dman, dodorama: Field default markup - removing the divitis 2015-08-26 09:36:43 +01:00
Alex Pott 46ffe7005b Issue #2552831 by olli: Eslint errors in quickedit/js/editors/formEditor.js 2015-08-19 00:21:38 +01:00
Alex Pott 9435942a3a Issue #2526326 by borisson_, Berdir, Wim Leers, Xano: Update CacheableMetadata & AccessResult to use RefinableCacheableDependency(Interface|Trait) 2015-08-14 17:30:57 +01:00
Alex Pott f3ed9812c8 Issue #2503963 by Wim Leers, dawehner, nlisgo, mlhess, xjm, effulgentsia, JvE: XSS in Quick Edit: entity title is not safely encoded 2015-08-11 10:34:21 +01:00
Alex Pott fad555c2eb Issue #2545826 by JohnAlbin, nod_: Update.eslintrc to work with eslint 1.0.0 2015-08-07 15:08:23 +01:00
Nathaniel Catchpole d3c33d5821 Issue #2506581 by alexpott, Wim Leers, Fabianx, xjm, joelpittet, Cottser, dawehner: Remove SafeMarkup::set() from Renderer::doRender 2015-07-20 16:15:11 +01:00
webchick 79c2dc4c4d Issue #2494063 by tohesi, trwad, dcmul, droplet, nod_, naveenvalecha: Update Backbone to 1.2.1 2015-07-02 00:09:51 -07:00
Alex Pott 1f53649bfb Issue #1392754 by tss, justAChris, jhodgdon: Comply with new documentation standards for @file for namespaced class files 2015-06-26 21:53:33 +01:00
Alex Pott 68d4f0be10 Issue #2511472 by Wim Leers, Fabianx, dawehner: Refactor all usages of drupal_render()/Renderer::render() that break #2450993 2015-06-24 16:31:20 -05:00
Alex Pott 88163fde6d Issue #2505201 by munzirtaha: Quick Edit toolbar's arrow should be reversed in RTL 2015-06-24 16:04:52 -05:00
Nathaniel Catchpole 30ca0d1de6 Issue #2481453 by dawehner, pwolanin, rteijeiro, neclimdul, znerol: Implement query parameter based content negotiation as alternative to extensions 2015-06-08 11:11:09 +01:00
Jennifer Hodgdon 38833e0f83 Issue #2493683 by nod_, dawehner, eiriksm, Wim Leers: JSDoc for JS using Backbone 2015-06-06 08:55:42 -07:00
Alex Pott 068edfc14e Issue #2395831 by dawehner, fago, martin107, cafuego, YesCT, plach, jibran, larowlan, Wim Leers, effulgentsia, klausi: Entity forms skip validation of fields that are not in the EntityFormDisplay 2015-06-05 21:46:55 +01:00
Alex Pott 132564c751 Issue #2494561 by googletorp: double newline in the end of quickedit.module 2015-05-26 15:27:47 +01:00
Nathaniel Catchpole 0c80f49b90 Issue #2475483 by Arla, alexpott, Berdir, jeroen.b: Cannot quickedit an image or date field 2015-05-26 10:39:16 +01:00
xjm ac3b76625c Issue #2383871 by mgifford, rpayanm, a_thakur, maximpodorov, AohRveTPV, jhodgdon: Spellchecking Drupal - PHP 2015-05-24 15:51:18 -05:00
xjm 088f8b357a Issue #2491155 by mikeburrelljr, Mac_Weber, opdavies: Update drupal.org and kernel.org URLs in core modules (Follow-up to 2489912) 2015-05-24 15:08:46 -05:00
Alex Pott 4c49e1e59f Issue #1533366 by nod_, valthebald, Jelle_S, Wim Leers: Simplify and optimize Drupal.ajax() instantiation and implementation 2015-05-20 12:02:57 +01:00
xjm f9b6f97613 Issue #2489912 by mikeburrelljr, opdavies, larowlan: Update Drupal.org URL in core modules 2015-05-18 14:08:10 -07:00
xjm 4f2257113e Issue #2383865 by mgifford, pguillard, rpayanm, alexpott, jhodgdon: Spellchecking Drupal - Javascript 2015-05-12 16:54:27 -07:00