Commit Graph

175 Commits (026c09b6ce8e2f1e25e91d5a432a968e321d080e)

Author SHA1 Message Date
Dries Buytaert e5f2c1ef0e - Usability improvement: avoid showing two login forms on one page. Suggested
by Keith.
2003-06-15 20:24:49 +00:00
Dries Buytaert 8a9a5ba3da - Bugfix: the variable 'user_mail_welcome_approval_subject' was too long.
Modified patch from Al; used 'user_mail_approval_subject' instead of
  'user_mail_welcome_approval_subj'.  Patch #11 by Al.  Fixes bug #1976.
2003-06-15 19:17:43 +00:00
Dries Buytaert c31fe45f2f - Improvement: fixed wrapping in code samples in user module so that admin help doesn't have a huge horizontal scrollbar. Patch #13 by Al. 2003-06-15 19:11:17 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert 3e9aabe058 - Moved some CXX checks to a centralized place; less error-prone. 2003-06-14 07:02:32 +00:00
Dries Buytaert d95499bf03 - Bugfix: small Xtemplate fixes. Patch by Ax. (Slightly modified.)
- Bugfix: block patch fix.  Patch by Gerhard.

- Bugfix: fixed broken URL in ping.  Patch by Gerhard.

  (This should fix the problems shown on http://www.blo.gs/info.php?id=1515.)

- Improvement: added better password generator.  Patch #1 by Al.  Fixes bug
  #1935.

- Improvement: performance improvement to the blog module.  Patch by Marco.
2003-06-13 17:34:18 +00:00
Dries Buytaert 9e813c08a4 - Bugfix: when clean URLs are enabled, the cookie path was not always set correctly when the
user logged using the user block from within a subdirectory.  Patch by Ulf Rompe.
2003-06-11 20:42:31 +00:00
Dries Buytaert 3b8c99d91e - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan.
- Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.

- Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:

  <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />

  IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.

- Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.

- Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.

- Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.

- Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.

- Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.

- Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
2003-06-11 18:16:32 +00:00
Dries Buytaert cf5a17ca0d Patch be Matt Westgate:
- Bugfix: in the user_admin_edit() function, the data array returned from the callback modules was not being merged into the edit array.

- Bugfix: added enctype="multipart/form-data" to the form tag so that we can update things like the avatar image in the admin interface.
2003-06-10 19:00:48 +00:00
Dries Buytaert d4ec431b44 - Bugfix: fixed approval e-mail and tidied up the e-mail handling. Patch #43 by
Al.  Fixes bug #1828.
2003-06-08 10:12:46 +00:00
Dries Buytaert ae45b735d3 - Bugfix: clicking the "Login" button after having created the first user
redirected you to an incorrect page.  Patch by Moshe.
2003-06-07 21:35:45 +00:00
Dries Buytaert 23423b46fb - Check the destrination URL before redirecting. 2003-06-07 15:59:49 +00:00
Dries Buytaert aa38097c07 - Dropped check_input(); use check_query() instead.
- Made the statistics module use referer_uri() for security's sake.
2003-06-06 21:37:11 +00:00
Dries Buytaert 48bf7db71c - Bugfix: removed redundant check_input()s such that quotes are handled
properly.  You couldn't use a username or passwords that had quotes.
2003-06-06 20:52:21 +00:00
Dries Buytaert 3436c02c81 - Bugfix: fixed the login problem due to incorrect use of drupal_goto().
Gerhard's patch was not 100% correct and I found a better alternative.
2003-06-06 17:30:09 +00:00
Dries Buytaert ed528531c7 - CSS improvements: use form functions wrapped in a <div> instead of
hard-coded form elements.  Modified patch by Kristjan.

  I added some CSS to drupal.css to center the text and ordered the
  list of CSS tags alphabetically.
2003-06-03 20:02:33 +00:00
Dries Buytaert c8b646320d - Resized two textfields for UI consistentcy. Patch by Stefan. 2003-06-02 18:09:07 +00:00
Dries Buytaert 5e2ce07616 - Documentation fixes by Kjartan. 2003-05-31 23:05:18 +00:00
Dries Buytaert 1fc8a18c2d - Al's CSS patches. This commit improves the themability of some core
components such as lists, form items, removes an ugly hack from the
  archive module and should fix the poll problem (although it doesn't
  Opera/Konqueror).
2003-05-29 10:18:38 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Kjartan Mannes 8c037610ab - $_SERVER["edit"] -> $_POST["edit"] 2003-05-19 18:59:34 +00:00
Kjartan Mannes 1a2f8acb2c - Patch by Jonathan Chaffer: $_SERVER["op"] -> $_POST["op"] 2003-05-19 18:58:50 +00:00
Dries Buytaert 8bc39e9083 - Undid my changes to user_access(). 2003-05-19 09:07:42 +00:00
Dries Buytaert 8205b62666 - Replaced some PHP_SELF's by request_uri()'s. Patch by Gerhard. 2003-05-18 20:21:35 +00:00
Dries Buytaert 494aa87e37 - Small change that reduces the number of SQL queries when a certain role has
no permissions set.
2003-05-18 09:10:17 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Dries Buytaert c60e3b13fa - Added missing t() function. Patch ba Al. 2003-05-06 06:42:01 +00:00
Dries Buytaert 54459cc01a - Fixed the function prototypes of the newly introduced theme_user_list(),
theme_node_list(), and theme_menu_list().  This will fix the excessive
  gap between lists and avoids generating empty <b></b> constructs.
2003-05-02 20:44:14 +00:00
Dries Buytaert 2d6408dff3 - Committed Adrian's item patch. It would be nice if one or more of the
standard themes could be updated to demonstrate the possibilities.
2003-04-29 20:48:50 +00:00
Dries Buytaert db04650411 - Added support for user registration guidelines. Patch by Al. Feature request #1109. 2003-04-28 21:36:43 +00:00
Dries Buytaert a956de78b9 - Fixed some PHP "notices". 2003-04-21 14:55:03 +00:00
Dries Buytaert 02f437a2f4 - Renamed 'validate_email_address' to 'valid_email_address'.
- Added a 'form_radio' function.
2003-04-13 13:42:51 +00:00
Dries Buytaert cb2d27c78d - Patch by Ax. Fixed some syntax errors:
-    case t("whatever");
    +    case t("whatever"):
2003-04-04 06:17:02 +00:00
Dries Buytaert 4742ba3549 - Fixed some SQL query directives. 2003-03-29 16:30:40 +00:00
Dries Buytaert d1be768b28 - Moved the logic of email validation from user_validate_mail to a new function
in common.inc.  Modified patch from Gerhard.
2003-03-28 10:55:27 +00:00
Dries Buytaert 65b6203700 - Another improvement to the e-mail address validation code. Fixed Debian
bug #185217.  Patch by Gerhard.
2003-03-19 17:34:27 +00:00
Dries Buytaert 31fce3f08c - Fixed glitch in e-mail verification code. Patch by Gerhard. 2003-03-18 19:18:30 +00:00
Dries Buytaert 170b674a09 - All LIMIT queries must go through the pager or through db_query_range().
The syntax for db_query_range() was enhanced so it matches db_query(). So
  you may pass extra arguments of the SQL statement which are checked via
  check_query() and then substituted into the SQL statement. After these
  optional arguments, you always pass $from and $count parameters which
  define your range.  Most often, the $from is 0 and the count is the max
  number of records you want returned.  Patch by Moshe.

- The pager_query() function for PEAR was enhanced so that it adds  proper
  GROUP BY statement counting the number of records to be paged. Patch by
  James Arthur.

- MSSQL database scheme by Moshe.
2003-03-16 07:02:20 +00:00
Dries Buytaert 1f2d2b73dd - Fixed a CSS glitch. Thanks Al.
- Removed extraneous %uri's.
2003-03-14 20:33:53 +00:00
Dries Buytaert 127c6fd465 - Fixed translation bug.
- Fixed broken queries: use 'AND' instead of '&&'.  Reported by Neil.

- Fixed broken URLs in e-mails.  Reported by Stefaan.
2003-03-12 21:31:09 +00:00
Dries Buytaert cd31f11348 - Fixed request 583. Patch by Al. 2003-03-10 21:08:35 +00:00
Kjartan Mannes 1421c878d1 - Moved moderation logic back into node module.
* After having a chat with Dries we have agreed on the logics (or
      more specifically he told me how its supposed to work). The queue
      module is just a method to make moderation public, but its not
      necessarily the only way. This brings the power back.
- Minor interface tweaks (names, case changes, etc).
- Fixed error that would show when you tried to view the profile of a
  blocked user.
2003-03-09 17:19:50 +00:00
Dries Buytaert 738cebbaf2 - Moved some block up to avoid the user module duplicating data. 2003-03-09 15:50:26 +00:00
Dries Buytaert d659fedb38 - Removed the path_uri() function in favor of the $base_url variable and
fixes a handful of bugs introduced by the clean URL patch.
2003-03-07 06:37:30 +00:00
Dries Buytaert 223c224d43 - Grammar fix. Patch by Al. 2003-03-02 20:33:20 +00:00
Dries Buytaert 91dfef65af - Fixed some typos spotted by Al Maw. 2003-02-25 19:52:32 +00:00
Dries Buytaert 277ceae515 - New menu houskeeping. Prototyped by Zbynek.
The following modules need updating:
    * glossary module
    * feed module (Breyten's version)
    * mailhandler module
    * notify module
    * project module
    * smileys module
    * admin module
    * style module
    * taxonomy_dhtml module

  To avoid unexpected problems menu_add() is deprecated (it will print an
  error message when used) and menu() should be used instead.
2003-02-20 22:44:51 +00:00
Dries Buytaert 52314ddc32 - Theme options patch. See mailing list. 2003-02-17 22:33:31 +00:00
Kjartan Mannes a76151351e - Modifying user_validate_mail() to accept more e-mail addresses. 2003-02-15 20:52:28 +00:00