Commit Graph

19 Commits (01018b68304e917836df9bdc051ef34e7da88ef0)

Author SHA1 Message Date
Dries Buytaert a461e3696c * tiny improvements (!= bug fixes) 2000-11-14 09:03:44 +00:00
Dries Buytaert 9559f61fca Another batch with a lot of internal updates, yet no visual changes to the
site:

- watchdog (rewrite):
   + the collected information provides more details and insights
     for post-mortem research
   + input limitation
- database abstraction layer:
   + mysql errors are now verbose and is no longer displayed in a
     browser - fixes a possible security risk
- admin.php:
   + updated watchdog page
   + fixed security flaw
- diary.php:
   + fixed nl2br problem
- themes:
   + fixed comment bug in all 3 themes.
- misc:
   + renamed some global variables for sake of consistency:
      $sitename  -->  $site_name
      $siteurl   -->  $site_url
   + added input check where (a) exploitable and (b) possible
   + added input size check
   + various small improvements
   + fixed various typoes

... and much, much more in fact.
2000-11-13 08:17:45 +00:00
Dries Buytaert 2c399b13a3 * Added some tags to ease navigation 2000-11-06 08:01:25 +00:00
Dries Buytaert 7f2e4572fa - fixed bug in search.php
- fixed bug in discussion.php
- theme update: comment() now takes 3 arguments:
    $comment - an object with comment data
    $link    - a link to the reply form of that particular
               comment
    $thread  - the subthread of that particular comment
- theme 'marvin' and theme 'zaphod' are updated, theme
  'unconed' is left to be done
2000-11-03 07:57:28 +00:00
Dries Buytaert 8a866e6d51 - Fixed quote bug in the comment tracker.
(suggestion UnConeD)
- Added anchors to comment links to easy comment navigation.
  (suggestion UnConeD)
- Fixed duplicate `you voted' after moderating a story.
  (suggestion UnConeD)
- Fixed quote bug in administration center.
- Expanded user administration with timezone information.
- Improved the theme system by eliminating the "preview" function.
  Let's not make the system more complex then it ought to be.
- Refined watchdog administration.
- ...
2000-11-02 09:23:07 +00:00
Dries Buytaert cbeb5ee468 This significant commit fixes 99% of all known bugs and improves drop.org
by means of better security checks in order to avoid malicious behavior.
In addition, quite some code has been fine-tuned.

However, as a result, every theme will require a small update ...
2000-10-24 07:24:24 +00:00
Dries Buytaert ef43f48575 A bunch of internal changes:
- better organisation of include files
 - renamed a few function to make more sense
 - small bugfix in the user account registration
 - ...
2000-10-21 13:59:27 +00:00
Dries Buytaert 11ee95dadc A big, fat commit with a shitload of internal changes. Not that much
visual changes:

- removed redundant files user.class.php, calendar.class.php
  and backend.class.php.
- converted *all* mysql queries to queries supported by the
  database abstraction layer.
- expanded the watchdog to record more information on what
  actually happened.
- bugfix: anonymous readers where not able to view comments.
- bugfix: anonymous readers could gain read-only access to
  the submission queue.
- bugfix: invalid includes in backend.php
- bugfix: invalid use of '$user->block'

and last but not least:

- redid 50% of the user account system
2000-10-19 13:31:23 +00:00
Dries Buytaert 801db51a1c * removed poll.php - it's totally outdated.
* fixed 2 bugs in the discussion forum.
2000-10-13 10:17:30 +00:00
Dries Buytaert b46f9a846f Bugfixes, amongst them:
- anonymous chicken was able to moderate commnets
 - "anonymous chicken" was displayed in the comment reply form
 - ...

The only thing left to be done is to tackle (or continue tackling)
the user accounts which in fact is quite some work. :o)
2000-10-12 06:44:11 +00:00
Dries Buytaert 73077e8778 A lot of (non-visual) updates! 2000-10-10 10:51:00 +00:00
Dries Buytaert 9a5e960638 * Reorganised a few things and fixed the theme-update bug reported by UCD. 2000-10-04 10:25:08 +00:00
Dries Buytaert e7019c2577 Changelog
---------
- improved the user information page.
- improved the story submission page.
- fixed comments score bug: '.00' --> 'x.00'
- tried fixing the calendar wrapping - UnConeD, is it fixed now?
- provided a link back to the submission queue after having voted
  for a story.
- fixed comment subject bug (and security flaw) by replacing
  quotes by ".
- updated theme 'zaphod': fixed 2 bugs.
- updated theme 'marvin': fixed 1 bug and improved the layout so
  things wrap (hopefully) better in Windows.
- comments have by default no subject pre-set - if no subject is
  provided, the user is warned and when a comment eventually got
  submitted without a subject, a subject is composed using the x
  first characters of the comment's body.
- improved comments on submit.php
- corrected a typo in the FAQ.

UnConeD
-------
- replace 'article.php' by 'discussion.php'
- comment() still uses old references to account.php: the
  parameters you supply to account.php does no longer hold.
  You have to update those links to the new syntax.
- commentcontrol() is outdated - copy paste the one of
  theme 'marvin' and adjust it to your likings.
2000-10-02 07:32:17 +00:00
Dries Buytaert 5fc99970ab I just commit everything what was queued in my backlog:
- Added a basic implementation of comment moderation
- Updated and renamed my 2 themes: I removed redundant boxes and tried to
  work towards simplicity.
- Disabled the other themes as they are broken (I gave you sufficent time
  to update them).
- Removed redundant files.
- Added security checks with regard to the usage of HTML tags.
2000-09-26 07:34:33 +00:00
Dries Buytaert 1f0a87f4e7 Over the last 2 days I redid and reorganized an afwul lot of code and
made quite a lot of additions.   The most remarkable addition is the
diary server, which I slapped together in less then 40 minutes.   Most
of the other changes are however `unvisible' for the user but add much
value to a better maintainability from a developer's objective.  Like
always, I fixed quite a number of small bugs that creeped into the code
so we should have a bigger, better and more stable drop.org.

Unfortunatly, some theme update _are_ required:


REQUIRED THEME UPDATES:
=======================

* use format_username() where usernames are used
* use format_date() where timestamps/dates are used
* use format_email() where e-mail addresses are displayed
* use format_url() where url are displayed
* replace 'formatTimestamp' with format_date
* replace 'morelink_*' with 'display_morelink'

[most of these functions are in function.inc or template.inc]

___PLEASE___ (<- this should get your attention ;) update your themes
as soon as possible - it only takes 30 min. to get in sync with the
other themes.  Don't start whining about the fact you don't know what
to change ... either eat the source cookie, or ask me to elaborate on
a few changes.  Just let me know what's puzzling you and I'll try to
help you out!


TODO LIST FOR NEXT WEEK
=======================
* Add checks for max. text length in textarea's?  Is there an HMTL
  attribute for this or ...?
* Comment moderation + mojo
* Edit/admin user accounts: block, delete, change permissions, ...
* E-mail password, change password, change e-mail address -> extra
  checks and routines to validate such `special' changes.
* Input checking - input filter: bad words, html tags, ...
2000-09-11 07:45:22 +00:00
Dries Buytaert 7daa3fd8ee A really BIG, BIG UPDATE, after two straight days of nothing but code
and sleep, new stuff is finally in drop.org.  This is a quite large
and wide-ranging update, which affects almost all of the system files
in one way or another.  I fixed quite a lot of bugs and added quite a
lot of new features, mostly administrative tools as these were really
lacking.  It's far from finished but it's a start ...
2000-09-04 16:14:46 +00:00
Dries Buytaert 75129c1fdd Bugfixes:
(1) fixed SQL bug in search.php.
  (2) fixed SQL bug in discussion.php.
  (3) fixed theme-bug in submit.php.
  (4) fixed theme-bug in discussion.php.
  (5) fixed Dries2-theme: it more or less works now though
      I still have to change the look/layout.

Important:
  (3) and (4) did fix the i-suddenly-seem-to-log-out behavior.
2000-07-12 07:15:09 +00:00
Dries Buytaert 448506a85a * 2 bugfixes to discussion.php and themes/Dries/theme.class.php.
* Added a 'disclaimer' and 'terms and conditions' to the FAQ.
2000-07-06 14:39:47 +00:00
Dries Buytaert 43e9bfb89e * discussion.php replaces both article.php and comments.php 2000-07-06 09:38:42 +00:00