diff --git a/composer.json b/composer.json index 0d4b093d74fb..d2910799592a 100644 --- a/composer.json +++ b/composer.json @@ -21,9 +21,12 @@ "composer/composer": "^2.0.2", "drupal/coder": "^8.3.10", "instaclick/php-webdriver": "^1.4.1", + "mglaman/phpstan-drupal": "^1.1.9", "mikey179/vfsstream": "^1.6.8", "phpunit/phpunit": "^9.5", "phpspec/prophecy-phpunit": "^2", + "phpstan/extension-installer": "^1.1", + "phpstan/phpstan": "^1.4.0", "symfony/css-selector": "^5.4", "symfony/phpunit-bridge": "^5.4", "symfony/var-dumper": "^5.4", @@ -51,7 +54,8 @@ "allow-plugins": { "composer/installers": true, "drupal/core-project-message": true, - "drupal/core-vendor-hardening": true + "drupal/core-vendor-hardening": true, + "phpstan/extension-installer": true } }, "extra": { diff --git a/composer.lock b/composer.lock index 32f3cbadaeed..4ed8369080aa 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies", "This file is @generated automatically" ], - "content-hash": "6209de25fead07a04a71b6af893db664", + "content-hash": "210789b4f85a82f083006db5aeafc33d", "packages": [ { "name": "asm89/stack-cors", @@ -5501,6 +5501,110 @@ }, "time": "2021-07-22T09:24:00+00:00" }, + { + "name": "mglaman/phpstan-drupal", + "version": "1.1.9", + "source": { + "type": "git", + "url": "https://github.com/mglaman/phpstan-drupal.git", + "reference": "74b356d990906fa0dd423544ef0d1b48cd52a246" + }, + "dist": { + "type": "zip", + "url": "https://api.github.com/repos/mglaman/phpstan-drupal/zipball/74b356d990906fa0dd423544ef0d1b48cd52a246", + "reference": "74b356d990906fa0dd423544ef0d1b48cd52a246", + "shasum": "" + }, + "require": { + "php": "^7.4 || ^8.0", + "phpstan/phpstan": "^1.0", + "symfony/finder": "~3.4.5 ||^4.2 || ^5.0 || ^6.0", + "symfony/yaml": "~3.4.5 || ^4.2|| ^5.0 || ^6.0", + "webflo/drupal-finder": "^1.2" + }, + "require-dev": { + "composer/installers": "^1.9", + "drupal/core-dev": "^8.8@alpha || ^9.0", + "drupal/core-recommended": "^8.8@alpha || ^9.0", + "drush/drush": "^9.6 || ^10.0", + "phpstan/extension-installer": "^1.1", + "phpstan/phpstan-deprecation-rules": "^1.0", + "phpstan/phpstan-strict-rules": "^1.0", + "phpunit/phpunit": "^6.5 || ^7.5 || ^8.0 || ^9", + "squizlabs/php_codesniffer": "^3.3" + }, + "suggest": { + "jangregor/phpstan-prophecy": "Provides a prophecy/prophecy extension for phpstan/phpstan.", + "phpstan/phpstan-deprecation-rules": "For catching deprecations, especially in Drupal core.", + "phpstan/phpstan-phpunit": "PHPUnit extensions and rules for PHPStan." + }, + "type": "phpstan-extension", + "extra": { + "branch-alias": { + "dev-main": "1.0-dev" + }, + "installer-paths": { + "tests/fixtures/drupal/core": [ + "type:drupal-core" + ], + "tests/fixtures/drupal/libraries/{$name}": [ + "type:drupal-library" + ], + "tests/fixtures/drupal/modules/contrib/{$name}": [ + "type:drupal-module" + ], + "tests/fixtures/drupal/profiles/contrib/{$name}": [ + "type:drupal-profile" + ], + "tests/fixtures/drupal/themes/contrib/{$name}": [ + "type:drupal-theme" + ] + }, + "phpstan": { + "includes": [ + "extension.neon" + ] + } + }, + "autoload": { + "files": [ + "drupal-phpunit-hack.php" + ], + "psr-4": { + "mglaman\\PHPStanDrupal\\": "src/" + } + }, + "notification-url": "https://packagist.org/downloads/", + "license": [ + "MIT" + ], + "authors": [ + { + "name": "Matt Glaman", + "email": "nmd.matt@gmail.com" + } + ], + "description": "Drupal extension and rules for PHPStan", + "support": { + "issues": "https://github.com/mglaman/phpstan-drupal/issues", + "source": "https://github.com/mglaman/phpstan-drupal/tree/1.1.9" + }, + "funding": [ + { + "url": "https://github.com/mglaman", + "type": "github" + }, + { + "url": "https://opencollective.com/phpstan-drupal", + "type": "open_collective" + }, + { + "url": "https://tidelift.com/funding/github/packagist/mglaman/phpstan-drupal", + "type": "tidelift" + } + ], + "time": "2022-01-17T15:57:58+00:00" + }, { "name": "mikey179/vfsstream", "version": "v1.6.10", @@ -6053,6 +6157,115 @@ }, "time": "2020-07-09T08:33:42+00:00" }, + { + "name": "phpstan/extension-installer", + "version": "1.1.0", + "source": { + "type": "git", + "url": "https://github.com/phpstan/extension-installer.git", + "reference": "66c7adc9dfa38b6b5838a9fb728b68a7d8348051" + }, + "dist": { + "type": "zip", + "url": "https://api.github.com/repos/phpstan/extension-installer/zipball/66c7adc9dfa38b6b5838a9fb728b68a7d8348051", + "reference": "66c7adc9dfa38b6b5838a9fb728b68a7d8348051", + "shasum": "" + }, + "require": { + "composer-plugin-api": "^1.1 || ^2.0", + "php": "^7.1 || ^8.0", + "phpstan/phpstan": ">=0.11.6" + }, + "require-dev": { + "composer/composer": "^1.8", + "phing/phing": "^2.16.3", + "php-parallel-lint/php-parallel-lint": "^1.2.0", + "phpstan/phpstan-strict-rules": "^0.11 || ^0.12" + }, + "type": "composer-plugin", + "extra": { + "class": "PHPStan\\ExtensionInstaller\\Plugin" + }, + "autoload": { + "psr-4": { + "PHPStan\\ExtensionInstaller\\": "src/" + } + }, + "notification-url": "https://packagist.org/downloads/", + "license": [ + "MIT" + ], + "description": "Composer plugin for automatic installation of PHPStan extensions", + "support": { + "issues": "https://github.com/phpstan/extension-installer/issues", + "source": "https://github.com/phpstan/extension-installer/tree/1.1.0" + }, + "time": "2020-12-13T13:06:13+00:00" + }, + { + "name": "phpstan/phpstan", + "version": "1.4.0", + "source": { + "type": "git", + "url": "https://github.com/phpstan/phpstan.git", + "reference": "72b04d97b5e6e60a081f17c416fef35bd521120b" + }, + "dist": { + "type": "zip", + "url": "https://api.github.com/repos/phpstan/phpstan/zipball/72b04d97b5e6e60a081f17c416fef35bd521120b", + "reference": "72b04d97b5e6e60a081f17c416fef35bd521120b", + "shasum": "" + }, + "require": { + "php": "^7.1|^8.0" + }, + "conflict": { + "phpstan/phpstan-shim": "*" + }, + "bin": [ + "phpstan", + "phpstan.phar" + ], + "type": "library", + "extra": { + "branch-alias": { + "dev-master": "1.4-dev" + } + }, + "autoload": { + "files": [ + "bootstrap.php" + ] + }, + "notification-url": "https://packagist.org/downloads/", + "license": [ + "MIT" + ], + "description": "PHPStan - PHP Static Analysis Tool", + "support": { + "issues": "https://github.com/phpstan/phpstan/issues", + "source": "https://github.com/phpstan/phpstan/tree/1.4.0" + }, + "funding": [ + { + "url": "https://github.com/ondrejmirtes", + "type": "github" + }, + { + "url": "https://github.com/phpstan", + "type": "github" + }, + { + "url": "https://www.patreon.com/phpstan", + "type": "patreon" + }, + { + "url": "https://tidelift.com/funding/github/packagist/phpstan/phpstan", + "type": "tidelift" + } + ], + "time": "2022-01-14T15:58:47+00:00" + }, { "name": "phpunit/php-code-coverage", "version": "9.2.10", @@ -8260,6 +8473,50 @@ ], "time": "2021-07-28T10:34:58+00:00" }, + { + "name": "webflo/drupal-finder", + "version": "1.2.2", + "source": { + "type": "git", + "url": "https://github.com/webflo/drupal-finder.git", + "reference": "c8e5dbe65caef285fec8057a4c718a0d4138d1ee" + }, + "dist": { + "type": "zip", + "url": "https://api.github.com/repos/webflo/drupal-finder/zipball/c8e5dbe65caef285fec8057a4c718a0d4138d1ee", + "reference": "c8e5dbe65caef285fec8057a4c718a0d4138d1ee", + "shasum": "" + }, + "require": { + "ext-json": "*" + }, + "require-dev": { + "mikey179/vfsstream": "^1.6", + "phpunit/phpunit": "^4.8" + }, + "type": "library", + "autoload": { + "classmap": [ + "src/DrupalFinder.php" + ] + }, + "notification-url": "https://packagist.org/downloads/", + "license": [ + "GPL-2.0-or-later" + ], + "authors": [ + { + "name": "Florian Weber", + "email": "florian@webflo.org" + } + ], + "description": "Helper class to locate a Drupal installation from a given path.", + "support": { + "issues": "https://github.com/webflo/drupal-finder/issues", + "source": "https://github.com/webflo/drupal-finder/tree/1.2.2" + }, + "time": "2020-10-27T09:42:17+00:00" + }, { "name": "webmozart/assert", "version": "1.10.0", diff --git a/composer/Metapackage/DevDependencies/composer.json b/composer/Metapackage/DevDependencies/composer.json index 3ed3c24e65f8..3fce8801d60e 100644 --- a/composer/Metapackage/DevDependencies/composer.json +++ b/composer/Metapackage/DevDependencies/composer.json @@ -15,8 +15,11 @@ "friends-of-behat/mink-browserkit-driver": "^1.4", "instaclick/php-webdriver": "^1.4.1", "justinrainbow/json-schema": "^5.2", + "mglaman/phpstan-drupal": "^1.1.9", "mikey179/vfsstream": "^1.6.8", "phpspec/prophecy-phpunit": "^2", + "phpstan/extension-installer": "^1.1", + "phpstan/phpstan": "^1.4.0", "phpunit/phpunit": "^9.5", "symfony/browser-kit": "^5.4", "symfony/css-selector": "^5.4", diff --git a/composer/Metapackage/PinnedDevDependencies/composer.json b/composer/Metapackage/PinnedDevDependencies/composer.json index 8116447c4b7f..96f959684e8e 100644 --- a/composer/Metapackage/PinnedDevDependencies/composer.json +++ b/composer/Metapackage/PinnedDevDependencies/composer.json @@ -22,6 +22,7 @@ "friends-of-behat/mink-browserkit-driver": "v1.6.1", "instaclick/php-webdriver": "1.4.10", "justinrainbow/json-schema": "5.2.11", + "mglaman/phpstan-drupal": "1.1.9", "mikey179/vfsstream": "v1.6.10", "myclabs/deep-copy": "1.10.2", "nikic/php-parser": "v4.13.2", @@ -32,6 +33,8 @@ "phpdocumentor/type-resolver": "1.6.0", "phpspec/prophecy": "v1.15.0", "phpspec/prophecy-phpunit": "v2.0.1", + "phpstan/extension-installer": "1.1.0", + "phpstan/phpstan": "1.4.0", "phpunit/php-code-coverage": "9.2.10", "phpunit/php-file-iterator": "3.0.6", "phpunit/php-invoker": "3.1.1", @@ -67,6 +70,7 @@ "symfony/lock": "v5.4.2", "symfony/phpunit-bridge": "v5.4.0", "theseer/tokenizer": "1.2.1", + "webflo/drupal-finder": "1.2.2", "webmozart/assert": "1.10.0" } } diff --git a/core/lib/Drupal/Core/TypedData/Validation/ExecutionContext.php b/core/lib/Drupal/Core/TypedData/Validation/ExecutionContext.php index ef3dd8670f8c..d2d728755772 100644 --- a/core/lib/Drupal/Core/TypedData/Validation/ExecutionContext.php +++ b/core/lib/Drupal/Core/TypedData/Validation/ExecutionContext.php @@ -298,14 +298,14 @@ class ExecutionContext implements ExecutionContextInterface { * {@inheritdoc} */ public function markObjectAsInitialized($cache_key) { - // Not supported, so nothing todo. + throw new \LogicException('\Symfony\Component\Validator\Context\ExecutionContextInterface::markObjectAsInitialized is unsupported.'); } /** * {@inheritdoc} */ public function isObjectInitialized($cache_key): bool { - // Not supported, so nothing todo. + throw new \LogicException('\Symfony\Component\Validator\Context\ExecutionContextInterface::isObjectInitialized is unsupported.'); } /** diff --git a/core/misc/cspell/dictionary.txt b/core/misc/cspell/dictionary.txt index 23311ddf0241..5c9b5066e97d 100644 --- a/core/misc/cspell/dictionary.txt +++ b/core/misc/cspell/dictionary.txt @@ -788,6 +788,7 @@ metapackages metatag metatags meΦΩ +mglaman miaus middlewares midgardmvc @@ -994,6 +995,7 @@ phpdocumentor phpfile phpserialize phpspec +phpstan phpunit phpunit's pianura diff --git a/core/phpstan-baseline.neon b/core/phpstan-baseline.neon new file mode 100644 index 000000000000..810464293b20 --- /dev/null +++ b/core/phpstan-baseline.neon @@ -0,0 +1,1152 @@ +parameters: + ignoreErrors: + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: includes/bootstrap.inc + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: includes/common.inc + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: includes/install.core.inc + + - + message: "#^A file could not be loaded from Drupal\\\\Core\\\\Extension\\\\ModuleHandlerInterface\\:\\:loadInclude$#" + count: 1 + path: includes/update.inc + + - + message: "#^Undefined variable\\: \\$base$#" + count: 1 + path: lib/Drupal/Component/Transliteration/PhpTransliteration.php + + - + message: "#^Undefined variable\\: \\$overrides$#" + count: 1 + path: lib/Drupal/Component/Transliteration/PhpTransliteration.php + + - + message: "#^Call to method getDefinitions\\(\\) on an unknown class Drupal\\\\Core\\\\Plugin\\\\CategorizingPluginManagerTrait\\.$#" + count: 3 + path: lib/Drupal/Core/Action/ActionManager.php + + - + message: "#^Call to method getSortedDefinitions\\(\\) on an unknown class Drupal\\\\Core\\\\Plugin\\\\CategorizingPluginManagerTrait\\.$#" + count: 1 + path: lib/Drupal/Core/Action/ActionManager.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: lib/Drupal/Core/Asset/CssCollectionOptimizer.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: lib/Drupal/Core/Asset/JsCollectionOptimizer.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: lib/Drupal/Core/Asset/JsCollectionRenderer.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: lib/Drupal/Core/Batch/BatchStorage.php + + - + message: "#^Call to method getDefinitions\\(\\) on an unknown class Drupal\\\\Core\\\\Plugin\\\\CategorizingPluginManagerTrait\\.$#" + count: 2 + path: lib/Drupal/Core/Block/BlockManager.php + + - + message: "#^Call to method getSortedDefinitions\\(\\) on an unknown class Drupal\\\\Core\\\\Plugin\\\\CategorizingPluginManagerTrait\\.$#" + count: 1 + path: lib/Drupal/Core/Block/BlockManager.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 3 + path: lib/Drupal/Core/Cache/ApcuBackend.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 4 + path: lib/Drupal/Core/Cache/DatabaseBackend.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: lib/Drupal/Core/Cache/MemoryBackend.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: lib/Drupal/Core/Cache/PhpBackend.php + + - + message: "#^Call to method getDefinitions\\(\\) on an unknown class Drupal\\\\Core\\\\Plugin\\\\CategorizingPluginManagerTrait\\.$#" + count: 3 + path: lib/Drupal/Core/Condition/ConditionManager.php + + - + message: "#^Call to method getSortedDefinitions\\(\\) on an unknown class Drupal\\\\Core\\\\Plugin\\\\CategorizingPluginManagerTrait\\.$#" + count: 1 + path: lib/Drupal/Core/Condition/ConditionManager.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: lib/Drupal/Core/Datetime/DateHelper.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: lib/Drupal/Core/EventSubscriber/FinishResponseSubscriber.php + + - + message: "#^Call to method getDefinitions\\(\\) on an unknown class Drupal\\\\Core\\\\Plugin\\\\CategorizingPluginManagerTrait\\.$#" + count: 3 + path: lib/Drupal/Core/Field/FieldTypePluginManager.php + + - + message: "#^Call to method getSortedDefinitions\\(\\) on an unknown class Drupal\\\\Core\\\\Plugin\\\\CategorizingPluginManagerTrait\\.$#" + count: 1 + path: lib/Drupal/Core/Field/FieldTypePluginManager.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: lib/Drupal/Core/Field/Plugin/Field/FieldFormatter/TimestampFormatter.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: lib/Drupal/Core/Field/Plugin/Field/FieldType/ChangedItem.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: lib/Drupal/Core/Field/Plugin/Field/FieldType/CreatedItem.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 4 + path: lib/Drupal/Core/Flood/DatabaseBackend.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 4 + path: lib/Drupal/Core/KeyValueStore/DatabaseStorageExpirable.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: lib/Drupal/Core/KeyValueStore/KeyValueDatabaseExpirableFactory.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: lib/Drupal/Core/Queue/DatabaseQueue.php + + - + message: "#^\\#pre_render value 'non\\-empty\\-string' at key '0' is invalid\\.$#" + count: 1 + path: lib/Drupal/Core/Render/Element/Pager.php + + - + message: "#^The \"\\#lazy_builder\" expects a callable array with arguments\\.$#" + count: 1 + path: lib/Drupal/Core/Render/PlaceholderGenerator.php + + - + message: "#^The \"\\#lazy_builder\" expects a callable array with arguments\\.$#" + count: 1 + path: lib/Drupal/Core/Render/Renderer.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: lib/Drupal/Core/Session/SessionHandler.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: lib/Drupal/Core/Session/SessionManager.php + + - + message: "#^Function twig_escape_filter not found\\.$#" + count: 1 + path: lib/Drupal/Core/Template/TwigExtension.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: lib/Drupal/Core/Template/TwigPhpStorageCache.php + + - + message: "#^Class Drupal\\\\simpletest\\\\TestBase not found\\.$#" + count: 1 + path: lib/Drupal/Core/Test/RunTests/TestFileParser.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/aggregator/aggregator.module + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/aggregator/src/Controller/AggregatorController.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/aggregator/src/Entity/Feed.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/aggregator/src/FeedStorage.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/aggregator/src/Plugin/aggregator/processor/DefaultProcessor.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/aggregator/tests/src/Functional/AggregatorCronTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/aggregator/tests/src/Kernel/Views/IntegrationTest.php + + - + message: "#^\\#lazy_builder value 'non\\-empty\\-string' at key '0' is invalid\\.$#" + count: 1 + path: modules/big_pipe/tests/modules/big_pipe_regression_test/src/BigPipeRegressionTestController.php + + - + message: "#^\\#lazy_builder callback 'hello_or_yarhar' at key '0' is not callable\\.$#" + count: 1 + path: modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php + + - + message: "#^\\#pre_render callback 'current_time' at key '0' is not callable\\.$#" + count: 1 + path: modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php + + - + message: "#^\\#lazy_builder value 'non\\-empty\\-string' at key '0' is invalid\\.$#" + count: 3 + path: modules/big_pipe/tests/modules/big_pipe_test/src/BigPipeTestController.php + + - + message: "#^\\#lazy_builder value 'non\\-empty\\-string' at key '0' is invalid\\.$#" + count: 1 + path: modules/block/src/BlockViewBuilder.php + + - + message: "#^\\#pre_render value 'non\\-empty\\-string' at key '0' is invalid\\.$#" + count: 1 + path: modules/block/src/BlockViewBuilder.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/block_content/tests/src/Functional/BlockContentRevisionsTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/block_content/tests/src/Functional/BlockContentSaveTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/block_content/tests/src/Kernel/Migrate/d6/MigrateBlockContentTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 3 + path: modules/block_content/tests/src/Kernel/Migrate/d6/MigrateCustomBlockContentTranslationTest.php + + - + message: "#^Function _add_ajax_listeners_to_plugin_inputs not found\\.$#" + count: 2 + path: modules/ckeditor5/ckeditor5.module + + - + message: "#^Function _add_attachments_to_editor_update_response not found\\.$#" + count: 2 + path: modules/ckeditor5/ckeditor5.module + + - + message: "#^Inner named functions are not supported by PHPStan\\. Consider refactoring to an anonymous function, class method, or a top\\-level\\-defined function\\. See issue \\#165 \\(https\\://github\\.com/phpstan/phpstan/issues/165\\) for more details\\.$#" + count: 2 + path: modules/ckeditor5/ckeditor5.module + + - + message: "#^Call to sprintf contains 1 placeholder, 0 values given\\.$#" + count: 1 + path: modules/ckeditor5/src/Controller/CKEditor5ImageController.php + + - + message: "#^Undefined variable\\: \\$info$#" + count: 1 + path: modules/color/color.module + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/comment/comment.module + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/comment/src/CommentForm.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/comment/src/CommentStatistics.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/comment/tests/src/Functional/CommentBlockTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/comment/tests/src/Functional/CommentTranslationUITest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/comment/tests/src/Functional/Views/DefaultViewRecentCommentsTest.php + + - + message: "#^Access to constant DEFAULT_COLLECTION on an unknown class Drupal\\\\config_override_test\\\\StorageInterface\\.$#" + count: 1 + path: modules/config/tests/config_override_test/src/ConfigOverrider.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/config_translation/src/FormElement/DateFormat.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 5 + path: modules/content_translation/src/ContentTranslationHandler.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/content_translation/src/Controller/ContentTranslationController.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/content_translation/tests/src/Functional/ContentTranslationUITestBase.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/datetime/src/Plugin/Field/FieldType/DateTimeItem.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 4 + path: modules/datetime/tests/src/Functional/DateTimeFieldTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/datetime/tests/src/Kernel/Views/FilterDateTimeTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/datetime_range/src/Plugin/Field/FieldType/DateRangeItem.php + + - + message: "#^Access to an undefined static property static\\(Drupal\\\\Tests\\\\dblog\\\\Functional\\\\DbLogResourceTest\\)\\:\\:\\$entityTypeId\\.$#" + count: 1 + path: modules/dblog/tests/src/Functional/DbLogResourceTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 3 + path: modules/dblog/tests/src/Functional/DbLogTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/dblog/tests/src/Kernel/DbLogTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/field/tests/src/Functional/NestedFormTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/field/tests/src/Kernel/Timestamp/TimestampFormatterTest.php + + - + message: "#^The \"%%alias_id%%\" service is deprecated in drupal\\:9\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use the \"route_enhancer\\.entity_bundle\" service instead\\. See https\\://www\\.drupal\\.org/node/3245017$#" + count: 1 + path: modules/field_ui/tests/src/Kernel/FieldUiRouteEnhancerTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/file/file.module + + - + message: "#^Function uploadprogress_get_info not found\\.$#" + count: 1 + path: modules/file/src/Controller/FileWidgetAjaxController.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/file/tests/src/Functional/FileFieldPathTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/file/tests/src/Functional/FileFieldRevisionTest.php + + - + message: "#^Access to an undefined static property static\\(Drupal\\\\Tests\\\\file\\\\Functional\\\\FileUploadJsonCookieTest\\)\\:\\:\\$entityTypeId\\.$#" + count: 1 + path: modules/file/tests/src/Functional/FileUploadJsonCookieTest.php + + - + message: "#^Access to an undefined static property static\\(Drupal\\\\Tests\\\\file\\\\Functional\\\\Hal\\\\FileUploadHalJsonCookieTest\\)\\:\\:\\$entityTypeId\\.$#" + count: 1 + path: modules/file/tests/src/Functional/Hal/FileUploadHalJsonCookieTest.php + + - + message: "#^Access to an undefined static property static\\(Drupal\\\\Tests\\\\file\\\\Functional\\\\Hal\\\\FileUploadHalJsonTestBase\\)\\:\\:\\$entityTypeId\\.$#" + count: 1 + path: modules/file/tests/src/Functional/Hal/FileUploadHalJsonTestBase.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/file/tests/src/Kernel/DeleteTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/file/tests/src/Kernel/UsageTest.php + + - + message: "#^\\#lazy_builder value 'string' at key '0' is invalid\\.$#" + count: 1 + path: modules/filter/src/FilterProcessResult.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 3 + path: modules/history/history.module + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/history/src/Plugin/views/filter/HistoryUserTimestamp.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/history/tests/src/Kernel/Views/HistoryTimestampTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/image/image.admin.inc + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/locale/locale.batch.inc + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/locale/locale.bulk.inc + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/locale/locale.compare.inc + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 3 + path: modules/locale/locale.module + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/locale/locale.translation.inc + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/locale/src/Form/TranslationStatusForm.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 5 + path: modules/locale/tests/src/Functional/LocaleUpdateBase.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/locale/tests/src/Functional/LocaleUpdateCronTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/locale/tests/src/Functional/LocaleUpdateInterfaceTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/menu_link_content/tests/src/Kernel/MenuLinksTest.php + + - + message: "#^Call to an undefined static method static\\(Drupal\\\\Tests\\\\migrate\\\\Kernel\\\\MigrateTestBase\\)\\:\\:migrateDumpAlter\\(\\)\\.$#" + count: 1 + path: modules/migrate/tests/src/Kernel/MigrateTestBase.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/migrate_drupal_ui/src/Batch/MigrateUpgradeImportBatch.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/migrate_drupal_ui/src/Form/ReviewForm.php + + - + message: "#^\\#lazy_builder value 'non\\-empty\\-string' at key '0' is invalid\\.$#" + count: 1 + path: modules/node/src/NodeViewBuilder.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/node/tests/src/Functional/NodeAdminTest.php + + - + message: "#^The \"access_check\\.node\\.revision\" service is deprecated\\. You should use the 'access_check\\.entity' service instead\\. See https\\://www\\.drupal\\.org/node/3161210$#" + count: 2 + path: modules/node/tests/src/Functional/NodeRevisionPermissionsTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/node/tests/src/Functional/NodeRevisionsAllTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/node/tests/src/Functional/NodeRevisionsTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/node/tests/src/Functional/NodeSaveTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/node/tests/src/Functional/NodeTranslationUITest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 3 + path: modules/node/tests/src/Functional/Views/FrontPageTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/node/tests/src/Functional/Views/NodeIntegrationTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 5 + path: modules/node/tests/src/Functional/Views/Wizard/NodeRevisionWizardTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/path_alias/src/AliasManager.php + + - + message: "#^Drupal\\\\Tests\\\\BrowserTestBase\\:\\:\\$defaultTheme is required\\. See https\\://www\\.drupal\\.org/node/3083055, which includes recommendations on which theme to use\\.$#" + count: 1 + path: modules/quickedit/tests/src/FunctionalJavascript/QuickEditJavascriptTestBase.php + + - + message: "#^Instantiated class EasyRdf_Graph not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/CommentAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Parser_Rdfa not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/CommentAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Graph not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/EntityReferenceFieldAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Parser_Rdfa not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/EntityReferenceFieldAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Graph not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/FileFieldAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Parser_Rdfa not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/FileFieldAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Graph not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/ImageFieldAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Parser_Rdfa not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/ImageFieldAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Graph not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/NodeAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Parser_Rdfa not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/NodeAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Graph not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/StandardProfileTest.php + + - + message: "#^Instantiated class EasyRdf_Parser_Rdfa not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/StandardProfileTest.php + + - + message: "#^Instantiated class EasyRdf_Graph not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/TaxonomyAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Parser_Rdfa not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/TaxonomyAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Graph not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/UserAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Parser_Rdfa not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Functional/UserAttributesTest.php + + - + message: "#^Instantiated class EasyRdf_Graph not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Kernel/Field/FieldRdfaTestBase.php + + - + message: "#^Instantiated class EasyRdf_Parser_Rdfa not found\\.$#" + count: 1 + path: modules/rdf/tests/src/Kernel/Field/FieldRdfaTestBase.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/search/src/SearchIndex.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/search/tests/src/Functional/SearchMultilingualEntityTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 3 + path: modules/search/tests/src/Functional/SearchRankingTest.php + + - + message: "#^Class Drupal\\\\block\\\\Entity\\\\Block referenced with incorrect case\\: Drupal\\\\block\\\\entity\\\\Block\\.$#" + count: 2 + path: modules/settings_tray/settings_tray.module + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/system/src/DateFormatListBuilder.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/system/src/Form/DateFormatDeleteForm.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/system/src/Form/DateFormatEditForm.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/system/system.install + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 6 + path: modules/system/system.tokens.inc + + - + message: "#^Class Drupal\\\\advisory_feed_test\\\\AdvisoriesTestHttpClient extends @final class GuzzleHttp\\\\Client\\.$#" + count: 1 + path: modules/system/tests/modules/advisory_feed_test/src/AdvisoriesTestHttpClient.php + + - + message: "#^File core/modules/system/tests/modules/entity_test/entity_test\\.inc could not be loaded from Drupal\\\\Core\\\\Extension\\\\ModuleHandlerInterface\\:\\:loadInclude$#" + count: 2 + path: modules/system/tests/modules/entity_test/entity_test.install + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/system/tests/modules/entity_test/src/Plugin/Field/FieldType/ChangedTestItem.php + + - + message: "#^Result of function usleep \\(void\\) is used\\.$#" + count: 1 + path: modules/system/tests/modules/hold_test/src/EventSubscriber/HoldTestSubscriber.php + + - + message: "#^Configuration entity must define a `config_export` key\\. See https\\://www\\.drupal\\.org/node/2481909$#" + count: 1 + path: modules/system/tests/modules/module_installer_config_test/src/Entity/TestConfigType.php + + - + message: "#^Instantiated class Drupal\\\\Tests\\\\system\\\\Functional\\\\FileTransfer\\\\Exception not found\\.$#" + count: 1 + path: modules/system/tests/src/Functional/FileTransfer/FileTransferTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/system/tests/src/Kernel/System/CronQueueTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/system/tests/src/Kernel/Token/TokenReplaceKernelTest.php + + - + message: "#^Call to function unset\\(\\) contains undefined variable \\$handler\\.$#" + count: 1 + path: modules/taxonomy/src/Plugin/views/argument/IndexTidDepthModifier.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/toolbar/src/Controller/ToolbarController.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 4 + path: modules/update/src/UpdateProcessor.php + + - + message: "#^Drupal\\\\Tests\\\\BrowserTestBase\\:\\:\\$defaultTheme is required\\. See https\\://www\\.drupal\\.org/node/3083055, which includes recommendations on which theme to use\\.$#" + count: 1 + path: modules/update/tests/src/Functional/UpdateUploaderTestBase.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/update/update.fetch.inc + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 4 + path: modules/update/update.module + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/user/src/Controller/UserController.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/user/src/EventSubscriber/UserRequestSubscriber.php + + - + message: "#^Access to an undefined static property static\\(Drupal\\\\Tests\\\\user\\\\Functional\\\\RestRegisterUserTest\\)\\:\\:\\$entityTypeId\\.$#" + count: 1 + path: modules/user/tests/src/Functional/RestRegisterUserTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/user/tests/src/Functional/UserCreateTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/user/tests/src/Functional/UserEditTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 5 + path: modules/user/tests/src/Functional/UserPasswordResetTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/user/tests/src/Functional/UserPictureTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/user/tests/src/Functional/UserRegistrationTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/user/tests/src/Functional/Views/UserChangedTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/user/tests/src/FunctionalJavascript/UserPasswordResetTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 5 + path: modules/user/user.module + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/views/src/Plugin/views/argument/Date.php + + - + message: "#^Undefined variable\\: \\$arg$#" + count: 1 + path: modules/views/src/Plugin/views/argument_validator/None.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/views/src/Plugin/views/cache/Time.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/views/src/Plugin/views/field/Date.php + + - + message: "#^Undefined variable\\: \\$def$#" + count: 2 + path: modules/views/src/Plugin/views/relationship/EntityReverse.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/views/src/ViewExecutable.php + + - + message: "#^Configuration entity must define a `config_export` key\\. See https\\://www\\.drupal\\.org/node/2481909$#" + count: 1 + path: modules/views/tests/modules/views_config_entity_test/src/Entity/ViewsConfigEntityTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/views/tests/src/Functional/BulkFormTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/views/tests/src/Functional/DefaultViewsTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/views/tests/src/Functional/GlossaryTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 6 + path: modules/views/tests/src/Functional/Wizard/ItemsPerPageTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/views/tests/src/Functional/Wizard/PagerTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 3 + path: modules/views/tests/src/Functional/Wizard/SortingTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/views/tests/src/FunctionalJavascript/ClickSortingAJAXTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 3 + path: modules/views/tests/src/Kernel/Handler/FieldDropbuttonTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/views/tests/src/Kernel/Handler/FieldFieldTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 2 + path: modules/views/tests/src/Kernel/RenderCacheIntegrationTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/views/views.theme.inc + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: modules/views/views.views_execution.inc + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: rebuild.php + + - + message: "#^The \"%%alias_id%%\" alias is deprecated in drupal\\:9\\.0\\.0 and is removed from drupal\\:20\\.0\\.0\\. This is a test\\.$#" + count: 1 + path: tests/Drupal/FunctionalTests/Core/Container/ServiceDeprecationTest.php + + - + message: "#^The \"deprecation_test\\.service\" service is deprecated in drupal\\:9\\.0\\.0 and is removed from drupal\\:20\\.0\\.0\\. This is a test\\.$#" + count: 1 + path: tests/Drupal/FunctionalTests/Core/Container/ServiceDeprecationTest.php + + - + message: "#^Drupal\\\\Tests\\\\BrowserTestBase\\:\\:\\$defaultTheme is required\\. See https\\://www\\.drupal\\.org/node/3083055, which includes recommendations on which theme to use\\.$#" + count: 1 + path: tests/Drupal/FunctionalTests/Installer/InstallerExistingConfigNoSystemSiteTest.php + + - + message: "#^Drupal\\\\Tests\\\\BrowserTestBase\\:\\:\\$defaultTheme is required\\. See https\\://www\\.drupal\\.org/node/3083055, which includes recommendations on which theme to use\\.$#" + count: 1 + path: tests/Drupal/FunctionalTests/Installer/InstallerExistingConfigTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 12 + path: tests/Drupal/KernelTests/Core/Cache/GenericCacheBackendUnitTestBase.php + + - + message: "#^The \"%%alias_id%%\" service is deprecated in drupal\\:8\\.0\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use the \"config\\.storage\\.sync\" service instead\\. See https\\://www\\.drupal\\.org/node/2574957$#" + count: 1 + path: tests/Drupal/KernelTests/Core/Config/ConfigStorageStagingTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 4 + path: tests/Drupal/KernelTests/Core/Entity/ContentEntityChangedTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 9 + path: tests/Drupal/KernelTests/Core/Entity/EntityCrudHookTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: tests/Drupal/KernelTests/Core/Entity/EntityTypeConstraintsTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: tests/Drupal/KernelTests/Core/KeyValueStore/GarbageCollectionTest.php + + - + message: "#^\\#pre_render callback 'element_info_test…' at key '1' is not trusted\\.$#" + count: 1 + path: tests/Drupal/KernelTests/Core/Render/Element/WeightTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: tests/Drupal/KernelTests/Core/TempStore/TempStoreDatabaseTest.php + + - + message: "#^Instantiated class Drupal\\\\FunctionalTests\\\\BrowserMissingDependentModuleMethodTest not found\\.$#" + count: 1 + path: tests/Drupal/KernelTests/Core/Test/BrowserTestBaseTest.php + + - + message: "#^Instantiated class Drupal\\\\FunctionalTests\\\\BrowserMissingDependentModuleTest not found\\.$#" + count: 1 + path: tests/Drupal/KernelTests/Core/Test/BrowserTestBaseTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 5 + path: tests/Drupal/KernelTests/Core/TypedData/TypedDataTest.php + + - + message: "#^Parameter \\$template of method Drupal\\\\KernelTests\\\\KernelTestBase\\:\\:prepareTemplate\\(\\) has invalid type Text_Template\\.$#" + count: 1 + path: tests/Drupal/KernelTests/KernelTestBase.php + + - + message: "#^Instantiated class Drupal\\\\KernelTests\\\\KernelMissingDependentModuleMethodTest not found\\.$#" + count: 1 + path: tests/Drupal/KernelTests/KernelTestBaseTest.php + + - + message: "#^Instantiated class Drupal\\\\KernelTests\\\\KernelMissingDependentModuleTest not found\\.$#" + count: 1 + path: tests/Drupal/KernelTests/KernelTestBaseTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: tests/Drupal/TestSite/Commands/TestSiteInstallCommand.php + + - + message: "#^A file could not be loaded from Drupal\\\\Core\\\\Extension\\\\ModuleHandlerInterface\\:\\:loadInclude$#" + count: 1 + path: tests/Drupal/TestTools/Extension/SchemaInspector.php + + - + message: "#^Instantiated class Drupal\\\\Tests\\\\AssertHelperTestClass not found\\.$#" + count: 2 + path: tests/Drupal/Tests/AssertHelperTraitTest.php + + - + message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" + count: 1 + path: tests/Drupal/Tests/BrowserTestBase.php + + - + message: "#^Array has 2 duplicate keys with value 'ClassWithConstants\\.SOME_KEY' \\(\\\\Drupal\\\\Tests\\\\Component\\\\Annotation\\\\Doctrine\\\\Fixtures\\\\ClassWithConstants\\:\\:SOME_KEY, \\\\Drupal\\\\Tests\\\\Component\\\\Annotation\\\\Doctrine\\\\Fixtures\\\\ClassWithConstants\\:\\:SOME_KEY\\)\\.$#" + count: 1 + path: tests/Drupal/Tests/Component/Annotation/Doctrine/DocParserTest.php + + - + message: "#^Function container_test_file_service_test_service_function not found\\.$#" + count: 1 + path: tests/Drupal/Tests/Component/DependencyInjection/ContainerTest.php + + - + message: "#^Result of static method Drupal\\\\Composer\\\\Composer\\:\\:ensureComposerVersion\\(\\) \\(void\\) is used\\.$#" + count: 1 + path: tests/Drupal/Tests/Composer/ComposerTest.php + + - + message: "#^Class Drupal\\\\Driver\\\\Database\\\\corefake\\\\Install\\\\Tasks not found\\.$#" + count: 1 + path: tests/Drupal/Tests/Core/Database/InstallerObjectTest.php + + - + message: "#^Class Drupal\\\\Driver\\\\Database\\\\fake\\\\Install\\\\Tasks not found\\.$#" + count: 1 + path: tests/Drupal/Tests/Core/Database/InstallerObjectTest.php + + - + message: "#^Array has 2 duplicate keys with value 'default' \\('default', 'default'\\)\\.$#" + count: 1 + path: tests/Drupal/Tests/Core/Mail/MailManagerTest.php + + - + message: "#^Call to method getDefinitions\\(\\) on an unknown class Drupal\\\\Core\\\\Plugin\\\\CategorizingPluginManagerTrait\\.$#" + count: 3 + path: tests/Drupal/Tests/Core/Plugin/CategorizingPluginManagerTraitTest.php + + - + message: "#^Call to method getSortedDefinitions\\(\\) on an unknown class Drupal\\\\Core\\\\Plugin\\\\CategorizingPluginManagerTrait\\.$#" + count: 1 + path: tests/Drupal/Tests/Core/Plugin/CategorizingPluginManagerTraitTest.php + + - + message: "#^\\#access_callback callback class '\\$this\\(Drupal\\\\Tests\\\\Core\\\\Render\\\\RendererCallbackTest\\)' at key '0' does not implement Drupal\\\\Core\\\\Security\\\\TrustedCallbackInterface\\.$#" + count: 1 + path: tests/Drupal/Tests/Core/Render/RendererCallbackTest.php + + - + message: "#^\\#lazy_builder callback '\\\\\\\\Drupal\\\\\\\\Tests\\\\\\\\Core…' at key '0' is not trusted\\.$#" + count: 1 + path: tests/Drupal/Tests/Core/Render/RendererCallbackTest.php + + - + message: "#^\\#post_render callback class 'Drupal\\\\Tests\\\\Core\\\\Render\\\\RendererCallbackTest' at key '0' does not implement Drupal\\\\Core\\\\Security\\\\TrustedCallbackInterface\\.$#" + count: 1 + path: tests/Drupal/Tests/Core/Render/RendererCallbackTest.php + + - + message: "#^\\#pre_render callback '\\\\\\\\Drupal\\\\\\\\Tests\\\\\\\\Core…' at key '0' is not trusted\\.$#" + count: 1 + path: tests/Drupal/Tests/Core/Render/RendererCallbackTest.php + + - + message: "#^The \"\\#lazy_builder\" expects a callable array with arguments\\.$#" + count: 1 + path: tests/Drupal/Tests/Core/Render/RendererPlaceholdersTest.php + + - + message: "#^\\#access_callback value 'literal\\-string&non\\-empty\\-string' at key '0' is invalid\\.$#" + count: 1 + path: tests/Drupal/Tests/Core/Render/RendererTest.php + + - + message: "#^Call to an undefined static method PHPUnit\\\\Util\\\\ErrorHandler\\:\\:handleError\\(\\)\\.$#" + count: 1 + path: tests/Drupal/Tests/Listeners/DrupalListener.php + diff --git a/core/phpstan-partial.neon b/core/phpstan-partial.neon new file mode 100644 index 000000000000..8d78ca825f7d --- /dev/null +++ b/core/phpstan-partial.neon @@ -0,0 +1,10 @@ +# Configuration file for PHPStan static code checking, see https://phpstan.org . +# PHPStan is triggered on Drupal CI in commit-code-check.sh. +includes: + - phpstan.neon.dist + +# Do not add additional configuration to this file. This configuration exists +# only to allow core/scripts/dev/commit-code-check.sh to run against a subset of +# the codebase. +parameters: + reportUnmatchedIgnoredErrors: false diff --git a/core/phpstan.neon.dist b/core/phpstan.neon.dist new file mode 100644 index 000000000000..868e63576c48 --- /dev/null +++ b/core/phpstan.neon.dist @@ -0,0 +1,38 @@ +# Configuration file for PHPStan static code checking, see https://phpstan.org . +# PHPStan is triggered on Drupal CI in commit-code-check.sh. +includes: + - phpstan-baseline.neon + +parameters: + + level: 0 + + paths: + - . + - ../composer + + excludePaths: + # Skip settings. + - ../*/settings*.php + # Skip test fixtures. + - */tests/fixtures/*.php + # Below extends on purpose a non existing class for testing. + - modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/fruit/ExtendingNonInstalledClass.php + # @todo files below need to be excluded as they prevent baseline generation. + # Fixing them is a priority. + - modules/link/tests/src/Kernel/LinkItemTest.php + + ignoreErrors: + # new static() is a best practice in Drupal, so we cannot fix that. + - "#^Unsafe usage of new static#" + + # Ignore common errors for now. + - "#^Access to an undefined property#" + - "#^Call to an undefined method#" + - "#^Cannot unset offset#" + - "#should return .* but return statement is missing#" + - "#Drupal calls should be avoided in classes, use dependency injection instead#" + - "#^Plugin definitions cannot be altered.#" + - "#^Missing cache backend declaration for performance.#" + - "#cache tag might be unclear and does not contain the cache key in it.#" + - "#^Class .* extends @internal class#" diff --git a/core/scripts/dev/commit-code-check.sh b/core/scripts/dev/commit-code-check.sh index e5cba556954c..9660d8084b2b 100755 --- a/core/scripts/dev/commit-code-check.sh +++ b/core/scripts/dev/commit-code-check.sh @@ -11,6 +11,7 @@ # - File modes. # - No changes to core/node_modules directory. # - PHPCS checks PHP and YAML files. +# - PHPStan checks PHP files. # - ESLint checks JavaScript and YAML files. # - Checks .es6.js and .js files are equivalent. # - Stylelint checks CSS files. @@ -110,6 +111,10 @@ TOP_LEVEL=$(git rev-parse --show-toplevel) # This variable will be set to one when the file core/phpcs.xml.dist is changed. PHPCS_XML_DIST_FILE_CHANGED=0 +# This variable will be set to one when the files core/phpstan-baseline.neon or +# core/phpstan.neon.dist are changed. +PHPSTAN_DIST_FILE_CHANGED=0 + # This variable will be set to one when one of the eslint config file is # changed: # - core/.eslintrc.passing.json @@ -126,6 +131,10 @@ for FILE in $FILES; do PHPCS_XML_DIST_FILE_CHANGED=1; fi; + if [[ $FILE == "core/phpstan-baseline.neon" || $FILE == "core/phpstan.neon.dist" ]]; then + PHPSTAN_DIST_FILE_CHANGED=1; + fi; + if [[ $FILE == "core/.eslintrc.json" || $FILE == "core/.eslintrc.passing.json" || $FILE == "core/.eslintrc.jquery.json" ]]; then ESLINT_CONFIG_PASSING_FILE_CHANGED=1; fi; @@ -181,6 +190,28 @@ printf "\n" printf -- '-%.0s' {1..100} printf "\n" +# Run PHPStan on all files in one go for better performance. APCu is disabled to +# ensure that the composer classmap is not corrupted. +if [[ $PHPSTAN_DIST_FILE_CHANGED == "1" ]]; then + printf "\nRunning PHPStan on *all* files.\n" + php -d apc.enabled=0 -d apc.enable_cli=0 vendor/bin/phpstan analyze --no-progress --configuration="$TOP_LEVEL/core/phpstan.neon.dist" +else + printf "\nRunning PHPStan on changed files.\n" + php -d apc.enabled=0 -d apc.enable_cli=0 vendor/bin/phpstan analyze --no-progress --configuration="$TOP_LEVEL/core/phpstan-partial.neon" $ABS_FILES +fi +if [ "$?" -ne "0" ]; then + # If there are failures set the status to a number other than 0. + FINAL_STATUS=1 + printf "\nPHPStan: ${red}failed${reset}\n" +else + printf "\nPHPStan: ${green}passed${reset}\n" +fi + +# Add a separator line to make the output easier to read. +printf "\n" +printf -- '-%.0s' {1..100} +printf "\n" + # When the file core/phpcs.xml.dist has been changed, then PHPCS must check all files. if [[ $PHPCS_XML_DIST_FILE_CHANGED == "1" ]]; then # Test all files with phpcs rules.