Issue #3276839 by Spokje, mondrake: Remove leftover dumpHeaders property

core/modules/big_pipe/tests/src/Functional/BigPipeTest.php

@@ -39,11 +39,6 @@ class BigPipeTest extends BrowserTestBase {
    */
   protected $defaultTheme = 'stark';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected $dumpHeaders = TRUE;
-
   /**
    * {@inheritdoc}
    */

core/modules/dynamic_page_cache/tests/src/Functional/DynamicPageCacheIntegrationTest.php

@@ -22,11 +22,6 @@ use Drupal\Tests\BrowserTestBase;
  */
 class DynamicPageCacheIntegrationTest extends BrowserTestBase {
 
-  /**
-   * {@inheritdoc}
-   */
-  protected $dumpHeaders = TRUE;
-
   /**
    * {@inheritdoc}
    */

core/modules/image/tests/src/Functional/ImageFieldDisplayTest.php

@@ -24,8 +24,6 @@ class ImageFieldDisplayTest extends ImageFieldTestBase {
     compareFiles as drupalCompareFiles;
   }
 
-  protected $dumpHeaders = TRUE;
-
   /**
    * Modules to enable.
    *

core/modules/node/tests/src/Functional/NodeAccessCacheabilityTest.php

@@ -52,8 +52,6 @@ class NodeAccessCacheabilityTest extends NodeTestBase {
    * @see node_query_node_access_alter()
    */
   public function testNodeAccessCacheabilitySafeguard() {
-    $this->dumpHeaders = TRUE;
-
     // The node grants cache context should be added automatically.
     $this->drupalGet(new Url('node_access_test_auto_bubbling'));
     $this->assertCacheContext('user.node_grants:view');

core/modules/node/tests/src/Functional/Views/FrontPageTest.php

@@ -26,11 +26,6 @@ class FrontPageTest extends ViewTestBase {
    */
   protected $defaultTheme = 'stark';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected $dumpHeaders = TRUE;
-
   /**
    * The entity storage for nodes.
    *

core/modules/page_cache/tests/src/Functional/PageCacheTagsIntegrationTest.php

@@ -23,8 +23,6 @@ class PageCacheTagsIntegrationTest extends BrowserTestBase {
    */
   protected $profile = 'standard';
 
-  protected $dumpHeaders = TRUE;
-
   /**
    * {@inheritdoc}
    */

core/modules/page_cache/tests/src/Functional/PageCacheTest.php

@@ -20,8 +20,6 @@ class PageCacheTest extends BrowserTestBase {
 
   use AssertPageCacheContextsAndTagsTrait;
 
-  protected $dumpHeaders = TRUE;
-
   /**
    * Modules to enable.
    *

core/modules/responsive_image/tests/src/Functional/ResponsiveImageFieldDisplayTest.php

@@ -26,8 +26,6 @@ class ResponsiveImageFieldDisplayTest extends ImageFieldTestBase {
    */
   protected $defaultTheme = 'stark';
 
-  protected $dumpHeaders = TRUE;
-
   /**
    * Responsive image style entity instance we test with.
    *

core/modules/search/tests/src/Functional/SearchPageCacheTagsTest.php

@@ -25,11 +25,6 @@ class SearchPageCacheTagsTest extends BrowserTestBase {
    */
   protected $defaultTheme = 'stark';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected $dumpHeaders = TRUE;
-
   /**
    * A user with permission to search content.
    *

core/modules/system/tests/src/Functional/Cache/PageCacheTagsTestBase.php

@@ -10,13 +10,6 @@ use Drupal\Tests\BrowserTestBase;
  */
 abstract class PageCacheTagsTestBase extends BrowserTestBase {
 
-  /**
-   * {@inheritdoc}
-   *
-   * Always enable header dumping in page cache tags tests, this aids debugging.
-   */
-  protected $dumpHeaders = TRUE;
-
   /**
    * {@inheritdoc}
    */

core/modules/system/tests/src/Functional/Cache/SessionExistsCacheContextTest.php

@@ -28,8 +28,6 @@ class SessionExistsCacheContextTest extends BrowserTestBase {
    * Tests \Drupal\Core\Cache\Context\SessionExistsCacheContext::getContext().
    */
   public function testCacheContext() {
-    $this->dumpHeaders = TRUE;
-
     // 1. No session (anonymous).
     $this->assertSessionCookieOnClient(FALSE);
     $this->drupalGet(Url::fromRoute('<front>'));

core/modules/system/tests/src/Functional/Common/EarlyRenderingControllerTest.php

@@ -12,11 +12,6 @@ use Drupal\Tests\BrowserTestBase;
  */
 class EarlyRenderingControllerTest extends BrowserTestBase {
 
-  /**
-   * {@inheritdoc}
-   */
-  protected $dumpHeaders = TRUE;
-
   /**
    * {@inheritdoc}
    */

core/modules/system/tests/src/Functional/Session/SessionTest.php

@@ -24,8 +24,6 @@ class SessionTest extends BrowserTestBase {
    */
   protected $defaultTheme = 'stark';
 
-  protected $dumpHeaders = TRUE;
-
   /**
    * Tests for \Drupal\Core\Session\WriteSafeSessionHandler::setSessionWritable()
    * ::isSessionWritable and \Drupal\Core\Session\SessionManager::regenerate().

core/modules/system/tests/src/Functional/UpdateSystem/UpdateScriptTest.php

@@ -37,11 +37,6 @@ class UpdateScriptTest extends BrowserTestBase {
    */
   protected $defaultTheme = 'stark';
 
-  /**
-   * {@inheritdoc}
-   */
-  protected $dumpHeaders = TRUE;
-
   /**
    * The URL to the status report page.
    *

core/modules/workspaces/tests/src/Functional/WorkspaceCacheContextTest.php

@@ -31,8 +31,6 @@ class WorkspaceCacheContextTest extends BrowserTestBase {
    * Tests the 'workspace' cache context.
    */
   public function testWorkspaceCacheContext() {
-    $this->dumpHeaders = TRUE;
-
     $renderer = \Drupal::service('renderer');
     $cache_contexts_manager = \Drupal::service("cache_contexts_manager");
 

core/phpstan-baseline.neon

@@ -2178,11 +2178,6 @@ parameters:
 			count: 2
 			path: modules/node/src/Plugin/views/row/Rss.php
 
-		-
-			message: "#^Access to an undefined property Drupal\\\\Tests\\\\node\\\\Functional\\\\NodeAccessCacheabilityTest\\:\\:\\$dumpHeaders\\.$#"
-			count: 1
-			path: modules/node/tests/src/Functional/NodeAccessCacheabilityTest.php
-
 		-
 			message: "#^Access to an undefined property Drupal\\\\Tests\\\\node\\\\Functional\\\\NodeAccessGrantsCacheContextTest\\:\\:\\$noAccessUser2\\.$#"
 			count: 1
@@ -2653,10 +2648,6 @@ parameters:
 			count: 1
 			path: modules/system/tests/modules/service_provider_test/src/TestFileUsage.php
 
-		-
-			message: "#^Access to an undefined property Drupal\\\\Tests\\\\system\\\\Functional\\\\Cache\\\\SessionExistsCacheContextTest\\:\\:\\$dumpHeaders\\.$#"
-			count: 1
-			path: modules/system/tests/src/Functional/Cache/SessionExistsCacheContextTest.php
 
 		-
 			message: "#^Access to an undefined property Drupal\\\\Tests\\\\system\\\\Functional\\\\Entity\\\\EntityListBuilderTest\\:\\:\\$webUser\\.$#"
@@ -3603,10 +3594,6 @@ parameters:
 			count: 1
 			path: modules/workspaces/src/WorkspacePublisher.php
 
-		-
-			message: "#^Access to an undefined property Drupal\\\\Tests\\\\workspaces\\\\Functional\\\\WorkspaceCacheContextTest\\:\\:\\$dumpHeaders\\.$#"
-			count: 1
-			path: modules/workspaces/tests/src/Functional/WorkspaceCacheContextTest.php
 
 		-
 			message: "#^Access to an undefined property Drupal\\\\Tests\\\\workspaces\\\\Kernel\\\\EntityReferenceSupportedNewEntitiesConstraintValidatorTest\\:\\:\\$entityTypeManager\\.$#"
@@ -3623,11 +3610,6 @@ parameters:
 			count: 5
 			path: profiles/demo_umami/modules/demo_umami_content/src/InstallHelper.php
 
-		-
-			message: "#^Access to an undefined property Drupal\\\\Tests\\\\standard\\\\Functional\\\\StandardTest\\:\\:\\$dumpHeaders\\.$#"
-			count: 1
-			path: profiles/standard/tests/src/Functional/StandardTest.php
-
 		-
 			message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#"
 			count: 1

core/profiles/standard/tests/src/Functional/StandardTest.php

@@ -170,7 +170,6 @@ class StandardTest extends BrowserTestBase {
 
     // Verify certain routes' responses are cacheable by Dynamic Page Cache, to
     // ensure these responses are very fast for authenticated users.
-    $this->dumpHeaders = TRUE;
     $this->drupalLogin($this->adminUser);
     $url = Url::fromRoute('contact.site_page');
     $this->drupalGet($url);