From fcde99a4ddfde3c725b10454ba575d82c8cc7aa1 Mon Sep 17 00:00:00 2001 From: Steven Wittens Date: Tue, 12 Dec 2006 06:06:41 +0000 Subject: [PATCH] #60916: Fix comment subject being empty when comment only contains HTML tags. --- modules/comment/comment.module | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/modules/comment/comment.module b/modules/comment/comment.module index 865b4560f50..7445ca6186e 100644 --- a/modules/comment/comment.module +++ b/modules/comment/comment.module @@ -1545,9 +1545,15 @@ function _comment_form_submit($form_values) { // 1) Filter it into HTML // 2) Strip out all HTML tags // 3) Convert entities back to plain-text. - // Note: format is checked by check_markup(). - $form_values['subject'] = truncate_utf8(decode_entities(strip_tags(check_markup($form_values['comment'], $form_values['format']))), 29, TRUE); + // Note: format is checked by check_markup(). + $form_values['subject'] = trim(truncate_utf8(decode_entities(strip_tags(check_markup($form_values['comment'], $form_values['format']))), 29, TRUE)); + // Edge cases where the comment body is populated only by HTML tags will + // require a default subject. + if ($form_values['subject'] == '') { + $form_values['subject'] = t('(No subject)'); + } } + return $form_values; }