Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #733054 followup by lussoluca: Fixed Watchdog logging of all searches is performance hit; need ability to turn it off.

8.0.x
Alex Pott 2014-07-22 21:00:58 +01:00
parent d29adc88ad
commit f959ce8ffb
1 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
core/modules/search/src/Controller/SearchController.php
View File

@ -26,24 +26,14 @@ class SearchController extends ControllerBase {
*/ */
protected $searchPageRepository; protected $searchPageRepository;
/**
* The configuration factory.
*
* @var \Drupal\Core\Config\ConfigFactory
*/
protected $configFactory;
/** /**
* Constructs a new search controller. * Constructs a new search controller.
* *
* @param \Drupal\search\SearchPageRepositoryInterface $search_page_repository * @param \Drupal\search\SearchPageRepositoryInterface $search_page_repository
* The search page repository. * The search page repository.
* @param \Drupal\Core\Config\ConfigFactory $factory
* The configuration factory object.
*/ */
public function __construct(SearchPageRepositoryInterface $search_page_repository, ConfigFactory $factory) { public function __construct(SearchPageRepositoryInterface $search_page_repository) {
$this->searchPageRepository = $search_page_repository; $this->searchPageRepository = $search_page_repository;
$this->configFactory = $factory;
} }
/** /**
@ -51,8 +41,7 @@ class SearchController extends ControllerBase {
*/ */
public static function create(ContainerInterface $container) { public static function create(ContainerInterface $container) {
return new static( return new static(
$container->get('search.search_page_repository'), $container->get('search.search_page_repository')
$container->get('config.factory')
); );
} }
@ -87,7 +76,7 @@ class SearchController extends ControllerBase {
if ($request->query->has('keys')) { if ($request->query->has('keys')) {
if ($plugin->isSearchExecutable()) { if ($plugin->isSearchExecutable()) {
// Log the search. // Log the search.
if ($this->configFactory->get('search.settings')->get('logging')) { if ($this->config('search.settings')->get('logging')) {
watchdog('search', 'Searched %type for %keys.', array('%keys' => $keys, '%type' => $entity->label()), WATCHDOG_NOTICE); watchdog('search', 'Searched %type for %keys.', array('%keys' => $keys, '%type' => $entity->label()), WATCHDOG_NOTICE);
} }