Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3488179 by phenaproxima, thejimbirch: RecipeConfigurator::getIncludedRecipe() should statically cache recipe objects to avoid performance problems 

(cherry picked from commit bc8a19c8f7)
merge-requests/8400/merge
Alex Pott 2024-11-19 09:30:00 +00:00
parent 5d70089198
commit ee95592cf3
No known key found for this signature in database
GPG Key ID: BDA67E7EE836E5CE
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
core/lib/Drupal/Core/Recipe/RecipeConfigurator.php
View File

@ -15,6 +15,13 @@ final class RecipeConfigurator {
*/
public readonly array $recipes;
/**
* A cache of already-loaded recipes, keyed by path.
*
* @var \Drupal\Core\Recipe\Recipe[]
*/
private static array $cache = [];
/**
* @param string[] $recipes
* A list of recipes for a recipe to apply. The recipes will be applied in
@ -56,8 +63,11 @@ final class RecipeConfigurator {
$path = $include_path . "/$name/recipe.yml";
}
if (array_key_exists($path, static::$cache)) {
return static::$cache[$path];
}
if (file_exists($path)) {
return Recipe::createFromDirectory(dirname($path));
return static::$cache[$path] = Recipe::createFromDirectory(dirname($path));
}
$search_path = dirname($path, 2);
throw new UnknownRecipeException($name, $search_path, sprintf("Can not find the %s recipe, search path: %s", $name, $search_path));