Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2834445 by claudiu.cristea: Don't fetch the entity type ID on each iteration in SqlContentEntityStorageSchema::getFieldSchemaData()

8.3.x
Alex Pott 2016-12-14 11:24:16 +00:00
parent 230c5bf0e1
commit edbbe397c1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php
View File

@ -676,13 +676,13 @@ class SqlContentEntityStorageSchema implements DynamicallyFieldableEntityStorage
protected function getFieldSchemaData($field_name, array $field_schema, array $column_mapping, $schema_key) { protected function getFieldSchemaData($field_name, array $field_schema, array $column_mapping, $schema_key) {
$data = array(); $data = array();
$entity_type_id = $this->entityType->id();
foreach ($field_schema[$schema_key] as $key => $columns) { foreach ($field_schema[$schema_key] as $key => $columns) {
// To avoid clashes with entity-level indexes or unique keys we use // To avoid clashes with entity-level indexes or unique keys we use
// "{$entity_type_id}_field__" as a prefix instead of just // "{$entity_type_id}_field__" as a prefix instead of just
// "{$entity_type_id}__". We additionally namespace the specifier by the // "{$entity_type_id}__". We additionally namespace the specifier by the
// field name to avoid clashes when multiple fields of the same type are // field name to avoid clashes when multiple fields of the same type are
// added to an entity type. // added to an entity type.
$entity_type_id = $this->entityType->id();
$real_key = $this->getFieldSchemaIdentifierName($entity_type_id, $field_name, $key); $real_key = $this->getFieldSchemaIdentifierName($entity_type_id, $field_name, $key);
foreach ($columns as $column) { foreach ($columns as $column) {
// Allow for indexes and unique keys to specified as an array of column // Allow for indexes and unique keys to specified as an array of column