Issue #2902381 by neclimdul, mfernea, Mile23, alexpott: Revert phpcs.xml.dist changes from "Ensure that we're using the right ruleset for coding standards checking"
Nathaniel Catchpole
parent
e59a03df3d
commit
e9b1184d03
|
|
@ -16,20 +16,20 @@
|
|||
|
||||
<!-- Only include specific sniffs that pass. This ensures that, if new sniffs are added, HEAD does not fail.-->
|
||||
<!-- Drupal sniffs -->
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Array/DisallowLongArraySyntaxSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Classes/ClassCreateInstanceSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Classes/ClassDeclarationSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Classes/FullyQualifiedNamespaceSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Classes/InterfaceNameSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Classes/UnusedUseStatementSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Classes/UseLeadingBackslashSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/CSS/ClassDefinitionNameSpacingSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/CSS/ColourDefinitionSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/ClassCommentSniff.php">
|
||||
<rule ref="Drupal.Array.DisallowLongArraySyntax"/>
|
||||
<rule ref="Drupal.Classes.ClassCreateInstance"/>
|
||||
<rule ref="Drupal.Classes.ClassDeclaration"/>
|
||||
<rule ref="Drupal.Classes.FullyQualifiedNamespace"/>
|
||||
<rule ref="Drupal.Classes.InterfaceName"/>
|
||||
<rule ref="Drupal.Classes.UnusedUseStatement"/>
|
||||
<rule ref="Drupal.Classes.UseLeadingBackslash"/>
|
||||
<rule ref="Drupal.CSS.ClassDefinitionNameSpacing"/>
|
||||
<rule ref="Drupal.CSS.ColourDefinition"/>
|
||||
<rule ref="Drupal.Commenting.ClassComment">
|
||||
<exclude name="Drupal.Commenting.ClassComment.Missing"/>
|
||||
</rule>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/DataTypeNamespaceSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/DocCommentSniff.php">
|
||||
<rule ref="Drupal.Commenting.DataTypeNamespace"/>
|
||||
<rule ref="Drupal.Commenting.DocComment">
|
||||
<!-- Sniff for these errors: SpacingAfterTagGroup, WrongEnd, SpacingBetween,
|
||||
ContentAfterOpen, SpacingBeforeShort, TagValueIndent, ShortStartSpace,
|
||||
SpacingAfter -->
|
||||
|
|
@ -49,9 +49,9 @@
|
|||
<exclude name="Drupal.Commenting.DocComment.TagGroupSpacing"/>
|
||||
<exclude name="Drupal.Commenting.DocComment.MissingShort"/>
|
||||
</rule>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/DocCommentStarSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/FileCommentSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/FunctionCommentSniff.php">
|
||||
<rule ref="Drupal.Commenting.DocCommentStar"/>
|
||||
<rule ref="Drupal.Commenting.FileComment"/>
|
||||
<rule ref="Drupal.Commenting.FunctionComment">
|
||||
<exclude name="Drupal.Commenting.FunctionComment.IncorrectTypeHint"/>
|
||||
<exclude name="Drupal.Commenting.FunctionComment.InvalidNoReturn"/>
|
||||
<exclude name="Drupal.Commenting.FunctionComment.InvalidTypeHint"/>
|
||||
|
|
@ -64,14 +64,14 @@
|
|||
<exclude name="Drupal.Commenting.FunctionComment.ParamMissingDefinition"/>
|
||||
<exclude name="Drupal.Commenting.FunctionComment.TypeHintMissing"/>
|
||||
</rule>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/VariableCommentSniff.php">
|
||||
<rule ref="Drupal.Commenting.VariableComment">
|
||||
<!-- Sniff for: DuplicateVar, EmptyVar, InlineVariableName -->
|
||||
<exclude name="Drupal.Commenting.VariableComment.IncorrectVarType"/>
|
||||
<exclude name="Drupal.Commenting.VariableComment.MissingVar"/>
|
||||
<exclude name="Drupal.Commenting.VariableComment.VarOrder"/>
|
||||
<exclude name="Drupal.Commenting.VariableComment.WrongStyle"/>
|
||||
</rule>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/InlineCommentSniff.php">
|
||||
<rule ref="Drupal.Commenting.InlineComment">
|
||||
<!-- Sniff for: NoSpaceBefore, WrongStyle -->
|
||||
<exclude name="Drupal.Commenting.InlineComment.DocBlock"/>
|
||||
<exclude name="Drupal.Commenting.InlineComment.InvalidEndChar"/>
|
||||
|
|
@ -79,58 +79,58 @@
|
|||
<exclude name="Drupal.Commenting.InlineComment.SpacingAfter"/>
|
||||
<exclude name="Drupal.Commenting.InlineComment.SpacingBefore"/>
|
||||
</rule>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/PostStatementCommentSniff.php" />
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/ControlStructures/ElseIfSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/ControlStructures/ControlSignatureSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/ControlStructures/InlineControlStructureSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Files/EndFileNewlineSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Files/FileEncodingSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Files/TxtFileLineLengthSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Formatting/MultiLineAssignmentSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Formatting/SpaceInlineIfSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Formatting/SpaceUnaryOperatorSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Functions/DiscouragedFunctionsSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Functions/FunctionDeclarationSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/InfoFiles/AutoAddedKeysSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/InfoFiles/ClassFilesSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/InfoFiles/DuplicateEntrySniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/InfoFiles/RequiredSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Methods/MethodDeclarationSniff.php">
|
||||
<rule ref="Drupal.Commenting.PostStatementComment"/>
|
||||
<rule ref="Drupal.ControlStructures.ElseIf"/>
|
||||
<rule ref="Drupal.ControlStructures.ControlSignature"/>
|
||||
<rule ref="Drupal.ControlStructures.InlineControlStructure"/>
|
||||
<rule ref="Drupal.Files.EndFileNewline"/>
|
||||
<rule ref="Drupal.Files.FileEncoding"/>
|
||||
<rule ref="Drupal.Files.TxtFileLineLength"/>
|
||||
<rule ref="Drupal.Formatting.MultiLineAssignment"/>
|
||||
<rule ref="Drupal.Formatting.SpaceInlineIf"/>
|
||||
<rule ref="Drupal.Formatting.SpaceUnaryOperator"/>
|
||||
<rule ref="Drupal.Functions.DiscouragedFunctions"/>
|
||||
<rule ref="Drupal.Functions.FunctionDeclaration"/>
|
||||
<rule ref="Drupal.InfoFiles.AutoAddedKeys"/>
|
||||
<rule ref="Drupal.InfoFiles.ClassFiles"/>
|
||||
<rule ref="Drupal.InfoFiles.DuplicateEntry"/>
|
||||
<rule ref="Drupal.InfoFiles.Required"/>
|
||||
<rule ref="Drupal.Methods.MethodDeclaration">
|
||||
<!-- Silence method name underscore warning which is covered already in
|
||||
Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps. -->
|
||||
<exclude name="Drupal.Methods.MethodDeclaration.Underscore"/>
|
||||
</rule>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/NamingConventions/ValidVariableNameSniff.php">
|
||||
<rule ref="Drupal.NamingConventions.ValidVariableName">
|
||||
<!-- Sniff for: LowerStart -->
|
||||
<exclude name="Drupal.NamingConventions.ValidVariableName.LowerCamelName"/>
|
||||
</rule>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Scope/MethodScopeSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/EmptyInstallSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/FunctionAliasSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/FunctionTSniff.php">
|
||||
<rule ref="Drupal.Scope.MethodScope"/>
|
||||
<rule ref="Drupal.Semantics.EmptyInstall"/>
|
||||
<rule ref="Drupal.Semantics.FunctionAlias"/>
|
||||
<rule ref="Drupal.Semantics.FunctionT">
|
||||
<exclude name="Drupal.Semantics.FunctionT.NotLiteralString"/>
|
||||
<exclude name="Drupal.Semantics.FunctionT.ConcatString"/>
|
||||
</rule>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/FunctionWatchdogSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/InstallHooksSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/LStringTranslatableSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/PregSecuritySniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/TInHookMenuSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/TInHookSchemaSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/CloseBracketSpacingSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/CommaSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/EmptyLinesSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/NamespaceSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/ObjectOperatorIndentSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/ObjectOperatorSpacingSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/OpenBracketSpacingSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/OpenTagNewlineSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/OperatorSpacingSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/ScopeClosingBraceSniff.php"/>
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/ScopeIndentSniff.php"/>
|
||||
<rule ref="Drupal.Semantics.FunctionWatchdog"/>
|
||||
<rule ref="Drupal.Semantics.InstallHooks"/>
|
||||
<rule ref="Drupal.Semantics.LStringTranslatable"/>
|
||||
<rule ref="Drupal.Semantics.PregSecurity"/>
|
||||
<rule ref="Drupal.Semantics.TInHookMenu"/>
|
||||
<rule ref="Drupal.Semantics.TInHookSchema"/>
|
||||
<rule ref="Drupal.WhiteSpace.CloseBracketSpacing"/>
|
||||
<rule ref="Drupal.WhiteSpace.Comma"/>
|
||||
<rule ref="Drupal.WhiteSpace.EmptyLines"/>
|
||||
<rule ref="Drupal.WhiteSpace.Namespace"/>
|
||||
<rule ref="Drupal.WhiteSpace.ObjectOperatorIndent"/>
|
||||
<rule ref="Drupal.WhiteSpace.ObjectOperatorSpacing"/>
|
||||
<rule ref="Drupal.WhiteSpace.OpenBracketSpacing"/>
|
||||
<rule ref="Drupal.WhiteSpace.OpenTagNewline"/>
|
||||
<rule ref="Drupal.WhiteSpace.OperatorSpacing"/>
|
||||
<rule ref="Drupal.WhiteSpace.ScopeClosingBrace"/>
|
||||
<rule ref="Drupal.WhiteSpace.ScopeIndent"/>
|
||||
|
||||
<!-- Drupal Practice sniffs -->
|
||||
<rule ref="../vendor/drupal/coder/coder_sniffer/DrupalPractice/Sniffs/Commenting/ExpectedExceptionSniff.php"/>
|
||||
<rule ref="DrupalPractice.Commenting.ExpectedException"/>
|
||||
|
||||
<!-- Generic sniffs -->
|
||||
<rule ref="Generic.Files.ByteOrderMark"/>
|
||||
|
|
@ -146,7 +146,7 @@
|
|||
<rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
|
||||
<rule ref="Generic.PHP.DeprecatedFunctions"/>
|
||||
<rule ref="Generic.PHP.DisallowShortOpenTag"/>
|
||||
<rule ref="Generic.PHP.LowerCaseKeyword" />
|
||||
<rule ref="Generic.PHP.LowerCaseKeyword"/>
|
||||
<rule ref="Generic.PHP.UpperCaseConstant"/>
|
||||
<rule ref="Generic.WhiteSpace.DisallowTabIndent"/>
|
||||
|
||||
|
|
@ -200,7 +200,7 @@
|
|||
<rule ref="PSR2.Classes.PropertyDeclaration">
|
||||
<exclude name="PSR2.Classes.PropertyDeclaration.Underscore"/>
|
||||
</rule>
|
||||
<rule ref="PSR2.Namespaces.NamespaceDeclaration" />
|
||||
<rule ref="PSR2.Namespaces.NamespaceDeclaration"/>
|
||||
<rule ref="PSR2.Namespaces.UseDeclaration">
|
||||
<exclude name="PSR2.Namespaces.UseDeclaration.UseAfterNamespace"/>
|
||||
</rule>
|
||||
|
|
@ -245,7 +245,7 @@
|
|||
<rule ref="Squiz.Arrays.ArrayDeclaration.ValueNoNewline">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration" />
|
||||
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration"/>
|
||||
<!-- Disable some error messages that we already cover. -->
|
||||
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.AsNotLower">
|
||||
<severity>0</severity>
|
||||
|
|
@ -264,7 +264,7 @@
|
|||
<rule ref="Squiz.ControlStructures.ForLoopDeclaration.SpacingBeforeClose">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
<rule ref="Squiz.Functions.MultiLineFunctionDeclaration" />
|
||||
<rule ref="Squiz.Functions.MultiLineFunctionDeclaration"/>
|
||||
<rule ref="Squiz.Functions.MultiLineFunctionDeclaration.BraceOnSameLine">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
|
|
|
|||
Loading…
Reference in New Issue