Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3480293 by gapple: ConfigTarget::__construct() documentation references incorrect ToConfig enum name 

(cherry picked from commit ba24f05967)
(cherry picked from commit c26c5ee413)
merge-requests/10226/head
Alex Pott 2024-11-14 12:34:17 +00:00
parent 4b3308017f
commit e977788ee4
No known key found for this signature in database
GPG Key ID: BDA67E7EE836E5CE
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/lib/Drupal/Core/Form/ConfigTarget.php
View File

@ -74,8 +74,8 @@ final class ConfigTarget {
* return an array with the transformed values, also keyed by property path.
* The callback will receive the form state object as its second argument.
* The callback may return a special values:
* - ToConfig::NoMapping, to indicate that the given form value does not
* need to be mapped onto the Config object
* - ToConfig::NoOp, to indicate that the given form value does not need to
* be mapped onto the Config object
* - ToConfig::DeleteKey to indicate that the targeted property path should
* be deleted from config.
* Defaults to NULL.
@ -237,7 +237,7 @@ final class ConfigTarget {
}
// Set the returned value, or if a special value (one of the cases in the
// ConfigTargetValue enum): apply the appropriate action.
// ToConfig enum): apply the appropriate action.
array_walk($value, fn (mixed $value, string $property) => match ($value) {
// No-op.
ToConfig::NoOp => NULL,

4
core/tests/Drupal/Tests/Core/Form/ConfigTargetTest.php
View File

@ -286,14 +286,14 @@ class ConfigTargetTest extends UnitTestCase {
$config->set('something', FALSE)->shouldBeCalledTimes(1);
$config_target->setValue($config->reveal(), 'No', $this->prophesize(FormStateInterface::class)->reveal());
// Test `ConfigTargetValue::NoMapping`: nothing should happen to the Config.
// Test `ToConfig::NoOp`: nothing should happen to the Config.
$config = $this->prophesize(Config::class);
$config->getName()->willReturn('foo.settings');
$config->set('something', Argument::any())->shouldBeCalledTimes(0);
$config->clear('something', Argument::any())->shouldBeCalledTimes(0);
$config_target->setValue($config->reveal(), '<test:noop>', $this->prophesize(FormStateInterface::class)->reveal());
// Test `ConfigTargetValue::DeleteKey`: Config::clear() should be called.
// Test `ToConfig::DeleteKey`: Config::clear() should be called.
$config = $this->prophesize(Config::class);
$config->getName()->willReturn('foo.settings');
$config->clear('something')->shouldBeCalledTimes(1);